public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4 CurrentSpeed to filter table
@ 2022-09-08  5:40 Heng Luo
  2022-09-08  6:10 ` [edk2-devel] " Yao, Jiewen
  2022-09-13  8:45 ` Lu, James
  0 siblings, 2 replies; 4+ messages in thread
From: Heng Luo @ 2022-09-08  5:40 UTC (permalink / raw)
  To: devel
  Cc: Jian J Wang, Liming Gao, Zhiguang Liu, Dandan Bi, Star Zeng,
	Zhichao Gao

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4051

The Type4 CurrentSpeed field may be various.
So this patch adds it into the filter table.

Signed-off-by: Heng Luo <heng.luo@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
---
 MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
index 348082ff86..d61edc846b 100644
--- a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
+++ b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
@@ -1,7 +1,7 @@
 /** @file
   This driver measures SMBIOS table to TPM.
 
-Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2015 - 2022, Intel Corporation. All rights reserved.<BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
@@ -66,6 +66,7 @@ SMBIOS_FILTER_TABLE  mSmbiosFilterType4BlackList[] = {
   { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, EnabledCoreCount2), FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, EnabledCoreCount2), 0                                  },
   { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, ThreadCount2),      FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, ThreadCount2),      0                                  },
   { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, Voltage),           FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, Voltage),           0                                  },
+  { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, CurrentSpeed),      FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, CurrentSpeed),      0                                  },
 };
 SMBIOS_FILTER_TABLE  mSmbiosFilterType17BlackList[] = {
   { 0x11, OFFSET_OF (SMBIOS_TABLE_TYPE17, SerialNumber), FIELD_SIZE_OF (SMBIOS_TABLE_TYPE17, SerialNumber), SMBIOS_FILTER_TABLE_FLAG_IS_STRING },
-- 
2.31.1.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4 CurrentSpeed to filter table
  2022-09-08  5:40 [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4 CurrentSpeed to filter table Heng Luo
@ 2022-09-08  6:10 ` Yao, Jiewen
  2022-09-14  1:19   ` Gao, Zhichao
  2022-09-13  8:45 ` Lu, James
  1 sibling, 1 reply; 4+ messages in thread
From: Yao, Jiewen @ 2022-09-08  6:10 UTC (permalink / raw)
  To: devel@edk2.groups.io, Luo, Heng
  Cc: Wang, Jian J, Gao, Liming, Liu, Zhiguang, Bi, Dandan, Zeng, Star,
	Gao, Zhichao

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng
> Luo
> Sent: Thursday, September 8, 2022 1:41 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Bi,
> Dandan <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>
> Subject: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe:
> Add Type4 CurrentSpeed to filter table
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4051
> 
> The Type4 CurrentSpeed field may be various.
> So this patch adds it into the filter table.
> 
> Signed-off-by: Heng Luo <heng.luo@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> ---
> 
> MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurement
> Dxe.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git
> a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasuremen
> tDxe.c
> b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasureme
> ntDxe.c
> index 348082ff86..d61edc846b 100644
> ---
> a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasuremen
> tDxe.c
> +++
> b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasureme
> ntDxe.c
> @@ -1,7 +1,7 @@
>  /** @file
>    This driver measures SMBIOS table to TPM.
> 
> -Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2015 - 2022, Intel Corporation. All rights reserved.<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  **/
> @@ -66,6 +66,7 @@ SMBIOS_FILTER_TABLE  mSmbiosFilterType4BlackList[]
> = {
>    { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, EnabledCoreCount2),
> FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, EnabledCoreCount2),
> 0                                  },
>    { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, ThreadCount2),
> FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, ThreadCount2),
> 0                                  },
>    { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, Voltage),           FIELD_SIZE_OF
> (SMBIOS_TABLE_TYPE4, Voltage),           0                                  },
> +  { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, CurrentSpeed),
> FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, CurrentSpeed),
> 0                                  },
>  };
>  SMBIOS_FILTER_TABLE  mSmbiosFilterType17BlackList[] = {
>    { 0x11, OFFSET_OF (SMBIOS_TABLE_TYPE17, SerialNumber),
> FIELD_SIZE_OF (SMBIOS_TABLE_TYPE17, SerialNumber),
> SMBIOS_FILTER_TABLE_FLAG_IS_STRING },
> --
> 2.31.1.windows.1
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4 CurrentSpeed to filter table
  2022-09-08  5:40 [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4 CurrentSpeed to filter table Heng Luo
  2022-09-08  6:10 ` [edk2-devel] " Yao, Jiewen
@ 2022-09-13  8:45 ` Lu, James
  1 sibling, 0 replies; 4+ messages in thread
From: Lu, James @ 2022-09-13  8:45 UTC (permalink / raw)
  To: devel@edk2.groups.io, Luo, Heng
  Cc: Wang, Jian J, Gao, Liming, Liu, Zhiguang, Bi, Dandan, Zeng, Star,
	Gao, Zhichao

Reviewed-by: James Lu <james.lu@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng Luo
Sent: Thursday, September 8, 2022 1:41 PM
To: devel@edk2.groups.io
Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
Subject: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4 CurrentSpeed to filter table

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4051

The Type4 CurrentSpeed field may be various.
So this patch adds it into the filter table.

Signed-off-by: Heng Luo <heng.luo@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
---
 MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
index 348082ff86..d61edc846b 100644
--- a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
+++ b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
@@ -1,7 +1,7 @@
 /** @file
   This driver measures SMBIOS table to TPM.
 
-Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2015 - 2022, Intel Corporation. All rights reserved.<BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
@@ -66,6 +66,7 @@ SMBIOS_FILTER_TABLE  mSmbiosFilterType4BlackList[] = {
   { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, EnabledCoreCount2), FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, EnabledCoreCount2), 0                                  },
   { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, ThreadCount2),      FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, ThreadCount2),      0                                  },
   { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, Voltage),           FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, Voltage),           0                                  },
+  { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, CurrentSpeed),      FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, CurrentSpeed),      0                                  },
 };
 SMBIOS_FILTER_TABLE  mSmbiosFilterType17BlackList[] = {
   { 0x11, OFFSET_OF (SMBIOS_TABLE_TYPE17, SerialNumber), FIELD_SIZE_OF (SMBIOS_TABLE_TYPE17, SerialNumber), SMBIOS_FILTER_TABLE_FLAG_IS_STRING },
-- 
2.31.1.windows.1







^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4 CurrentSpeed to filter table
  2022-09-08  6:10 ` [edk2-devel] " Yao, Jiewen
@ 2022-09-14  1:19   ` Gao, Zhichao
  0 siblings, 0 replies; 4+ messages in thread
From: Gao, Zhichao @ 2022-09-14  1:19 UTC (permalink / raw)
  To: Yao, Jiewen, devel@edk2.groups.io, Luo, Heng
  Cc: Wang, Jian J, Gao, Liming, Liu, Zhiguang, Bi, Dandan, Zeng, Star

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao@intel.com>
> Sent: Thursday, September 8, 2022 2:11 PM
> To: devel@edk2.groups.io; Luo, Heng <heng.luo@intel.com>
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Bi,
> Dandan <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe:
> Add Type4 CurrentSpeed to filter table
> 
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng
> > Luo
> > Sent: Thursday, September 8, 2022 1:41 PM
> > To: devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> > Bi, Dandan <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>;
> > Gao, Zhichao <zhichao.gao@intel.com>
> > Subject: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe:
> > Add Type4 CurrentSpeed to filter table
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4051
> >
> > The Type4 CurrentSpeed field may be various.
> > So this patch adds it into the filter table.
> >
> > Signed-off-by: Heng Luo <heng.luo@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Dandan Bi <dandan.bi@intel.com>
> > Cc: Star Zeng <star.zeng@intel.com>
> > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > ---
> >
> >
> MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurement
> > Dxe.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git
> >
> a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasuremen
> > tDxe.c
> >
> b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasureme
> > ntDxe.c
> > index 348082ff86..d61edc846b 100644
> > ---
> >
> a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasuremen
> > tDxe.c
> > +++
> >
> b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasureme
> > ntDxe.c
> > @@ -1,7 +1,7 @@
> >  /** @file
> >    This driver measures SMBIOS table to TPM.
> >
> > -Copyright (c) 2015 - 2019, Intel Corporation. All rights
> > reserved.<BR>
> > +Copyright (c) 2015 - 2022, Intel Corporation. All rights
> > +reserved.<BR>
> >  SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >  **/
> > @@ -66,6 +66,7 @@ SMBIOS_FILTER_TABLE  mSmbiosFilterType4BlackList[]
> =
> > {
> >    { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, EnabledCoreCount2),
> > FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, EnabledCoreCount2),
> > 0                                  },
> >    { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, ThreadCount2),
> FIELD_SIZE_OF
> > (SMBIOS_TABLE_TYPE4, ThreadCount2),
> > 0                                  },
> >    { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, Voltage),           FIELD_SIZE_OF
> > (SMBIOS_TABLE_TYPE4, Voltage),           0                                  },
> > +  { 0x04, OFFSET_OF (SMBIOS_TABLE_TYPE4, CurrentSpeed),
> > FIELD_SIZE_OF (SMBIOS_TABLE_TYPE4, CurrentSpeed),
> > 0                                  },
> >  };
> >  SMBIOS_FILTER_TABLE  mSmbiosFilterType17BlackList[] = {
> >    { 0x11, OFFSET_OF (SMBIOS_TABLE_TYPE17, SerialNumber),
> > FIELD_SIZE_OF (SMBIOS_TABLE_TYPE17, SerialNumber),
> > SMBIOS_FILTER_TABLE_FLAG_IS_STRING },
> > --
> > 2.31.1.windows.1
> >
> >
> >
> > 
> >


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-09-14  1:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-08  5:40 [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4 CurrentSpeed to filter table Heng Luo
2022-09-08  6:10 ` [edk2-devel] " Yao, Jiewen
2022-09-14  1:19   ` Gao, Zhichao
2022-09-13  8:45 ` Lu, James

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox