Re: [PATCH] UefiPayloadPkg: The UPL info section is not aligned at 4-byte boundary

["Lu, James" <james.lu@intel.com>]

Reviewed-by: James Lu <james.lu@intel.com>

-----Original Message-----
From: Hsu, VictorX <victorx.hsu@intel.com> 
Sent: Wednesday, November 16, 2022 11:08 AM
To: devel@edk2.groups.io
Cc: Hsu, VictorX <victorx.hsu@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>
Subject: [PATCH] UefiPayloadPkg: The UPL info section is not aligned at 4-byte boundary

From: VictorX Hsu <victorx.hsu@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4153

1.Upgrade spec revision to 0.9
2.Align .upld_info with 4-byte boundary by spec

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: James Lu <james.lu@intel.com>
Cc: Gua Guo <gua.guo@intel.com>
Signed-off-by: VictorX Hsu <victorx.hsu@intel.com>
---
 UefiPayloadPkg/UniversalPayloadBuild.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/UefiPayloadPkg/UniversalPayloadBuild.py b/UefiPayloadPkg/UniversalPayloadBuild.py
index 6003de36d1..50a5950e7c 100644
--- a/UefiPayloadPkg/UniversalPayloadBuild.py
+++ b/UefiPayloadPkg/UniversalPayloadBuild.py
@@ -31,7 +31,7 @@ class UPLD_INFO_HEADER(LittleEndianStructure):
     def __init__(self):

         self.Identifier     =  b'PLDH'

         self.HeaderLength   = sizeof(UPLD_INFO_HEADER)

-        self.SpecRevision   = 0x0007

+        self.SpecRevision   = 0x0009

         self.Revision       = 0x0000010105

         self.ImageId        = b'UEFI'

         self.ProducerId     = b'INTEL'

@@ -133,7 +133,7 @@ def BuildUniversalPayload(Args, MacroList):
                        FvOutputDir,

                        EntryOutputDir

                        )

-    set_section    = '"{}" -I {} -O {} --set-section-alignment .upld.upld_info=16 --set-section-alignment .upld.uefi_fv=16 {}'.format (

+    set_section    = '"{}" -I {} -O {} --set-section-alignment .upld_info=4 --set-section-alignment .upld.uefi_fv=16 {}'.format (

                        LlvmObjcopyPath,

                        ObjCopyFlag,

                        ObjCopyFlag,

-- 
2.28.0.windows.1