From: james.lu@intel.com
To: "Ni, Ray" <ray.ni@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Guo" <guo.dong@intel.com>, "Guo, Gua" <gua.guo@intel.com>
Subject: Re: [PATCH] UefiPayloadPkg: Add macro to support selective driver in UPL
Date: Tue, 5 Jul 2022 08:45:40 +0000 [thread overview]
Message-ID: <BN6PR11MB1908E6EB0B9F2B2705382F9288819@BN6PR11MB1908.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MWHPR11MB1631BD958D87A62EDCA2BB418CBE9@MWHPR11MB1631.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 2203 bytes --]
Replied as below
Thanks,
James
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Monday, July 4, 2022 11:34 AM
To: Lu, James <james.lu@intel.com>; devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Guo, Gua <gua.guo@intel.com>
Subject: RE: [PATCH] UefiPayloadPkg: Add macro to support selective driver in UPL
>
> +!if $(GENERIC_MEMORY_TEST_ENABLE) == TRUE
>
> +
> MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/Generic
> MemoryTestDxe.inf
>
> +!endif
>
> +!if $(NULL_MEMORY_TEST_ENABLE) == TRUE
>
>
> MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryT
> estDxe.inf
>
> +!endif
1. Is there a configuration that both GENERIC and NULL memory test is FALSE?
If no, can we add a macro like "MEMORY_TEST" and its value could be "GENERIC" or "NULL"?
[James]
Will resolve in patch v2
> +!if $(ATA_ENABLE) == TRUE
>
> MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
>
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
>
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
2. AtaAtapiPassThru also produces "gEfiExtScsiPassThruProtocolGuid" which is used by ScsiBusDxe.
So, maybe we need to always include AtaAtapiPassThru driver.
[James]
This is to align client case that AtaAtapiPassThru.inf will not be included while ATA_ENABLE == FALSE
And ScsiBusDxe is taken care the flow while gEfiExtScsiPassThruProtocolGuid not existing
>
> #
>
> # Usb Support
>
> @@ -671,7 +685,9 @@
> !if $(PS2_KEYBOARD_ENABLE) == TRUE
>
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf
>
> !endif
>
> +!if $(PS2_MOUSE_ENABLE) == TRUE
>
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf
>
> +!endif
>
>
>
> #
>
> # Console Support
>
> @@ -742,12 +758,14 @@
> # This should be FALSE for compiling the dynamic command.
>
> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
>
> }
>
> +!if $(PERFORMANCE_MEASUREMENT_ENABLE) == TRUE
3. Thanks for catching that.
[-- Attachment #2: Type: text/html, Size: 7707 bytes --]
prev parent reply other threads:[~2022-07-05 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 10:35 [PATCH] UefiPayloadPkg: Add macro to support selective driver in UPL james.lu
2022-07-04 3:34 ` Ni, Ray
2022-07-05 8:45 ` james.lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR11MB1908E6EB0B9F2B2705382F9288819@BN6PR11MB1908.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox