From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.82364.1657010749913979519 for ; Tue, 05 Jul 2022 01:45:50 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Atq8pK5g; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: james.lu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657010749; x=1688546749; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=L5qV5lCV/bkLsM75J0ednBJofhpk0ZXzAW+STslMUcg=; b=Atq8pK5ghWAvjV89oMpCYZpFnKYe/jGZ2tdUjkS1Y+YOU47AHtBMx/NL OK6vPS9JJdEtqSUpfXJmMxzyMO3NfcNx40PBFELIlGYLx9+UFeV+xu+qA tJthW7BcsNPl5umzsI2iQ8aojrgmlaJBmZ8kdE93r2lEy7ayyTZyFjejW aMwMDFJht4dXulRhoZGB+XmkVZIK1CF8sllO7tPMbzbwIoj49Ud6/VntV nZOoYgydUahTT7z5hXCz+3F3QVdO3Xxj5sxfCf6+USgfOvbhs/ZC9pft5 vDQCGkcZMncQwyvmN83mzK/1Iu3KhtxTdWCKIs+wPY4SJTLSk3ALALpEs w==; X-IronPort-AV: E=McAfee;i="6400,9594,10398"; a="284406103" X-IronPort-AV: E=Sophos;i="5.92,245,1650956400"; d="scan'208,217";a="284406103" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2022 01:45:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,245,1650956400"; d="scan'208,217";a="719649496" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 05 Jul 2022 01:45:49 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 5 Jul 2022 01:45:49 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 5 Jul 2022 01:45:48 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 5 Jul 2022 01:45:48 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 5 Jul 2022 01:45:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QKXLUHA/wHCKhItVcEhm5XcY0ufhwahJTN/EoWLscEJyxFwHycP98VpVWb/S127aeoucZ0iT8wdcDEzknIdTsbg6Te5yF3gshMZQWP3XO1SWgUKNnUHpB/sr5nFUApdWAuGEAiY5VYE+iOK05VQDvLzMOY9vrF6deL6DdmvsUSaAi9smLyjS9wtBXSL9zfsok0aaSE4fIlyFWChhn0LIXpV+d5IsuONITUER5MT2vIESNKWYVqjPJEtW+4UoxdFoUjP1eAI0MAXC0tneMy55giTcrNG95H6CcRwcvNrUwV/Og1cbX2E+FdB803gqAips8xVFRWksXgCvedXDOZrauw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Ax6ejijwQqpgrtDsP7GyTuJV6w/RHYYpviRWFNjwas=; b=AObRj9uP3kHxUZe3k1aP1rDMvjjmfgf/NNDoWhbndSB0KSUCbZqxC8pQBlADPivdI0GfDXxLktQUcsMv/uy7JH9UXwm1wJeNCjR3BS3586u0QmAXqm7VKB0GHr2q3vtM7MGOF16f0O3CV7XpJh7XdDZ7INrA/3eNAlquj4vp/ITV+0m+PChlpYITuOp1Pn9uwCUi0eU8oRp7KZ4mPEwecAmq3sVWJevnPB+ZdntvkqzFu8TNdM8I4WkNAHe/ZA+ZZavZfMSx02+Ux/2HsBTQbTgEZHWqKI/uex2BVdh2Cos7vjhvqyor+hjwHS+WdA/yOY7x+K/VdXjf58pIzFO5GQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN6PR11MB1908.namprd11.prod.outlook.com (2603:10b6:404:103::13) by BN6PR11MB1507.namprd11.prod.outlook.com (2603:10b6:405:9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Tue, 5 Jul 2022 08:45:41 +0000 Received: from BN6PR11MB1908.namprd11.prod.outlook.com ([fe80::d980:aec4:5d03:4373]) by BN6PR11MB1908.namprd11.prod.outlook.com ([fe80::d980:aec4:5d03:4373%7]) with mapi id 15.20.5395.022; Tue, 5 Jul 2022 08:45:41 +0000 From: james.lu@intel.com To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Guo, Gua" Subject: Re: [PATCH] UefiPayloadPkg: Add macro to support selective driver in UPL Thread-Topic: [PATCH] UefiPayloadPkg: Add macro to support selective driver in UPL Thread-Index: AQHYitrLPD+HrqiR3UidknbFiY7+qK1tmCGAgAHnGrA= Date: Tue, 5 Jul 2022 08:45:40 +0000 Message-ID: References: <38b574266fdeaa275743eab94caf39acfe71b2bc.1656412190.git.james.lu@intel.com> In-Reply-To: Accept-Language: en-001, en-US, zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f8333cf9-6a03-4184-ba57-08da5e62bdc7 x-ms-traffictypediagnostic: BN6PR11MB1507:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a7BENDQuR8eJYbfhUGh4SUoF6rXzj8V8Pvw5cAc3czx1Grf3yEtZFS/eOkYrQtvapTjIDBt0vFKg15/q8ivQPTI1WqR3z4OaWbWY4PPlaEUVVSYXaAse5B5RFSl7ZSSetGcQfG7NlXB/bj/xwCyAtcai3t6vQkqw1vbE6+D/MpWIeJTWzBDG8dQs3RadXfYjP5iXwUSn0qVpqOpn7Hxij4WE9D0FYjFoSkaj6KUdDBHMOGQff3KZC2ddbftUVAR3Lo3VxD0HAjwGZPepyr7u7Lz1B7CThqOhNHicALm8fanqwoBaclA8GiSGM1KVFtczPRL/ac5wKJlWE/7w/CsHzh+KnazZ6HDUHrJzDLy7xQDN4WTMA23dT6Fbf+wD65loyxZJN7yZGZ5yksYygFgTdS6jWbo/at6sx5/HqjDX9f5pm5N9/43CWVoO3pOH7vDxvaPSOtDwcHGBppKufR8BqoWIoMnNfomwcNRWTMmCKgQSUVXbEV+POtyV1sjbbNFZvfxZlNxo9WvwE5TWfebBk8mmuHnJ5G7HvHgqDZ2VM4xjvRciulNI4S8BO1s/1USEkFGPyZjvuEj1Qmst+KK4kiZldKnoGb9Q4lMn7vWf2Rq4Ty1FBXhCqBVkR2900htXcwmDSXyTGEoUXkNX/OvU9MHHiVpKwethD0E0gzn9Gkhq6JJHsvGnHCrT54jAmFI7fyGGTnGjI8L0EAdWcqv9wwIk+NOqDY/uNka2dCm1LwGRMdlbQ84hIdOE8GoPuD+dU3NBeFPRpkPa1LytDdjh/eaktQcDJIlLop0SA+CM2QlXJgBbMm2cL9QJypZEJVDc x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(136003)(376002)(346002)(39860400002)(26005)(9686003)(71200400001)(66946007)(76116006)(83380400001)(41300700001)(2906002)(8676002)(4326008)(64756008)(66446008)(66476007)(66556008)(5660300002)(107886003)(33656002)(8936002)(478600001)(52536014)(186003)(53546011)(110136005)(54906003)(7696005)(6506007)(82960400001)(316002)(122000001)(55016003)(38070700005)(38100700002)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?05jYD6MSZasWGYNvfqJedoMGiCt5B2RtabaHIAxoW6dyE1aGbGD5a0P2+i31?= =?us-ascii?Q?KQQYbWtgubft7gIcPNsIuH5yr0q7nvrsGh5C0VdEizz6b96V+uu/UIs6/Ilc?= =?us-ascii?Q?ruTiIgkvCRajIiqrygGbbNJru4k4dSCDl4NKu+/UV0m4jecP6QntcBdIgUpG?= =?us-ascii?Q?V0cJD3EXNly2ClDtwH8ZvD7vjYNVqWCZg2L7ykimSSGnU+oLwMiupMEgwaDV?= =?us-ascii?Q?ny8Vz6DVSmjfg1SOf8SJD4dWBfH7JQBD+SrNDNs2erAEKZTi0L+ThMEcJ9g6?= =?us-ascii?Q?6Se5vmfvQP/4x1jyTjMA6Y2qLTHFcUhyxMC/KaerEotF4gIOZUPz5VBo+2al?= =?us-ascii?Q?IvYP42rwncdag+wSkVrinEQD7+ITaoxd8TRR9rVh7wOq1GHxbQix5cOP6M+x?= =?us-ascii?Q?fagd0dQdtPjXVHahJD4Z40/tnuwJpzoN00vkkwLtu+nJEaWWzsYkZqeb26H5?= =?us-ascii?Q?/J8T1TaPXIR5Lo9fLrvuKMtAj8Z7k1mER1BIdLujWj/HUHUN4zJmiXiGDQ0L?= =?us-ascii?Q?ug2Q5aR1pRCsuutsCKvIyu/QMTVtHbcfny+I4U7YzBB3nW7sDiYtFp6SbSyw?= =?us-ascii?Q?eAidATzzSQjwuzboOpAedU/1fGPEKbliMSHfDrtaGehlvgW1yTgUFTLovoyB?= =?us-ascii?Q?sC5YXF/WQfEEwfmE1rTjhrw0zoI+dxLMNgCNu5SXoqUq7XWAFasJNctIaUiw?= =?us-ascii?Q?bRV+1T6hc/v7XxX1efs20DJnWrK7VIk7qoLZ1tr2FWLE657E3Yk2iCcAdOAU?= =?us-ascii?Q?lU/YWdZNImMZmLRTMV1JnorSUsrhp+h8o8ObHvj6Y+b1VLV3FngmEKEJZTlG?= =?us-ascii?Q?gortb62GNe+X6D0+clhqGwdzr4ahhEr1Lfq581+bEvp5qdNksd9JcPgWgIBU?= =?us-ascii?Q?ZMy3Wm/+bESryo6+0pSLC3VJoU1xz+vkjTQwM1RTOrKWYqosrGmT+XIKyt+D?= =?us-ascii?Q?j2OUgGQL0j1vmdaU47e5zEOwedb682aEaNlsszUa5YTn6b0uKwqEgSTHHJFb?= =?us-ascii?Q?P+e2dEndfAaGQ0WITAKvkZjGs9EKCNrSMOjausRtIpGvf3MqZ+1e4/UpTnQU?= =?us-ascii?Q?cgin0kOLpDNtKJ+eNmUGfJaiNrWYIHl2u5I155JQWuNABB4rnpiFwLEHS8Pw?= =?us-ascii?Q?EPsOHr00KFbwYKnx3lxYl9bHHauLmiGmyEPXHoPPQ9TRvm1NK20Ij1VLBQz7?= =?us-ascii?Q?qHmzAnOWkQ3rdG4ifXRmSyCqbtr2w202U2Ao3rBAKrnqqiDccOVVuxgagy4S?= =?us-ascii?Q?+SmMcseo772ujCRLMVVIZn5hWkVd4rL4q6QQSHF9h9nYDmtHvIwvP2f4LVgu?= =?us-ascii?Q?FwqY6pLGzmYVnzz3LAQ9+s/YEFcV91hnQpAjjHkR3n8ct6u5xyLR1YwA/pXj?= =?us-ascii?Q?wACiFTbr7++eYdgTPJzFZbrKqCXsFWKBy5nsfWNcMh/tJeXySog+1Nhdml+2?= =?us-ascii?Q?fmvETnX833F2cjiWR53WdWeWZdRlMO/P8vj+I1SOgolYRYIB834BNH9TK6xg?= =?us-ascii?Q?avxNREGmLrm4h1ynwvhdCNIeyhGcPlE56MFQ3dUxlekc12jNlD4MMgeC95O4?= =?us-ascii?Q?Rd0TEDb6vDLY6cLmye/zUx+v4eOmotl+tLG17kMr?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8333cf9-6a03-4184-ba57-08da5e62bdc7 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2022 08:45:40.9510 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mYjSGYKIuuGQfZOhpdA7rHU4G2CO76TooA15vyUxeTRF9V6HsWB/nVrO3RXYGrtNp1cU256gcg4DXA0yA/7Ctw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1507 Return-Path: james.lu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN6PR11MB1908E6EB0B9F2B2705382F9288819BN6PR11MB1908namp_" --_000_BN6PR11MB1908E6EB0B9F2B2705382F9288819BN6PR11MB1908namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Replied as below Thanks, James -----Original Message----- From: Ni, Ray Sent: Monday, July 4, 2022 11:34 AM To: Lu, James ; devel@edk2.groups.io Cc: Dong, Guo ; Guo, Gua Subject: RE: [PATCH] UefiPayloadPkg: Add macro to support selective driver = in UPL > > +!if $(GENERIC_MEMORY_TEST_ENABLE) =3D=3D TRUE > > + > MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/Generic > MemoryTestDxe.inf > > +!endif > > +!if $(NULL_MEMORY_TEST_ENABLE) =3D=3D TRUE > > > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryT > estDxe.inf > > +!endif 1. Is there a configuration that both GENERIC and NULL memory test is FALSE= ? If no, can we add a macro like "MEMORY_TEST" and its value could be "GENERI= C" or "NULL"? [James] Will resolve in patch v2 > +!if $(ATA_ENABLE) =3D=3D TRUE > > MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > > MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf 2. AtaAtapiPassThru also produces "gEfiExtScsiPassThruProtocolGuid" which i= s used by ScsiBusDxe. So, maybe we need to always include AtaAtapiPassThru driver. [James] This is to align client case that AtaAtapiPassThru.inf will not be included= while ATA_ENABLE =3D=3D FALSE And ScsiBusDxe is taken care the flow while gEfiExtScsiPassThruProtocolGuid= not existing > > # > > # Usb Support > > @@ -671,7 +685,9 @@ > !if $(PS2_KEYBOARD_ENABLE) =3D=3D TRUE > > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > > !endif > > +!if $(PS2_MOUSE_ENABLE) =3D=3D TRUE > > MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf > > +!endif > > > > # > > # Console Support > > @@ -742,12 +758,14 @@ > # This should be FALSE for compiling the dynamic command. > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > } > > +!if $(PERFORMANCE_MEASUREMENT_ENABLE) =3D=3D TRUE 3. Thanks for catching that. --_000_BN6PR11MB1908E6EB0B9F2B2705382F9288819BN6PR11MB1908namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Replied as below

 

 

Thanks,

James

 

-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Monday, July 4, 2022 11:34 AM
To: Lu, James <james.lu@intel.com>; devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Guo, Gua <gua.guo@intel.com>= ;
Subject: RE: [PATCH] UefiPayloadPkg: Add macro to support selective driver = in UPL

 

>

> +!if $(GENERIC_MEMORY_TEST_ENABLE) =3D=3D TR= UE

>

> +

> MdeModulePkg/Universal/MemoryTest/GenericMem= oryTestDxe/Generic

> MemoryTestDxe.inf

>

> +!endif

>

> +!if $(NULL_MEMORY_TEST_ENABLE) =3D=3D TRUE<= o:p>

>

>

> MdeModulePkg/Universal/MemoryTest/NullMemory= TestDxe/NullMemoryT

> estDxe.inf

>

> +!endif

 

1. Is there a configuration that both GENERIC and= NULL memory test is FALSE?

If no, can we add a macro like "MEMORY_TEST&= quot; and its value could be "GENERIC" or "NULL"?<= /o:p>

[James]

Will resolve in patch v2

 

 

> +!if $(ATA_ENABLE) =3D=3D TRUE

>

>    MdeModulePkg/Bus/Pci/SataC= ontrollerDxe/SataControllerDxe.inf

>

>    MdeModulePkg/Bus/Ata/AtaBu= sDxe/AtaBusDxe.inf

>

>    MdeModulePkg/Bus/Ata/AtaAt= apiPassThru/AtaAtapiPassThru.inf

 

2. AtaAtapiPassThru also produces "gEfiExtSc= siPassThruProtocolGuid" which is used by ScsiBusDxe.

So, maybe we need to always include AtaAtapiPassT= hru driver.

[James]

This is to align client case that AtaAtapiPassThru.inf wi= ll not be included while ATA_ENABLE =3D=3D FALSE

And ScsiBusDxe is taken care the flow while gEfiExtScsiPa= ssThruProtocolGuid not existing

 

>

>    #

>

>    # Usb Support

>

> @@ -671,7 +685,9 @@

>  !if $(PS2_KEYBOARD_ENABLE) =3D=3D TRUE=

>

>    MdeModulePkg/Bus/Isa/Ps2Ke= yboardDxe/Ps2KeyboardDxe.inf

>

>  !endif

>

> +!if $(PS2_MOUSE_ENABLE) =3D=3D TRUE

>

>    MdeModulePkg/Bus/Isa/Ps2Mo= useDxe/Ps2MouseDxe.inf

>

> +!endif

>

>

>

>    #

>

>    # Console Support

>

> @@ -742,12 +758,14 @@

>        #&= nbsp; This should be FALSE for compiling the dynamic command.

>

>        gE= fiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE

>

>    }

>

> +!if $(PERFORMANCE_MEASUREMENT_ENABLE) =3D= =3D TRUE

 

3. Thanks for catching that.

--_000_BN6PR11MB1908E6EB0B9F2B2705382F9288819BN6PR11MB1908namp_--