From: "Loh, Tien Hock" <tien.hock.loh@intel.com>
To: Haojian Zhuang <haojian.zhuang@linaro.org>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"christopher.Co@microsoft.com" <christopher.Co@microsoft.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"thloh85@gmail.com" <thloh85@gmail.com>
Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver
Date: Fri, 19 Jun 2020 08:48:02 +0000 [thread overview]
Message-ID: <BN6PR11MB38603D3400B55AB9DB1D9819BD980@BN6PR11MB3860.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MN2PR11MB38695E3F135DDE9F954E020CBD9D0@MN2PR11MB3869.namprd11.prod.outlook.com>
Hi Leif, Ard,
Can you help on the questions I have below?
Thanks!
> -----Original Message-----
> From: Loh, Tien Hock
> Sent: Tuesday, June 16, 2020 4:39 PM
> To: 'Haojian Zhuang' <haojian.zhuang@linaro.org>; 'leif.lindholm@linaro.org'
> <leif.lindholm@linaro.org>; 'ard.biesheuvel@linaro.org'
> <ard.biesheuvel@linaro.org>; 'christopher.Co@microsoft.com'
> <christopher.Co@microsoft.com>
> Cc: 'devel@edk2.groups.io' <devel@edk2.groups.io>; 'thloh85@gmail.com'
> <thloh85@gmail.com>
> Subject: RE: [PATCH v2 0/3] add DwMmcHcDxe driver
>
> Hi Leif, Ard,
>
> I talked to Haojian and got to know that you wanted the patch to go into the
> MdeModulePkg.
> I don't have a lot of context on it, do you have specific requirement?
> The driver at its current state already uses the MdeModulePkg's SdDxe's API, so
> some more specific changes would help me understand and fix the concern you
> have.
>
> Thanks
>
> > -----Original Message-----
> > From: Loh, Tien Hock
> > Sent: Thursday, September 12, 2019 12:59 PM
> > To: Haojian Zhuang <haojian.zhuang@linaro.org>;
> > leif.lindholm@linaro.org; ard.biesheuvel@linaro.org;
> > christopher.Co@microsoft.com
> > Cc: devel@edk2.groups.io; thloh85@gmail.com
> > Subject: RE: [PATCH v2 0/3] add DwMmcHcDxe driver
> >
> > Hi Ard, Leif, Christopher,
> >
> > Any comments on the patches?
> >
> > Thanks!
> > Tien Hock
> > > -----Original Message-----
> > > From: Haojian Zhuang <haojian.zhuang@linaro.org>
> > > Sent: Monday, September 2, 2019 5:31 PM
> > > To: Loh, Tien Hock <tien.hock.loh@intel.com>
> > > Cc: leif.lindholm@linaro.org; ard.biesheuvel@linaro.org;
> > > christopher.Co@microsoft.com; devel@edk2.groups.io;
> > > thloh85@gmail.com
> > > Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver
> > >
> > > Hi Leif, Ard, Christopher,
> > >
> > > Could you help to share the comments on this patch set? Thanks a lot.
> > >
> > > Best Regards
> > > Haojian
> > >
> > > On Thu, Aug 15, 2019 at 09:09:19AM +0000, Loh, Tien Hock wrote:
> > > > Hi Leif, Ard, Christopher,
> > > >
> > > > Haojian and I have tested the driver on 2 platforms, any further
> > > > comments
> > > on this?
> > > >
> > > > Thanks
> > > > Tien Hock
> > > >
> > > > > -----Original Message-----
> > > > > From: Haojian Zhuang <haojian.zhuang@linaro.org>
> > > > > Sent: Tuesday, July 30, 2019 3:33 PM
> > > > > To: Loh, Tien Hock <tien.hock.loh@intel.com>;
> > > > > leif.lindholm@linaro.org; ard.biesheuvel@linaro.org;
> > > > > christopher.Co@microsoft.com
> > > > > Cc: devel@edk2.groups.io; thloh85@gmail.com
> > > > > Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver
> > > > >
> > > > > On Wed, Jul 24, 2019 at 05:26:03PM +0800,
> > > > > tien.hock.loh@intel.com
> > > wrote:
> > > > > > From: "Tien Hock, Loh" <tien.hock.loh@intel.com>
> > > > > >
> > > > > > Changelog:
> > > > > > v3:
> > > > > > * Fix an issue in NonDiscoverableDeviceDxe driver where it
> > > > > > did not
> > > > > invalidate
> > > > > > cache before copying the memory.
> > > > > > v2:
> > > > > > *Split DwMmcHcDxe driver into two patches. One is for
> > > > > > PlatformDwMmc
> > > > > protocol,
> > > > > > and the other is for DwMmcHcDxe driver.
> > > > > > v1:
> > > > > > *Add NonDiscoverableDeviceDxe for embedded platform. Make
> > > > > DwMmcHcDxe driver
> > > > > > to support both eMMC and SD controller.
> > > > > >
> > > > > > Haojian Zhuang (3):
> > > > > > EmbeddedPkg: add NonDiscoverableDeviceDxe driver
> > > > > > EmbeddedPkg: add PlatformDwMmc protocol
> > > > > > EmbeddedPkg/Drivers: add DwMmcHcDxe driver
> > > > > >
> > > > > > .../Drivers/DwMmcHcDxe/ComponentName.c | 214 ++
> > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c | 1295
> > > > > +++++++++
> > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec | 40 +
> > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h | 815
> > > ++++++
> > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf | 69 +
> > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c | 2366
> > > > > +++++++++++++++++
> > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h | 983
> +++++++
> > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c | 1042
> > > ++++++++
> > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c | 1104 ++++++++
> > > > > > EmbeddedPkg/EmbeddedPkg.dec | 1 +
> > > > > > EmbeddedPkg/Include/Protocol/PlatformDwMmc.h | 79 +
> > > > > > .../NonDiscoverableDeviceDxe/ComponentName.c | 124 +
> > > > > > .../NonDiscoverableDeviceDxe.c | 243 ++
> > > > > > .../NonDiscoverableDeviceDxe.inf | 52 +
> > > > > > .../NonDiscoverableDeviceIo.c | 976 +++++++
> > > > > > .../NonDiscoverableDeviceIo.h | 92 +
> > > > > > 16 files changed, 9495 insertions(+) create mode 100644
> > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c
> > > > > > create mode 100644
> > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c
> > > > > > create mode 100644
> > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec
> > > > > > create mode 100644
> > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h
> > > > > > create mode 100644
> > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf
> > > > > > create mode 100644
> > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c
> > > > > > create mode 100644
> > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h
> > > > > > create mode 100644
> > > EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c
> > > > > > create mode 100644
> EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c
> > > > > > create mode 100644
> > > EmbeddedPkg/Include/Protocol/PlatformDwMmc.h
> > > > > > create mode 100644
> > > > > >
> > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c
> > > > > > create mode 100644
> > > > > >
> > > > >
> > >
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic
> > > > > eDx
> > > > > > e.c create mode 100644
> > > > > >
> > > > >
> > >
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic
> > > > > eDx
> > > > > > e.inf create mode 100644
> > > > > >
> > > > >
> > >
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic
> > > > > eIo
> > > > > > .c create mode 100644
> > > > > >
> > > > >
> > >
> EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic
> > > > > eIo
> > > > > > .h
> > > > > >
> > > > > > --
> > > > > > 2.19.0
> > > > > >
> > > > >
> > > > > Hi Leif, Ard & Chris,
> > > > >
> > > > > Could you help to share your comments on this patch set?
> > > > >
> > > > > Best Regards
> > > > > Haojian
next prev parent reply other threads:[~2020-06-19 8:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 9:26 [PATCH v2 0/3] add DwMmcHcDxe driver Loh, Tien Hock
2019-07-24 9:26 ` [PATCH v2 1/3] EmbeddedPkg: add NonDiscoverableDeviceDxe driver Loh, Tien Hock
2019-07-24 9:26 ` [PATCH v2 2/3] EmbeddedPkg: add PlatformDwMmc protocol Loh, Tien Hock
2019-07-24 9:26 ` [PATCH v2 3/3] EmbeddedPkg/Drivers: add DwMmcHcDxe driver Loh, Tien Hock
2019-07-25 5:09 ` [PATCH v2 0/3] " haojian.zhuang
2019-07-30 7:33 ` Haojian Zhuang
2019-08-15 9:09 ` Loh, Tien Hock
2019-09-02 9:31 ` Haojian Zhuang
2019-09-12 4:59 ` Loh, Tien Hock
2020-06-16 8:38 ` Loh, Tien Hock
2020-06-19 8:48 ` Loh, Tien Hock [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-07-24 9:21 Loh, Tien Hock
2018-08-15 7:36 Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR11MB38603D3400B55AB9DB1D9819BD980@BN6PR11MB3860.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox