From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.2505.1592556485562953745 for ; Fri, 19 Jun 2020 01:48:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=uESCrEL6; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: tien.hock.loh@intel.com) IronPort-SDR: MUmmyMkA6KwEMfSiizGhjgvb22E+HCxuag4YQ2t5RN8ZyeHKchXESnaaHR5DZ1fm1MHsxkD9BE 2Qt2vA4jr1YA== X-IronPort-AV: E=McAfee;i="6000,8403,9656"; a="130257366" X-IronPort-AV: E=Sophos;i="5.75,254,1589266800"; d="scan'208";a="130257366" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2020 01:48:04 -0700 IronPort-SDR: 5dKhNY44euFIbuJquEYrN7parSpGmHA6eruWWTvMyvc2dTq5606ikNcApy7b8WCSgTDtQpl+Ds pBrrDJkEOjSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,254,1589266800"; d="scan'208";a="277938120" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga006.jf.intel.com with ESMTP; 19 Jun 2020 01:48:04 -0700 Received: from orsmsx124.amr.corp.intel.com (10.22.240.120) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 19 Jun 2020 01:48:04 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX124.amr.corp.intel.com (10.22.240.120) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 19 Jun 2020 01:48:03 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 19 Jun 2020 01:48:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cZiuvaIegaoskAYwHI5KzIDmtCUZ1Ve6VASdqOnmABJGZisSD27/nGy2hh8/Vyq/14BFaWJunJYQrrTwvP5deGheDevgnUr97s2Q4pV0E0hCP+xD7GgfPR6Pmtx7AQAyn8gO+k2G9KdfPtAuKSpVjFAphgxqLgH1QAgoE6r9beTs1poAi5xNBoXHDqD1Uls5vxGn7O/ByUGqN0/nrkH0Z4i2lgsStw8n2ixjni0xL+N58AuRrcc6Siy0lDti2ie/nrc64Vd/qturEMjn/5P5I9FMT2a6teuApVjoQYpQSekUT3Ku7u2F4zdFhaUpFd9TVYWvMYRA1LvM7qbAHaiM6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SXhJ5doJH7vgOmbMaQNNzB6XdC/O6ExPn+xatgK3CBc=; b=ShSt69pdZIWpKtywv629tsChKmei3KHTRAhugkIFMCddkcdm7ZnoJoWx+1w+SKk6tuJ8yiksWiZcAxMoCymUDZYNgV9HstyESnWkhE7GPyQ5NlUazNIK0zMIhz6Dv/k6cotjksRjoBTNPE9Q/kqEFdMrG1So8TQxwAxTn/ma6nDvyF+OdVRzMwDn5MLtz+Kl3DAQtkW9cvyg2NmLBA3li4mlUNxwabfkFUkA5etkSS9+z/8q4iNX8Ng2jdZxJaUIYYxDMvNPMw8/4K8+6oTLYQ9zbedxjOh23kJF/ZkgUExz+F/zYhSyjN3+joDG+ATb6CDiEPPPzEeOGjPxwiM2hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SXhJ5doJH7vgOmbMaQNNzB6XdC/O6ExPn+xatgK3CBc=; b=uESCrEL6NmtNltKhkNrnmPwbw+Q9EVB1/EIneA5jqOJhOoUcR4Dt3JB7DwzwfHxwHfDBGohdnwJkhv8t23e/PAejFdnoK9ESwSEOFm34xaBah6p5pRyh9Lh3g2JGNZNfP0S8to9dkSFTeux/K+u8yoPwNpFQkHt1vw+ALiSxsdE= Received: from BN6PR11MB3860.namprd11.prod.outlook.com (2603:10b6:405:77::14) by BN7PR11MB2706.namprd11.prod.outlook.com (2603:10b6:406:b3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Fri, 19 Jun 2020 08:48:02 +0000 Received: from BN6PR11MB3860.namprd11.prod.outlook.com ([fe80::8154:470e:db9c:99bd]) by BN6PR11MB3860.namprd11.prod.outlook.com ([fe80::8154:470e:db9c:99bd%7]) with mapi id 15.20.3109.023; Fri, 19 Jun 2020 08:48:02 +0000 From: "Loh, Tien Hock" To: Haojian Zhuang , "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" , "christopher.Co@microsoft.com" CC: "devel@edk2.groups.io" , "thloh85@gmail.com" Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver Thread-Topic: [PATCH v2 0/3] add DwMmcHcDxe driver Thread-Index: AQHVQgHjv9n2w3nTgkexcjW/jhKm4abiR+kAgBnGCbCAG8pEAIAP8SvwgbUkV1CABLrREA== Date: Fri, 19 Jun 2020 08:48:02 +0000 Message-ID: References: <20190724092606.185319-1-tien.hock.loh@intel.com> <20190730073300.GH6058@gmail.com> <20190902093116.GA29393@hackbox2.linaro.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.220] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6a3ff5f7-4bf6-4e99-e35c-08d8142d79fc x-ms-traffictypediagnostic: BN7PR11MB2706: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0439571D1D x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nS6iWnMNuXcFJtiReqUG3emTSsDQvwWcN+kAIsPQH4WqwnwKrnF6PIAUnfOPbiQf4ttMTTg+Rh78qHR+nhCPzLl05zdYV9waz0fP8Lma9fz6dWoB5yG+O8nJTtezLAwKXWp3hTSiMcVSy8z+vp39mMg8ZNjnTUALsxgw2gjubBUPpMcdIMKX74cwUAbI7YDUjJTXCPWpVzNV3v/Jtij10ZzX9nRksf81jnge0szBwL4Ge91UBDu16wePvIUwY5cFbRGACVZdaoMmwrDqEJ0Xhgp/9nSDURhrYHvP0xxX0Kn19RfwqZepY1AByWE9pL4K9eyy73z40pwBtUtQcLQE/Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3860.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(4636009)(396003)(366004)(346002)(136003)(39860400002)(376002)(53546011)(6506007)(66476007)(110136005)(66446008)(52536014)(64756008)(66556008)(478600001)(2906002)(8936002)(76116006)(316002)(45080400002)(55016002)(33656002)(54906003)(66946007)(8676002)(26005)(86362001)(5660300002)(9686003)(7696005)(83380400001)(4326008)(71200400001)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: kzCM8cLgF/kSn/Dsumxe4ltk9DhU3yiPgi/asI5mD9j63h2fra3HKi6UoKLeYY/natp+2jFjPnX99ZcDWwE77ve23JQF1hthFsTJOHY3djbeU/5nb54OaC1YAciPZ992aMy97cV34RU53C6lzsBOYRutC8Mihlm7yWCGgaUVFjqxQpQDlklcysGU4WnNHm52mebXZ4EZorG4dmBnblaOBe7gSGIq8VYSDSpK0Psw2y7IswTMPw7OCvGidckKc4enJfHrzIIs571tMlSfxWZqQTTU/4IpUniLRVxCmM/8CZCLDpMbCNAuwscFV5dEYSa+fkOKQoAO0OSxOWsCqdBm+rXg2dg0iWbvGDXtu+VECZPc7/H24YU9gUO2NLdOPsEHDQ37nvX2MpjEkPgm/r8N6UX6EIQDjMIdwTE83iJeryt7jBG9KqIgYmyWcRhv3FYvwQtaOYbBEyOwIz4xBKjVdVQC2mfJ4UdXR4KvUinM6lWPXisFz0OOmQsLKm45Lilc x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 6a3ff5f7-4bf6-4e99-e35c-08d8142d79fc X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2020 08:48:02.2567 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BosbQqnEuQ2ET89kObq8o+1fq4RiZmR0Ly7wC0L2+Xd3eSdHA/ZnMNz9VMDDR682P5cbB22zl/R2E6Jhor8kYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2706 Return-Path: tien.hock.loh@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, Ard, Can you help on the questions I have below? Thanks!=20 > -----Original Message----- > From: Loh, Tien Hock > Sent: Tuesday, June 16, 2020 4:39 PM > To: 'Haojian Zhuang' ; 'leif.lindholm@linaro.o= rg' > ; 'ard.biesheuvel@linaro.org' > ; 'christopher.Co@microsoft.com' > > Cc: 'devel@edk2.groups.io' ; 'thloh85@gmail.com' > > Subject: RE: [PATCH v2 0/3] add DwMmcHcDxe driver >=20 > Hi Leif, Ard, >=20 > I talked to Haojian and got to know that you wanted the patch to go into = the > MdeModulePkg. > I don't have a lot of context on it, do you have specific requirement? > The driver at its current state already uses the MdeModulePkg's SdDxe's A= PI, so > some more specific changes would help me understand and fix the concern y= ou > have. >=20 > Thanks >=20 > > -----Original Message----- > > From: Loh, Tien Hock > > Sent: Thursday, September 12, 2019 12:59 PM > > To: Haojian Zhuang ; > > leif.lindholm@linaro.org; ard.biesheuvel@linaro.org; > > christopher.Co@microsoft.com > > Cc: devel@edk2.groups.io; thloh85@gmail.com > > Subject: RE: [PATCH v2 0/3] add DwMmcHcDxe driver > > > > Hi Ard, Leif, Christopher, > > > > Any comments on the patches? > > > > Thanks! > > Tien Hock > > > -----Original Message----- > > > From: Haojian Zhuang > > > Sent: Monday, September 2, 2019 5:31 PM > > > To: Loh, Tien Hock > > > Cc: leif.lindholm@linaro.org; ard.biesheuvel@linaro.org; > > > christopher.Co@microsoft.com; devel@edk2.groups.io; > > > thloh85@gmail.com > > > Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver > > > > > > Hi Leif, Ard, Christopher, > > > > > > Could you help to share the comments on this patch set? Thanks a lot. > > > > > > Best Regards > > > Haojian > > > > > > On Thu, Aug 15, 2019 at 09:09:19AM +0000, Loh, Tien Hock wrote: > > > > Hi Leif, Ard, Christopher, > > > > > > > > Haojian and I have tested the driver on 2 platforms, any further > > > > comments > > > on this? > > > > > > > > Thanks > > > > Tien Hock > > > > > > > > > -----Original Message----- > > > > > From: Haojian Zhuang > > > > > Sent: Tuesday, July 30, 2019 3:33 PM > > > > > To: Loh, Tien Hock ; > > > > > leif.lindholm@linaro.org; ard.biesheuvel@linaro.org; > > > > > christopher.Co@microsoft.com > > > > > Cc: devel@edk2.groups.io; thloh85@gmail.com > > > > > Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver > > > > > > > > > > On Wed, Jul 24, 2019 at 05:26:03PM +0800, > > > > > tien.hock.loh@intel.com > > > wrote: > > > > > > From: "Tien Hock, Loh" > > > > > > > > > > > > Changelog: > > > > > > v3: > > > > > > * Fix an issue in NonDiscoverableDeviceDxe driver where it > > > > > > did not > > > > > invalidate > > > > > > cache before copying the memory. > > > > > > v2: > > > > > > *Split DwMmcHcDxe driver into two patches. One is for > > > > > > PlatformDwMmc > > > > > protocol, > > > > > > and the other is for DwMmcHcDxe driver. > > > > > > v1: > > > > > > *Add NonDiscoverableDeviceDxe for embedded platform. Make > > > > > DwMmcHcDxe driver > > > > > > to support both eMMC and SD controller. > > > > > > > > > > > > Haojian Zhuang (3): > > > > > > EmbeddedPkg: add NonDiscoverableDeviceDxe driver > > > > > > EmbeddedPkg: add PlatformDwMmc protocol > > > > > > EmbeddedPkg/Drivers: add DwMmcHcDxe driver > > > > > > > > > > > > .../Drivers/DwMmcHcDxe/ComponentName.c | 214 ++ > > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c | 1295 > > > > > +++++++++ > > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec | 40 + > > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h | 815 > > > ++++++ > > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf | 69 + > > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c | 2366 > > > > > +++++++++++++++++ > > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h | 983 > +++++++ > > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c | 1042 > > > ++++++++ > > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c | 1104 ++++++++ > > > > > > EmbeddedPkg/EmbeddedPkg.dec | 1 + > > > > > > EmbeddedPkg/Include/Protocol/PlatformDwMmc.h | 79 + > > > > > > .../NonDiscoverableDeviceDxe/ComponentName.c | 124 + > > > > > > .../NonDiscoverableDeviceDxe.c | 243 ++ > > > > > > .../NonDiscoverableDeviceDxe.inf | 52 + > > > > > > .../NonDiscoverableDeviceIo.c | 976 +++++++ > > > > > > .../NonDiscoverableDeviceIo.h | 92 + > > > > > > 16 files changed, 9495 insertions(+) create mode 100644 > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c > > > > > > create mode 100644 > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c > > > > > > create mode 100644 > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec > > > > > > create mode 100644 > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h > > > > > > create mode 100644 > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf > > > > > > create mode 100644 > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c > > > > > > create mode 100644 > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h > > > > > > create mode 100644 > > > EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c > > > > > > create mode 100644 > EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c > > > > > > create mode 100644 > > > EmbeddedPkg/Include/Protocol/PlatformDwMmc.h > > > > > > create mode 100644 > > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c > > > > > > create mode 100644 > > > > > > > > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > > > > eDx > > > > > > e.c create mode 100644 > > > > > > > > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > > > > eDx > > > > > > e.inf create mode 100644 > > > > > > > > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > > > > eIo > > > > > > .c create mode 100644 > > > > > > > > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > > > > eIo > > > > > > .h > > > > > > > > > > > > -- > > > > > > 2.19.0 > > > > > > > > > > > > > > > > Hi Leif, Ard & Chris, > > > > > > > > > > Could you help to share your comments on this patch set? > > > > > > > > > > Best Regards > > > > > Haojian