From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.8611.1589298444945145602 for ; Tue, 12 May 2020 08:47:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=SQ43PYpu; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: liming.gao@intel.com) IronPort-SDR: UkLfFYrQlyQNvI/PBaufy3rAdB54S+9CxojyM3OYoGf06LiXElKqzKMo5p3pBy2W0gFxfsn0Ni cwmFoMesySoA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2020 08:47:24 -0700 IronPort-SDR: alfGqNF3SB7AEHIgqszPhsLwFvIgnHmXRRXVYMNgf/v60XdFiX7DWV3dALNmcUFljQGYAYxV6W KsifnPn19Ycw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,384,1583222400"; d="scan'208";a="286697171" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 12 May 2020 08:47:22 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 08:47:19 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 08:47:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LJBvXXw/Sz5//LO1PtjCgums4L9TCS0owGXuzXZg5+piAXcaI/qywLfKjWm5ZnjzLEdrjXfKyh/DQTSp0qYcDUHOhs6G3M3j4AIkWhW/l8LNdd5Ojt0QTv+CQ0D/oJuG4S9KxaH5BJZomL2QGIBRZ1DsChgYEWpsav/7jC7iVVCM4sEwoeEPBr3JfnfsUHFXbIUTPNmsUmrpnd495yAQ0I9f8miIgHaoyVnjOoxclgf9JXHEIiZ7R49PtVnDwTUDZyxofJkrsAO/EDVlyfdwY9yuizkXuw4KwxCqymRu70Kw93Q0Qk6l4AaXFmOgfv2RbstSEYyH8Y2dnNM5m+xraQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2uhGe8xLj+xvmD3Tvl6OcVesQiVLdysgdRT2ktfPC+8=; b=LD7+z5JkDyFIvuaY94LQnc5RgTv5fHO9nVGqLGCxlOW0vSL6RWf2lHndE9h5hedqLnqgXcK23jxayXEwv/pai0vfR3NdhvbvN/4MYlC6snuhlbM+1oTSYmACvzCACDAVRaxub6FDjHKHZCssSOij+PO4DVJ2O7KMX57PWjWisywQ4O9Owqd/RBk74y1EVI3kB51hqr58RcgjJKwwejqTikEwcEBsNL1xoc8qqrvj9tEOQ4zOIRYmoOzMKVt2JLNemXdDN4pMB4f0dKAD3mUXNX0tRNBWULf8uKpS2dKV/knyuj6E/xQu5xyer7tO0QNGix2axFhwkiZjIwXZV7i/VA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2uhGe8xLj+xvmD3Tvl6OcVesQiVLdysgdRT2ktfPC+8=; b=SQ43PYpugFmRbZAWIuzUPSyHA7eD/Y2d6pKf7psYCH+pSZVi6zaWNV6p2d87jOAcTKft+mfkxqy8rGnXxjGrW2CjH9DTZXKfTndpgVGlP2ckqKI2HzWP1m3qzO4gokK+u1BVo2PI3APKYHkw9JA+Hitr12dk1n3tLKgvXJY5KIo= Received: from BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) by BN6PR11MB1905.namprd11.prod.outlook.com (2603:10b6:404:ff::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26; Tue, 12 May 2020 15:47:14 +0000 Received: from BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0]) by BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0%7]) with mapi id 15.20.2979.033; Tue, 12 May 2020 15:47:14 +0000 From: "Liming Gao" To: "devel@edk2.groups.io" , "oleksiyy@ami.com" , "Xu, Wei6" CC: "Kinney, Michael D" , "Wang, Jian J" , "Wu, Hao A" , Felix Polyudov Subject: Re: [edk2-devel] [PATCH V3 5/5] MdeModulePkg: Add FMP Capsule Image Header extension Thread-Topic: [edk2-devel] [PATCH V3 5/5] MdeModulePkg: Add FMP Capsule Image Header extension Thread-Index: AQHWJ95gbk8ZQF6h+USqpFFF34F4YKijvSsAgADPHgCAAAxikA== Date: Tue, 12 May 2020 15:47:13 +0000 Message-ID: References: <20200511215040.31780-1-oleksiyy@ami.com> <20200511215040.31780-6-oleksiyy@ami.com> <6BD875C24FFE2A4E8D6EFC142C67836F03FFFFA072@atlms1.us.megatrends.com> In-Reply-To: <6BD875C24FFE2A4E8D6EFC142C67836F03FFFFA072@atlms1.us.megatrends.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f0193789-9bbd-4bc0-fcd4-08d7f68bbdb9 x-ms-traffictypediagnostic: BN6PR11MB1905: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3276; x-forefront-prvs: 0401647B7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CN6jlU3BEejNIxnQndxxzolSv/T7ekmxy3qOE9FP6clFvgaLPhKy9Jl3bnYMPsQI5k0xxr5xI00uKB++odHBfB20vSxNMkIrYm5ysa9LiTsBSCoAiKNmuKMbMOLyWk2j07z35vt2vieLxzJucOtOq8uQ4tm5DAuuG+2RR2U2e/QzaH8NUEIgz+17taODQkw8dusg5MJOZBUvj+wwNQwBBDwGLFcb9iLkRJO2kFsGXKrsIXux30J9IWeaFzrJWEkd8E0q3stV2riuQvpjqnIZyFqmewbKp3RMwrw0N1xzR72tGSpDFrzsnq99APAcJTZLtwUIlrcCew8m6p327K+yTzvWBrtbXaCWzHqwvil8Q5IeJHYH+n+lXBEwKe6S4H/JwUrHQwsUQXikZUE2ZmxglYPv5SW6cnmBuJlokNEGkT7vrR1dHqgBY0Afkf1/iGOiPS1le/7O58v9HvHEDZfdi+fT9em7pKdypOI7U+rgxngL6Uitof864tWxx9Ly3qsSdd3EK7++KFOPqh8+GT3FmzjN65QWlX6yBynR7yVLLo7gHlwquGAk0t6nONZM4BWou9nmYNjyVXmMw0jLj/dKJGqnKLp5bfs1qHeQUBbRrKU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3972.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(376002)(346002)(39860400002)(396003)(136003)(33430700001)(33656002)(110136005)(54906003)(478600001)(55016002)(316002)(2906002)(9686003)(52536014)(7696005)(6506007)(53546011)(966005)(66556008)(76116006)(71200400001)(66946007)(8936002)(66476007)(64756008)(33440700001)(8676002)(66446008)(5660300002)(86362001)(186003)(6636002)(4326008)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 4QrAUIdW6h8XFOMKZrSfgYusInKxE+vsW7wARKDl83PJNVo/kcJWlPCOiYBp99YAUaAXw/y/4Cb9FHMrW+AGXRWTGgjLPJx1oQHr+cA6TfVWYqFWYWrGCtZBbfPYI4sf0MHs9Q2s0wWwtruLGn9pdEf3Zodlpw/a79yF6vs1cvdJQDWGpa5PNkFdpWObGNAKmKMABfnQHPJa07BjQhkHbh1so/BTP1eydTE8Q2WAy16wDgheEHtqyGoK5ZWrsPsbP/SGpu0eP9f45oqD0Z4ZCHZrnZiVK6b6meX4WijPrwuE7OsLny3EmBejEeL5oJ0TXHuCB6+5qA0l+P0AoinzWGEBJtYvxIS5ZOZH9oKJ3yuL29cmF/Lm/Q2odeIlURCqpDXw8Y6kjzzJFCE01ylHg2qxWHGD5CoEIKFFB2wFztE2N+D+1Sh30Md76mWjds1a6JBBY4SUXem363o4yaSda9Uu+LzzF4181pTJij6dp9CXK5Kaqp+eHWUfWoTcYnaN MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f0193789-9bbd-4bc0-fcd4-08d7f68bbdb9 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2020 15:47:13.8285 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y4sShU+z9Z8iEWFAq9n7B0ZbJGV5EQ8g/EWMY9u2J4gdJCWJWvw1W707kocOjSE5ZRzHMMKrLK9odcGFR9XGtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1905 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Oleksiy: I understand your purpose. But, if new definition brings the incompatibl= e change to the existing driver, we need to update the driver and avoid the= impact. So, Wei suggests you to check version and keep current implementat= ion. Wei doesn't request to support the new feature.=20 Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oleksiy Y= akovlev > Sent: Tuesday, May 12, 2020 11:00 PM > To: Xu, Wei6 ; devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D ; Wang, Jian J ; Wu, > Hao A ; Felix Polyudov > Subject: Re: [edk2-devel] [PATCH V3 5/5] MdeModulePkg: Add FMP Capsule I= mage Header extension >=20 > Hi Wei. >=20 > The intention of this patch series was to add headers to MdePkg, to make= it possible start working on features implementation. > Implementing all features in all affected files through all possible mod= ule was not in my intentions at all. > I agreed to change DxeCapsuleLib to speed up adoption of this series. We= need this headers ASAP to start implementing those > features in our own products. So we need headers before soft freeze. >=20 > Regards, Oleksiy. >=20 > -----Original Message----- > From: Xu, Wei6 [mailto:wei6.xu@intel.com] > Sent: Monday, May 11, 2020 10:39 PM > To: devel@edk2.groups.io; Oleksiy Yakovlev > Cc: Gao, Liming; Kinney, Michael D; Wang, Jian J; Wu, Hao A; Felix Polyu= dov > Subject: RE: [edk2-devel] [PATCH V3 5/5] MdeModulePkg: Add FMP Capsule I= mage Header extension >=20 > Hi Oleksiy, >=20 > Thanks a lot for the update. But besides it, there are several other pla= ces need to be updated as well: > https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Application/C= apsuleApp/CapsuleDump.c#L99 > https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Library/DxeCa= psuleLibFmp/DxeCapsuleLib.c#L522 > https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Library/DxeCa= psuleLibFmp/DxeCapsuleLib.c#L926 > https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Library/DxeCa= psuleLibFmp/DxeCapsuleLib.c#L946 > https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Library/DxeCa= psuleLibFmp/DxeCapsuleLib.c#L1242 > https://github.com/tianocore/edk2/blob/master/SignedCapsulePkg/Universal= /RecoveryModuleLoadPei/RecoveryModuleLoadPei.c#L3 > 31 > https://github.com/tianocore/edk2/blob/master/SignedCapsulePkg/Universal= /RecoveryModuleLoadPei/RecoveryModuleLoadPei.c#L6 > 37 >=20 > BR, > Wei >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oleksiy Y= akovlev > Sent: Tuesday, May 12, 2020 5:51 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D ; Wang, Jian J ; Wu, > Hao A ; Felixp@ami.com; oleksiyy@ami.com > Subject: [edk2-devel] [PATCH V3 5/5] MdeModulePkg: Add FMP Capsule Image= Header extension >=20 > Add bitmask to structure which gives a binary-inspectable mechanism to d= etermine if a capsule contains an authentication section or > depex section. > (UEFI 2.8 errata a, mantis 2026) >=20 > Signed-off-by: Oleksiy Yakovlev > --- > MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c b/Mde= ModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c > index 5dda561..af80039 100644 > --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c > +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c > @@ -285,8 +285,10 @@ ValidateFmpCapsule ( > DEBUG((DEBUG_ERROR, "ImageHeader->Version(0x%x) Unknown\n", Image= Header->Version)); > return EFI_INVALID_PARAMETER; > } > - if (ImageHeader->Version < EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HE= ADER_INIT_VERSION) { > + if (ImageHeader->Version =3D=3D 1) { > FmpImageHeaderSize =3D OFFSET_OF(EFI_FIRMWARE_MANAGEMENT_CAPSULE_= IMAGE_HEADER, UpdateHardwareInstance); > + } else { > + FmpImageHeaderSize =3D > + OFFSET_OF(EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER, > + ImageCapsuleSupport); > } > if (FmpImageSize < FmpImageHeaderSize) { > DEBUG((DEBUG_ERROR, "FmpImageSize(0x%lx) < FmpImageHeaderSize(0x%= x)\n", FmpImageSize, FmpImageHeaderSize)); > -- > 2.9.0.windows.1 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and propri= etary to American Megatrends (AMI). This communication > is intended to be read only by the individual or entity to whom it is ad= dressed or by their designee. If the reader of this message is > not the intended recipient, you are on notice that any distribution of t= his message, in any form, is strictly prohibited. Please > promptly notify the sender by reply e-mail or by telephone at 770-246-86= 00, and then delete or destroy all copies of the transmission. >=20 >=20 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and propri= etary to American Megatrends (AMI). This communication > is intended to be read only by the individual or entity to whom it is ad= dressed or by their designee. If the reader of this message is > not the intended recipient, you are on notice that any distribution of t= his message, in any form, is strictly prohibited. Please > promptly notify the sender by reply e-mail or by telephone at 770-246-86= 00, and then delete or destroy all copies of the transmission. >=20 >=20