From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.8995.1589529052322864288 for ; Fri, 15 May 2020 00:50:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=IbN96x3w; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: liming.gao@intel.com) IronPort-SDR: iHBGkbbKhz25OIP/B+I5AH7wyVU2K7Gp+z1FTSS8L+1aVT2BL6WV3D9Ule6x5PgSxUdJVjMvGW rpSnQGwOq+lA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 00:50:51 -0700 IronPort-SDR: AZ7XH0pdmbS0GxQQKcW3XnQilUUbKAA7VmdOwdo6Av20Da7gCEvbwhOXarV5EqhZAIYz9llpgW JOEFwYmFjjSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,394,1583222400"; d="scan'208";a="307352890" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 15 May 2020 00:50:51 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 May 2020 00:50:50 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 15 May 2020 00:50:50 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 15 May 2020 00:50:50 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 May 2020 00:50:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VaOqkvuXTQUDmJ5woEDnB0PSVln3yja1Wr+7/ae+7AD8UdFjfaWpJyjCDO1jKYTg1T5MnSUrOppV3+YuP0dMNBBqwQRyzaf1V5xnokcJld7eSfvhcNo2GS0zHieGPrXJx7SmUbJr4vGYsNDZLwe3TjgBnlJ7kXJ2++HAKclbDXolmZ5HHhduY/2InltMwBXw+ApQ7qfJ8ILbIsTryqJ56IHDVDOPCQ6sQgUUf3DUNJ87Xs2qVy/p+SS4nRkEGk9XYmmQtJMgh95GNIOeD9cjP6fhj/Wnz0oSZq41eFoEjDNRRT3Amty4By0+y2sy1m2RbImX0WPpmERRlVCqDrrcVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PWmb3HfeUETGy6MhbdzNcbnUNPR4QxC+s3hPepQz6g8=; b=QX6Yq9Ks2KXNAuKTrW/+b4iyp4pxtlWIqoLQZvBWDus6Z8cz+DFry1fzk3FMaPAAMdjDs7ZRzZuFdCA9kjX4WoUDmm9vG7gfRr2GWPqeHjywdTi1vClzpNXwhj4UFnd5Rh/QnMdeaA/sXYET1WxNmDurG7jFhSUeBwdI75omdP43dBT5KgSfXbxQOX8HP9VyiiviuvYAEn/f2iN0O0fu9g/8pRNJtTd+p0PDUv6806qY6ThS8I8s4xqkxzqXPT7Njo/mbQj+RVqcuxTYnB7d01cKTfhvn+XqbNybCt96XHv+y0f3ewqFmMHA8ooJPDw2lpwgk+l2VOvuHHlSfUCGhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PWmb3HfeUETGy6MhbdzNcbnUNPR4QxC+s3hPepQz6g8=; b=IbN96x3wjxnTzG2zGh0nZmYzYa8HQaaitZU03JKZiwgc/voCZEmr2jhdc3iIU6Nxf8BW7yMmHokeCwQD8G74TR+PGfHxmPZiupkNeAcpoM6NyafQZI4/BeLTjSXgfwurDAg+L8kfrK4UzmOoIDR885drrzC1YInNpLExwAtlIMI= Received: from BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) by BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25; Fri, 15 May 2020 07:50:45 +0000 Received: from BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0]) by BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0%7]) with mapi id 15.20.3000.022; Fri, 15 May 2020 07:50:45 +0000 From: "Liming Gao" To: "Ni, Ray" , "devel@edk2.groups.io" , "oleksiyy@ami.com" CC: "Kinney, Michael D" , "Felixp@ami.com" , "robert@ami.com" Subject: Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol Thread-Topic: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol Thread-Index: AQHWJKJ4SI133BIPGEunZcXvbxoad6iiVWLAgAXFqwCAAJB+kIAAJR3AgAAA/7A= Date: Fri, 15 May 2020 07:50:45 +0000 Message-ID: References: <20200507190310.38968-1-oleksiyy@ami.com> <20200507190310.38968-6-oleksiyy@ami.com> <734D49CCEBEEF84792F5B80ED585239D5C5356E7@SHSMSX104.ccr.corp.intel.com> <160F1CC8B9ACB17A.23170@groups.io> <734D49CCEBEEF84792F5B80ED585239D5C55F3F8@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C55F3F8@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.207] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 71847148-a327-4a78-fbf6-08d7f8a4accb x-ms-traffictypediagnostic: BN6PR11MB3972: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2803; x-forefront-prvs: 04041A2886 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7Xsc8bStNLprti7ZarTXZ/hcMDpAZm3auJJkA3Xdv68F3UMZX8GXkq+Tf25O0mjHcPXLKrhBzLnpY/kNRNi1AKDPHmbeDTTrEVGiGANBTfNiAbl8qJ81keGNm/B5IMpW3JKF+q2qCjRRsWkzjb+qCN7u7Pk5BtU35LZIvrEk9WSPZzOJDGQIWf2gHfjQjUJAo8DUkdLaC7fw4D0vtBfy7WJa5sJIDaFK60uKisuPtHhaJQqio/qnJwgLRXWSvrRe2/Klf0/OmWPxUsDpdnllgsDQ4E3X2jXpsHPEh1VEgnHjAi74fMfWWpU526coanpg/V1gHezCDhmW+v1r4wb8/kYEMxdlfqNW3ecK3+IH/CHzrITK5At0MVOpvmg1CWEdyRqTfVgsMVYs6HxT7t6K+mUm0AqVA1YxqZjhVkP4g+WwY7SdscBpGK50jwjNQVpGb51GgRO//0JIlz1BMKQXsd/7W3BAg/t2nfXFL0zFdtKUDZ1RI8OrU+ze5w897BOZX6RidTtoS+y8UlrTykMSVQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3972.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(366004)(376002)(396003)(346002)(136003)(39860400002)(4326008)(66946007)(8676002)(66556008)(66476007)(64756008)(66446008)(71200400001)(76116006)(7696005)(26005)(2906002)(15650500001)(5660300002)(6506007)(186003)(53546011)(966005)(33656002)(8936002)(52536014)(86362001)(55016002)(478600001)(316002)(54906003)(9686003)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: qQ+bwG8LUxBLtZjwknFRsQRxtGfvEEi5w2tMYla0BfEnqlqF52CUWY19ZVxyDnYhWX8qnS3h0zoxftj/GTybrYM++sb1uXNO5lCMzbBSjBnkWWIoI6wbCojnPJoxDnQdCFkprwfXz4ARxS7VwFHLN069ljQHe/YXRy85iHkXtyJ5nwuAGD5uuLfJOTNRj5BdMoTQ64EAId5SFFzpyMC1OANIJ08N+Ati+aq2UgBgBViLFkr88yAZWX6rjyNji3ywgqB/8qSihSuODWl8Xu0ys5k+gZUXi6mOZUzwCyMy2YDHTB3KXYsE6i13pvjRtpIVi5tMBeieI+17LHmEmVe/OBt+P4OW13z00sWOZfA5sj/D/ngYZ+rsEuYMXs2btaIcPkQ4Twj32z7x0hbc/jIcHyCKrLViRpIZZKeJLsqNZFoDZAYLrt2gpWzRLLLjknvnWALU0B8HhX8X7w4ZuTYmqeLSkP9LY+TdksRLk5XmkMrBfQ0jEX6uRCp/VK5EcXix MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 71847148-a327-4a78-fbf6-08d7f8a4accb X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2020 07:50:45.2899 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kkqmt/52JjcpB4yXBzvQKar3DXlNEieP8XNIQFB4IVnBmKToWu5c5Pph356jHRgky3uxm1eujhdpfPWIGW4V0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3972 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable https://github.com/tianocore/edk2/pull/625 is created for MdePkg change. > -----Original Message----- > From: Ni, Ray > Sent: Friday, May 15, 2020 3:49 PM > To: devel@edk2.groups.io; Ni, Ray ; Gao, Liming ; oleksiyy@ami.com > Cc: Kinney, Michael D ; Felixp@ami.com; robe= rt@ami.com > Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpSe= rvices Protocol >=20 > I just sent out the change to update GetProcessorInfo() to return 6-leve= l topology info. >=20 > The patch has been reviewed by Eric before pushing to edk2-staging repo. >=20 > Please tell me when the MdePkg/MpServices.h is merged. > I will trigger the merge after that. >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Ni, Ray > > Sent: Friday, May 15, 2020 1:34 PM > > To: Gao, Liming ; devel@edk2.groups.io; oleksiyy= @ami.com > > Cc: Kinney, Michael D ; Felixp@ami.com; ro= bert@ami.com > > Subject: Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for Mp= Services Protocol > > > > sure I will. > > > > > -----Original Message----- > > > From: Gao, Liming > > > Sent: Friday, May 15, 2020 12:57 PM > > > To: Ni, Ray ; devel@edk2.groups.io; oleksiyy@ami.c= om > > > Cc: Kinney, Michael D ; Felixp@ami.com; = robert@ami.com > > > Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for = MpServices Protocol > > > > > > Ray: > > > I see https://github.com/tianocore/edk2-staging/commit/2409b787fa1= 96780e0fd101b2ad706575f82e2fc also includes > > the > > > code change in UefiCpuPkg/Library/MpInitLib/MpLib.c. The change has = passed review. > > > > > > Can you send the separate patch for the change in UefiCpuPkg? > > > > > > Thanks > > > Liming > > > > -----Original Message----- > > > > From: Ni, Ray > > > > Sent: Monday, May 11, 2020 1:01 PM > > > > To: devel@edk2.groups.io; oleksiyy@ami.com > > > > Cc: Gao, Liming ; Kinney, Michael D ; Felixp@ami.com; > > > robert@ami.com > > > > Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures fo= r MpServices Protocol > > > > > > > > Robert, > > > > I did similar change to MpService.h in > > > > https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e= 0fd101b2ad706575f82e2fc. > > > > > > > > My plan was to move the change to edk2 once the spec is published. > > > > It seems your change doesn't conflict with my change. More comment= s are added in your change > > > > which I think is better than mine. > > > > > > > > A minor comment to the comment in below. > > > > > > > > > + > > > > > +/// Location2 The 6-level physical location of the processor,= including the > > > > > +/// physical package number that identifies the cartridge, = the physical > > > > > +/// module number within package, the physical tile number = within the > > > > > module, > > > > > +/// the physical die number within the tile, the physical c= ore number within > > > > > +/// package, and logical thread number within core. > > > > > > > > Can you move the above comment to the line before "Location2" fiel= d and remove > > > > the "Location2 "? It aligns to existing comments style. > > > > > > > > > +typedef union { > > > > > + EFI_CPU_PHYSICAL_LOCATION2 Location2; > > > > > +} EXTENDED_PROCESSOR_INFORMATION; > > > > > + > > > > > + > > > > > > > > With that, Reviewed-by: Ray Ni > > > > > > > > > > > > >=20 >=20