From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.7478.1589437779167571817 for ; Wed, 13 May 2020 23:29:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=is9l5UIW; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: liming.gao@intel.com) IronPort-SDR: 8siDEkefGQdF1zzEwsvzHLSlgeROriF6MJjxZeVCWaaMyHErZqSRcCPq7dufwg/pE3EpCFRa9+ 8I5e6LT6/CZQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 23:29:38 -0700 IronPort-SDR: IENraDsFYXI7f0hu/R7As41No/TlOB4hklvZUxvdqrTnQdHR6O0whHEs1FSBz3dKo8hYNfUMEX FW5Ke60dm9fA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,390,1583222400"; d="scan'208";a="409961212" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga004.jf.intel.com with ESMTP; 13 May 2020 23:29:38 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 23:29:38 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 13 May 2020 23:29:37 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 13 May 2020 23:29:37 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 23:29:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bRGS0BSt9AdNXF5oVUopkUyyMht4L3IcxNP7F73I+D3laEeC/iKzkz7LLWVP/sqc1m7U3GJBJPJ9czQTKKbRMGhf9YmYR48bB6RVIOkQ8qZiL5HWGsx3qAQDo2tz3F5n1nvlMZYTiLdPfke4M/LLPHGmi8VXZOukuzofitapLF/EjNuux2kWD5IXO3Bl6pR+ag4dT1GqfNvZ0eAFpjXuSXZWyG2hSTAlGcU4gi+sHCZypll84BV0/wVxwBkJ/oQdEbFzOTTRyImdjQ6DqBV/qi7UYSQuPlzhjCCKf6BTSlwwdiugxw6EnQDz1jqLvT6xgVD3zKIWilQMB6VyqkTRTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ie7c2AYl+hxepLMQYO2+z6a/7e2V4jrepLBSPUkjs2I=; b=Iprd5oBSpuu0PXBp2mnkBPWgqo5eSVMrcpU0ejVKhnDWPJt8WuRZYJXINSlLkCvMXi6ICfn+oeYxopuUIJJP5kNwTF0YLqvywzdtJ24+GGrdrlui3i32BndWr4Z9Ba0vzQoIsZ8heEDuFcEVjRSF7mQQnwf56/rDmnznNVZgkw8T4/ypv+UZwl4qqPkEFADCueaIuFgbPuKU5Y9NRPQAmLId0VqMwzaK2I2ltK2RESEc7EN2RgXCasv9dZuca5cwrZOqsvLqM9WOH4EfRtaA0DCo9ursep4AUkobYgZsiV/oVPM0gaduIiCZq3Va9nWbBHpTHH1Srjad4RGy4HzAPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ie7c2AYl+hxepLMQYO2+z6a/7e2V4jrepLBSPUkjs2I=; b=is9l5UIWuk+Mamwg6lZ1sZQFZ1jFJVQeev20p735sYX/5G53VXR3btsUq/ueg1Ldp46RbbLbfMpxpp5vRg74qzoHvhf/HzhwQcoOdPY6c3rpuVwwQn9ZKYOlWFr6RTKpSwbwxRW3QqCuAYKb8reKrzn1iAZbR7b+XgsZ3dzEFRk= Received: from BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) by BN6PR11MB1345.namprd11.prod.outlook.com (2603:10b6:404:49::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Thu, 14 May 2020 06:29:33 +0000 Received: from BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0]) by BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0%7]) with mapi id 15.20.3000.022; Thu, 14 May 2020 06:29:33 +0000 From: "Liming Gao" To: "Jiang, Guomin" , "devel@edk2.groups.io" , "oleksiyy@ami.com" CC: "Feng, Bob C" , "Kinney, Michael D" , "Felixp@ami.com" , "Liu, Zhiguang" Subject: Re: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Topic: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Index: AQHWKWBD5ja4y4LYHEyIAm4bQHYx9qim8LaAgAAuWkA= Date: Thu, 14 May 2020 06:29:32 +0000 Message-ID: References: <20200513195248.50296-1-oleksiyy@ami.com> <20200513195248.50296-2-oleksiyy@ami.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.195] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3348d8ae-5a1c-4716-d704-08d7f7d02a42 x-ms-traffictypediagnostic: BN6PR11MB1345: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 040359335D x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d/enzjPuFFNuXwVVw1WR7T7f+ZFkIC3D5fuX4bI58EjLoR1yvOcHm7kcfmKOX4HGvpt6ZX2dLZ6ewugB1niHPtTxCWNYOeayJvmDiNdzilR6SsnfXUO+57ai20eDryzkNxGGiL0bfON6+AXAD5NJsHlJL4rg1mdIxsNpp3Spzowcq6HrFifj1aB+pDELXXNz10PNt7HDNbxNHhrsB/n+o+JMph8uuoQNLYjwewIbz1QPa8udC6ADLZrFXHQpBIb9MWZEHcS2Bo+ae6yeoS/kMww4ujLwHYXusDNH8dctNA946ynxcDKWt/4X7CgpIBwSYfQl2RSxmUadz6AcXOn5RWtY5epr8DfBPxvLMmAJT5HyXLR3AQg7BJCF5iJ2c3gooXG239b5uu4txwK9XzhV0wOHgXGsrh0Um2+UvRBtGU6XFlWNPYXqVvb81Mkj2VqT9sH0M5xKMSAqEDkoj5i/23GDXKJYG7YUX0dLG20syTqyWx8sUuFN27ggXQEf0SOwiNg1lNz9+CgE6Axf/HuWQw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3972.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(136003)(366004)(376002)(39860400002)(346002)(54906003)(6506007)(64756008)(86362001)(5660300002)(71200400001)(4326008)(66476007)(66556008)(52536014)(2906002)(76116006)(7696005)(26005)(55016002)(966005)(53546011)(107886003)(66446008)(33656002)(66946007)(478600001)(110136005)(186003)(8936002)(9686003)(316002)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: QRs/Gi41eBT0F9a4yS7ru4W9vYBGZiuU4GtyZMflbpC+mpE9CNusS8S/NegO9gBFvz9XqnzqW5LCNdtlccI28D/jIpMXYwtuVr1QnIWB7/c3D1QiOkD+zysuxOOAPccONfH7i8ypLhEoaINsZUyJOZIX9ZW0O/cC5tbwMOEK6h+j5dmm3lyIQGWhKzBpFVwhrNE9HNuyIMsC1+Rg5BCrHW4nTiITDta7VKYS9L9X7bpB/clgHBnIGcnLIRwZ8bUJsqkw7ehnQeyAAEVzvOyKb9x2BAAnar6SLYssa8ijE/pZwGszNLXBkc1h74w1Ijv6RQr0XWDlvu98FaGmG8OeSj4I/yNlG9LgCG/oJrMEeXEDALQy0juS4mviBRScvYeODn5heGYxnxgRZ/8I/AvUdaNJzQWxlunAoPKdBeQqTLO65LzekW2SbcQ4BIQbQMZnVvW24l0PtospnOgSwPORdYdomSyjqzHWqHw4m9WTY4EPUXkYQxMGvt4vJd6U1Bwr MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 3348d8ae-5a1c-4716-d704-08d7f7d02a42 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2020 06:29:32.9796 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YxIClrgwGwSYIfh5XPKXs3SXvsxTYwXtDjHqdkRa8BffHq07ciSrLHDb4oH28n7EYJQaNZmw5+CpJTI8FK/bQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1345 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Guomin: This definition is defined in new UEFI2.8 spec. Previous version patch m= iss this definition.=20 Revision Number #define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010000=20 #define EFI_SERIAL_IO_PROTOCOL_REVISION1p1 0x00010001 Thanks Liming > -----Original Message----- > From: Jiang, Guomin > Sent: Thursday, May 14, 2020 11:43 AM > To: devel@edk2.groups.io; oleksiyy@ami.com > Cc: Feng, Bob C ; Gao, Liming ; Kinney, Michael D ; > Felixp@ami.com > Subject: RE: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with D= eviceTypeGuid >=20 > Add some comments. >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Oleksiy > > Yakovlev > > Sent: Thursday, May 14, 2020 3:53 AM > > To: devel@edk2.groups.io > > Cc: Feng, Bob C ; Gao, Liming > > ; Kinney, Michael D = ; > > Felixp@ami.com; oleksiyy@ami.com > > Subject: [edk2-devel] [PATCH v7 1/7] MdePkg: Extend SERIAL_IO with > > DeviceTypeGuid > > > > EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001. > > CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure. > > UEFI 2.8 mantis 1832. > > > > Signed-off-by: Oleksiy Yakovlev > > > > Reviewed-by: Liming Gao > > --- > > MdePkg/Include/Protocol/SerialIo.h | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/MdePkg/Include/Protocol/SerialIo.h > > b/MdePkg/Include/Protocol/SerialIo.h > > index 51eaa53..e2e0c61 100644 > > --- a/MdePkg/Include/Protocol/SerialIo.h > > +++ b/MdePkg/Include/Protocol/SerialIo.h > > @@ -263,6 +263,7 @@ typedef struct { > > } EFI_SERIAL_IO_MODE; > > > > #define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010000 > > +#define EFI_SERIAL_IO_PROTOCOL_REVISION1p1 0x00010001 >=20 > Why add this new definition, it is not exist in patch v5 but exist in pa= tch v6? >=20 > > #define SERIAL_IO_INTERFACE_REVISION > > EFI_SERIAL_IO_PROTOCOL_REVISION > > > > /// > > @@ -287,6 +288,14 @@ struct _EFI_SERIAL_IO_PROTOCOL { > > /// Pointer to SERIAL_IO_MODE data. > > /// > > EFI_SERIAL_IO_MODE *Mode; > > + /// > > + /// Pointer to a GUID identifying the device connected to the seria= l port. > > + /// This field is NULL when the protocol is installed by the serial > > + port /// driver and may be populated by a platform driver for a > > + serial port /// with a known device attached. The field will remain > > + NULL if there is /// no platform serial device identification infor= mation > > available. > > + /// > > + CONST EFI_GUID *DeviceTypeGuid; // Revision 1.1 > > }; > > > > extern EFI_GUID gEfiSerialIoProtocolGuid; > > -- > > 2.9.0.windows.1 > > > > > > Please consider the environment before printing this email. > > > > The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is inten= ded > > to be read only by the individual or entity to whom it is addressed or= by their > > designee. If the reader of this message is not the intended recipient,= you are > > on notice that any distribution of this message, in any form, is stric= tly > > prohibited. Please promptly notify the sender by reply e-mail or by > > telephone at 770-246-8600, and then delete or destroy all copies of th= e > > transmission. > > > >=20