From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.1973.1588776796699920491 for ; Wed, 06 May 2020 07:53:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Rqquf+mK; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: liming.gao@intel.com) IronPort-SDR: q0aN0ChSvy5ziwbU1DjCA8O7bPKMhNVMX7PhmU84HqAiwLsj/BkG9gz0pEwUMu5zk1UZ+wdWu1 PdKObZZHbyGQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2020 07:53:15 -0700 IronPort-SDR: /33I9gZ5GpA+LBlA8tfe8+iA1u+DubEwMLsfPrCvijWI7SsHm/jzHwAmCzfNAxCQevCJPOT8xB f0Pqg8lW6G6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,359,1583222400"; d="scan'208";a="304819649" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 06 May 2020 07:53:14 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 07:53:14 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 07:53:14 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 07:53:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dC0Nn9Bq+c4N4HweUEbGZhO68Lw300zqzLtsSqXWC1NzX+svj2HBgppoPrtPslYdMMVItGhpZ8zU7z2+6iDowu9GQyQK150OvfK/OWTzwK0TYyws/U+JKKFbTmtkz9CMf1Pt351BY3xUAfotkEJFJzOsHo6qMSNhGrhofSfkABZQ5xKhAd4/vxNqknGkq9dc8Ka2dfaQR0Epj06GzPxyPozw01FqkITatnbndqU9PxNs3CXOJ2yuU2reOXQYW1QROEbC5gm9/JM6cH9W49RKO0JMN15aa4KUbjGfoiYn1hSWHZarvcFEcYbhMT1FPT/NHoq4VQjwNJUemiRGxF7uew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gbMFEyo6Kqp4MdK2wAEbyShQNQVKoRNmyIV2g0uhQyU=; b=gYvjfQanC/GpC38KhwLaItVlaGlUi/gzPJPYWsElH97wTnRhZn7HKgHwv2SQ/ExjR/laE5mPk59+YvQMvZLs2k/KdvEre80F7B1d0rbxncPjVG04+2vhKIj2cwT/B1SyBeyvGUBg9dfSITeg2/nslMJI7dqPq1camARfPcAYX7Jsgp/bmurn0Uvf0CpEo80YL7kJyOzHN7SrVZ6vSoszXTrwyLDFTk79+UiGAnxp4It1zqDiisYrIO30Ndy9GL3EQxauF7M/vzEbgzxBAio1hUTVE+uVbC9A4KoZ3lqwFikIFW3i1pG82SSjDVYwp0LgempHM/JcvgOHer1aLVfSGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gbMFEyo6Kqp4MdK2wAEbyShQNQVKoRNmyIV2g0uhQyU=; b=Rqquf+mK5Ro0Pwj4F7Gj8oaf4ufI0MMEoXsuXJnF9xpBIu/Er6tSrG2TvxTyvrHRRn0S71GZKZS3y3gGlQL/YL62uwlqfy5uLhY30anW5tF68KW3PYhsTJ6u51mJn38QBJ3u98EvDsfwqCxpP2ApuTkSHqYEvlZS5uToEzBy38U= Received: from BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) by BN6PR11MB1570.namprd11.prod.outlook.com (2603:10b6:405:a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.21; Wed, 6 May 2020 14:53:12 +0000 Received: from BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::75bf:f1b7:1d9d:475d]) by BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::75bf:f1b7:1d9d:475d%3]) with mapi id 15.20.2958.033; Wed, 6 May 2020 14:53:12 +0000 From: "Liming Gao" To: "devel@edk2.groups.io" , "thomas.lendacky@amd.com" , "lersek@redhat.com" CC: "Justen, Jordan L" , Ard Biesheuvel , "Dong, Eric" , "Ni, Ray" , Brijesh Singh , Anthony Perard , "You, Benjamin" , "Dong, Guo" , Julien Grall , "Ma, Maurice" , Andrew Fish Subject: Re: [edk2-devel] [PATCH 4/4] UefiCpuPkg/CpuExceptionHandler: Revert binary patching in standard CpuExceptionHandlerLib Thread-Topic: [edk2-devel] [PATCH 4/4] UefiCpuPkg/CpuExceptionHandler: Revert binary patching in standard CpuExceptionHandlerLib Thread-Index: AQHWH/W1fCoH9y1HVUOkctWplAdGOKiaFW8AgAERsYCAAAS54A== Date: Wed, 6 May 2020 14:53:11 +0000 Message-ID: References: <26e51d24-fe19-4fa1-6bac-6936041af39d@amd.com> In-Reply-To: <26e51d24-fe19-4fa1-6bac-6936041af39d@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.221] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 384a5134-9d29-4d94-51d3-08d7f1cd32e0 x-ms-traffictypediagnostic: BN6PR11MB1570: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 03950F25EC x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b9RGfKYZwEBO+ZXpg38DKTks8jBB10RD1PAzlfBtcljdRRedyYRFC/HMPtkvpQF9WFqoGhq2/ANsB0OAzqWybRz2yg57e9MVW0Zx+GVM06z28XHXtntiNbEH+VmVshFREYp2Oaid2LCQHPyNlwIkSiMy1jcRba1E98UD1X4ihTp7S59n+OL3NTz+fu/ZQggTIoYuWpHCCN/SZfshiv2k7p33nuAb8C0Tr4Bp8z3OFe3aOp0XUeGGc8Zo8msAnzvBgy3N3G78LwB+g7TZ4RKyjY9IeOLKm/S/i4xVunKeBQeQCyq71a7bM3MeHUDzyalepLD3MqkuNVqKH6Q1Zk74PIqYJ6KU4+AOKxcblZt+TWwFCAz+aMsIRw6zL5os1BgXjlDRADSxWkB7w2bVrcKJFynKfVm5FJoaUfIiez9FCeuWwS1j8dddbFHgCIYY3IEHPHu/j2ujzskKKv5DbbAcz3IRZnhExuwW3YXF+DpbnzCJhLcYK6rKnZ9oQLyEwirPXwGK7OhJuyfI+8M6esBpMK7LG2vA7OBdZ9QF0aGK2n7knMf4IIqpiARB5CiW0xsFUDgR2ybHDmzSkifwJJ4uHD1Vwl/jkuXQYRvhZ1VWbfQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3972.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(376002)(39860400002)(366004)(396003)(136003)(33430700001)(64756008)(66476007)(45080400002)(76116006)(66556008)(66446008)(478600001)(66946007)(53546011)(7696005)(16799955002)(2906002)(186003)(26005)(71200400001)(33440700001)(19627235002)(6506007)(5660300002)(8676002)(8936002)(55016002)(9686003)(4326008)(86362001)(52536014)(966005)(33656002)(110136005)(54906003)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: kUmVnogUVuNNkQPQh/u1rSV3RJtXo7uxXtMK3ckUhXoxbTbxs0smNKwsUN8AKQJtS+aFh1eH+E2ukxcDwhtJ2CmUxPUY7dtgumEjwwIhSlJg3R2yqjvcKVT+8gE+p5CrecHJJgMJH20x+jLTMYB9S3mMkRQrm+1DBtYi4B7AIq+VKWBs/kBWRI+dm1IE2Z/E4JbIoAIEdBltcXBjtJH/nRk7cBhGpoMP9cfgY1k8k30nlskMHq55CZIjN/lzvtmCP7NIKEeFzV1vIB9Y0aX1TuosegEe8y1sv1u/wVAm2LyRu8gZgau0vPn0YM/BM7U3dhItJCZ0XyAWdcPmbKijW6g0ht6hjK7nNgEi8GnEvStsuQfPxywWsdyjM2LNJA+UM6/wMoJ7cWSwFsFIptaRV4bJo1B8QTKJBAwBRq3BBigPQTMXgW8yi0suAiXlGag0WadpcYM9qsoW9Ul/zBPjAbLch71JekkVf3gb2hdGXzYuyZf7YTt+y0HUaG2a9VAjwxewfmDiAghozRi1cZOC6ZdECWnFoMgQrU36RTpYZAIgxSGvrC991rvJ4zO06/fzr0aA6ZpsXa7m3/xGk/zfYm49Eh6jbbdMtI3NnzL85UysNhS1Ere7mD5m9VUtls6UaAQVeJgWeK8RFm5mRbQwIdv/8bf6AdaY6+jxbbe7Kx13flmCGPzHu2J84Jbgel7UsM3IfR9Cv7PMGDkKflVrgqoNNrTVrv303fhtK2NCWvAZYsf81mTyw+2F0jGDtZzuVU8ZN5byZzHDvq7nQTUg8Q47Faanck4gVtZkWJ/rsCw= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 384a5134-9d29-4d94-51d3-08d7f1cd32e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2020 14:53:11.7117 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Fzril9ExKpNzW+NPl3umawXxuJA5HtaDShTUGPRTwAeZQ+vTgQbuigGMcKHXi4bX1HJO38FjXCEB5/UlHY+HDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1570 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thomas: > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Lendacky,= Thomas > Sent: Wednesday, May 6, 2020 10:35 PM > To: devel@edk2.groups.io; lersek@redhat.com > Cc: Justen, Jordan L ; Ard Biesheuvel ; Gao, Liming ; > Dong, Eric ; Ni, Ray ; Brijesh Si= ngh ; Anthony Perard > ; You, Benjamin ; Don= g, Guo ; Julien Grall > ; Ma, Maurice ; Andrew Fish > Subject: Re: [edk2-devel] [PATCH 4/4] UefiCpuPkg/CpuExceptionHandler: Re= vert binary patching in standard CpuExceptionHandlerLib >=20 > On 5/5/20 5:15 PM, Laszlo Ersek via groups.io wrote: > > On 05/01/20 22:17, Lendacky, Thomas wrote: > >> BZ: > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugz= illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D2340&d > ata=3D02%7C01%7Cthomas.lendacky%40amd.com%7Cd2ec699d2c644a55724008d7f141= d96f%7C3dd8961fe4884e608e11a82d994e183d% > 7C0%7C0%7C637243137431443098&sdata=3DoTTju7144KZc8VCmQqu74UilIOzQyji= 9jlO%2BMJeZYyU%3D&reserved=3D0 > >> > >> Now that an XCODE5 specific CpuExceptionHandlerLib library is in plac= e, > >> revert the changes made to the ExceptionHandlerAsm.nasm in commit > >> 2db0ccc2d7fe ("UefiCpuPkg: Update CpuExceptionHandlerLib pass XCODE5 = tool > >> chain") so that binary patching of flash code is not performed. > >> > >> Cc: Eric Dong > >> Cc: Ray Ni > >> Cc: Laszlo Ersek > >> Cc: Liming Gao > >> Signed-off-by: Tom Lendacky > >> --- > >> .../X64/ExceptionHandlerAsm.nasm | 25 +++++-----------= --- > >> 1 file changed, 6 insertions(+), 19 deletions(-) > >> > >> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionH= andlerAsm.nasm > b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerAsm.nasm > >> index 19198f273137..3814f9de3703 100644 > >> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerA= sm.nasm > >> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerA= sm.nasm > >> @@ -34,7 +34,7 @@ AsmIdtVectorBegin: > >> db 0x6a ; push #VectorNum > >> db ($ - AsmIdtVectorBegin) / ((AsmIdtVectorEnd - AsmIdtVec= torBegin) / 32) ; VectorNum > >> push rax > >> - mov rax, strict qword 0 ; mov rax, ASM_PFX(CommonInte= rruptEntry) > >> + mov rax, ASM_PFX(CommonInterruptEntry) > >> jmp rax > >> %endrep > >> AsmIdtVectorEnd: > >> @@ -44,8 +44,7 @@ HookAfterStubHeaderBegin: > >> @VectorNum: > >> db 0 ; 0 will be fixed > >> push rax > >> - mov rax, strict qword 0 ; mov rax, HookAfterStubHead= erEnd > >> -JmpAbsoluteAddress: > >> + mov rax, HookAfterStubHeaderEnd > >> jmp rax > >> HookAfterStubHeaderEnd: > >> mov rax, rsp > >> @@ -257,7 +256,8 @@ HasErrorCode: > >> ; and make sure RSP is 16-byte aligned > >> ; > >> sub rsp, 4 * 8 + 8 > >> - call ASM_PFX(CommonExceptionHandler) > >> + mov rax, ASM_PFX(CommonExceptionHandler) > >> + call rax > >> add rsp, 4 * 8 + 8 > >> > >> cli > >> @@ -365,24 +365,11 @@ DoIret: > >> ; comments here for definition of address map > >> global ASM_PFX(AsmGetTemplateAddressMap) > >> ASM_PFX(AsmGetTemplateAddressMap): > >> - lea rax, [AsmIdtVectorBegin] > >> + mov rax, AsmIdtVectorBegin > >> mov qword [rcx], rax > >> mov qword [rcx + 0x8], (AsmIdtVectorEnd - AsmIdtVectorBegi= n) / 32 > >> - lea rax, [HookAfterStubHeaderBegin] > >> + mov rax, HookAfterStubHeaderBegin > >> mov qword [rcx + 0x10], rax > >> - > >> -; Fix up CommonInterruptEntry address > >> - lea rax, [ASM_PFX(CommonInterruptEntry)] > >> - lea rcx, [AsmIdtVectorBegin] > >> -%rep 32 > >> - mov qword [rcx + (JmpAbsoluteAddress - 8 - HookAfterStubHeade= rBegin)], rax > >> - add rcx, (AsmIdtVectorEnd - AsmIdtVectorBegin) / 32 > >> -%endrep > >> -; Fix up HookAfterStubHeaderEnd > >> - lea rax, [HookAfterStubHeaderEnd] > >> - lea rcx, [JmpAbsoluteAddress] > >> - mov qword [rcx - 8], rax > >> - > >> ret > >> > >> ;------------------------------------------------------------------= ------------------- > >> > > > > With this patch applied, the differences with the "original" remain: > > > > $ git diff 2db0ccc2d7fe^..HEAD -- \ > > UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerA= sm.nasm > > > >> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionH= andlerAsm.nasm > b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerAsm.nasm > >> index ba8993d84b0b..3814f9de3703 100644 > >> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerA= sm.nasm > >> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerA= sm.nasm > >> @@ -1,12 +1,6 @@ > >> ;------------------------------------------------------------------= ------------ ; > >> -; Copyright (c) 2012 - 2014, Intel Corporation. All rights reserved.=
> >> -; This program and the accompanying materials > >> -; are licensed and made available under the terms and conditions of = the BSD License > >> -; which accompanies this distribution. The full text of the license= may be found at > >> -; https://nam11.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2= Fopensource.org%2Flicenses%2Fbsd- > license.php&data=3D02%7C01%7Cthomas.lendacky%40amd.com%7Cd2ec699d2c6= 44a55724008d7f141d96f%7C3dd8961fe4884e608e > 11a82d994e183d%7C0%7C0%7C637243137431443098&sdata=3DSZAc83Y%2BwZauGc= j47EDgc10fnxSucy2ljeI9PcaJSvE%3D&reser > ved=3D0. > >> -; > >> -; THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BAS= IS, > >> -; WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS = OR IMPLIED. > >> +; Copyright (c) 2012 - 2018, Intel Corporation. All rights reserved.=
> >> +; SPDX-License-Identifier: BSD-2-Clause-Patent > >> ; > >> ; Module Name: > >> ; > > > > This is expected. > > > >> @@ -189,17 +183,19 @@ HasErrorCode: > >> push rax > >> push rax > >> sidt [rsp] > >> - xchg rax, [rsp + 2] > >> - xchg rax, [rsp] > >> - xchg rax, [rsp + 8] > >> + mov bx, word [rsp] > >> + mov rax, qword [rsp + 2] > >> + mov qword [rsp], rax > >> + mov word [rsp + 8], bx > >> > >> xor rax, rax > >> push rax > >> push rax > >> sgdt [rsp] > >> - xchg rax, [rsp + 2] > >> - xchg rax, [rsp] > >> - xchg rax, [rsp + 8] > >> + mov bx, word [rsp] > >> + mov rax, qword [rsp + 2] > >> + mov qword [rsp], rax > >> + mov word [rsp + 8], bx > >> > >> ;; UINT64 Ldtr, Tr; > >> xor rax, rax > >> > > > > Also expected, from commit f4c898f2b2db > > ("UefiCpuPkg/CpuExceptionHandlerLib: Fix split lock", 2019-09-20). > > > > Therefore, for this patch: > > > > Reviewed-by: Laszlo Ersek > > > > *However*, this revert must be restricted to the original > > "SecPeiCpuExceptionHandlerLib.inf" instance, i.e. where binary patchin= g > > is not acceptable. (Otherwise, in combination with my request (1) unde= r > > patch#1, we'd needlessly break the PEI / DXE / SMM lib instances under > > XCODE5.) > > > > (1) Therefore, please insert a new patch between patches #1 and #2, su= ch > > that the new patch flip > > > > - PeiCpuExceptionHandlerLib.inf > > - DxeCpuExceptionHandlerLib.inf > > - SmmCpuExceptionHandlerLib.inf > > > > to using "Xcode5ExceptionHandlerAsm.nasm". > > > > (If you wish, you can squash these modifications into the updated > > patch#1, rather than inserting them as a separate patch between #1 and > > #2.) > > > > > > In summary, I suggest the following end-state: > > > > - we should have a self-patching NASM file, and one without > > self-patching, > > > > - the self-patching variant should be called > > "Xcode5ExceptionHandlerAsm.nasm" (because the *only* reason for the > > self-patching is xcode5), > > > > - we should have 5 INF files in total, > > > > - "PeiCpuExceptionHandlerLib.inf", "DxeCpuExceptionHandlerLib.inf", > > "SmmCpuExceptionHandlerLib.inf" should use > > "Xcode5ExceptionHandlerAsm.nasm" (the self-patching is harmless), > > > > - "SecPeiCpuExceptionHandlerLib.inf" should use > > "ExceptionHandlerAsm.nasm" (self-patching is invalid, so don't do it), > > > > - "Xcode5SecPeiCpuExceptionHandlerLib.inf" should use > > "Xcode5ExceptionHandlerAsm.nasm" (the self-patching is invalid, but we > > can't avoid it when building with XCODE5), > > > > - platforms should resolve the CpuExceptionHandlerLib class to > > "Xcode5SecPeiCpuExceptionHandlerLib.inf" only for the XCODE5 toolchain > > *and* for the SEC phase. >=20 > Ok, I have v2 ready to go, but when I ran it through the integration tes= ts > using a pull request I received some errors (see > https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=3D6516&vi= ew=3Dresults). > The error is the same in all cases and the error message is: >=20 > CRITICAL - > UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandle= rLib.inf > not in UefiCpuPkg/UefiCpuPkg.dsc >=20 > Any idea about the reason for this message? Is it due to the [Components= ] > section of the UefiCpuPkg/UefiCpuPkg.dsc file? Should that section not u= se > the !if check and just list both .inf files > (SecPeiCpuExceptionHandlerLib.inf and Xcode5SecPeiCpuExceptionHandlerLib= .inf)? >=20 Yes. Package DSC [Components] section should list all module INF files, th= en verify their build.=20 Thanks Liming > Thanks, > Tom >=20 > > > > Thanks, > > Laszlo > > > > > > > > >=20 >=20