From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.1025.1588774119097356924 for ; Wed, 06 May 2020 07:08:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=NPJs3QFr; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: liming.gao@intel.com) IronPort-SDR: Hr3QLqdQTCzy9c3ljdVq5PA9f0MRNawj3NoCPRVoS3OB7aecPqpEz9HBV3BPSn2RhyMmHKRMNE QIoZJhZSV8zQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2020 07:08:37 -0700 IronPort-SDR: 3iF5CdD3vn89Y79w158SE1nxkt9K1R3ubRO2ZmRsLWYpvyIRcOE7zm57b9lR8EtpfzA6ldJDoT GZRWInAuMAYg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,359,1583222400"; d="scan'208";a="284633583" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by fmsmga004.fm.intel.com with ESMTP; 06 May 2020 07:08:37 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 07:08:36 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 07:08:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U9E/joZvzYj3gqrlWf+40TeFQsCdI1Se17/SXsBnPvq/6cgMWuOmm6LM6WnBYnIaqkpHv3wRzI79gshNY6iPzb5iG1t7aQfvGqtfCN+sQbSNXzed8bUFygqjv9gEmuI4XmHYnROep800gRgUdyuTNRWok1CLO7jU5PwNM4E+V58LXeEeQihLFnDRUfWImcgmRAI0tPHrMbX149Yt74Ke+Fb7U7nmMXDVzz6oKkpgcFauFaaWVCexMqTfFcCvFgAylDFQ7JSAAEAgXnhC1XPe+tyoCyF+zxXOxdfKlbhrTjyj0zsAKTQ1OrWUYoUY93BvXzHyu8w5/T0Eg4wHQDYKlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XPHnK1W9vVKBIfz76gb0Se/Y3G7QUKtwTIZGBX53hjY=; b=BEp1gYIUspCUekeuYYnnRq12psBxM/vdmXf72jK2uH8BH3ktX4F4yno8ZO7++dCGJAB7brlWhrph6IUa7Q1Z/RF8guQKvA03vc/MISARNPjvH/C9HPRMSyYh5+HZay49VKw36AwWp5+l2CrxLN+yTMDSBqZnXowqpou861hqY70ZbztkxmQYmoTl7Rh8cn2/7PrLWIyGSr6MGMqg4jMGtem36NSNFxLic5crKR/M+cSvnctKWlLEWcOoOoh3Suuj9G1OdenDkfoEkj86IkS8NagSjOiP0RaaNa4lTnOAkLbqq3P92c/VPc+MAqkI2KXAXYgwxgDRGytb7gzVUWqVgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XPHnK1W9vVKBIfz76gb0Se/Y3G7QUKtwTIZGBX53hjY=; b=NPJs3QFrV/EQqZZTK4Fla2JPeZAhqany+arGFdBhP3M8oLX8t5BvCpIZCOMNghN9ixNlcouWNX6TuJnVhD42vwOBauXVxi2BJQ/h0WlutT5VA7+aQM0OPnzC/PVBR/gyeeN7uNRGVoiZQKMCcwA1LnFNvTfYCoyQG94efc2u3fU= Received: from BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) by BN6PR11MB1682.namprd11.prod.outlook.com (2603:10b6:404:3e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20; Wed, 6 May 2020 14:08:35 +0000 Received: from BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::75bf:f1b7:1d9d:475d]) by BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::75bf:f1b7:1d9d:475d%3]) with mapi id 15.20.2958.033; Wed, 6 May 2020 14:08:35 +0000 From: "Liming Gao" To: "Xu, Wei6" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , Sean Brogan Subject: Re: [edk2-devel] [PATCH 0/4] FmpDevicePkg: Move capsule dependency implement to library Thread-Topic: [edk2-devel] [PATCH 0/4] FmpDevicePkg: Move capsule dependency implement to library Thread-Index: AQHWHWCT0TSOlBCO60iwLSTzxvtzfKibJN6w Date: Wed, 6 May 2020 14:08:35 +0000 Message-ID: References: <20200428132530.4068-1-wei6.xu@intel.com> In-Reply-To: <20200428132530.4068-1-wei6.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.221] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b4ab7c5-0f1f-48cb-32be-08d7f1c6f791 x-ms-traffictypediagnostic: BN6PR11MB1682: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 03950F25EC x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GXSYcvbOXdpJ52U4hyHnEN/qlmEpZNQ6XBfUECrdSS9ts2i5yWmicnLwcdBl4OfH+gfSOJ5h88NfAk4IbaIgLVVfYDN+b48KibUjb6qu49Ep9hvwIkD6Al+luHEpf4s8bYbNquiVibgE2PACrD2JUXKcIWDzCsizvPNzzQMtHYRxJrL04vtuoSpsugAAGpdJwDHA3ezSYm2gJLSM9mmdft9gqoV+yCptJI07S6vzGdoQpGhV9i5VlVzvOgXzIGkk5uNLz6w9yll9VOM4FJYzOgngzUyTHhpsQlKeJ17QXS13DtFMJdnf5qS961WvbSkJs2+H9yj/2FhWU7KBm6bbf7mYvnh/sm4jBCaIfCo0+Kcdv5vQ4ZvJpMg1X9US8etiPChZvQUHzBYKVX1zoDgPFjTgKjeJfDay2Pm8x3Z/Vy5T256ZGKMN3kiE98kJSk5WqIUvNx5PFDvcyjAyosVXtUy9zwxftwhF/Ng2W/jYihDTwmwiF19Y1c05gQwl89DcVPQLKSx22LCZce8GRxhGtLgnpgHIZWg9qOLkU0l1mi6D2D3bfxy6vTOfG/8AVeKNl+46xxukEHGr+J5ZXLp1h+thiZkzLRN4/N9TcwC728w= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3972.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(39860400002)(136003)(376002)(346002)(396003)(366004)(33430700001)(8676002)(54906003)(66946007)(64756008)(66556008)(66476007)(5660300002)(8936002)(4326008)(26005)(966005)(186003)(110136005)(55016002)(66446008)(7696005)(76116006)(9686003)(2906002)(52536014)(316002)(478600001)(33440700001)(53546011)(71200400001)(86362001)(33656002)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: yw08QK+GjlptZ0oBIx4HHbeP6bYmrgCCl+njsxbeeUaez+79f2dimv249y0FK6aSk7qt1CtP1pexAmJPSrEGO/k2aITcac04KsB2+ibFbdaSOrwY1bdj4HjMdEKlwPGuRvQ1Ccs4umcwGsV0c5v6mAkQTDoG5OZdSDCgsQlYRdOvflRgbt8T7LPIwccuINYlB9GZsSRu93mEAR30Tbg3OdVIdKHSUy88OJlLhB+Y7TyqlT267v1/EgNRrOgVO2rKnX/ZnCrtMEnUb49mBFXRdqq8fRukXLVHQv84ahFs+2/JrTvbsKzGADhHE0LvOUMQGQ1g6KPcciTF/QI3GNklU8iJjtYBk25WOrNhNQOAz9FMFdbgzrmeVlBYX8REZyU9aes/+km3XwJBAcFrZKs6Ety+8Rwac1vELo0eIS3A0e7uA66GXP1jumkIpUJ8WNUPQip0VnSmmHFBB4huq0sAAMPEkyMDPMNnvV1p4unGJtYtrIqKjXnmnYupCZFQNpz0CZUzwtck8I+LokLMUOccHUEijKQD/vTOE5of+v6za4tGUvnJj+0FRuNXuKDH5CT8EsUqvZLltyzHyyHX5luiwAGlUJa4PvzH2ODkKHF5ANZI/4CEq2reZSV9+xU0MLWwbQp0oaBgczvdtIoo8HUX3zPzPTFXHLNpfyfh6LiBxNBqgakAsAWdwLSfPQQ2TwixoDUzMQvHp9JlpCbpBktlze0RzQeU3atMvnrlEZyd+iRxJg7VRAJa45Mxmfnwm7rVBH8UGALLnuVNHbvJR/98bxALffDeCaI8s5G2QmreCvU= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5b4ab7c5-0f1f-48cb-32be-08d7f1c6f791 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2020 14:08:35.3592 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8G6igHqoYOzyWnxnJtSeU27aaQDR3UCHR7EzegiGOLp0MgCmEO9XSKUmEkZtBSmz0cLP4BZduVKyF1CTRetoYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1682 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Xu, Wei6 > Sent: Tuesday, April 28, 2020 9:25 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming ; Sean Brogan > > Subject: [edk2-devel] [PATCH 0/4] FmpDevicePkg: Move capsule dependency i= mplement to library >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2696 >=20 > This patch series move the implementation of Fmp Capsule Dependency from > FmpDxe driver into two library classes. FmpDependencyLib is a base lib > to provide generic dependency evaluation services. FmpDependencyCheckLib > is a platform lib to provide dependency check services during firmware > update. Platform can perform the dependency check in platform specific > manner by implementing its own FmpDependencyCheckLib. > This patch series also add unit test for EvaluateDependency API in > FmpDependencyLib. >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Sean Brogan > Signed-off-by: Wei6 Xu >=20 >=20 > Wei6 Xu (4): > FmpDevicePkg: Add FmpDependency library class and BASE instance > FmpDevicePkg/Test: Add FmpDependencyLib unit test. > FmpDevicePkg: Add FmpDependencyCheck library class and instances > FmpDevicePkg/FmpDxe: Use FmpDependencyLib and FmpDependencyCheckLib >=20 > FmpDevicePkg/FmpDevicePkg.ci.yaml | 10 + > FmpDevicePkg/FmpDevicePkg.dec | 15 +- > FmpDevicePkg/FmpDevicePkg.dsc | 14 +- > FmpDevicePkg/FmpDevicePkg.uni | 4 +- > FmpDevicePkg/FmpDxe/Dependency.h | 63 --- > FmpDevicePkg/FmpDxe/FmpDxe.c | 255 ++-------- > FmpDevicePkg/FmpDxe/FmpDxe.h | 3 + > FmpDevicePkg/FmpDxe/FmpDxe.inf | 4 +- > FmpDevicePkg/FmpDxe/FmpDxeLib.inf | 4 +- > .../Include/Library/FmpDependencyCheckLib.h | 71 +++ > FmpDevicePkg/Include/Library/FmpDependencyLib.h | 104 ++++ > .../FmpDependencyCheckLib/FmpDependencyCheckLib.c | 533 +++++++++++++++= ++++++ > .../FmpDependencyCheckLib.inf | 51 ++ > .../FmpDependencyCheckLib.uni | 13 + > .../FmpDependencyCheckLibNull.c | 74 +++ > .../FmpDependencyCheckLibNull.inf | 30 ++ > .../FmpDependencyCheckLibNull.uni | 13 + > .../FmpDependencyLib/FmpDependencyLib.c} | 314 ++++-------- > .../Library/FmpDependencyLib/FmpDependencyLib.inf | 34 ++ > .../Library/FmpDependencyLib/FmpDependencyLib.uni | 12 + > FmpDevicePkg/Test/FmpDeviceHostPkgTest.dsc | 28 ++ > .../FmpDependencyLib/EvaluateDependencyUnitTest.c | 271 +++++++++++ > .../FmpDependencyLibUnitTestsHost.inf | 34 ++ > .../FmpDependencyLibUnitTestsUefi.inf | 35 ++ > 24 files changed, 1508 insertions(+), 481 deletions(-) > delete mode 100644 FmpDevicePkg/FmpDxe/Dependency.h > create mode 100644 FmpDevicePkg/Include/Library/FmpDependencyCheckLib.h > create mode 100644 FmpDevicePkg/Include/Library/FmpDependencyLib.h > create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDepende= ncyCheckLib.c > create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDepende= ncyCheckLib.inf > create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDepende= ncyCheckLib.uni > create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLibNull/FmpDep= endencyCheckLibNull.c > create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLibNull/FmpDep= endencyCheckLibNull.inf > create mode 100644 FmpDevicePkg/Library/FmpDependencyCheckLibNull/FmpDep= endencyCheckLibNull.uni > rename FmpDevicePkg/{FmpDxe/Dependency.c =3D> Library/FmpDependencyLib/F= mpDependencyLib.c} (55%) > create mode 100644 FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLi= b.inf > create mode 100644 FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLi= b.uni > create mode 100644 FmpDevicePkg/Test/FmpDeviceHostPkgTest.dsc > create mode 100644 FmpDevicePkg/Test/UnitTest/Library/FmpDependencyLib/E= valuateDependencyUnitTest.c > create mode 100644 FmpDevicePkg/Test/UnitTest/Library/FmpDependencyLib/F= mpDependencyLibUnitTestsHost.inf > create mode 100644 FmpDevicePkg/Test/UnitTest/Library/FmpDependencyLib/F= mpDependencyLibUnitTestsUefi.inf >=20 > -- > 2.16.2.windows.1