From: "Liming Gao" <liming.gao@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Laszlo Ersek <lersek@redhat.com>,
Sean Brogan <sean.brogan@microsoft.com>,
"Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [PATCH] .gitmodules: ignore untracked files in brotli
Date: Mon, 27 Apr 2020 15:33:01 +0000 [thread overview]
Message-ID: <BN6PR11MB39726A4254A3C01AE2B8952D80AF0@BN6PR11MB3972.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200427012051.5724-1-shenglei.zhang@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Monday, April 27, 2020 9:21 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek <lersek@redhat.com>; Sean Brogan <sean.brogan@microsoft.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: [PATCH] .gitmodules: ignore untracked files in brotli
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2692
> BrotliCompress submodule change for BaseTools causes untracked
> files in BaseTools after building. This is regression for git.
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> .gitmodules | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitmodules b/.gitmodules
> index 41099f6fd701..29370a5c2fe8 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -16,3 +16,4 @@
> [submodule "BaseTools/Source/C/BrotliCompress/brotli"]
> path = BaseTools/Source/C/BrotliCompress/brotli
> url = https://github.com/google/brotli
> + ignore = untracked
> --
> 2.18.0.windows.1
next prev parent reply other threads:[~2020-04-27 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 1:20 [PATCH] .gitmodules: ignore untracked files in brotli Zhang, Shenglei
2020-04-27 15:33 ` Liming Gao [this message]
2020-04-28 12:52 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR11MB39726A4254A3C01AE2B8952D80AF0@BN6PR11MB3972.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox