* [PATCH] .gitmodules: ignore untracked files in brotli
@ 2020-04-27 1:20 Zhang, Shenglei
2020-04-27 15:33 ` Liming Gao
2020-04-28 12:52 ` Laszlo Ersek
0 siblings, 2 replies; 3+ messages in thread
From: Zhang, Shenglei @ 2020-04-27 1:20 UTC (permalink / raw)
To: devel; +Cc: Laszlo Ersek, Sean Brogan, Bob Feng, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2692
BrotliCompress submodule change for BaseTools causes untracked
files in BaseTools after building. This is regression for git.
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
.gitmodules | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitmodules b/.gitmodules
index 41099f6fd701..29370a5c2fe8 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -16,3 +16,4 @@
[submodule "BaseTools/Source/C/BrotliCompress/brotli"]
path = BaseTools/Source/C/BrotliCompress/brotli
url = https://github.com/google/brotli
+ ignore = untracked
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] .gitmodules: ignore untracked files in brotli
2020-04-27 1:20 [PATCH] .gitmodules: ignore untracked files in brotli Zhang, Shenglei
@ 2020-04-27 15:33 ` Liming Gao
2020-04-28 12:52 ` Laszlo Ersek
1 sibling, 0 replies; 3+ messages in thread
From: Liming Gao @ 2020-04-27 15:33 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io
Cc: Laszlo Ersek, Sean Brogan, Feng, Bob C
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Monday, April 27, 2020 9:21 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek <lersek@redhat.com>; Sean Brogan <sean.brogan@microsoft.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: [PATCH] .gitmodules: ignore untracked files in brotli
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2692
> BrotliCompress submodule change for BaseTools causes untracked
> files in BaseTools after building. This is regression for git.
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> .gitmodules | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitmodules b/.gitmodules
> index 41099f6fd701..29370a5c2fe8 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -16,3 +16,4 @@
> [submodule "BaseTools/Source/C/BrotliCompress/brotli"]
> path = BaseTools/Source/C/BrotliCompress/brotli
> url = https://github.com/google/brotli
> + ignore = untracked
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] .gitmodules: ignore untracked files in brotli
2020-04-27 1:20 [PATCH] .gitmodules: ignore untracked files in brotli Zhang, Shenglei
2020-04-27 15:33 ` Liming Gao
@ 2020-04-28 12:52 ` Laszlo Ersek
1 sibling, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2020-04-28 12:52 UTC (permalink / raw)
To: Shenglei Zhang, devel; +Cc: Sean Brogan, Bob Feng, Liming Gao
On 04/27/20 03:20, Shenglei Zhang wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2692
> BrotliCompress submodule change for BaseTools causes untracked
> files in BaseTools after building. This is regression for git.
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> .gitmodules | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitmodules b/.gitmodules
> index 41099f6fd701..29370a5c2fe8 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -16,3 +16,4 @@
> [submodule "BaseTools/Source/C/BrotliCompress/brotli"]
> path = BaseTools/Source/C/BrotliCompress/brotli
> url = https://github.com/google/brotli
> + ignore = untracked
>
Looks plausible -- I haven't been aware of this setting, but it is
indeed documented in the gitmodules(5) manual.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-28 12:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-27 1:20 [PATCH] .gitmodules: ignore untracked files in brotli Zhang, Shenglei
2020-04-27 15:33 ` Liming Gao
2020-04-28 12:52 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox