From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.299.1588001873832242236 for ; Mon, 27 Apr 2020 08:37:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=kS2dPicU; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: liming.gao@intel.com) IronPort-SDR: uS1CcOWimak8lIddThJNlzWPPRlsmsXdKGVxJNmH1AGx0Uo4XBKkJZIVfE8jDsIaBP4MP9sxKH npRlozF96fsA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2020 08:37:52 -0700 IronPort-SDR: uDFDQaWl9Iu8drg5Q/t15QmvFgVsdyxESmJSiMZXAtZRh78EOPadIKP+jZuiwB/gfLp/g8IooD 2MMUrTdoV5gA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,324,1583222400"; d="scan'208";a="302407310" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 27 Apr 2020 08:37:51 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 08:37:49 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 08:37:48 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 08:37:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rd+HzcPQGfk0o2KAc5odfO+TaFMlblVfZ5ae3exVNr2BUJNHiEBVvZ7L+N/YHvOVHyF4pV2/IQRdhN2V4gtPUA91Chs3Le5c7xtEXQjw9/ggtn7y7T3zMx2Q+g77hF3srbjFi/p2fNMWCrZoddr4SzxDuiT0xHda+pSgeJI42rEeqXKl9ZiVeQ2ssiFOBYUINfkATR18MrPp+NWreNwMoUnxpmq0oYHPrXy4SW6ID6kfLgvk3bLQKR3t6rX8HL2dOLxxxJXYeHJkFOc5iPv9E7V0aa6IbkHirJWpznGA/0nWtjgyeOPYAsGeG2UVg8gFh7rH8eCjrKFH2VrzhGZybg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0V2ki8hYUe44jf1BwWx6IKUOPl8JzgB1DI8YoAnB3jU=; b=JW0WKIw/o71iZhx8N9fhCscBBRNNdbg+SXsni8blBvL2SecCMCf8TT8DEAdaXWVkssLPqfflJqnKoK3if0R+ZEJLtsK4pn2ZGgZSIIZOM4AMTRy7LPj4vY8i+NnZnvWcEuph2ldEkLv4SHkQlEacBmTZsnEthkF/zpeJ6JE2IgBtRqztaK7KC6VSYdKZq9p9XtFyo8mayd81aYsmSHcmIYJG7aXR6CngfY7xYH4HHwyFMeM2k5DFuecvZkYxws4jwcpJXfvbR2agqM1Xug2NvzZM1we9Iga1dKOef7/hNdl/wOUp4OMLEJEfe6DCnC8zdB2RALjFwwQ7iF/V7zM6ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0V2ki8hYUe44jf1BwWx6IKUOPl8JzgB1DI8YoAnB3jU=; b=kS2dPicUYnNUPcCLk1b0wZHepfpkRzhZ1rem2TkJ37urRO1lrQ9rQHQitH8/FDcWh2y+fc1r2yS+b4D1ee73JAgdGIdxNN+wRYnrOX+cLtLFQ9urUJkrSKZdFlKbpslcjw/Dgfw+4b3bsQxH9/7zVszscSOtdZP8d4k47/EBfgY= Received: from BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) by BN6PR11MB1650.namprd11.prod.outlook.com (2603:10b6:405:11::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Mon, 27 Apr 2020 15:37:46 +0000 Received: from BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::4dcc:bc5c:def:9ae9]) by BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::4dcc:bc5c:def:9ae9%5]) with mapi id 15.20.2937.023; Mon, 27 Apr 2020 15:37:46 +0000 From: "Liming Gao" To: "devel@edk2.groups.io" , "leif@nuviainc.com" CC: "Feng, Bob C" Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: explicitly import decode_header PatchCheck.py Thread-Topic: [edk2-devel] [PATCH 1/1] BaseTools: explicitly import decode_header PatchCheck.py Thread-Index: AQHWF/V06IEnYu52t0yvY6DZHo7IIKiNI2Jw Date: Mon, 27 Apr 2020 15:37:45 +0000 Message-ID: References: <20200421154222.32485-1-leif@nuviainc.com> In-Reply-To: <20200421154222.32485-1-leif@nuviainc.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: spf=none (sender IP is ) smtp.mailfrom=liming.gao@intel.com; x-originating-ip: [134.191.221.119] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 30ab44c9-ced7-485d-dcd0-08d7eac0ef0f x-ms-traffictypediagnostic: BN6PR11MB1650: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 0386B406AA x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3972.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(39860400002)(136003)(396003)(366004)(376002)(52536014)(966005)(107886003)(186003)(86362001)(4326008)(9686003)(55016002)(478600001)(5660300002)(33656002)(66446008)(8676002)(66476007)(26005)(6506007)(2906002)(66946007)(110136005)(316002)(53546011)(64756008)(7696005)(71200400001)(76116006)(81156014)(66556008)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7hmHCF8uMFAefk7aJmqcDch4QjKA4VfMnLl/rdIvYQqM/eF3HEB1004tz+PiPANva2QAs8TCCxpk2X3kHsJOGrNYVE52jxuATwyhKQEcyIM5/LxAoDc5dRc9qaq8a5s7s68mjStYaBNZjNJWcpeaaTC3QKdS7PUpvAw7owHJcaQvy5gooTxgJmpv7Sfa30vfuh6jVmO4FTxt5YUsrBFTeDp+LtwymMjX4+G/e+oc7tu9H+xIbBIRwPljhAwZKbXhqZuE3t4YUfh7G3cm9P6Ha6C8ExMByC6whbIjZBo4oZaWD2TMbEdg0SEJAiY+ioVEpBCgq6X3Tr2a+lerq9tdkV8bNL9BlGG1LIeRC3KygKhOTBBxv7zbuEIWyeLapwzER9i4so2uaQgi3OsYP0taQNpbxvpZNvwUXgeKHge2aNylrcm9bB1xPp3ZtL02D2MVijXs476ErfMKNuhugQu6giOAhC+s1TLtZwcPVsnz4zEuj2wpah+xw9cH6I5w8oZo9OyIhakflY/Ub37c3OPXxQ== x-ms-exchange-antispam-messagedata: /zRfgPRJ7C/HuSm8vSVLqSu5o06LP94mPEMqMwynM47upQE74k4rp7hYBTH9kM3UrNZcYqBHJW+9uFKtjqi3YWepczR4cUZowy2INPbP6bdEhKrZ6Nl8+urfAHhM0fROPhM8wfmUuO+1kT2uUgu69EnmVcXzwmMQEnfcp9IJH17SRHvHlAYESMBeCsDLtRuTSShbIEoh2LtBQJCZ52JC8w1pHPm1NSL/ihQ14JTxQKp2btstFhyxhPqIWJf9Slq/SQTqgXbZFWhrIEYjDPpFV9x2POKIN4KONdU8TXrVUuVMOeF2kSTrJ94cZtxVQe5CEtkuPGn7avdTWScmS41ztFMXV2rWKcqgwgSuZG8lJVlDnkGI3ZaFiGGHSsI2LDS3qnJHVQUATy5k+t7iFqQOv2DE+dXFz+v22Ek1NK/Mc5NS7vZdV/mSZOT3Ab+VcxgIQt72YQN04/xeOfFdDa2zKMXGv+IpDXlyiLecy4eDBhkuqp2Vz6ITPps5LSDro6NZjQiDvV3JQMuKzEOE3XLiuPihH1vqEaILZxTL6b+Y1tXiK/rTkYn3+EEaHwHazEjIrwcIEjlIldElvRmRpPLVsGy/59pfS9Ap47gPfbq8UBrxrID3C7ojkPvOc4Bm+/lN2yOOnb/SRf5GcLix5QMcJOMWx832tE1iCnNdrm+rhWW9U0Rk7iJJCWOymp6aEKi2QWmqqJUCGFFIytery/BuacAO2aybaRGXW9jANxT/zOjSbKVw+TWcsaLViAAvqwNqXofzj9KHsrXsclxxnG5Lmic8vd/iPIXvh8I8j0L8/AwRgGM1vpVXlieaBYrbdRj6 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 30ab44c9-ced7-485d-dcd0-08d7eac0ef0f X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2020 15:37:45.9850 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MjGXWYWv3886eXe9OxvvXxJ+Ezk1r9EQKWRrjxSTgqKcoiL2aOECGcnV9oQbUrhlsnlH7oMkLgp120NVOIyMiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1650 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Lefi: Is email.header built-in lib? If this change doesn't require user to ins= tall the additional python library, I am OK with change.=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Leif Lind= holm > Sent: Tuesday, April 21, 2020 11:42 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [edk2-devel] [PATCH 1/1] BaseTools: explicitly import decode_he= ader PatchCheck.py >=20 > On Debian 10 (Buster), when running PatchCheck.py with python2, a > backtrace is printed, starting from: >=20 > File "../edk2/BaseTools/Scripts/PatchCheck.py", line 595, in find_patc= h_pieces > parts =3D email.header.decode_header(pmail.get('subject')) > AttributeError: 'module' object has no attribute 'header' >=20 > When using python3, this backtrace does not appear. >=20 > Explicitly importing decode_header resolves this for python2 and does no= t > appear to cause any issues with python3. >=20 > Cc: Bob Feng > Cc: Liming Gao > Signed-off-by: Leif Lindholm > --- >=20 > I'm pretty sure this used to work with python 2, > but I'm not sure when it stopped... >=20 > BaseTools/Scripts/PatchCheck.py | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCh= eck.py > index 13da6967785d..675ce273e830 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -19,6 +19,8 @@ import re > import subprocess > import sys >=20 > +from email.header import decode_header > + > class Verbose: > SILENT, ONELINE, NORMAL =3D range(3) > level =3D NORMAL > -- > 2.20.1 >=20 >=20 >=20