From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.13359.1589208116825240316 for ; Mon, 11 May 2020 07:41:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=nufHtwGr; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: liming.gao@intel.com) IronPort-SDR: CA0lQ19uxXkWty+a7JBW0ubIfW2e4ZRvuhliFvdzplRsLuLu1uvHSW8TlU7gT7/3/H8W1pJ0sp 789qZWSyUaFw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 07:41:56 -0700 IronPort-SDR: 9WpqCMrH/foWhbytZFrEqaoRl/2YeF5v1eG6ylya40jUZhvsvd+7cpZawnPo/nL0W2V9k1uRzh gK7oEpnlzi7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,380,1583222400"; d="scan'208";a="371242405" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 11 May 2020 07:41:56 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 07:41:55 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 11 May 2020 07:41:55 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 11 May 2020 07:41:55 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 07:41:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZxSGE+TaLCp5t9hEPwjy3NTy5XKdOaNvH0ENtRmWv/T46WiRUSALpT3cBFYAtXumIw7zAI02DvTBjmhrlJDua22QPJSrCw+JdQKHyVX/cc/n/tljWaUwB3giBSLh4JUxZST4F5gz9jktOdEMmVszHYjUQ2DALjk6etvsdXBwIt0GOEL38e+f5KnlP6y4vY4H6vsj9iP9+zb46OTL3URe81/xcaOMfJC+SvdvUK3HMFZ6B9KPzTm+vvvvCFZrn/G3Qse+qsjbQDQdY7yYLsYfgTKLexcKt05bCLkrr4t9INk0vzB5rlR8rhYvuuVpUBdjBW6IwsX0N+5FAcGOF7bMRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Ba5TIRuYKhG1KrtTkMZMvLhpomsAA3Kpx8718EhNc0=; b=j3/x9rElttt9cWC8cpOdvEYClJ7pg/RCQ5f5nUdz8RQOloVmbC9wxh6muNIT/MeWaS0yWUDNgnpTo1l6vtb0OGpAWUX25cDNyN5mXo5RhtnHBftaGcLpv5py1RPrneqTSD5pnI6or1FXQbmBEsAGkBJEnIDVmR3/89j4609ezEMWOO7+pekR1k+ef8TdQPjPJaNY6+2B+ehLT+foxNH/V0LOQqmMhasEZBH0PxN9veqtuVN//g9lqU0T+x72LQSPsSWy+EWhVz8aHEBwZAV4o08bgnFxGpuzXEDp/KKnHYJdn7jm8num9i0qWfQsmkAYbuioadY/s08/66xL1j+zmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Ba5TIRuYKhG1KrtTkMZMvLhpomsAA3Kpx8718EhNc0=; b=nufHtwGryl+aqOLg0/hHcMYDhEG7w/+mGFmufGxpb/PzxKFEIiLImpj4J0cfKNye3Xd1mNA8ebRe4lX6ay87GwG9++c6UV9cNJzR+C1ZSD4JC+dRUy+aGZieh31nbyd120Y21mPFozMsaVs8ukIJWkp7iSGcPlin0KQrkrEJg/E= Received: from BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) by BN6PR11MB1508.namprd11.prod.outlook.com (2603:10b6:405:b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.33; Mon, 11 May 2020 14:41:52 +0000 Received: from BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0]) by BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0%7]) with mapi id 15.20.2979.033; Mon, 11 May 2020 14:41:52 +0000 From: "Liming Gao" To: "devel@edk2.groups.io" , "oleksiyy@ami.com" , "Liu, Zhiguang" CC: "Kinney, Michael D" , Felix Polyudov Subject: Re: [edk2-devel] [PATCH v2 3/4] MdePkg: Add EFI_PROPERTIES_TABLE Thread-Topic: [edk2-devel] [PATCH v2 3/4] MdePkg: Add EFI_PROPERTIES_TABLE Thread-Index: AQHWJKbZObDUbzxOR06gF5Sgd6ixdaidtNqAgACcvwCABKkuwA== Date: Mon, 11 May 2020 14:41:52 +0000 Message-ID: References: <20200507193443.76728-1-oleksiyy@ami.com> <20200507193443.76728-4-oleksiyy@ami.com> <6BD875C24FFE2A4E8D6EFC142C67836F03FFFF9C25@atlms1.us.megatrends.com> In-Reply-To: <6BD875C24FFE2A4E8D6EFC142C67836F03FFFF9C25@atlms1.us.megatrends.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 44eb9580-0f12-40f7-3021-08d7f5b97218 x-ms-traffictypediagnostic: BN6PR11MB1508: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 04004D94E2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O8lEbmk1L7jNESSW31h0LiBmO9gw0HVHPZEb4aylPrv6V+fxiX0iVRJwzFjvvgYMPaYjQ11JxUD4rc6CF6qcl/XCk0jh+APWHGGsXnBb3eO7VmIUj+RtunPweegxi9bBNRnnFjANvOME8wmDyiipWYg+/niyPD0Nn6o72L1+rI9RukjU4P0hkSZowq3Qwchmhm3BeyTtPK1i1fzusxC9HSe4jOby49UHPF0ZAqfnk+tNflpjHaFp69ZJ9uLiI4ITRsMfxR//DDMAvWZ0h4s79uo9/lYwQOvLZlWk2RqIlLwAPPDBl4rxtlK+4FyrCUZouU/sYZPA94tbfUzjKQ/j0H7ll1jWfu16YgBrIl554gjxYVsCQhOd0bNKMqxPSpBatG2kAzkglvVfdulo2DN95gS2CjdQEVxp7GlzpnMWr+48t2NIteBcuuwMs8u5fiG6t4SLeINpxN4DfjMv5QFN+bLNK14f1YdICwBVmiurAzx6LEVKw3wmDYHnhlfvJ6u+/ToFaoq2qAfs0yYWBMVNplPTmPTwDELM2Xb2FvzM1NwNWnnWOnuyNOXDYImqBe05JXQ5zFx0LikqHrKfh/aSK5d8HqYrp3sgc5b8DCPK3Hk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3972.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(376002)(136003)(366004)(39860400002)(396003)(33430700001)(66446008)(64756008)(66556008)(5660300002)(71200400001)(4326008)(55016002)(8676002)(52536014)(9686003)(6636002)(2906002)(110136005)(54906003)(316002)(33440700001)(66476007)(76116006)(8936002)(66946007)(6506007)(33656002)(86362001)(26005)(7696005)(478600001)(186003)(53546011)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 9EtU6i5TBERbIrYhSkbqm8cMzeFJ+oZyBd9tjA4fsf+Bp/FMlNM7AkO35ORa3wHlwUpo502EVcfMV8AVx6bHALjlCKlfCsBrZt4gCMpeNt1ifV4TpSGvNCDUV+uLBi7cbrSICqaUsYOegSfeArQ8fZlC+7DIGuFRcU15pD7PaN8xmdbgHrkJ1C2p7TvLVPtMo+ykwn0pi/Tb6ynpNotqYwjDb2fPg6ObiQ/+dQZrmw7BrJTeN4ZpmEl5R55rPpPD+X75sm2Qzmw9JoFhR8RT2YEaJEHdMVyoSoZg6IukUhBce1lTlfg81j64dFcbzjb+ebD/K6fCH3a+X1ArFyuuihfwfjayd7to48foWNeFLkH7UGL/+stgAvWgLO8EFyhqFEBKXSxQPVQ4vmEqGvvSLJVLOePvAtriOglfuptaPnZkTJFOW/RV52inI2Cjutu+dxJMQzKQtsIil6cpPcatQuTVEFRR5RC4VMgm/wiBWGWDa305ndZSQH9PL4XwtI6E MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 44eb9580-0f12-40f7-3021-08d7f5b97218 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2020 14:41:52.6478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bnECUP1Z9bJy/8xuqzSj5Dn+w7dYsvsGllFvtA6teshqUHKDIzNkEnLm951p/qno39m1NFewKr2RgoyVD2WA3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1508 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Oleksiy: Please create the pull request for this patch set. Then, we can easy rev= iew it.=20 On this patch, I have two minor comments. Please also mention spec versi= on in file header, and update this macro definition.=20 #define _RT_PROPERTIES_TABLE_GUID_H__ =3D=3D> #define __RT_PROPERTIES_TABLE_GUID_H__ Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oleksiy Y= akovlev > Sent: Friday, May 8, 2020 11:29 PM > To: Liu, Zhiguang ; devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D ; Felix Polyudov > Subject: Re: [edk2-devel] [PATCH v2 3/4] MdePkg: Add EFI_PROPERTIES_TABL= E >=20 > Hi Zhiguang. >=20 > Is this about MdePkg.dec or about new added file RtPropertiesTable.h? >=20 > Regards, Oleksiy. > -----Original Message----- > From: Liu, Zhiguang [mailto:zhiguang.liu@intel.com] > Sent: Friday, May 08, 2020 2:08 AM > To: devel@edk2.groups.io; Oleksiy Yakovlev > Cc: Gao, Liming; Kinney, Michael D; Felix Polyudov > Subject: RE: [edk2-devel] [PATCH v2 3/4] MdePkg: Add EFI_PROPERTIES_TABL= E >=20 > Hi Oleksiy, > This patch is not correct and can't be applied to master branch. > Can you confirm? > The line number seems not consistent. >=20 > Thanks > Zhiguang >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Oleksiy > > Yakovlev > > Sent: Friday, May 8, 2020 3:35 AM > > To: devel@edk2.groups.io > > Cc: Gao, Liming ; Kinney, Michael D > > ; Felixp@ami.com; oleksiyy@ami.com > > Subject: [edk2-devel] [PATCH v2 3/4] MdePkg: Add EFI_PROPERTIES_TABLE > > > > Define Guid & data structure for EFI_RT_PROPERTIES_TABLE, designed to = be > > published by a > > platform if it no longer supports all EFI runtime services once > > ExitBootServices() > > has been called by the OS. > > (UEFI 2.8 errata a, mantis 2049) > > > > Signed-off-by: Oleksiy Yakovlev > > --- > > MdePkg/Include/Guid/RtPropertiesTable.h | 68 > > +++++++++++++++++++++++++++++++ > > MdePkg/MdePkg.dec | 6 +++ > > 2 files changed, 74 insertions(+) > > create mode 100644 MdePkg/Include/Guid/RtPropertiesTable.h > > > > diff --git a/MdePkg/Include/Guid/RtPropertiesTable.h > > b/MdePkg/Include/Guid/RtPropertiesTable.h > > new file mode 100644 > > index 0000000..a5b6c14 > > --- /dev/null > > +++ b/MdePkg/Include/Guid/RtPropertiesTable.h > > @@ -0,0 +1,71 @@ > > +/** @file > > +Guid & data structure for EFI_RT_PROPERTIES_TABLE, designed to be > > published by a > > +platform if it no longer supports all EFI runtime services once > > ExitBootServices() > > +has been called by the OS. > > + > > + > > +Copyright (c) 2020, American Megatrends International LLC. All rights > > reserved.
> > +SPDX-License-Identifier: BSD-2-Clause-Patent > > + > > +**/ > > + > > +#ifndef _RT_PROPERTIES_TABLE_GUID_H__ > > +#define _RT_PROPERTIES_TABLE_GUID_H__ > > + > > +// > > +// Table, defined here, should be published by a platform if it no lo= nger > > supports all EFI runtime > > +// services once ExitBootServices() has been called by the OS. Note t= hat this > > is merely a hint > > +// to the OS, which it is free to ignore, and so the platform is stil= l required to > > provide callable > > +// implementations of unsupported runtime services that simply return > > EFI_UNSUPPORTED. > > +// > > +#define EFI_RT_PROPERTIES_TABLE_GUID \ > > + { 0xeb66918a, 0x7eef, 0x402a, \ > > + { 0x84, 0x2e, 0x93, 0x1d, 0x21, 0xc3, 0x8a, 0xe9 }} > > + > > + > > + > > +#pragma pack(1) > > + > > +typedef struct { > > + /// > > + /// Version of the structure, must be 0x1. > > + /// > > + UINT16 Version; > > + > > + /// > > + /// Size in bytes of the entire EFI_RT_PROPERTIES_TABLE, must be 8. > > + /// > > + UINT16 Length; > > + > > + /// > > + /// Bitmask of which calls are or are not supported, where a bit se= t to 1 > > indicates > > + /// that the call is supported, and 0 indicates that it is not. > > + /// > > + UINT32 RuntimeServicesSupported; > > +} EFI_RT_PROPERTIES_TABLE; > > + > > +#pragma pack() > > + > > +#define EFI_RT_PROPERTIES_TABLE_VERSION 0x1 > > + > > +#define EFI_RT_SUPPORTED_GET_TIME 0x0001 > > +#define EFI_RT_SUPPORTED_SET_TIME 0x0002 > > +#define EFI_RT_SUPPORTED_GET_WAKEUP_TIME 0x0004 > > +#define EFI_RT_SUPPORTED_SET_WAKEUP_TIME 0x0008 > > +#define EFI_RT_SUPPORTED_GET_VARIABLE 0x0010 > > +#define EFI_RT_SUPPORTED_GET_NEXT_VARIABLE_NAME 0x0020 > > +#define EFI_RT_SUPPORTED_SET_VARIABLE 0x0040 > > +#define EFI_RT_SUPPORTED_SET_VIRTUAL_ADDRESS_MAP 0x0080 > > +#define EFI_RT_SUPPORTED_CONVERT_POINTER 0x0100 > > +#define EFI_RT_SUPPORTED_GET_NEXT_HIGH_MONOTONIC_COUNT > > 0x0200 > > +#define EFI_RT_SUPPORTED_RESET_SYSTEM 0x0400 > > +#define EFI_RT_SUPPORTED_UPDATE_CAPSULE 0x0800 > > +#define EFI_RT_SUPPORTED_QUERY_CAPSULE_CAPABILITIES 0x1000 > > +#define EFI_RT_SUPPORTED_QUERY_VARIABLE_INFO 0x2000 > > + > > +extern EFI_GUID gEfiRtPropertiesTableGuid; > > + > > +#endif > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > > index 99e75f7..d5340c5 100644 > > --- a/MdePkg/MdePkg.dec > > +++ b/MdePkg/MdePkg.dec > > @@ -655,6 +655,12 @@ > > gEfiBttAbstractionGuid =3D { 0x18633bfc, 0x1735, 0x4217, { = 0x8a, 0xc9, > > 0x17, 0x23, 0x92, 0x82, 0xd3, 0xf8 }} > > > > # > > + # GUIDs defined in UEFI2.8a > > + # > > + ## Include/Guid/RtPropertiesTable.h > > + gEfiRtPropertiesTableGuid =3D { 0xeb66918a, 0x7eef, 0x402a, { = 0x84, 0x2e, > > 0x93, 0x1d, 0x21, 0xc3, 0x8a, 0xe9 }} > > + > > + # > > # GUID defined in PI1.0 > > # > > ## Include/Guid/AprioriFileName.h > > -- > > 2.9.0.windows.1 > > > > > > Please consider the environment before printing this email. > > > > The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is inten= ded > > to be read only by the individual or entity to whom it is addressed or= by their > > designee. If the reader of this message is not the intended recipient,= you are > > on notice that any distribution of this message, in any form, is stric= tly > > prohibited. Please promptly notify the sender by reply e-mail or by > > telephone at 770-246-8600, and then delete or destroy all copies of th= e > > transmission. > > > > >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and propri= etary to American Megatrends (AMI). This communication > is intended to be read only by the individual or entity to whom it is ad= dressed or by their designee. If the reader of this message is > not the intended recipient, you are on notice that any distribution of t= his message, in any form, is strictly prohibited. Please > promptly notify the sender by reply e-mail or by telephone at 770-246-86= 00, and then delete or destroy all copies of the transmission. >=20 >=20