From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.4976.1587458794629584383 for ; Tue, 21 Apr 2020 01:46:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Jp41xwzx; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: liming.gao@intel.com) IronPort-SDR: zcgmV1bABmgRyLJlCr55M/OSKt532fXxEX64/8JQR1qmpJHcMWAhHgUmQ/nIfMebb77yAWg3mV 9kXXLEcolOow== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2020 01:46:33 -0700 IronPort-SDR: zrovFwli3uhM0xZ9M7siU+92tZOnYvn1XsIOBaRkAvDjKvHpXupDD+T5MyPEpL9tYa1QtSDtte iAd3ICzpTl/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,409,1580803200"; d="scan'208";a="456026106" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga005.fm.intel.com with ESMTP; 21 Apr 2020 01:46:33 -0700 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 01:46:33 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX161.amr.corp.intel.com (10.22.240.84) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 01:46:33 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 01:46:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a12PDvOA7VpK9EiqSrtfA0fyhj1sQr6vRE1UF9xol379Eb0caM6fuZMTkS9RGDD3eH8mXXZIZ7gdzjJQEeQoSLt0dwI/4rHqF1EnpkRfoFumL7XRFTLeNOvNjPiu7vHsWDmuFOvMSjsTLkrzQxgGX5A4Ngqg8FpCpzp5a6bzn9wrpdQA98Uy6TQKNkj43pOb6xYA+7Rpb38/FpIR111ZZuTf2L2gxAF6XYNL6VEiH+ziLXEhWSI1Nd/gqvh6IdEVJb8I4r7kmcuuHBO/CqpnQ8PvoIK/6qV+Umr0A4e2Xi81zAyG4Fa74hYklcI5xLKSnV2W0qXR9KzVEeO4M1le6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i4/9WEgE7os70Zl9sfMTDZ2xxw61TdYfiIWP6d16tB0=; b=RgNj9foAQARP28ngtchSkw3Z228pp+nAs0C9fP3t6RIrhNsKI9TFuyiFvLoFITyOVK20zfmQMM0BqR5MYD5t8eb04r9RpTyAURVmWgYFUJ03BbMId85NptLwE+x3QrRNJ28UMLSUq0O5OmYanxUrJVBk2JD8OdQU7Onb6pydr5cUxy/Aw2h8H06NGMkd6npATfYlgalASSwajuA2htZi9ZPhVwWMMLVjFzS9U1k8jGwUUEifo9EsCTINcMdEIv99on3SaokjKSYIVsHFR8U2ALlAaa7d/gkr+CyvYpc+9DqK0fRAsOKo86A8tQvLcK01Gop/faqStRH446ZPjuxFGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i4/9WEgE7os70Zl9sfMTDZ2xxw61TdYfiIWP6d16tB0=; b=Jp41xwzxuhygI9eTmQZzTw9SrE2gzWKshaO66W3pZVqXuoIhlzOGkq+zmnvvV5LLli6Rnp84ATWFqWTMNRridWxOhkdZ3qOZoqRiqeLKOIsL9tf5ccL5Y7l/0+Q3DyovspTsBqRnxWIWSFbmqVE1Xbzgax24QyFrvd6ZBlBHmS8= Received: from BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) by BN6PR11MB1378.namprd11.prod.outlook.com (2603:10b6:404:4a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Tue, 21 Apr 2020 08:46:30 +0000 Received: from BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::4dcc:bc5c:def:9ae9]) by BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::4dcc:bc5c:def:9ae9%5]) with mapi id 15.20.2921.027; Tue, 21 Apr 2020 08:46:30 +0000 From: "Liming Gao" To: Laszlo Ersek , "Bi, Dandan" CC: "devel@edk2.groups.io" , "samer.el-haj-mahmoud@arm.com" , "Wang, Jian J" , "Wu, Hao A" , Leif Lindholm , Ard Biesheuvel , nd , "samer@elhajmahmoud.com" Subject: Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms Thread-Topic: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms Thread-Index: AQHWD0zX3I+gOJ5N5Emzavdx92p+FKh/CWqAgALyqgCAARe4gIAAPv+AgAAAYhA= Date: Tue, 21 Apr 2020 08:46:30 +0000 Message-ID: References: <20200410152925.6119-1-samer@elhajmahmoud.com> <20200410152925.6119-2-samer@elhajmahmoud.com> <08951bf6-9efc-dc7c-ab2c-2c1ccda756a2@redhat.com> <3C0D5C461C9E904E8F62152F6274C0BB40DC74D1@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: spf=none (sender IP is ) smtp.mailfrom=liming.gao@intel.com; x-originating-ip: [192.55.52.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: db74ed63-6cec-472d-71c7-08d7e5d07cf1 x-ms-traffictypediagnostic: BN6PR11MB1378: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 038002787A x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3972.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(376002)(346002)(366004)(396003)(136003)(39860400002)(66446008)(33656002)(66946007)(76116006)(52536014)(66556008)(66476007)(5660300002)(55016002)(966005)(64756008)(9686003)(478600001)(2906002)(186003)(26005)(316002)(71200400001)(53546011)(4326008)(6506007)(7696005)(86362001)(81156014)(110136005)(54906003)(8676002)(8936002)(6636002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: azPCUJpg/0h3SmyZdBUFrert3HO7q4gvdBedeSfPQL8LLh1hMKopahw90149PgCKKkW9xbTgqVopgwXd+CjJa7yiK3oHr5ClBVQxO0+2KrmP1GuOtciTrlVR24LyBYZLoEP6BVrpl89jJ39+jRz/Hsv3H3G9/r2S6pSIANbA+zIUX/HfI6l4kZQEJ5yUojzt7rtyVJ51aSP7xsHTyNjy7beat0FJVxYzbKy18lvHSrLPAF4uAiwcBK0hH9czVWNS2sg649Rx8Stt1Ed1e0JTl7MGyhPREsmsTpRVq4/VqHcWTw5wPahofcjOcS0p+wk7Zuf2cmTiOgv9BR87CjLLscMyt36U4ntuphg2Ylvz4xvI/mO3GrC+z5c0LiZn7F7RrnizMxaGkFU1bto6w2vdViwp2Kx+eJSxi3cY6xHpZbSLo9YnQwobwP/ojSisfm4aliR4YHuHkMnkPHYyVQANEnJmiHmvB6rKoLkV8xPbhjLNOKynwBtZJ1xAJaW356LqgxNw8f/kOWRG0HEAOJ9FztsuLJzekZw8DvfqsVcMVeqpXbyUCnGgTDoapcQ1KOdE x-ms-exchange-antispam-messagedata: ylywhH42JRacx9C8OQAOQrKLIxktr5SECw4f4t9BVfWvmpB1FaJ6Oy9hlAhPZe+Sxht+SKKMD0aKnHrL+S3j/OH/aKIKOZNYOfFt4sta2Vu6WAZGZc2bbRZtpxthDd167Q3toxsrEQj/LUjmaHcTkw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: db74ed63-6cec-472d-71c7-08d7e5d07cf1 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 08:46:30.7461 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vnEX1LaCKgNrqf5fGxo/xYIt07BAndL/mgNl8aEe9nKcBFx5tlQwGL3Cu00aXIb6cg0cNDNJZOdA7NVmKC6Erw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1378 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Laszlo: I understand Module reviewer R-B is enough for the patch. R: Package Reviewer: Cc address for patches and questions. Reviewers hel= p maintainers review code, but don't have push access. A designated Pac= kage Reviewer is reasonably familiar with the Package (or some modules thereof), and/or provides testing or regression testing for the Packa= ge (or some modules thereof), in certain platforms and environments. Thanks Liming -----Original Message----- From: Laszlo Ersek =20 Sent: 2020=1B$BG/=1B(B4=1B$B7n=1B(B21=1B$BF|=1B(B 16:42 To: Bi, Dandan Cc: devel@edk2.groups.io; samer.el-haj-mahmoud@arm.com; Wang, Jian J ; Wu, Hao A ; Gao, Liming ; Leif Lindholm ; Ard Biesheuvel ; nd ; samer@elhajmahmoud.com Subject: Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExpose= dTableVersions default for Arm64 platforms On 04/21/20 06:56, Bi, Dandan wrote: > Hi Laszlo, >=20 > I think it should be Ok. > But if can get ACK/R-B from the maintainer of MdeModulePkg, that would b= e better, which follows process more. Yes, I agree, but Jian and Hao are not responding. Could you poke them int= ernally at Intel, please? Thanks Laszlo >=20 >=20 > Thanks, > Dandan >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Monday, April 20, 2020 8:15 PM >> To: Bi, Dandan >> Cc: devel@edk2.groups.io; samer.el-haj-mahmoud@arm.com; Wang, Jian J=20 >> ; Wu, Hao A ; Gao, Liming=20 >> ; Leif Lindholm ; Ard=20 >> Biesheuvel ; nd ;=20 >> samer@elhajmahmoud.com >> Subject: Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: >> PcdAcpiExposedTableVersions default for Arm64 platforms >> >> Dandan, >> >> On 04/18/20 17:14, Samer El-Haj-Mahmoud wrote: >>> Jian, Hao, >>> >>> Can you please push this simple patch? It has been reviewed a while=20 >>> ago >> and ready to be committed. >> >> should we consider your R-b on the first patch sufficient for pushing? >> >> You are marked as "R" for "MdeModulePkg: ACPI modules", but=20 >> technically speaking, "MdeModulePkg.dec" needs an ACK from either Jian = or Hao. >> >> Content-wise, your approval looks sufficient, but I don't want to assum= e. >> Please confirm. >> >> Thank >> Laszlo >> >>>> -----Original Message----- >>>> From: devel@edk2.groups.io On Behalf Of >> Samer >>>> El- Haj-Mahmoud via groups.io >>>> Sent: Friday, April 10, 2020 11:29 AM >>>> To: devel@edk2.groups.io >>>> Cc: Dandan Bi ; Liming Gao=20 >>>> ; Jian J Wang ; Hao A=20 >>>> Wu ; Leif Lindholm ; Ard=20 >>>> Biesheuvel >>>> Subject: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: >>>> PcdAcpiExposedTableVersions default for Arm64 platforms >>>> >>>> Set the default value of PcdAcpiExposedTableVersions for Aarch64=20 >>>> platforms to 0x20. Previously, the default was set to 0x3E for all=20 >>>> platforms. The new value removes ACPI 1.0b compatability, which=20 >>>> forces the use of XSDT 64-bit pointer, as required by Arm SBBR >> specification. >>>> This also resolves an error reported by acpiview command, as seen=20 >>>> on the RPi (see https://github.com/pftf/RPi4/issues/25). >>>> >>>> Cc: Dandan Bi >>>> Cc: Liming Gao >>>> Cc: Jian J Wang >>>> Cc: Hao A Wu >>>> Cc: Leif Lindholm >>>> Cc: Ard Biesheuvel >>>> >>>> Signed-off-by: Samer El-Haj-Mahmoud >>>> Reviewed-by: Ard Biesheuvel >>>> Reviewed-by: Dandan Bi >>>> --- >>>> MdeModulePkg/MdeModulePkg.dec | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/MdeModulePkg/MdeModulePkg.dec=20 >>>> b/MdeModulePkg/MdeModulePkg.dec index >> 497574cb0870..fac16f262cf8 >>>> 100644 >>>> --- a/MdeModulePkg/MdeModulePkg.dec >>>> +++ b/MdeModulePkg/MdeModulePkg.dec >>>> @@ -1548,6 +1548,9 @@ >>>> # @Prompt Console Output Row of Text Setup >>>> >>>> >> gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40 >> 000 >>>> 00e >>>> >>>> +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] >>>> + >>>> >> +gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20| >> UINT >>>> 32| >>>> +0x0001004c >>>> + >>>> [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, >> PcdsDynamicEx] >>>> ## UART clock frequency is for the baud rate configuration. >>>> # @Prompt Serial Port Clock Rate. >>>> -- >>>> 2.17.1 >>>> >>>> >>>> >>> >>> >>>=20 >>> >=20