From: "Liming Gao" <liming.gao@intel.com>
To: Oleksiy Yakovlev <oleksiyy@ami.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Felixp@ami.com" <Felixp@ami.com>
Subject: Re: [PATCH v4 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid
Date: Mon, 11 May 2020 14:46:52 +0000 [thread overview]
Message-ID: <BN6PR11MB3972A914529E265D33E1004780A10@BN6PR11MB3972.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200508214611.70592-2-oleksiyy@ami.com>
Oleksiy:
For new added field DeviceTypeGuid, is there more comment for it?
> + CONST EFI_GUID *DeviceTypeGuid; // Revision 1.1
Thanks
Liming
> -----Original Message-----
> From: Oleksiy Yakovlev <oleksiyy@ami.com>
> Sent: Saturday, May 9, 2020 5:46 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Felixp@ami.com; oleksiyy@ami.com
> Subject: [PATCH v4 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid
>
> EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001.
> CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure.
> UEFI 2.8 mantis 1832.
>
> Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
> ---
> MdePkg/Include/Protocol/SerialIo.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/Protocol/SerialIo.h b/MdePkg/Include/Protocol/SerialIo.h
> index 51eaa53..b2398c2 100644
> --- a/MdePkg/Include/Protocol/SerialIo.h
> +++ b/MdePkg/Include/Protocol/SerialIo.h
> @@ -262,7 +262,7 @@ typedef struct {
> UINT32 StopBits;
> } EFI_SERIAL_IO_MODE;
>
> -#define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010000
> +#define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010001
> #define SERIAL_IO_INTERFACE_REVISION EFI_SERIAL_IO_PROTOCOL_REVISION
>
> ///
> @@ -287,6 +287,7 @@ struct _EFI_SERIAL_IO_PROTOCOL {
> /// Pointer to SERIAL_IO_MODE data.
> ///
> EFI_SERIAL_IO_MODE *Mode;
> + CONST EFI_GUID *DeviceTypeGuid; // Revision 1.1
> };
>
> extern EFI_GUID gEfiSerialIoProtocolGuid;
> --
> 2.9.0.windows.1
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication
> is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is
> not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please
> promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
next prev parent reply other threads:[~2020-05-11 14:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 21:46 [PATCH v4 0/7] Add definitions introduced in UEFI 2.8 Oleksiy Yakovlev
2020-05-08 21:46 ` [PATCH v4 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Oleksiy Yakovlev
2020-05-11 14:46 ` Liming Gao [this message]
2020-05-08 21:46 ` [PATCH v4 2/7] BaseTools: REST style formset Oleksiy Yakovlev
2020-05-08 21:46 ` [PATCH v4 3/7] MdePkg: " Oleksiy Yakovlev
2020-05-08 21:46 ` [PATCH v4 4/7] BaseTools: Bootable NVDIMM namespaces Oleksiy Yakovlev
2020-05-08 21:46 ` [PATCH v4 5/7] MdePkg: " Oleksiy Yakovlev
2020-05-08 21:46 ` [PATCH v4 6/7] MdePkg: Add UEFI Spec Revision 2.8 Oleksiy Yakovlev
2020-05-08 21:46 ` [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support Oleksiy Yakovlev
2020-05-09 2:34 ` [edk2-devel] " Zhiguang Liu
2020-05-11 14:14 ` Liming Gao
[not found] ` <160DFEDDA3DFE660.21511@groups.io>
2020-05-11 14:48 ` Liming Gao
2020-05-11 15:04 ` Oleksiy Yakovlev
2020-05-11 15:10 ` Liming Gao
2020-05-11 14:52 ` [PATCH v4 0/7] Add definitions introduced in UEFI 2.8 Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR11MB3972A914529E265D33E1004780A10@BN6PR11MB3972.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox