From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.13466.1589208417039207183 for ; Mon, 11 May 2020 07:46:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=cDI58fSZ; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: liming.gao@intel.com) IronPort-SDR: d4tSAJYojrpcU2VmuABF0lfMWZojqMon8pdJT1EtHU36p17VjRmSIbEyyA2by4PNTR6XFxz/pm IgcxenJqs/Cw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 07:46:56 -0700 IronPort-SDR: JA3fw27NFckSSB8/Q9Smbk71J/xwGF3FQSlwaznbP/ypHpCSzNnDP4gBh9mw6i7jd2ucvbN7GS +OJMIn294FUA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,380,1583222400"; d="scan'208";a="261790290" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga003.jf.intel.com with ESMTP; 11 May 2020 07:46:56 -0700 Received: from orsmsx114.amr.corp.intel.com (10.22.240.10) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 07:46:55 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX114.amr.corp.intel.com (10.22.240.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 07:46:55 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 07:46:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b/80I5kJYZkIPjRM2lR8OLsbYpkuiSX6NtgddTapj1f/C9q8wOd75PyjsV9g0dF2zw9G2EQd32CVoKNM8RiMa5sisAmnel0RUpfNP3KL9hBq1zWLswipPdY6P4R2cEsBfhTbHoQX8hXjUakMSkHGjX5Y9o1z/CXhDP3eFr7IDSfogkuoUSbASJfTX0RHrrT2uxIzcLM10ZJzc21KR1ltpLeK12Bdbjuq7r29HG6wDQY8Yz/aKFE7f5r0h8Zc3CsgALx354GZwrnd0NXAFO88DGHr2aquLnyPsydxxcEF/JXBe3M7Te8JOVijMXXEF7VHAyK2EqIHMF7dyh7SvIQAaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MzAuKtpNdguDSDEFdAC4dVqZtMOCFh0zGhT6bOLarNY=; b=iRO9PKf/JPBe5fM8ITRgdxjvet/IWJUOESEuky40I/9BuNoFs/RroWJNmAUjvIAVlDt/LH+x+CpkZxP3ow68+jPIrUmmePe1mvPqiwaX5REeBRTLL8/PHcCBpGHADUIP5HyA4rQdpbMCd0KCNr9ieSx1W2CHxYHYKECrfMj7am+oEugKrahk2INxv/x9cEuW48521HYlBTIyvEVEAZqWGJQRjtDHhBFOOn+1Lwb0bDB4CYqXjnH7YBAkKHv7wW4HakqjWonIIk+3n3gvqFd7BM3IS5GdfjJv97TnghwfHM8By84/3wmUGz/R3VDXk7dF3o97MgAblPQSq9wCmZYQJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MzAuKtpNdguDSDEFdAC4dVqZtMOCFh0zGhT6bOLarNY=; b=cDI58fSZ9iqj9K/w52rWREPdpxaSCaGWNYCayDaTImCuB7xaT9VC7y9KmBFKXoH3GYJakhQi+dlV3nBNubjSwpJ0gcNmwYxefQCtqIAIDEw1uZpcl3sLFobHCKNqsFdW8+SL6j+uAJBsDTC8oNERMSjSO56l9aFDtUg4y2+wF8Y= Received: from BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) by BN6PR11MB1233.namprd11.prod.outlook.com (2603:10b6:404:44::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Mon, 11 May 2020 14:46:52 +0000 Received: from BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0]) by BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0%7]) with mapi id 15.20.2979.033; Mon, 11 May 2020 14:46:52 +0000 From: "Liming Gao" To: Oleksiy Yakovlev , "devel@edk2.groups.io" CC: "Feng, Bob C" , "Kinney, Michael D" , "Felixp@ami.com" Subject: Re: [PATCH v4 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Topic: [PATCH v4 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Index: AQHWJYJg8eBrvKz9QUSNkiTSwcFveKii+plw Date: Mon, 11 May 2020 14:46:52 +0000 Message-ID: References: <20200508214611.70592-1-oleksiyy@ami.com> <20200508214611.70592-2-oleksiyy@ami.com> In-Reply-To: <20200508214611.70592-2-oleksiyy@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: ami.com; dkim=none (message not signed) header.d=none;ami.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8b412454-3811-4cd6-a1e5-08d7f5ba249a x-ms-traffictypediagnostic: BN6PR11MB1233: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-forefront-prvs: 04004D94E2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BdxIQgA6co53VQOWGLFLwwWdRpVsYwx3EWbloDMbip6ogeIn3JZa8JMCxIwntUxum6dPV412nXk78Ou5bAhUOWsxLbT3Msx9uPeKBAUoAljOVhuo+aulazwAzrJQmUv8rFB7b+t7mhX6YGproLm7O6mjMU0yISzUAnol9SAxBj4tMvnG2PU3a93e4FvNy9LZrg3l//Eww++/xbeU5p+4aRpk5RJF3WVsOKERwVR25VYbW1I6JzbqrV7/9hjJaOqWdfi53Mo3fqRHgFNaGPxwFwQxkEUNHKS1r/cqO922fG5sU9CetTUN+wCek5fdEpE9YaCbCKgYclZUJ58KcaKKf0x4q1mFLyNnTXC19iDKO20t19ivYqjDPurCpM1ieJ8axGxYZqhOg7R4NVD0g0dAZ9HMf/R9EEb3pI7F/FnQ4vHOvBxFjhUVu0eVLQAE+uKnFK/Nj/2L8SCZ3YB9xS4p+aAUmTnFVA0jFYIsLTQMfFRwqw6wWIuSFR9mvbgGkXyWjbG8Lb0PJNNPwpZkt4WH9w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3972.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(39860400002)(136003)(376002)(346002)(396003)(366004)(33430700001)(110136005)(4326008)(2906002)(86362001)(55016002)(7696005)(64756008)(66556008)(71200400001)(33440700001)(33656002)(76116006)(66946007)(26005)(186003)(66446008)(66476007)(8676002)(8936002)(54906003)(6506007)(53546011)(316002)(5660300002)(52536014)(9686003)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: uJqWOEWjGD79vJ8ocSo1B/RFiPHtL/0Vp5X67eCSweiOGOk13Zhe3tg3qiUricIYGpCn+d0JyvOilgsiJ4UYLOvvus+GXJRj7wlY9xDbtiKDs3cPZbu3nNAss/2x7+AFZfWe+7aAb4Oa5e3o+SlRm+RUnmU9p8TEkSJiPZKs4N1TODNcFi3DfDl1wxk31SsxwEcyRLkYk47dXF8L0/5d+pbT3HHyPfj85QzAgN0/jTNqPQmnnJJOIc/iRh6F+wRmVcry2a/oYim9t4it7NgwhUaT7HcGnf4aamKy/Xuq66NvqR8zfvz0CN332ocenkNqOOn0w2B2csGTzLpAtZ03DFV95bRo6me/sdaaQjPkKuFJaee+7+FMOvTzPJeIwcIzKzTUQBJRZFCnTmSgO9pYSwVZumK/pspXY90h5CXDLD4nv+LYcCdiDXHVy6R9e2c99f+kOxKXmMDhicbp2yeO1GCt5aGrbScG8+lalxwx1Ooj4APp1GMhBzmCYCCChRtF MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8b412454-3811-4cd6-a1e5-08d7f5ba249a X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2020 14:46:52.1021 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f1NsEEWFJlvN6gheTzYXjPY5dqJJJ8hBtKZyRepQo7ZZlH8BIAvcC5C8oru+lPr2tOHMSYQezezEA2M74vIjjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1233 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Oleksiy: For new added field DeviceTypeGuid, is there more comment for it? > + CONST EFI_GUID *DeviceTypeGuid; // Revision 1.1 Thanks Liming > -----Original Message----- > From: Oleksiy Yakovlev > Sent: Saturday, May 9, 2020 5:46 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming ; Kinney, Michael D ; > Felixp@ami.com; oleksiyy@ami.com > Subject: [PATCH v4 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid >=20 > EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001. > CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure. > UEFI 2.8 mantis 1832. >=20 > Signed-off-by: Oleksiy Yakovlev > --- > MdePkg/Include/Protocol/SerialIo.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/MdePkg/Include/Protocol/SerialIo.h b/MdePkg/Include/Protocol= /SerialIo.h > index 51eaa53..b2398c2 100644 > --- a/MdePkg/Include/Protocol/SerialIo.h > +++ b/MdePkg/Include/Protocol/SerialIo.h > @@ -262,7 +262,7 @@ typedef struct { > UINT32 StopBits; > } EFI_SERIAL_IO_MODE; >=20 > -#define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010000 > +#define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010001 > #define SERIAL_IO_INTERFACE_REVISION EFI_SERIAL_IO_PROTOCOL_REVISION >=20 > /// > @@ -287,6 +287,7 @@ struct _EFI_SERIAL_IO_PROTOCOL { > /// Pointer to SERIAL_IO_MODE data. > /// > EFI_SERIAL_IO_MODE *Mode; > + CONST EFI_GUID *DeviceTypeGuid; // Revision 1.1 > }; >=20 > extern EFI_GUID gEfiSerialIoProtocolGuid; > -- > 2.9.0.windows.1 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and proprie= tary to American Megatrends (AMI). This communication > is intended to be read only by the individual or entity to whom it is add= ressed or by their designee. If the reader of this message is > not the intended recipient, you are on notice that any distribution of th= is message, in any form, is strictly prohibited. Please > promptly notify the sender by reply e-mail or by telephone at 770-246-860= 0, and then delete or destroy all copies of the transmission.