[PATCH v4 0/7] Add definitions introduced in UEFI 2.8

[PATCH v4 0/7] Add definitions introduced in UEFI 2.8

[Oleksiy Yakovlev]

Following patches add/update structures/definitions, that was 
introduced/modified by UEFI Spec v.2.8.

Oleksiy Yakovlev (7):
  MdePkg: Extend SERIAL_IO with DeviceTypeGuid
  BaseTools:  REST style formset
  MdePkg:  REST style formset
  BaseTools: Bootable NVDIMM namespaces
  MdePkg: Bootable NVDIMM namespaces
  MdePkg: Add UEFI Spec Revision 2.8
  MdePkg: UEFI JSON Capsule Support

 .../Common/UefiInternalFormRepresentation.h        |  1 +
 BaseTools/Source/C/Include/Protocol/DevicePath.h   | 12 +++
 MdePkg/Include/Guid/CapsuleReport.h                | 29 +++++++
 MdePkg/Include/Guid/HiiPlatformSetupFormset.h      |  4 +
 MdePkg/Include/Guid/JsonCapsule.h                  | 97 ++++++++++++++++++++++
 MdePkg/Include/Protocol/DevicePath.h               | 12 +++
 MdePkg/Include/Protocol/SerialIo.h                 |  3 +-
 .../Include/Uefi/UefiInternalFormRepresentation.h  |  1 +
 MdePkg/Include/Uefi/UefiSpec.h                     |  2 +
 MdePkg/MdePkg.dec                                  | 11 +++
 10 files changed, 171 insertions(+), 1 deletion(-)
 create mode 100644 MdePkg/Include/Guid/JsonCapsule.h

-- 
2.9.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[PATCH v4 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid

[Oleksiy Yakovlev]

EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001.
CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure.
UEFI 2.8 mantis 1832.

Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
---
 MdePkg/Include/Protocol/SerialIo.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/Protocol/SerialIo.h b/MdePkg/Include/Protocol/SerialIo.h
index 51eaa53..b2398c2 100644
--- a/MdePkg/Include/Protocol/SerialIo.h
+++ b/MdePkg/Include/Protocol/SerialIo.h
@@ -262,7 +262,7 @@ typedef struct {
   UINT32  StopBits;
 } EFI_SERIAL_IO_MODE;
 
-#define EFI_SERIAL_IO_PROTOCOL_REVISION    0x00010000
+#define EFI_SERIAL_IO_PROTOCOL_REVISION    0x00010001
 #define SERIAL_IO_INTERFACE_REVISION  EFI_SERIAL_IO_PROTOCOL_REVISION
 
 ///
@@ -287,6 +287,7 @@ struct _EFI_SERIAL_IO_PROTOCOL {
   /// Pointer to SERIAL_IO_MODE data.
   ///
   EFI_SERIAL_IO_MODE          *Mode;
+  CONST EFI_GUID               *DeviceTypeGuid; // Revision 1.1
 };
 
 extern EFI_GUID gEfiSerialIoProtocolGuid;
-- 
2.9.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

Re: [PATCH v4 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid

[Liming Gao]

Oleksiy:
  For new added field DeviceTypeGuid, is there more comment for it?

> +  CONST EFI_GUID               *DeviceTypeGuid; // Revision 1.1

Thanks
Liming
> -----Original Message-----
> From: Oleksiy Yakovlev <oleksiyy@ami.com>
> Sent: Saturday, May 9, 2020 5:46 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Felixp@ami.com; oleksiyy@ami.com
> Subject: [PATCH v4 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid
> 
> EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001.
> CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure.
> UEFI 2.8 mantis 1832.
> 
> Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
> ---
>  MdePkg/Include/Protocol/SerialIo.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/Protocol/SerialIo.h b/MdePkg/Include/Protocol/SerialIo.h
> index 51eaa53..b2398c2 100644
> --- a/MdePkg/Include/Protocol/SerialIo.h
> +++ b/MdePkg/Include/Protocol/SerialIo.h
> @@ -262,7 +262,7 @@ typedef struct {
>    UINT32  StopBits;
>  } EFI_SERIAL_IO_MODE;
> 
> -#define EFI_SERIAL_IO_PROTOCOL_REVISION    0x00010000
> +#define EFI_SERIAL_IO_PROTOCOL_REVISION    0x00010001
>  #define SERIAL_IO_INTERFACE_REVISION  EFI_SERIAL_IO_PROTOCOL_REVISION
> 
>  ///
> @@ -287,6 +287,7 @@ struct _EFI_SERIAL_IO_PROTOCOL {
>    /// Pointer to SERIAL_IO_MODE data.
>    ///
>    EFI_SERIAL_IO_MODE          *Mode;
> +  CONST EFI_GUID               *DeviceTypeGuid; // Revision 1.1
>  };
> 
>  extern EFI_GUID gEfiSerialIoProtocolGuid;
> --
> 2.9.0.windows.1
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication
> is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is
> not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please
> promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[PATCH v4 2/7] BaseTools: REST style formset

[Oleksiy Yakovlev]

In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined.

(UEFI 2.8 mantis 1853)

Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
---
 BaseTools/Source/C/Include/Common/UefiInternalFormRepresentation.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/BaseTools/Source/C/Include/Common/UefiInternalFormRepresentation.h b/BaseTools/Source/C/Include/Common/UefiInternalFormRepresentation.h
index b0bd7c5..b9fa8c3 100644
--- a/BaseTools/Source/C/Include/Common/UefiInternalFormRepresentation.h
+++ b/BaseTools/Source/C/Include/Common/UefiInternalFormRepresentation.h
@@ -728,6 +728,7 @@ typedef struct _EFI_IFR_QUESTION_HEADER {
 #define EFI_IFR_FLAG_READ_ONLY          0x01
 #define EFI_IFR_FLAG_CALLBACK           0x04
 #define EFI_IFR_FLAG_RESET_REQUIRED     0x10
+#define EFI_IFR_FLAG_REST_STYLE         0x20
 #define EFI_IFR_FLAG_RECONNECT_REQUIRED 0x40
 #define EFI_IFR_FLAG_OPTIONS_ONLY       0x80
 
-- 
2.9.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[PATCH v4 3/7] MdePkg: REST style formset

[Oleksiy Yakovlev]

New ClassGuid EFI_HII_REST_STYLE_FORMSET_GUID is defined.
In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined.

(UEFI 2.8 mantis 1853)

Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
---
 MdePkg/Include/Guid/HiiPlatformSetupFormset.h        | 4 ++++
 MdePkg/Include/Uefi/UefiInternalFormRepresentation.h | 1 +
 2 files changed, 5 insertions(+)

diff --git a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h b/MdePkg/Include/Guid/HiiPlatformSetupFormset.h
index 540483d..db7b80b 100644
--- a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h
+++ b/MdePkg/Include/Guid/HiiPlatformSetupFormset.h
@@ -22,8 +22,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define EFI_HII_USER_CREDENTIAL_FORMSET_GUID \
   { 0x337f4407, 0x5aee, 0x4b83, { 0xb2, 0xa7, 0x4e, 0xad, 0xca, 0x30, 0x88, 0xcd } }
 
+#define EFI_HII_REST_STYLE_FORMSET_GUID \
+  { 0x790217bd, 0xbecf, 0x485b, { 0x91, 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8b, 0x27 } }
+
 extern EFI_GUID gEfiHiiPlatformSetupFormsetGuid;
 extern EFI_GUID gEfiHiiDriverHealthFormsetGuid;
 extern EFI_GUID gEfiHiiUserCredentialFormsetGuid;
+extern EFI_GUID gEfiHiiRestStyleFormsetGuid;
 
 #endif
diff --git a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h b/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h
index 4a1346a..40fcdb7 100644
--- a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h
+++ b/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h
@@ -825,6 +825,7 @@ typedef struct _EFI_IFR_QUESTION_HEADER {
 #define EFI_IFR_FLAG_READ_ONLY          0x01
 #define EFI_IFR_FLAG_CALLBACK           0x04
 #define EFI_IFR_FLAG_RESET_REQUIRED     0x10
+#define EFI_IFR_FLAG_REST_STYLE         0x20
 #define EFI_IFR_FLAG_RECONNECT_REQUIRED 0x40
 #define EFI_IFR_FLAG_OPTIONS_ONLY       0x80
 
-- 
2.9.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[PATCH v4 4/7] BaseTools: Bootable NVDIMM namespaces

[Oleksiy Yakovlev]

Provided a mechanism for UEFI FW to identify and hand off bootable
NVDIMM namespaces to the OS by standardizing the EFI device path.
EFI device path for physical NVDIMM devices changed from an ACPI
_ADR device to an ACPI NVDIMM device for correctness.
(UEFI 2.8 mantis 1858)

Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
---
 BaseTools/Source/C/Include/Protocol/DevicePath.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/BaseTools/Source/C/Include/Protocol/DevicePath.h b/BaseTools/Source/C/Include/Protocol/DevicePath.h
index e3571ef..27f8135 100644
--- a/BaseTools/Source/C/Include/Protocol/DevicePath.h
+++ b/BaseTools/Source/C/Include/Protocol/DevicePath.h
@@ -719,6 +719,18 @@ typedef struct {
   UINT8                           StopBits;
 } UART_DEVICE_PATH;
 
+///
+/// NVDIMM Namespace Device Path SubType.
+///
+#define NVDIMM_NAMESPACE_DP               0x20
+typedef struct {
+  EFI_DEVICE_PATH_PROTOCOL        Header;
+  ///
+  /// Namespace unique label identifier UUID.
+  ///
+  EFI_GUID Uuid;
+} NVDIMM_NAMESPACE_DEVICE_PATH;
+
 //
 // Use VENDOR_DEVICE_PATH struct
 //
-- 
2.9.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[PATCH v4 5/7] MdePkg: Bootable NVDIMM namespaces

[Oleksiy Yakovlev]

Provided a mechanism for UEFI FW to identify and hand off bootable
NVDIMM namespaces to the OS by standardizing the EFI device path.
EFI device path for physical NVDIMM devices changed from an ACPI
_ADR device to an ACPI NVDIMM device for correctness.
(UEFI 2.8 mantis 1858)

Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
---
 MdePkg/Include/Protocol/DevicePath.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/MdePkg/Include/Protocol/DevicePath.h b/MdePkg/Include/Protocol/DevicePath.h
index aaec0a6..4cf4b65 100644
--- a/MdePkg/Include/Protocol/DevicePath.h
+++ b/MdePkg/Include/Protocol/DevicePath.h
@@ -712,6 +712,18 @@ typedef struct {
   UINT8                           StopBits;
 } UART_DEVICE_PATH;
 
+///
+/// NVDIMM Namespace Device Path SubType.
+///
+#define NVDIMM_NAMESPACE_DP               0x20
+typedef struct {
+  EFI_DEVICE_PATH_PROTOCOL        Header;
+  ///
+  /// Namespace unique label identifier UUID.
+  ///
+  EFI_GUID Uuid;
+} NVDIMM_NAMESPACE_DEVICE_PATH;
+
 //
 // Use VENDOR_DEVICE_PATH struct
 //
-- 
2.9.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[PATCH v4 6/7] MdePkg: Add UEFI Spec Revision 2.8

[Oleksiy Yakovlev]

Added entrie in the EFI_SYSTEM_TABLE related definitions section,
to signify UEFI 2.8 spec revision.
(UEFI 2.8 mantis 1926)

Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
---
 MdePkg/Include/Uefi/UefiSpec.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg/Include/Uefi/UefiSpec.h
index 8ffaf97..b9282cc 100644
--- a/MdePkg/Include/Uefi/UefiSpec.h
+++ b/MdePkg/Include/Uefi/UefiSpec.h
@@ -1788,6 +1788,7 @@ EFI_STATUS
 // EFI Runtime Services Table
 //
 #define EFI_SYSTEM_TABLE_SIGNATURE      SIGNATURE_64 ('I','B','I',' ','S','Y','S','T')
+#define EFI_2_80_SYSTEM_TABLE_REVISION  ((2 << 16) | (80))
 #define EFI_2_70_SYSTEM_TABLE_REVISION  ((2 << 16) | (70))
 #define EFI_2_60_SYSTEM_TABLE_REVISION  ((2 << 16) | (60))
 #define EFI_2_50_SYSTEM_TABLE_REVISION  ((2 << 16) | (50))
-- 
2.9.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support

[Oleksiy Yakovlev]

Added Guids and structures, that defines the work flow to perform
capsule update using JSON objects.
(UEFI 2.8 mantis 1935)

Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
---
 MdePkg/Include/Guid/CapsuleReport.h | 29 +++++++++++
 MdePkg/Include/Guid/JsonCapsule.h   | 97 +++++++++++++++++++++++++++++++++++++
 MdePkg/Include/Uefi/UefiSpec.h      |  1 +
 MdePkg/MdePkg.dec                   | 11 +++++
 4 files changed, 138 insertions(+)
 create mode 100644 MdePkg/Include/Guid/JsonCapsule.h

diff --git a/MdePkg/Include/Guid/CapsuleReport.h b/MdePkg/Include/Guid/CapsuleReport.h
index 93d2bb7..ab0f552 100644
--- a/MdePkg/Include/Guid/CapsuleReport.h
+++ b/MdePkg/Include/Guid/CapsuleReport.h
@@ -93,6 +93,35 @@ typedef struct {
   ///
 } EFI_CAPSULE_RESULT_VARIABLE_FMP;

+typedef struct {
+
+  ///
+  /// Version of this structure, currently 0x00000001
+  ///
+  UINT32    Version;
+
+  ///
+  /// The unique identifier of the capsule whose processing result is recorded in this variable.
+  /// 0x00000000 b \x13 0xEFFFFFFF b \x13 Implementation Reserved
+  /// 0xF0000000 b \x13 0xFFFFFFFF b \x13 Specification Reserved
+  /// #define REDFISH_DEFINED_JSON_SCHEMA 0xF000000
+  /// The JSON payload shall conform to a Redfish-defined JSON schema, see DMTF-Redfish
+  /// Specification.
+  ///
+  UINT32 CapsuleId;
+
+  ///
+  /// The length of Resp in bytes.
+  ///
+  UINT32 RespLength;
+
+  ///
+  /// Variable length buffer containing the replied JSON payload to the caller who delivered JSON
+  /// capsule to system. The definition of the JSON schema used in the replied payload is beyond
+  /// the scope of this specification.
+  ///
+  /// UINT8 Resp[];
+ } EFI_CAPSULE_RESULT_VARIABLE_JSON;

 extern EFI_GUID gEfiCapsuleReportGuid;

diff --git a/MdePkg/Include/Guid/JsonCapsule.h b/MdePkg/Include/Guid/JsonCapsule.h
new file mode 100644
index 0000000..721636f
--- /dev/null
+++ b/MdePkg/Include/Guid/JsonCapsule.h
@@ -0,0 +1,97 @@
+/** @file
+Guid & data structure for tables defined for reporting firmware configuration data to EFI
+Configuration Tables and also for processing JSON payload capsule.
+
+
+Copyright (c) 2020, American Megatrends International LLC. All rights reserved.<BR>
+SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#ifndef _JSON_CAPSULE_GUID_H__
+#define _JSON_CAPSULE_GUID_H__
+
+//
+// The address reported in the table entry identified by EFI_JSON_CAPSULE_DATA_TABLE_GUID will be
+// referenced as physical and will not be fixed up when transition from preboot to runtime phase. The
+// addresses reported in these table entries identified by EFI_JSON_CONFIG_DATA_TABLE_GUID and
+// EFI_JSON_CAPSULE_RESULT_TABLE_GUID will be referenced as virtual and will be fixed up when
+// transition from preboot to runtime phase.
+//
+#define EFI_JSON_CONFIG_DATA_TABLE_GUID \
+    {0x87367f87, 0x1119, 0x41ce, \
+    {0xaa, 0xec, 0x8b, 0xe0, 0x11, 0x1f, 0x55, 0x8a }}
+#define EFI_JSON_CAPSULE_DATA_TABLE_GUID \
+    {0x35e7a725, 0x8dd2, 0x4cac, \
+    {0x80, 0x11, 0x33, 0xcd, 0xa8, 0x10, 0x90, 0x56 }}
+#define EFI_JSON_CAPSULE_RESULT_TABLE_GUID \
+    {0xdbc461c3, 0xb3de, 0x422a,\
+    {0xb9, 0xb4, 0x98, 0x86, 0xfd, 0x49, 0xa1, 0xe5 }}
+#define EFI_JSON_CAPSULE_ID_GUID \
+    {0x67d6f4cd, 0xd6b8,  0x4573, \
+    {0xbf, 0x4a, 0xde, 0x5e, 0x25, 0x2d, 0x61, 0xae }}
+
+
+#pragma pack(1)
+
+typedef struct {
+  ///
+  /// Version of the structure, initially 0x00000001.
+  ///
+  UINT32 Version;
+
+  ///
+  /// The unique identifier of this capsule.
+  ///
+  UINT32 CapsuleId;
+
+  ///
+  /// The length of the JSON payload immediately following this header, in bytes.
+  ///
+  UINT32 PayloadLength;
+
+  ///
+  /// Variable length buffer containing the JSON payload that should be parsed and applied to the system. The
+  /// definition of the JSON schema used in the payload is beyond the scope of this specification.
+  /// UINT8 Payload[];
+} EFI_JSON_CAPSULE_HEADER;
+
+typedef struct {
+  ///
+  /// The length of the following ConfigData, in bytes.
+  ///
+  UINT32 ConfigDataLength;
+
+  ///
+  /// Variable length buffer containing the JSON payload that describes one group of configuration data within
+  /// current system. The definition of the JSON schema used in this payload is beyond the scope of this specification.
+  ///
+  ///UINT8 ConfigData[ConfigDataLength];
+} EFI_JSON_CONFIG_DATA_ITEM;
+
+typedef struct {
+  ///
+  /// Version of the structure, initially 0x00000001.
+  ///
+  UINT32 Version;
+
+  ///
+  ////The total length of EFI_JSON_CAPSULE_CONFIG_DATA, in bytes.
+  ///
+  UINT32 TotalLength;
+
+  ///
+  /// Array of configuration data groups.
+  ///
+  /// EFI_JSON_CONFIG_DATA_ITEM ConfigDataList[];
+} EFI_JSON_CAPSULE_CONFIG_DATA;
+
+#pragma pack()
+
+extern EFI_GUID gEfiJsonConfigDataTableGuid;
+extern EFI_GUID gEfiJsonCapsuleDataTableGuid;
+extern EFI_GUID gEfiJsonCapsuleResultTableGuid;
+extern EFI_GUID gEfiJsonCapsuleIdGuid;
+
+
+#endif
diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg/Include/Uefi/UefiSpec.h
index b9282cc..3547345 100644
--- a/MdePkg/Include/Uefi/UefiSpec.h
+++ b/MdePkg/Include/Uefi/UefiSpec.h
@@ -1783,6 +1783,7 @@ EFI_STATUS
 #define EFI_OS_INDICATIONS_FMP_CAPSULE_SUPPORTED            0x0000000000000008
 #define EFI_OS_INDICATIONS_CAPSULE_RESULT_VAR_SUPPORTED     0x0000000000000010
 #define EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY          0x0000000000000040
+#define EFI_OS_INDICATIONS_JSON_CONFIG_DATA_REFRESH         0x0000000000000080

 //
 // EFI Runtime Services Table
diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index 0b9c4bc..5dc02f2 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -645,6 +645,17 @@
   ## Include/Guid/Btt.h
   gEfiBttAbstractionGuid         = { 0x18633bfc, 0x1735, 0x4217, { 0x8a, 0xc9, 0x17, 0x23, 0x92, 0x82, 0xd3, 0xf8 }}

+  # GUIDs defined in UEFI2.8
+  #
+  ## Include/Guid/JsonCapsule.h
+  gEfiJsonConfigDataTableGuid      = { 0x87367f87, 0x1119, 0x41ce, { 0xaa, 0xec, 0x8b, 0xe0, 0x11, 0x1f, 0x55, 0x8a }}
+  gEfiJsonCapsuleDataTableGuid     = { 0x35e7a725, 0x8dd2, 0x4cac, { 0x80, 0x11, 0x33, 0xcd, 0xa8, 0x10, 0x90, 0x56 }}
+  gEfiJsonCapsuleResultTableGuid   = { 0xdbc461c3, 0xb3de, 0x422a, { 0xb9, 0xb4, 0x98, 0x86, 0xfd, 0x49, 0xa1, 0xe5 }}
+  gEfiJsonCapsuleIdGuid            = { 0x67d6f4cd, 0xd6b8, 0x4573, { 0xbf, 0x4a, 0xde, 0x5e, 0x25, 0x2d, 0x61, 0xae }}
+
+  ## Include\Guid\HiiPlatformSetupFormset.h
+  gEfiHiiResetStyleFormsetGuid     = { 0x790217bd, 0xbecf, 0x485b, { 0x91, 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8b, 0x27 }}
+
   #
   # GUID defined in PI1.0
   #
--
2.9.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

Re: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support

[Zhiguang Liu]

Hi Oleksiy.

I think we all agree to remove the comment marker before the final parameter in struct.
Please see this mail https://edk2.groups.io/g/devel/message/57895
Let me know if you have any concern.

And one little suggestion. 
If you send a newer version but don't change anything, you can take the Reviewed-by in your commit message if you get one.
So, the reviewer doesn't have to review the same patch again 😊

Thanks
Zhiguang

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> Yakovlev
> Sent: Saturday, May 9, 2020 5:46 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Felixp@ami.com; oleksiyy@ami.com
> Subject: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support
> 
> Added Guids and structures, that defines the work flow to perform capsule
> update using JSON objects.
> (UEFI 2.8 mantis 1935)
> 
> Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
> ---
>  MdePkg/Include/Guid/CapsuleReport.h | 29 +++++++++++
>  MdePkg/Include/Guid/JsonCapsule.h   | 97
> +++++++++++++++++++++++++++++++++++++
>  MdePkg/Include/Uefi/UefiSpec.h      |  1 +
>  MdePkg/MdePkg.dec                   | 11 +++++
>  4 files changed, 138 insertions(+)
>  create mode 100644 MdePkg/Include/Guid/JsonCapsule.h
> 
> diff --git a/MdePkg/Include/Guid/CapsuleReport.h
> b/MdePkg/Include/Guid/CapsuleReport.h
> index 93d2bb7..ab0f552 100644
> --- a/MdePkg/Include/Guid/CapsuleReport.h
> +++ b/MdePkg/Include/Guid/CapsuleReport.h
> @@ -93,6 +93,35 @@ typedef struct {
>    ///
>  } EFI_CAPSULE_RESULT_VARIABLE_FMP;
> 
> +typedef struct {
> +
> +  ///
> +  /// Version of this structure, currently 0x00000001  ///
> +  UINT32    Version;
> +
> +  ///
> +  /// The unique identifier of the capsule whose processing result is
> recorded in this variable.
> +  /// 0x00000000 b  0xEFFFFFFF b  Implementation Reserved  ///
> + 0xF0000000 b  0xFFFFFFFF b  Specification Reserved  /// #define
> + REDFISH_DEFINED_JSON_SCHEMA 0xF000000  /// The JSON payload shall
> + conform to a Redfish-defined JSON schema, see DMTF-Redfish  ///
> + Specification.
> +  ///
> +  UINT32 CapsuleId;
> +
> +  ///
> +  /// The length of Resp in bytes.
> +  ///
> +  UINT32 RespLength;
> +
> +  ///
> +  /// Variable length buffer containing the replied JSON payload to the
> + caller who delivered JSON  /// capsule to system. The definition of
> + the JSON schema used in the replied payload is beyond  /// the scope of
> this specification.
> +  ///
> +  /// UINT8 Resp[];
> + } EFI_CAPSULE_RESULT_VARIABLE_JSON;
> 
>  extern EFI_GUID gEfiCapsuleReportGuid;
> 
> diff --git a/MdePkg/Include/Guid/JsonCapsule.h
> b/MdePkg/Include/Guid/JsonCapsule.h
> new file mode 100644
> index 0000000..721636f
> --- /dev/null
> +++ b/MdePkg/Include/Guid/JsonCapsule.h
> @@ -0,0 +1,97 @@
> +/** @file
> +Guid & data structure for tables defined for reporting firmware
> +configuration data to EFI Configuration Tables and also for processing JSON
> payload capsule.
> +
> +
> +Copyright (c) 2020, American Megatrends International LLC. All rights
> +reserved.<BR>
> +SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#ifndef _JSON_CAPSULE_GUID_H__
> +#define _JSON_CAPSULE_GUID_H__
> +
> +//
> +// The address reported in the table entry identified by
> +EFI_JSON_CAPSULE_DATA_TABLE_GUID will be // referenced as physical
> and
> +will not be fixed up when transition from preboot to runtime phase. The
> +// addresses reported in these table entries identified by
> +EFI_JSON_CONFIG_DATA_TABLE_GUID and //
> EFI_JSON_CAPSULE_RESULT_TABLE_GUID will be referenced as virtual and
> will be fixed up when // transition from preboot to runtime phase.
> +//
> +#define EFI_JSON_CONFIG_DATA_TABLE_GUID \
> +    {0x87367f87, 0x1119, 0x41ce, \
> +    {0xaa, 0xec, 0x8b, 0xe0, 0x11, 0x1f, 0x55, 0x8a }} #define
> +EFI_JSON_CAPSULE_DATA_TABLE_GUID \
> +    {0x35e7a725, 0x8dd2, 0x4cac, \
> +    {0x80, 0x11, 0x33, 0xcd, 0xa8, 0x10, 0x90, 0x56 }} #define
> +EFI_JSON_CAPSULE_RESULT_TABLE_GUID \
> +    {0xdbc461c3, 0xb3de, 0x422a,\
> +    {0xb9, 0xb4, 0x98, 0x86, 0xfd, 0x49, 0xa1, 0xe5 }} #define
> +EFI_JSON_CAPSULE_ID_GUID \
> +    {0x67d6f4cd, 0xd6b8,  0x4573, \
> +    {0xbf, 0x4a, 0xde, 0x5e, 0x25, 0x2d, 0x61, 0xae }}
> +
> +
> +#pragma pack(1)
> +
> +typedef struct {
> +  ///
> +  /// Version of the structure, initially 0x00000001.
> +  ///
> +  UINT32 Version;
> +
> +  ///
> +  /// The unique identifier of this capsule.
> +  ///
> +  UINT32 CapsuleId;
> +
> +  ///
> +  /// The length of the JSON payload immediately following this header, in
> bytes.
> +  ///
> +  UINT32 PayloadLength;
> +
> +  ///
> +  /// Variable length buffer containing the JSON payload that should be
> +parsed and applied to the system. The
> +  /// definition of the JSON schema used in the payload is beyond the scope
> of this specification.
> +  /// UINT8 Payload[];
> +} EFI_JSON_CAPSULE_HEADER;
> +
> +typedef struct {
> +  ///
> +  /// The length of the following ConfigData, in bytes.
> +  ///
> +  UINT32 ConfigDataLength;
> +
> +  ///
> +  /// Variable length buffer containing the JSON payload that describes
> +one group of configuration data within
> +  /// current system. The definition of the JSON schema used in this payload
> is beyond the scope of this specification.
> +  ///
> +  ///UINT8 ConfigData[ConfigDataLength]; } EFI_JSON_CONFIG_DATA_ITEM;
> +
> +typedef struct {
> +  ///
> +  /// Version of the structure, initially 0x00000001.
> +  ///
> +  UINT32 Version;
> +
> +  ///
> +  ////The total length of EFI_JSON_CAPSULE_CONFIG_DATA, in bytes.
> +  ///
> +  UINT32 TotalLength;
> +
> +  ///
> +  /// Array of configuration data groups.
> +  ///
> +  /// EFI_JSON_CONFIG_DATA_ITEM ConfigDataList[]; }
> +EFI_JSON_CAPSULE_CONFIG_DATA;
> +
> +#pragma pack()
> +
> +extern EFI_GUID gEfiJsonConfigDataTableGuid; extern EFI_GUID
> +gEfiJsonCapsuleDataTableGuid; extern EFI_GUID
> +gEfiJsonCapsuleResultTableGuid; extern EFI_GUID gEfiJsonCapsuleIdGuid;
> +
> +
> +#endif
> diff --git a/MdePkg/Include/Uefi/UefiSpec.h
> b/MdePkg/Include/Uefi/UefiSpec.h index b9282cc..3547345 100644
> --- a/MdePkg/Include/Uefi/UefiSpec.h
> +++ b/MdePkg/Include/Uefi/UefiSpec.h
> @@ -1783,6 +1783,7 @@ EFI_STATUS
>  #define EFI_OS_INDICATIONS_FMP_CAPSULE_SUPPORTED
> 0x0000000000000008
>  #define EFI_OS_INDICATIONS_CAPSULE_RESULT_VAR_SUPPORTED
> 0x0000000000000010
>  #define EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY
> 0x0000000000000040
> +#define EFI_OS_INDICATIONS_JSON_CONFIG_DATA_REFRESH
> 0x0000000000000080
> 
>  //
>  // EFI Runtime Services Table
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> 0b9c4bc..5dc02f2 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -645,6 +645,17 @@
>    ## Include/Guid/Btt.h
>    gEfiBttAbstractionGuid         = { 0x18633bfc, 0x1735, 0x4217, { 0x8a, 0xc9,
> 0x17, 0x23, 0x92, 0x82, 0xd3, 0xf8 }}
> 
> +  # GUIDs defined in UEFI2.8
> +  #
> +  ## Include/Guid/JsonCapsule.h
> +  gEfiJsonConfigDataTableGuid      = { 0x87367f87, 0x1119, 0x41ce, { 0xaa,
> 0xec, 0x8b, 0xe0, 0x11, 0x1f, 0x55, 0x8a }}
> +  gEfiJsonCapsuleDataTableGuid     = { 0x35e7a725, 0x8dd2, 0x4cac, { 0x80,
> 0x11, 0x33, 0xcd, 0xa8, 0x10, 0x90, 0x56 }}
> +  gEfiJsonCapsuleResultTableGuid   = { 0xdbc461c3, 0xb3de, 0x422a, { 0xb9,
> 0xb4, 0x98, 0x86, 0xfd, 0x49, 0xa1, 0xe5 }}
> +  gEfiJsonCapsuleIdGuid            = { 0x67d6f4cd, 0xd6b8, 0x4573, { 0xbf, 0x4a,
> 0xde, 0x5e, 0x25, 0x2d, 0x61, 0xae }}
> +
> +  ## Include\Guid\HiiPlatformSetupFormset.h
> +  gEfiHiiResetStyleFormsetGuid     = { 0x790217bd, 0xbecf, 0x485b, { 0x91,
> 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8b, 0x27 }}
> +
>    #
>    # GUID defined in PI1.0
>    #
> --
> 2.9.0.windows.1
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).  This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
> 
> 

Re: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support

[Liming Gao]

Oleksiy:
  I don't find this GUID C macro definition. Is it introduced by UEFI JSON?

> +  ## Include\Guid\HiiPlatformSetupFormset.h
> +  gEfiHiiResetStyleFormsetGuid     = { 0x790217bd, 0xbecf, 0x485b, { 0x91,
> 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8b, 0x27 }}

Thanks
Liming
> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Saturday, May 9, 2020 10:34 AM
> To: devel@edk2.groups.io; oleksiyy@ami.com
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Felixp@ami.com
> Subject: RE: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support
> 
> Hi Oleksiy.
> 
> I think we all agree to remove the comment marker before the final parameter in struct.
> Please see this mail https://edk2.groups.io/g/devel/message/57895
> Let me know if you have any concern.
> 
> And one little suggestion.
> If you send a newer version but don't change anything, you can take the Reviewed-by in your commit message if you get one.
> So, the reviewer doesn't have to review the same patch again 😊
> 
> Thanks
> Zhiguang
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> > Yakovlev
> > Sent: Saturday, May 9, 2020 5:46 AM
> > To: devel@edk2.groups.io
> > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> > <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > Felixp@ami.com; oleksiyy@ami.com
> > Subject: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support
> >
> > Added Guids and structures, that defines the work flow to perform capsule
> > update using JSON objects.
> > (UEFI 2.8 mantis 1935)
> >
> > Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
> > ---
> >  MdePkg/Include/Guid/CapsuleReport.h | 29 +++++++++++
> >  MdePkg/Include/Guid/JsonCapsule.h   | 97
> > +++++++++++++++++++++++++++++++++++++
> >  MdePkg/Include/Uefi/UefiSpec.h      |  1 +
> >  MdePkg/MdePkg.dec                   | 11 +++++
> >  4 files changed, 138 insertions(+)
> >  create mode 100644 MdePkg/Include/Guid/JsonCapsule.h
> >
> > diff --git a/MdePkg/Include/Guid/CapsuleReport.h
> > b/MdePkg/Include/Guid/CapsuleReport.h
> > index 93d2bb7..ab0f552 100644
> > --- a/MdePkg/Include/Guid/CapsuleReport.h
> > +++ b/MdePkg/Include/Guid/CapsuleReport.h
> > @@ -93,6 +93,35 @@ typedef struct {
> >    ///
> >  } EFI_CAPSULE_RESULT_VARIABLE_FMP;
> >
> > +typedef struct {
> > +
> > +  ///
> > +  /// Version of this structure, currently 0x00000001  ///
> > +  UINT32    Version;
> > +
> > +  ///
> > +  /// The unique identifier of the capsule whose processing result is
> > recorded in this variable.
> > +  /// 0x00000000 b  0xEFFFFFFF b  Implementation Reserved  ///
> > + 0xF0000000 b  0xFFFFFFFF b  Specification Reserved  /// #define
> > + REDFISH_DEFINED_JSON_SCHEMA 0xF000000  /// The JSON payload shall
> > + conform to a Redfish-defined JSON schema, see DMTF-Redfish  ///
> > + Specification.
> > +  ///
> > +  UINT32 CapsuleId;
> > +
> > +  ///
> > +  /// The length of Resp in bytes.
> > +  ///
> > +  UINT32 RespLength;
> > +
> > +  ///
> > +  /// Variable length buffer containing the replied JSON payload to the
> > + caller who delivered JSON  /// capsule to system. The definition of
> > + the JSON schema used in the replied payload is beyond  /// the scope of
> > this specification.
> > +  ///
> > +  /// UINT8 Resp[];
> > + } EFI_CAPSULE_RESULT_VARIABLE_JSON;
> >
> >  extern EFI_GUID gEfiCapsuleReportGuid;
> >
> > diff --git a/MdePkg/Include/Guid/JsonCapsule.h
> > b/MdePkg/Include/Guid/JsonCapsule.h
> > new file mode 100644
> > index 0000000..721636f
> > --- /dev/null
> > +++ b/MdePkg/Include/Guid/JsonCapsule.h
> > @@ -0,0 +1,97 @@
> > +/** @file
> > +Guid & data structure for tables defined for reporting firmware
> > +configuration data to EFI Configuration Tables and also for processing JSON
> > payload capsule.
> > +
> > +
> > +Copyright (c) 2020, American Megatrends International LLC. All rights
> > +reserved.<BR>
> > +SPDX-License-Identifier: BSD-2-Clause-Patent
> > +
> > +**/
> > +
> > +#ifndef _JSON_CAPSULE_GUID_H__
> > +#define _JSON_CAPSULE_GUID_H__
> > +
> > +//
> > +// The address reported in the table entry identified by
> > +EFI_JSON_CAPSULE_DATA_TABLE_GUID will be // referenced as physical
> > and
> > +will not be fixed up when transition from preboot to runtime phase. The
> > +// addresses reported in these table entries identified by
> > +EFI_JSON_CONFIG_DATA_TABLE_GUID and //
> > EFI_JSON_CAPSULE_RESULT_TABLE_GUID will be referenced as virtual and
> > will be fixed up when // transition from preboot to runtime phase.
> > +//
> > +#define EFI_JSON_CONFIG_DATA_TABLE_GUID \
> > +    {0x87367f87, 0x1119, 0x41ce, \
> > +    {0xaa, 0xec, 0x8b, 0xe0, 0x11, 0x1f, 0x55, 0x8a }} #define
> > +EFI_JSON_CAPSULE_DATA_TABLE_GUID \
> > +    {0x35e7a725, 0x8dd2, 0x4cac, \
> > +    {0x80, 0x11, 0x33, 0xcd, 0xa8, 0x10, 0x90, 0x56 }} #define
> > +EFI_JSON_CAPSULE_RESULT_TABLE_GUID \
> > +    {0xdbc461c3, 0xb3de, 0x422a,\
> > +    {0xb9, 0xb4, 0x98, 0x86, 0xfd, 0x49, 0xa1, 0xe5 }} #define
> > +EFI_JSON_CAPSULE_ID_GUID \
> > +    {0x67d6f4cd, 0xd6b8,  0x4573, \
> > +    {0xbf, 0x4a, 0xde, 0x5e, 0x25, 0x2d, 0x61, 0xae }}
> > +
> > +
> > +#pragma pack(1)
> > +
> > +typedef struct {
> > +  ///
> > +  /// Version of the structure, initially 0x00000001.
> > +  ///
> > +  UINT32 Version;
> > +
> > +  ///
> > +  /// The unique identifier of this capsule.
> > +  ///
> > +  UINT32 CapsuleId;
> > +
> > +  ///
> > +  /// The length of the JSON payload immediately following this header, in
> > bytes.
> > +  ///
> > +  UINT32 PayloadLength;
> > +
> > +  ///
> > +  /// Variable length buffer containing the JSON payload that should be
> > +parsed and applied to the system. The
> > +  /// definition of the JSON schema used in the payload is beyond the scope
> > of this specification.
> > +  /// UINT8 Payload[];
> > +} EFI_JSON_CAPSULE_HEADER;
> > +
> > +typedef struct {
> > +  ///
> > +  /// The length of the following ConfigData, in bytes.
> > +  ///
> > +  UINT32 ConfigDataLength;
> > +
> > +  ///
> > +  /// Variable length buffer containing the JSON payload that describes
> > +one group of configuration data within
> > +  /// current system. The definition of the JSON schema used in this payload
> > is beyond the scope of this specification.
> > +  ///
> > +  ///UINT8 ConfigData[ConfigDataLength]; } EFI_JSON_CONFIG_DATA_ITEM;
> > +
> > +typedef struct {
> > +  ///
> > +  /// Version of the structure, initially 0x00000001.
> > +  ///
> > +  UINT32 Version;
> > +
> > +  ///
> > +  ////The total length of EFI_JSON_CAPSULE_CONFIG_DATA, in bytes.
> > +  ///
> > +  UINT32 TotalLength;
> > +
> > +  ///
> > +  /// Array of configuration data groups.
> > +  ///
> > +  /// EFI_JSON_CONFIG_DATA_ITEM ConfigDataList[]; }
> > +EFI_JSON_CAPSULE_CONFIG_DATA;
> > +
> > +#pragma pack()
> > +
> > +extern EFI_GUID gEfiJsonConfigDataTableGuid; extern EFI_GUID
> > +gEfiJsonCapsuleDataTableGuid; extern EFI_GUID
> > +gEfiJsonCapsuleResultTableGuid; extern EFI_GUID gEfiJsonCapsuleIdGuid;
> > +
> > +
> > +#endif
> > diff --git a/MdePkg/Include/Uefi/UefiSpec.h
> > b/MdePkg/Include/Uefi/UefiSpec.h index b9282cc..3547345 100644
> > --- a/MdePkg/Include/Uefi/UefiSpec.h
> > +++ b/MdePkg/Include/Uefi/UefiSpec.h
> > @@ -1783,6 +1783,7 @@ EFI_STATUS
> >  #define EFI_OS_INDICATIONS_FMP_CAPSULE_SUPPORTED
> > 0x0000000000000008
> >  #define EFI_OS_INDICATIONS_CAPSULE_RESULT_VAR_SUPPORTED
> > 0x0000000000000010
> >  #define EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY
> > 0x0000000000000040
> > +#define EFI_OS_INDICATIONS_JSON_CONFIG_DATA_REFRESH
> > 0x0000000000000080
> >
> >  //
> >  // EFI Runtime Services Table
> > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> > 0b9c4bc..5dc02f2 100644
> > --- a/MdePkg/MdePkg.dec
> > +++ b/MdePkg/MdePkg.dec
> > @@ -645,6 +645,17 @@
> >    ## Include/Guid/Btt.h
> >    gEfiBttAbstractionGuid         = { 0x18633bfc, 0x1735, 0x4217, { 0x8a, 0xc9,
> > 0x17, 0x23, 0x92, 0x82, 0xd3, 0xf8 }}
> >
> > +  # GUIDs defined in UEFI2.8
> > +  #
> > +  ## Include/Guid/JsonCapsule.h
> > +  gEfiJsonConfigDataTableGuid      = { 0x87367f87, 0x1119, 0x41ce, { 0xaa,
> > 0xec, 0x8b, 0xe0, 0x11, 0x1f, 0x55, 0x8a }}
> > +  gEfiJsonCapsuleDataTableGuid     = { 0x35e7a725, 0x8dd2, 0x4cac, { 0x80,
> > 0x11, 0x33, 0xcd, 0xa8, 0x10, 0x90, 0x56 }}
> > +  gEfiJsonCapsuleResultTableGuid   = { 0xdbc461c3, 0xb3de, 0x422a, { 0xb9,
> > 0xb4, 0x98, 0x86, 0xfd, 0x49, 0xa1, 0xe5 }}
> > +  gEfiJsonCapsuleIdGuid            = { 0x67d6f4cd, 0xd6b8, 0x4573, { 0xbf, 0x4a,
> > 0xde, 0x5e, 0x25, 0x2d, 0x61, 0xae }}
> > +
> > +  ## Include\Guid\HiiPlatformSetupFormset.h
> > +  gEfiHiiResetStyleFormsetGuid     = { 0x790217bd, 0xbecf, 0x485b, { 0x91,
> > 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8b, 0x27 }}
> > +
> >    #
> >    # GUID defined in PI1.0
> >    #
> > --
> > 2.9.0.windows.1
> >
> >
> > Please consider the environment before printing this email.
> >
> > The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI).  This communication is intended
> > to be read only by the individual or entity to whom it is addressed or by their
> > designee. If the reader of this message is not the intended recipient, you are
> > on notice that any distribution of this message, in any form, is strictly
> > prohibited.  Please promptly notify the sender by reply e-mail or by
> > telephone at 770-246-8600, and then delete or destroy all copies of the
> > transmission.
> >
> > 

Re: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support

[Liming Gao]

Oleksiy:
  I review the full patch set. This change should be in patch 3/7. Please update it. With this change, you can add my RB Reviewed-by: Liming Gao <liming.gao@intel.com>.

Thanks
Liming
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao
> Sent: Monday, May 11, 2020 10:14 PM
> To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io; oleksiyy@ami.com
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com
> Subject: Re: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support
> 
> Oleksiy:
>   I don't find this GUID C macro definition. Is it introduced by UEFI JSON?
> 
> > +  ## Include\Guid\HiiPlatformSetupFormset.h
> > +  gEfiHiiResetStyleFormsetGuid     = { 0x790217bd, 0xbecf, 0x485b, { 0x91,
> > 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8b, 0x27 }}
> 
> Thanks
> Liming
> > -----Original Message-----
> > From: Liu, Zhiguang <zhiguang.liu@intel.com>
> > Sent: Saturday, May 9, 2020 10:34 AM
> > To: devel@edk2.groups.io; oleksiyy@ami.com
> > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > Felixp@ami.com
> > Subject: RE: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support
> >
> > Hi Oleksiy.
> >
> > I think we all agree to remove the comment marker before the final parameter in struct.
> > Please see this mail https://edk2.groups.io/g/devel/message/57895
> > Let me know if you have any concern.
> >
> > And one little suggestion.
> > If you send a newer version but don't change anything, you can take the Reviewed-by in your commit message if you get one.
> > So, the reviewer doesn't have to review the same patch again 😊
> >
> > Thanks
> > Zhiguang
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> > > Yakovlev
> > > Sent: Saturday, May 9, 2020 5:46 AM
> > > To: devel@edk2.groups.io
> > > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> > > <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > > Felixp@ami.com; oleksiyy@ami.com
> > > Subject: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support
> > >
> > > Added Guids and structures, that defines the work flow to perform capsule
> > > update using JSON objects.
> > > (UEFI 2.8 mantis 1935)
> > >
> > > Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
> > > ---
> > >  MdePkg/Include/Guid/CapsuleReport.h | 29 +++++++++++
> > >  MdePkg/Include/Guid/JsonCapsule.h   | 97
> > > +++++++++++++++++++++++++++++++++++++
> > >  MdePkg/Include/Uefi/UefiSpec.h      |  1 +
> > >  MdePkg/MdePkg.dec                   | 11 +++++
> > >  4 files changed, 138 insertions(+)
> > >  create mode 100644 MdePkg/Include/Guid/JsonCapsule.h
> > >
> > > diff --git a/MdePkg/Include/Guid/CapsuleReport.h
> > > b/MdePkg/Include/Guid/CapsuleReport.h
> > > index 93d2bb7..ab0f552 100644
> > > --- a/MdePkg/Include/Guid/CapsuleReport.h
> > > +++ b/MdePkg/Include/Guid/CapsuleReport.h
> > > @@ -93,6 +93,35 @@ typedef struct {
> > >    ///
> > >  } EFI_CAPSULE_RESULT_VARIABLE_FMP;
> > >
> > > +typedef struct {
> > > +
> > > +  ///
> > > +  /// Version of this structure, currently 0x00000001  ///
> > > +  UINT32    Version;
> > > +
> > > +  ///
> > > +  /// The unique identifier of the capsule whose processing result is
> > > recorded in this variable.
> > > +  /// 0x00000000 b  0xEFFFFFFF b  Implementation Reserved  ///
> > > + 0xF0000000 b  0xFFFFFFFF b  Specification Reserved  /// #define
> > > + REDFISH_DEFINED_JSON_SCHEMA 0xF000000  /// The JSON payload shall
> > > + conform to a Redfish-defined JSON schema, see DMTF-Redfish  ///
> > > + Specification.
> > > +  ///
> > > +  UINT32 CapsuleId;
> > > +
> > > +  ///
> > > +  /// The length of Resp in bytes.
> > > +  ///
> > > +  UINT32 RespLength;
> > > +
> > > +  ///
> > > +  /// Variable length buffer containing the replied JSON payload to the
> > > + caller who delivered JSON  /// capsule to system. The definition of
> > > + the JSON schema used in the replied payload is beyond  /// the scope of
> > > this specification.
> > > +  ///
> > > +  /// UINT8 Resp[];
> > > + } EFI_CAPSULE_RESULT_VARIABLE_JSON;
> > >
> > >  extern EFI_GUID gEfiCapsuleReportGuid;
> > >
> > > diff --git a/MdePkg/Include/Guid/JsonCapsule.h
> > > b/MdePkg/Include/Guid/JsonCapsule.h
> > > new file mode 100644
> > > index 0000000..721636f
> > > --- /dev/null
> > > +++ b/MdePkg/Include/Guid/JsonCapsule.h
> > > @@ -0,0 +1,97 @@
> > > +/** @file
> > > +Guid & data structure for tables defined for reporting firmware
> > > +configuration data to EFI Configuration Tables and also for processing JSON
> > > payload capsule.
> > > +
> > > +
> > > +Copyright (c) 2020, American Megatrends International LLC. All rights
> > > +reserved.<BR>
> > > +SPDX-License-Identifier: BSD-2-Clause-Patent
> > > +
> > > +**/
> > > +
> > > +#ifndef _JSON_CAPSULE_GUID_H__
> > > +#define _JSON_CAPSULE_GUID_H__
> > > +
> > > +//
> > > +// The address reported in the table entry identified by
> > > +EFI_JSON_CAPSULE_DATA_TABLE_GUID will be // referenced as physical
> > > and
> > > +will not be fixed up when transition from preboot to runtime phase. The
> > > +// addresses reported in these table entries identified by
> > > +EFI_JSON_CONFIG_DATA_TABLE_GUID and //
> > > EFI_JSON_CAPSULE_RESULT_TABLE_GUID will be referenced as virtual and
> > > will be fixed up when // transition from preboot to runtime phase.
> > > +//
> > > +#define EFI_JSON_CONFIG_DATA_TABLE_GUID \
> > > +    {0x87367f87, 0x1119, 0x41ce, \
> > > +    {0xaa, 0xec, 0x8b, 0xe0, 0x11, 0x1f, 0x55, 0x8a }} #define
> > > +EFI_JSON_CAPSULE_DATA_TABLE_GUID \
> > > +    {0x35e7a725, 0x8dd2, 0x4cac, \
> > > +    {0x80, 0x11, 0x33, 0xcd, 0xa8, 0x10, 0x90, 0x56 }} #define
> > > +EFI_JSON_CAPSULE_RESULT_TABLE_GUID \
> > > +    {0xdbc461c3, 0xb3de, 0x422a,\
> > > +    {0xb9, 0xb4, 0x98, 0x86, 0xfd, 0x49, 0xa1, 0xe5 }} #define
> > > +EFI_JSON_CAPSULE_ID_GUID \
> > > +    {0x67d6f4cd, 0xd6b8,  0x4573, \
> > > +    {0xbf, 0x4a, 0xde, 0x5e, 0x25, 0x2d, 0x61, 0xae }}
> > > +
> > > +
> > > +#pragma pack(1)
> > > +
> > > +typedef struct {
> > > +  ///
> > > +  /// Version of the structure, initially 0x00000001.
> > > +  ///
> > > +  UINT32 Version;
> > > +
> > > +  ///
> > > +  /// The unique identifier of this capsule.
> > > +  ///
> > > +  UINT32 CapsuleId;
> > > +
> > > +  ///
> > > +  /// The length of the JSON payload immediately following this header, in
> > > bytes.
> > > +  ///
> > > +  UINT32 PayloadLength;
> > > +
> > > +  ///
> > > +  /// Variable length buffer containing the JSON payload that should be
> > > +parsed and applied to the system. The
> > > +  /// definition of the JSON schema used in the payload is beyond the scope
> > > of this specification.
> > > +  /// UINT8 Payload[];
> > > +} EFI_JSON_CAPSULE_HEADER;
> > > +
> > > +typedef struct {
> > > +  ///
> > > +  /// The length of the following ConfigData, in bytes.
> > > +  ///
> > > +  UINT32 ConfigDataLength;
> > > +
> > > +  ///
> > > +  /// Variable length buffer containing the JSON payload that describes
> > > +one group of configuration data within
> > > +  /// current system. The definition of the JSON schema used in this payload
> > > is beyond the scope of this specification.
> > > +  ///
> > > +  ///UINT8 ConfigData[ConfigDataLength]; } EFI_JSON_CONFIG_DATA_ITEM;
> > > +
> > > +typedef struct {
> > > +  ///
> > > +  /// Version of the structure, initially 0x00000001.
> > > +  ///
> > > +  UINT32 Version;
> > > +
> > > +  ///
> > > +  ////The total length of EFI_JSON_CAPSULE_CONFIG_DATA, in bytes.
> > > +  ///
> > > +  UINT32 TotalLength;
> > > +
> > > +  ///
> > > +  /// Array of configuration data groups.
> > > +  ///
> > > +  /// EFI_JSON_CONFIG_DATA_ITEM ConfigDataList[]; }
> > > +EFI_JSON_CAPSULE_CONFIG_DATA;
> > > +
> > > +#pragma pack()
> > > +
> > > +extern EFI_GUID gEfiJsonConfigDataTableGuid; extern EFI_GUID
> > > +gEfiJsonCapsuleDataTableGuid; extern EFI_GUID
> > > +gEfiJsonCapsuleResultTableGuid; extern EFI_GUID gEfiJsonCapsuleIdGuid;
> > > +
> > > +
> > > +#endif
> > > diff --git a/MdePkg/Include/Uefi/UefiSpec.h
> > > b/MdePkg/Include/Uefi/UefiSpec.h index b9282cc..3547345 100644
> > > --- a/MdePkg/Include/Uefi/UefiSpec.h
> > > +++ b/MdePkg/Include/Uefi/UefiSpec.h
> > > @@ -1783,6 +1783,7 @@ EFI_STATUS
> > >  #define EFI_OS_INDICATIONS_FMP_CAPSULE_SUPPORTED
> > > 0x0000000000000008
> > >  #define EFI_OS_INDICATIONS_CAPSULE_RESULT_VAR_SUPPORTED
> > > 0x0000000000000010
> > >  #define EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY
> > > 0x0000000000000040
> > > +#define EFI_OS_INDICATIONS_JSON_CONFIG_DATA_REFRESH
> > > 0x0000000000000080
> > >
> > >  //
> > >  // EFI Runtime Services Table
> > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> > > 0b9c4bc..5dc02f2 100644
> > > --- a/MdePkg/MdePkg.dec
> > > +++ b/MdePkg/MdePkg.dec
> > > @@ -645,6 +645,17 @@
> > >    ## Include/Guid/Btt.h
> > >    gEfiBttAbstractionGuid         = { 0x18633bfc, 0x1735, 0x4217, { 0x8a, 0xc9,
> > > 0x17, 0x23, 0x92, 0x82, 0xd3, 0xf8 }}
> > >
> > > +  # GUIDs defined in UEFI2.8
> > > +  #
> > > +  ## Include/Guid/JsonCapsule.h
> > > +  gEfiJsonConfigDataTableGuid      = { 0x87367f87, 0x1119, 0x41ce, { 0xaa,
> > > 0xec, 0x8b, 0xe0, 0x11, 0x1f, 0x55, 0x8a }}
> > > +  gEfiJsonCapsuleDataTableGuid     = { 0x35e7a725, 0x8dd2, 0x4cac, { 0x80,
> > > 0x11, 0x33, 0xcd, 0xa8, 0x10, 0x90, 0x56 }}
> > > +  gEfiJsonCapsuleResultTableGuid   = { 0xdbc461c3, 0xb3de, 0x422a, { 0xb9,
> > > 0xb4, 0x98, 0x86, 0xfd, 0x49, 0xa1, 0xe5 }}
> > > +  gEfiJsonCapsuleIdGuid            = { 0x67d6f4cd, 0xd6b8, 0x4573, { 0xbf, 0x4a,
> > > 0xde, 0x5e, 0x25, 0x2d, 0x61, 0xae }}
> > > +
> > > +  ## Include\Guid\HiiPlatformSetupFormset.h
> > > +  gEfiHiiResetStyleFormsetGuid     = { 0x790217bd, 0xbecf, 0x485b, { 0x91,
> > > 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8b, 0x27 }}
> > > +
> > >    #
> > >    # GUID defined in PI1.0
> > >    #
> > > --
> > > 2.9.0.windows.1
> > >
> > >
> > > Please consider the environment before printing this email.
> > >
> > > The information contained in this message may be confidential and
> > > proprietary to American Megatrends (AMI).  This communication is intended
> > > to be read only by the individual or entity to whom it is addressed or by their
> > > designee. If the reader of this message is not the intended recipient, you are
> > > on notice that any distribution of this message, in any form, is strictly
> > > prohibited.  Please promptly notify the sender by reply e-mail or by
> > > telephone at 770-246-8600, and then delete or destroy all copies of the
> > > transmission.
> > >
> > >
> 
> 
> 

Re: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support

[Oleksiy Yakovlev]

Hi Liming.

Taking to account, that both 3 and 7 patch affects MdePkg.dec, should patch 7 be based on MdePkg already updated by patch 3, or original?

Regards, Oleksiy.



-----Original Message-----
From: Gao, Liming [mailto:liming.gao@intel.com] 
Sent: Monday, May 11, 2020 10:49 AM
To: devel@edk2.groups.io; Gao, Liming; Liu, Zhiguang; Oleksiy Yakovlev
Cc: Feng, Bob C; Kinney, Michael D; Felix Polyudov
Subject: RE: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support

Oleksiy:
  I review the full patch set. This change should be in patch 3/7. Please update it. With this change, you can add my RB Reviewed-by: Liming Gao <liming.gao@intel.com>.

Thanks
Liming
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao
> Sent: Monday, May 11, 2020 10:14 PM
> To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io; oleksiyy@ami.com
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com
> Subject: Re: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support
> 
> Oleksiy:
>   I don't find this GUID C macro definition. Is it introduced by UEFI JSON?
> 
> > +  ## Include\Guid\HiiPlatformSetupFormset.h
> > +  gEfiHiiResetStyleFormsetGuid     = { 0x790217bd, 0xbecf, 0x485b, { 0x91,
> > 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8b, 0x27 }}
> 
> Thanks
> Liming
> > -----Original Message-----
> > From: Liu, Zhiguang <zhiguang.liu@intel.com>
> > Sent: Saturday, May 9, 2020 10:34 AM
> > To: devel@edk2.groups.io; oleksiyy@ami.com
> > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > Felixp@ami.com
> > Subject: RE: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support
> >
> > Hi Oleksiy.
> >
> > I think we all agree to remove the comment marker before the final parameter in struct.
> > Please see this mail https://edk2.groups.io/g/devel/message/57895
> > Let me know if you have any concern.
> >
> > And one little suggestion.
> > If you send a newer version but don't change anything, you can take the Reviewed-by in your commit message if you get one.
> > So, the reviewer doesn't have to review the same patch again 😊
> >
> > Thanks
> > Zhiguang
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> > > Yakovlev
> > > Sent: Saturday, May 9, 2020 5:46 AM
> > > To: devel@edk2.groups.io
> > > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> > > <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > > Felixp@ami.com; oleksiyy@ami.com
> > > Subject: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support
> > >
> > > Added Guids and structures, that defines the work flow to perform capsule
> > > update using JSON objects.
> > > (UEFI 2.8 mantis 1935)
> > >
> > > Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
> > > ---
> > >  MdePkg/Include/Guid/CapsuleReport.h | 29 +++++++++++
> > >  MdePkg/Include/Guid/JsonCapsule.h   | 97
> > > +++++++++++++++++++++++++++++++++++++
> > >  MdePkg/Include/Uefi/UefiSpec.h      |  1 +
> > >  MdePkg/MdePkg.dec                   | 11 +++++
> > >  4 files changed, 138 insertions(+)
> > >  create mode 100644 MdePkg/Include/Guid/JsonCapsule.h
> > >
> > > diff --git a/MdePkg/Include/Guid/CapsuleReport.h
> > > b/MdePkg/Include/Guid/CapsuleReport.h
> > > index 93d2bb7..ab0f552 100644
> > > --- a/MdePkg/Include/Guid/CapsuleReport.h
> > > +++ b/MdePkg/Include/Guid/CapsuleReport.h
> > > @@ -93,6 +93,35 @@ typedef struct {
> > >    ///
> > >  } EFI_CAPSULE_RESULT_VARIABLE_FMP;
> > >
> > > +typedef struct {
> > > +
> > > +  ///
> > > +  /// Version of this structure, currently 0x00000001  ///
> > > +  UINT32    Version;
> > > +
> > > +  ///
> > > +  /// The unique identifier of the capsule whose processing result is
> > > recorded in this variable.
> > > +  /// 0x00000000 b  0xEFFFFFFF b  Implementation Reserved  ///
> > > + 0xF0000000 b  0xFFFFFFFF b  Specification Reserved  /// #define
> > > + REDFISH_DEFINED_JSON_SCHEMA 0xF000000  /// The JSON payload shall
> > > + conform to a Redfish-defined JSON schema, see DMTF-Redfish  ///
> > > + Specification.
> > > +  ///
> > > +  UINT32 CapsuleId;
> > > +
> > > +  ///
> > > +  /// The length of Resp in bytes.
> > > +  ///
> > > +  UINT32 RespLength;
> > > +
> > > +  ///
> > > +  /// Variable length buffer containing the replied JSON payload to the
> > > + caller who delivered JSON  /// capsule to system. The definition of
> > > + the JSON schema used in the replied payload is beyond  /// the scope of
> > > this specification.
> > > +  ///
> > > +  /// UINT8 Resp[];
> > > + } EFI_CAPSULE_RESULT_VARIABLE_JSON;
> > >
> > >  extern EFI_GUID gEfiCapsuleReportGuid;
> > >
> > > diff --git a/MdePkg/Include/Guid/JsonCapsule.h
> > > b/MdePkg/Include/Guid/JsonCapsule.h
> > > new file mode 100644
> > > index 0000000..721636f
> > > --- /dev/null
> > > +++ b/MdePkg/Include/Guid/JsonCapsule.h
> > > @@ -0,0 +1,97 @@
> > > +/** @file
> > > +Guid & data structure for tables defined for reporting firmware
> > > +configuration data to EFI Configuration Tables and also for processing JSON
> > > payload capsule.
> > > +
> > > +
> > > +Copyright (c) 2020, American Megatrends International LLC. All rights
> > > +reserved.<BR>
> > > +SPDX-License-Identifier: BSD-2-Clause-Patent
> > > +
> > > +**/
> > > +
> > > +#ifndef _JSON_CAPSULE_GUID_H__
> > > +#define _JSON_CAPSULE_GUID_H__
> > > +
> > > +//
> > > +// The address reported in the table entry identified by
> > > +EFI_JSON_CAPSULE_DATA_TABLE_GUID will be // referenced as physical
> > > and
> > > +will not be fixed up when transition from preboot to runtime phase. The
> > > +// addresses reported in these table entries identified by
> > > +EFI_JSON_CONFIG_DATA_TABLE_GUID and //
> > > EFI_JSON_CAPSULE_RESULT_TABLE_GUID will be referenced as virtual and
> > > will be fixed up when // transition from preboot to runtime phase.
> > > +//
> > > +#define EFI_JSON_CONFIG_DATA_TABLE_GUID \
> > > +    {0x87367f87, 0x1119, 0x41ce, \
> > > +    {0xaa, 0xec, 0x8b, 0xe0, 0x11, 0x1f, 0x55, 0x8a }} #define
> > > +EFI_JSON_CAPSULE_DATA_TABLE_GUID \
> > > +    {0x35e7a725, 0x8dd2, 0x4cac, \
> > > +    {0x80, 0x11, 0x33, 0xcd, 0xa8, 0x10, 0x90, 0x56 }} #define
> > > +EFI_JSON_CAPSULE_RESULT_TABLE_GUID \
> > > +    {0xdbc461c3, 0xb3de, 0x422a,\
> > > +    {0xb9, 0xb4, 0x98, 0x86, 0xfd, 0x49, 0xa1, 0xe5 }} #define
> > > +EFI_JSON_CAPSULE_ID_GUID \
> > > +    {0x67d6f4cd, 0xd6b8,  0x4573, \
> > > +    {0xbf, 0x4a, 0xde, 0x5e, 0x25, 0x2d, 0x61, 0xae }}
> > > +
> > > +
> > > +#pragma pack(1)
> > > +
> > > +typedef struct {
> > > +  ///
> > > +  /// Version of the structure, initially 0x00000001.
> > > +  ///
> > > +  UINT32 Version;
> > > +
> > > +  ///
> > > +  /// The unique identifier of this capsule.
> > > +  ///
> > > +  UINT32 CapsuleId;
> > > +
> > > +  ///
> > > +  /// The length of the JSON payload immediately following this header, in
> > > bytes.
> > > +  ///
> > > +  UINT32 PayloadLength;
> > > +
> > > +  ///
> > > +  /// Variable length buffer containing the JSON payload that should be
> > > +parsed and applied to the system. The
> > > +  /// definition of the JSON schema used in the payload is beyond the scope
> > > of this specification.
> > > +  /// UINT8 Payload[];
> > > +} EFI_JSON_CAPSULE_HEADER;
> > > +
> > > +typedef struct {
> > > +  ///
> > > +  /// The length of the following ConfigData, in bytes.
> > > +  ///
> > > +  UINT32 ConfigDataLength;
> > > +
> > > +  ///
> > > +  /// Variable length buffer containing the JSON payload that describes
> > > +one group of configuration data within
> > > +  /// current system. The definition of the JSON schema used in this payload
> > > is beyond the scope of this specification.
> > > +  ///
> > > +  ///UINT8 ConfigData[ConfigDataLength]; } EFI_JSON_CONFIG_DATA_ITEM;
> > > +
> > > +typedef struct {
> > > +  ///
> > > +  /// Version of the structure, initially 0x00000001.
> > > +  ///
> > > +  UINT32 Version;
> > > +
> > > +  ///
> > > +  ////The total length of EFI_JSON_CAPSULE_CONFIG_DATA, in bytes.
> > > +  ///
> > > +  UINT32 TotalLength;
> > > +
> > > +  ///
> > > +  /// Array of configuration data groups.
> > > +  ///
> > > +  /// EFI_JSON_CONFIG_DATA_ITEM ConfigDataList[]; }
> > > +EFI_JSON_CAPSULE_CONFIG_DATA;
> > > +
> > > +#pragma pack()
> > > +
> > > +extern EFI_GUID gEfiJsonConfigDataTableGuid; extern EFI_GUID
> > > +gEfiJsonCapsuleDataTableGuid; extern EFI_GUID
> > > +gEfiJsonCapsuleResultTableGuid; extern EFI_GUID gEfiJsonCapsuleIdGuid;
> > > +
> > > +
> > > +#endif
> > > diff --git a/MdePkg/Include/Uefi/UefiSpec.h
> > > b/MdePkg/Include/Uefi/UefiSpec.h index b9282cc..3547345 100644
> > > --- a/MdePkg/Include/Uefi/UefiSpec.h
> > > +++ b/MdePkg/Include/Uefi/UefiSpec.h
> > > @@ -1783,6 +1783,7 @@ EFI_STATUS
> > >  #define EFI_OS_INDICATIONS_FMP_CAPSULE_SUPPORTED
> > > 0x0000000000000008
> > >  #define EFI_OS_INDICATIONS_CAPSULE_RESULT_VAR_SUPPORTED
> > > 0x0000000000000010
> > >  #define EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY
> > > 0x0000000000000040
> > > +#define EFI_OS_INDICATIONS_JSON_CONFIG_DATA_REFRESH
> > > 0x0000000000000080
> > >
> > >  //
> > >  // EFI Runtime Services Table
> > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> > > 0b9c4bc..5dc02f2 100644
> > > --- a/MdePkg/MdePkg.dec
> > > +++ b/MdePkg/MdePkg.dec
> > > @@ -645,6 +645,17 @@
> > >    ## Include/Guid/Btt.h
> > >    gEfiBttAbstractionGuid         = { 0x18633bfc, 0x1735, 0x4217, { 0x8a, 0xc9,
> > > 0x17, 0x23, 0x92, 0x82, 0xd3, 0xf8 }}
> > >
> > > +  # GUIDs defined in UEFI2.8
> > > +  #
> > > +  ## Include/Guid/JsonCapsule.h
> > > +  gEfiJsonConfigDataTableGuid      = { 0x87367f87, 0x1119, 0x41ce, { 0xaa,
> > > 0xec, 0x8b, 0xe0, 0x11, 0x1f, 0x55, 0x8a }}
> > > +  gEfiJsonCapsuleDataTableGuid     = { 0x35e7a725, 0x8dd2, 0x4cac, { 0x80,
> > > 0x11, 0x33, 0xcd, 0xa8, 0x10, 0x90, 0x56 }}
> > > +  gEfiJsonCapsuleResultTableGuid   = { 0xdbc461c3, 0xb3de, 0x422a, { 0xb9,
> > > 0xb4, 0x98, 0x86, 0xfd, 0x49, 0xa1, 0xe5 }}
> > > +  gEfiJsonCapsuleIdGuid            = { 0x67d6f4cd, 0xd6b8, 0x4573, { 0xbf, 0x4a,
> > > 0xde, 0x5e, 0x25, 0x2d, 0x61, 0xae }}
> > > +
> > > +  ## Include\Guid\HiiPlatformSetupFormset.h
> > > +  gEfiHiiResetStyleFormsetGuid     = { 0x790217bd, 0xbecf, 0x485b, { 0x91,
> > > 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8b, 0x27 }}
> > > +
> > >    #
> > >    # GUID defined in PI1.0
> > >    #
> > > --
> > > 2.9.0.windows.1
> > >
> > >
> > > Please consider the environment before printing this email.
> > >
> > > The information contained in this message may be confidential and
> > > proprietary to American Megatrends (AMI).  This communication is intended
> > > to be read only by the individual or entity to whom it is addressed or by their
> > > designee. If the reader of this message is not the intended recipient, you are
> > > on notice that any distribution of this message, in any form, is strictly
> > > prohibited.  Please promptly notify the sender by reply e-mail or by
> > > telephone at 770-246-8600, and then delete or destroy all copies of the
> > > transmission.
> > >
> > >
> 
> 
> 


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

Re: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support

[Liming Gao]

Patch 7/7 bases on patch 3/7. 

Thanks
Liming
> -----Original Message-----
> From: Oleksiy Yakovlev <Oleksiyy@ami.com>
> Sent: Monday, May 11, 2020 11:04 PM
> To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Felix Polyudov <Felixp@ami.com>
> Subject: RE: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support
> 
> Hi Liming.
> 
> Taking to account, that both 3 and 7 patch affects MdePkg.dec, should patch 7 be based on MdePkg already updated by patch 3, or
> original?
> 
> Regards, Oleksiy.
> 
> 
> 
> -----Original Message-----
> From: Gao, Liming [mailto:liming.gao@intel.com]
> Sent: Monday, May 11, 2020 10:49 AM
> To: devel@edk2.groups.io; Gao, Liming; Liu, Zhiguang; Oleksiy Yakovlev
> Cc: Feng, Bob C; Kinney, Michael D; Felix Polyudov
> Subject: RE: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support
> 
> Oleksiy:
>   I review the full patch set. This change should be in patch 3/7. Please update it. With this change, you can add my RB Reviewed-by:
> Liming Gao <liming.gao@intel.com>.
> 
> Thanks
> Liming
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao
> > Sent: Monday, May 11, 2020 10:14 PM
> > To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io; oleksiyy@ami.com
> > Cc: Feng, Bob C <bob.c.feng@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com
> > Subject: Re: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support
> >
> > Oleksiy:
> >   I don't find this GUID C macro definition. Is it introduced by UEFI JSON?
> >
> > > +  ## Include\Guid\HiiPlatformSetupFormset.h
> > > +  gEfiHiiResetStyleFormsetGuid     = { 0x790217bd, 0xbecf, 0x485b, { 0x91,
> > > 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8b, 0x27 }}
> >
> > Thanks
> > Liming
> > > -----Original Message-----
> > > From: Liu, Zhiguang <zhiguang.liu@intel.com>
> > > Sent: Saturday, May 9, 2020 10:34 AM
> > > To: devel@edk2.groups.io; oleksiyy@ami.com
> > > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > > Felixp@ami.com
> > > Subject: RE: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support
> > >
> > > Hi Oleksiy.
> > >
> > > I think we all agree to remove the comment marker before the final parameter in struct.
> > > Please see this mail https://edk2.groups.io/g/devel/message/57895
> > > Let me know if you have any concern.
> > >
> > > And one little suggestion.
> > > If you send a newer version but don't change anything, you can take the Reviewed-by in your commit message if you get one.
> > > So, the reviewer doesn't have to review the same patch again 😊
> > >
> > > Thanks
> > > Zhiguang
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> > > > Yakovlev
> > > > Sent: Saturday, May 9, 2020 5:46 AM
> > > > To: devel@edk2.groups.io
> > > > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> > > > <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > > > Felixp@ami.com; oleksiyy@ami.com
> > > > Subject: [edk2-devel] [PATCH v4 7/7] MdePkg: UEFI JSON Capsule Support
> > > >
> > > > Added Guids and structures, that defines the work flow to perform capsule
> > > > update using JSON objects.
> > > > (UEFI 2.8 mantis 1935)
> > > >
> > > > Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
> > > > ---
> > > >  MdePkg/Include/Guid/CapsuleReport.h | 29 +++++++++++
> > > >  MdePkg/Include/Guid/JsonCapsule.h   | 97
> > > > +++++++++++++++++++++++++++++++++++++
> > > >  MdePkg/Include/Uefi/UefiSpec.h      |  1 +
> > > >  MdePkg/MdePkg.dec                   | 11 +++++
> > > >  4 files changed, 138 insertions(+)
> > > >  create mode 100644 MdePkg/Include/Guid/JsonCapsule.h
> > > >
> > > > diff --git a/MdePkg/Include/Guid/CapsuleReport.h
> > > > b/MdePkg/Include/Guid/CapsuleReport.h
> > > > index 93d2bb7..ab0f552 100644
> > > > --- a/MdePkg/Include/Guid/CapsuleReport.h
> > > > +++ b/MdePkg/Include/Guid/CapsuleReport.h
> > > > @@ -93,6 +93,35 @@ typedef struct {
> > > >    ///
> > > >  } EFI_CAPSULE_RESULT_VARIABLE_FMP;
> > > >
> > > > +typedef struct {
> > > > +
> > > > +  ///
> > > > +  /// Version of this structure, currently 0x00000001  ///
> > > > +  UINT32    Version;
> > > > +
> > > > +  ///
> > > > +  /// The unique identifier of the capsule whose processing result is
> > > > recorded in this variable.
> > > > +  /// 0x00000000 b  0xEFFFFFFF b  Implementation Reserved  ///
> > > > + 0xF0000000 b  0xFFFFFFFF b  Specification Reserved  /// #define
> > > > + REDFISH_DEFINED_JSON_SCHEMA 0xF000000  /// The JSON payload shall
> > > > + conform to a Redfish-defined JSON schema, see DMTF-Redfish  ///
> > > > + Specification.
> > > > +  ///
> > > > +  UINT32 CapsuleId;
> > > > +
> > > > +  ///
> > > > +  /// The length of Resp in bytes.
> > > > +  ///
> > > > +  UINT32 RespLength;
> > > > +
> > > > +  ///
> > > > +  /// Variable length buffer containing the replied JSON payload to the
> > > > + caller who delivered JSON  /// capsule to system. The definition of
> > > > + the JSON schema used in the replied payload is beyond  /// the scope of
> > > > this specification.
> > > > +  ///
> > > > +  /// UINT8 Resp[];
> > > > + } EFI_CAPSULE_RESULT_VARIABLE_JSON;
> > > >
> > > >  extern EFI_GUID gEfiCapsuleReportGuid;
> > > >
> > > > diff --git a/MdePkg/Include/Guid/JsonCapsule.h
> > > > b/MdePkg/Include/Guid/JsonCapsule.h
> > > > new file mode 100644
> > > > index 0000000..721636f
> > > > --- /dev/null
> > > > +++ b/MdePkg/Include/Guid/JsonCapsule.h
> > > > @@ -0,0 +1,97 @@
> > > > +/** @file
> > > > +Guid & data structure for tables defined for reporting firmware
> > > > +configuration data to EFI Configuration Tables and also for processing JSON
> > > > payload capsule.
> > > > +
> > > > +
> > > > +Copyright (c) 2020, American Megatrends International LLC. All rights
> > > > +reserved.<BR>
> > > > +SPDX-License-Identifier: BSD-2-Clause-Patent
> > > > +
> > > > +**/
> > > > +
> > > > +#ifndef _JSON_CAPSULE_GUID_H__
> > > > +#define _JSON_CAPSULE_GUID_H__
> > > > +
> > > > +//
> > > > +// The address reported in the table entry identified by
> > > > +EFI_JSON_CAPSULE_DATA_TABLE_GUID will be // referenced as physical
> > > > and
> > > > +will not be fixed up when transition from preboot to runtime phase. The
> > > > +// addresses reported in these table entries identified by
> > > > +EFI_JSON_CONFIG_DATA_TABLE_GUID and //
> > > > EFI_JSON_CAPSULE_RESULT_TABLE_GUID will be referenced as virtual and
> > > > will be fixed up when // transition from preboot to runtime phase.
> > > > +//
> > > > +#define EFI_JSON_CONFIG_DATA_TABLE_GUID \
> > > > +    {0x87367f87, 0x1119, 0x41ce, \
> > > > +    {0xaa, 0xec, 0x8b, 0xe0, 0x11, 0x1f, 0x55, 0x8a }} #define
> > > > +EFI_JSON_CAPSULE_DATA_TABLE_GUID \
> > > > +    {0x35e7a725, 0x8dd2, 0x4cac, \
> > > > +    {0x80, 0x11, 0x33, 0xcd, 0xa8, 0x10, 0x90, 0x56 }} #define
> > > > +EFI_JSON_CAPSULE_RESULT_TABLE_GUID \
> > > > +    {0xdbc461c3, 0xb3de, 0x422a,\
> > > > +    {0xb9, 0xb4, 0x98, 0x86, 0xfd, 0x49, 0xa1, 0xe5 }} #define
> > > > +EFI_JSON_CAPSULE_ID_GUID \
> > > > +    {0x67d6f4cd, 0xd6b8,  0x4573, \
> > > > +    {0xbf, 0x4a, 0xde, 0x5e, 0x25, 0x2d, 0x61, 0xae }}
> > > > +
> > > > +
> > > > +#pragma pack(1)
> > > > +
> > > > +typedef struct {
> > > > +  ///
> > > > +  /// Version of the structure, initially 0x00000001.
> > > > +  ///
> > > > +  UINT32 Version;
> > > > +
> > > > +  ///
> > > > +  /// The unique identifier of this capsule.
> > > > +  ///
> > > > +  UINT32 CapsuleId;
> > > > +
> > > > +  ///
> > > > +  /// The length of the JSON payload immediately following this header, in
> > > > bytes.
> > > > +  ///
> > > > +  UINT32 PayloadLength;
> > > > +
> > > > +  ///
> > > > +  /// Variable length buffer containing the JSON payload that should be
> > > > +parsed and applied to the system. The
> > > > +  /// definition of the JSON schema used in the payload is beyond the scope
> > > > of this specification.
> > > > +  /// UINT8 Payload[];
> > > > +} EFI_JSON_CAPSULE_HEADER;
> > > > +
> > > > +typedef struct {
> > > > +  ///
> > > > +  /// The length of the following ConfigData, in bytes.
> > > > +  ///
> > > > +  UINT32 ConfigDataLength;
> > > > +
> > > > +  ///
> > > > +  /// Variable length buffer containing the JSON payload that describes
> > > > +one group of configuration data within
> > > > +  /// current system. The definition of the JSON schema used in this payload
> > > > is beyond the scope of this specification.
> > > > +  ///
> > > > +  ///UINT8 ConfigData[ConfigDataLength]; } EFI_JSON_CONFIG_DATA_ITEM;
> > > > +
> > > > +typedef struct {
> > > > +  ///
> > > > +  /// Version of the structure, initially 0x00000001.
> > > > +  ///
> > > > +  UINT32 Version;
> > > > +
> > > > +  ///
> > > > +  ////The total length of EFI_JSON_CAPSULE_CONFIG_DATA, in bytes.
> > > > +  ///
> > > > +  UINT32 TotalLength;
> > > > +
> > > > +  ///
> > > > +  /// Array of configuration data groups.
> > > > +  ///
> > > > +  /// EFI_JSON_CONFIG_DATA_ITEM ConfigDataList[]; }
> > > > +EFI_JSON_CAPSULE_CONFIG_DATA;
> > > > +
> > > > +#pragma pack()
> > > > +
> > > > +extern EFI_GUID gEfiJsonConfigDataTableGuid; extern EFI_GUID
> > > > +gEfiJsonCapsuleDataTableGuid; extern EFI_GUID
> > > > +gEfiJsonCapsuleResultTableGuid; extern EFI_GUID gEfiJsonCapsuleIdGuid;
> > > > +
> > > > +
> > > > +#endif
> > > > diff --git a/MdePkg/Include/Uefi/UefiSpec.h
> > > > b/MdePkg/Include/Uefi/UefiSpec.h index b9282cc..3547345 100644
> > > > --- a/MdePkg/Include/Uefi/UefiSpec.h
> > > > +++ b/MdePkg/Include/Uefi/UefiSpec.h
> > > > @@ -1783,6 +1783,7 @@ EFI_STATUS
> > > >  #define EFI_OS_INDICATIONS_FMP_CAPSULE_SUPPORTED
> > > > 0x0000000000000008
> > > >  #define EFI_OS_INDICATIONS_CAPSULE_RESULT_VAR_SUPPORTED
> > > > 0x0000000000000010
> > > >  #define EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY
> > > > 0x0000000000000040
> > > > +#define EFI_OS_INDICATIONS_JSON_CONFIG_DATA_REFRESH
> > > > 0x0000000000000080
> > > >
> > > >  //
> > > >  // EFI Runtime Services Table
> > > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> > > > 0b9c4bc..5dc02f2 100644
> > > > --- a/MdePkg/MdePkg.dec
> > > > +++ b/MdePkg/MdePkg.dec
> > > > @@ -645,6 +645,17 @@
> > > >    ## Include/Guid/Btt.h
> > > >    gEfiBttAbstractionGuid         = { 0x18633bfc, 0x1735, 0x4217, { 0x8a, 0xc9,
> > > > 0x17, 0x23, 0x92, 0x82, 0xd3, 0xf8 }}
> > > >
> > > > +  # GUIDs defined in UEFI2.8
> > > > +  #
> > > > +  ## Include/Guid/JsonCapsule.h
> > > > +  gEfiJsonConfigDataTableGuid      = { 0x87367f87, 0x1119, 0x41ce, { 0xaa,
> > > > 0xec, 0x8b, 0xe0, 0x11, 0x1f, 0x55, 0x8a }}
> > > > +  gEfiJsonCapsuleDataTableGuid     = { 0x35e7a725, 0x8dd2, 0x4cac, { 0x80,
> > > > 0x11, 0x33, 0xcd, 0xa8, 0x10, 0x90, 0x56 }}
> > > > +  gEfiJsonCapsuleResultTableGuid   = { 0xdbc461c3, 0xb3de, 0x422a, { 0xb9,
> > > > 0xb4, 0x98, 0x86, 0xfd, 0x49, 0xa1, 0xe5 }}
> > > > +  gEfiJsonCapsuleIdGuid            = { 0x67d6f4cd, 0xd6b8, 0x4573, { 0xbf, 0x4a,
> > > > 0xde, 0x5e, 0x25, 0x2d, 0x61, 0xae }}
> > > > +
> > > > +  ## Include\Guid\HiiPlatformSetupFormset.h
> > > > +  gEfiHiiResetStyleFormsetGuid     = { 0x790217bd, 0xbecf, 0x485b, { 0x91,
> > > > 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8b, 0x27 }}
> > > > +
> > > >    #
> > > >    # GUID defined in PI1.0
> > > >    #
> > > > --
> > > > 2.9.0.windows.1
> > > >
> > > >
> > > > Please consider the environment before printing this email.
> > > >
> > > > The information contained in this message may be confidential and
> > > > proprietary to American Megatrends (AMI).  This communication is intended
> > > > to be read only by the individual or entity to whom it is addressed or by their
> > > > designee. If the reader of this message is not the intended recipient, you are
> > > > on notice that any distribution of this message, in any form, is strictly
> > > > prohibited.  Please promptly notify the sender by reply e-mail or by
> > > > telephone at 770-246-8600, and then delete or destroy all copies of the
> > > > transmission.
> > > >
> > > >
> >
> >
> > 
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication
> is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is
> not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please
> promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

Re: [PATCH v4 0/7] Add definitions introduced in UEFI 2.8

[Liming Gao]

Oleksiy:
  I see you contribute three patch set for UEFI2.8/UEFI2.8a/PI1.7a. With this change, please also update spec version in MdePkg.dec

# EFI1.10/UEFI2.7/PI1.7 and some Industry Standards.
==>
# EFI1.10/UEFI2.8a/PI1.7a and some Industry Standards.

  For this patch set, I have minor comments on 1/7 and 7/7. Other patches are good to me. Reviewed-by: Liming Gao <liming.gao@intel.com>

Thanks
Liming
> -----Original Message-----
> From: Oleksiy Yakovlev <oleksiyy@ami.com>
> Sent: Saturday, May 9, 2020 5:46 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Felixp@ami.com; oleksiyy@ami.com
> Subject: [PATCH v4 0/7] Add definitions introduced in UEFI 2.8
> 
> Following patches add/update structures/definitions, that was
> introduced/modified by UEFI Spec v.2.8.
> 
> Oleksiy Yakovlev (7):
>   MdePkg: Extend SERIAL_IO with DeviceTypeGuid
>   BaseTools:  REST style formset
>   MdePkg:  REST style formset
>   BaseTools: Bootable NVDIMM namespaces
>   MdePkg: Bootable NVDIMM namespaces
>   MdePkg: Add UEFI Spec Revision 2.8
>   MdePkg: UEFI JSON Capsule Support
> 
>  .../Common/UefiInternalFormRepresentation.h        |  1 +
>  BaseTools/Source/C/Include/Protocol/DevicePath.h   | 12 +++
>  MdePkg/Include/Guid/CapsuleReport.h                | 29 +++++++
>  MdePkg/Include/Guid/HiiPlatformSetupFormset.h      |  4 +
>  MdePkg/Include/Guid/JsonCapsule.h                  | 97 ++++++++++++++++++++++
>  MdePkg/Include/Protocol/DevicePath.h               | 12 +++
>  MdePkg/Include/Protocol/SerialIo.h                 |  3 +-
>  .../Include/Uefi/UefiInternalFormRepresentation.h  |  1 +
>  MdePkg/Include/Uefi/UefiSpec.h                     |  2 +
>  MdePkg/MdePkg.dec                                  | 11 +++
>  10 files changed, 171 insertions(+), 1 deletion(-)
>  create mode 100644 MdePkg/Include/Guid/JsonCapsule.h
> 
> --
> 2.9.0.windows.1
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication
> is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is
> not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please
> promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.