From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.12672.1589206100576572736 for ; Mon, 11 May 2020 07:08:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Ym6hVJFQ; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: liming.gao@intel.com) IronPort-SDR: jdQaC6QmMk/Pz7an65N+Xv8OHk/Y2PJX2SYIwDa0zTm5nGQwNrXZseeyPAjJBKksvsRASkQggT p/rLH5oyI0jg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 07:08:19 -0700 IronPort-SDR: Y2UqrhA3w9Xlp4LqmmeqXaqk6DuwLd4//FRdpFBBS0rBxuLyTZmGaaO4VPrpXos+n0HVqPK8Pz MCV18GMYjCgQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,380,1583222400"; d="scan'208";a="371233323" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga001.fm.intel.com with ESMTP; 11 May 2020 07:08:19 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 07:08:10 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 11 May 2020 07:08:10 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 11 May 2020 07:08:10 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 07:08:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dVb21HcPL8+6i9atZc5LRoSD6Ch72w9GCH89jcNC+1aa5ElR8lqq4guJMw34pB+CdMuhaXS2hVSJwONojIUcbvejQFIgx3XpMSpdWK8r1fOidTtb8RHM0v281PTgXOIkhydp8LEBmcvV7gT5dl7XCCB0NhmWxMorLvZkk8Im115pZgi/bSMZJB6B0cjNqxTIBXbhRlqWys+7RJZA2P3Mws6Qu/1nJR6YYoQzMOgJ0QMxeo85WPQozfF7Mw1SdYIBKT+rGgrvPAnc59Ir0neE4h1HjdeDx1aYz8YUpjRfc6MYfDTTjdiJ9DUdkkDAx2nF2r6lQJgu3cwVsos+LuGjnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bo4D3HrayBHjG39Wm3wwWiv0Ja3kpXQRukgd9bhSq3Q=; b=MyDbpMAxB9ApwfYh5gzxhFZ2D7vA7sfi2vqM+gmLZYaN1fqVNFPUCwH3Ih4B22frl+p5Wya+fHpNCjl44LtQBP3uHHT9OE9HCfT0RzoAgHfSpa7QO7ueR7nhRRmQnrt0eb4QGgMsGClQhis7o8U25kg4Yr2SJ+V0IudU9lt6Wj7LvnTvKk7qR5lQjI00FKK/aIofZYMeOd4UPkTXbfW5vy9jc2YKafg5h6aPKNyC649HSyRGuS3Q2gSWWh8TnsRWuiJ9zGqddMIIL/f3l3eJBtYw0ep3fq5pnEsFd3YVZAIm2JqZvWixGjg9HiV6bGJKQ8Xkg6tx8bjo9rGvjjeTwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bo4D3HrayBHjG39Wm3wwWiv0Ja3kpXQRukgd9bhSq3Q=; b=Ym6hVJFQw33n0DUIcpq+fAqFjLMY2ER4DExRuP5iarDtF2n46/euggNUTKtQTXLYm9VCz8xquB45dU8ccKJOmW1RRfRevNptcj6ek0Sac2LLvBmDXC3T68GMTY61Ke6S6AR130eulfnS0qCKi+812G8Yr/mTAyWO0pnczl+PzLY= Received: from BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) by BN6PR11MB1796.namprd11.prod.outlook.com (2603:10b6:404:103::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Mon, 11 May 2020 14:08:05 +0000 Received: from BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0]) by BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0%7]) with mapi id 15.20.2979.033; Mon, 11 May 2020 14:08:05 +0000 From: "Liming Gao" To: "devel@edk2.groups.io" , "ard.biesheuvel@arm.com" CC: "Kinney, Michael D" , "Wang, Jian J" , "Wu, Hao A" , Leif Lindholm , Sami Mujawar , "Yao, Jiewen" Subject: Re: [edk2-devel] [PATCH resend 0/7] Add support for MM communicate2 protocol (PI 1.7a) Thread-Topic: [edk2-devel] [PATCH resend 0/7] Add support for MM communicate2 protocol (PI 1.7a) Thread-Index: AQHWI8u/exwotHxJZ02GKp5/omJeuKii8wAQ Date: Mon, 11 May 2020 14:08:05 +0000 Message-ID: References: <20200506172734.2475-1-ard.biesheuvel@arm.com> In-Reply-To: <20200506172734.2475-1-ard.biesheuvel@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6d857490-0d90-4c86-e702-08d7f5b4b99c x-ms-traffictypediagnostic: BN6PR11MB1796: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 04004D94E2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: J1YyY7C7alovaGI/o12wIoDPOX2osp+TJMdVW5+00F0Yi4SlqiuGufQulnt/0UeDXYIL6DzFFZr5p9cddQivnRoVqI4vVsAA/wXWbUji935uxDVCKah+l7IXjIogjyrcmWrJN6vTjvVmmUUKfMLw0cpXFRqO2EwNATOtPnU+nzAYUJenhcKF7fL4xBiBdF6JMRS++NA0sr4Dfg+EbssDuumMPEGfFKsI8GadH5mthobD/gH96CbliO9jSyOnGAADQkB/rFIFkmNQ2lvYTVxTFxFO4clsWKvbb+VkTGIFFM2jU2qCTuSPSMhySldBWP/YuC7aKgybVh6dxBTn86I1FrhbvhbXKvfraQZpwByds1oNHUamLVOGiwfbr2RIxuy3XYy2+JHh+yKP78jSO89yA0GWBdtGwVi0b+8QdlKF6mDlq/eEIVp3T+c0fzV9mi+igmp01oqoBmyrGgT+5tLN1yBNPA3mVpzjlLEt0GnX+bcIaDmy9mcJeYkv6W4Xi5ZsEFgDHw9bbALgj6CKekeZH8XikY2xAf4038tz0juhp7MFFO4HrEgKZNTl/7sWWYzPJW0aekb/yfuikHdja9EvdiMcSroj2OTojlKcXIHWvPo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3972.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(396003)(346002)(376002)(39860400002)(366004)(33430700001)(53546011)(66556008)(64756008)(110136005)(316002)(478600001)(6506007)(54906003)(55016002)(52536014)(8936002)(5660300002)(19627235002)(9686003)(2906002)(66946007)(76116006)(7696005)(66476007)(26005)(86362001)(33440700001)(966005)(66446008)(33656002)(107886003)(8676002)(71200400001)(186003)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: ocJIHyz21jnoG7jNZGD3HUDEjVYrtvpw8/wbI66BD4oQ4fwX/kZfdoDYRDhAbqZkDAfN8FVQRzAPQHdy1KXViah03gUxXquUppLAkX4+TEDtQoeBpRuzKN9N6bEguKTtBJCqj6Xg2CbYcP5iWTte8vvojhBgXdiMj3fhbO4MrXDAlUpNGzWha95W2xC0gGh0b3s19LSlbkakjZjyVqbcxSiDBRWlNJh/KqX66ubbCV87iTgi9tyhxkMcamlD1a6LTDqvoFSLyPZRLOw9SKGnJ9ww+0dXjOCsrJ1INr2zku5uP+e9ZPe0ZmXm3LMFCMZQuPUN5Cjj09NNyBS8HHz4hrKU+xRiNETIT14Ot8re9e5vYJa2zy5VOXMHcRRf01+m0txx6pbNrW9L1A1QaCcwkL9jRmIDtI+p8DIK+7MZ7K2SB+RxU8cPVIeGXK+QntWhczT6OkYJYnD2f7hcF7slxoQbnUkIqgVDxArpoA93/b2datN56N/UtAtz223gtEkB MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 6d857490-0d90-4c86-e702-08d7f5b4b99c X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2020 14:08:05.1911 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BeRHnjWKNTE76jgnIR2Bw3JclY4I1H/4CEuinan25eniBcJWB6jap2LTbRtt0mYaftZf3CwEZeka5XXIiuzn2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1796 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ard: I see this change updates VariableSmmRuntimeDxe to consume mMmCommunicat= ion2 with mVariableBufferPhysical and mVariableBuffer for physical and virt= ual.=20 But, FaultTolerantWriteSmmDxe consumes mMmCommunication2 with the same S= mmCommunicateHeader for physical and virtual.=20 Is there any difference between them? Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ard Biesh= euvel > Sent: Thursday, May 7, 2020 1:27 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Kinney, Michael D ; Gao, Liming > ; Wang, Jian J ; Wu, Hao A = ; Leif Lindholm > ; Sami Mujawar ; Yao, Jiewen > Subject: [edk2-devel] [PATCH resend 0/7] Add support for MM communicate2= protocol (PI 1.7a) >=20 > Now that version 1.7 errata A of the PI spec has finally been released, > we can take another look at this series, which incorporates the new MM > communicate2 protocol definition, updates the producers for conventional > SMM and standalone MM, and updates the variable store components to cons= ume > the new version of the protocol. This solves a long standing compatibili= ty > issue which made standalone MM fundamentally incompatible with a virtual= ly > remapped address space as installed by SetVirtualAddressMap(). >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Jiewen Yao >=20 > Ard Biesheuvel (7): > MdePkg: introduce MM communicate 2 protocol > MdeModulePkg/SmmIpl: expose MM communicate 2 protocol > ArmPkg/MmCommunicationDxe: expose MM Communicate 2 protocol > MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol > MdeModulePkg/FaultTolerantWriteSmmDxe: switch to MM communicate 2 > MdeModulePkg/VariableSmmRuntimeDxe: switch to MM communicate 2 > StandaloneMmPkg: switch to MM communicate 2 protocol >=20 > .../MmCommunicationDxe/MmCommunication.c | 81 +++++++++---------- > .../MmCommunicationDxe/MmCommunication.inf | 6 +- > .../Application/VariableInfo/VariableInfo.c | 19 +++-- > .../Application/VariableInfo/VariableInfo.inf | 2 +- > MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 80 ++++++++++++++++++ > MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf | 1 + > MdeModulePkg/Include/Guid/SmmVariableCommon.h | 6 +- > .../FaultTolerantWriteSmmCommon.h | 2 +- > .../FaultTolerantWriteSmmDxe.c | 25 +++--- > .../FaultTolerantWriteSmmDxe.h | 2 +- > .../FaultTolerantWriteSmmDxe.inf | 4 +- > .../RuntimeDxe/VariableSmmRuntimeDxe.c | 39 ++++----- > .../RuntimeDxe/VariableSmmRuntimeDxe.inf | 4 +- > MdePkg/Include/Protocol/MmCommunication2.h | 69 ++++++++++++++++ > MdePkg/MdePkg.dec | 7 ++ > StandaloneMmPkg/Core/StandaloneMmCore.h | 2 +- > .../StandaloneMmCpu/AArch64/StandaloneMmCpu.h | 2 +- > 17 files changed, 256 insertions(+), 95 deletions(-) > create mode 100644 MdePkg/Include/Protocol/MmCommunication2.h >=20 > -- > 2.17.1 >=20 >=20 >=20