From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.4389.1589240544574549379 for ; Mon, 11 May 2020 16:42:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=oopd6DGn; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: liming.gao@intel.com) IronPort-SDR: c4Kg+cbRVpI0ZutaxkstubS6BkdDxo1jaEdWqLxyHbfd1Bjk60GqMPpHEn2ucENAWItuIvfKaJ bghfiusxJ32A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 16:42:23 -0700 IronPort-SDR: nxE7zNsNCgt5nq4311rSeGkzsUVJQjA5ENEqOJpUQWCA2Lbzx+yB0XUXi0kmxKdt5dMZsibFH5 5rbuGAq1NS0A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,381,1583222400"; d="scan'208";a="436873301" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga005.jf.intel.com with ESMTP; 11 May 2020 16:42:23 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 16:42:23 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 11 May 2020 16:42:22 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 11 May 2020 16:42:22 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 16:42:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a8SZYkpXrEl6RliOmtubC/FtgeHMMenGzmHqDl+BekOPtvZYbLczmyU9SL+0yAqFHrrpcfCo5TcRR9LOoReucvxvF4sIZhLUkw5AhQGc0+7bX1IVaTSOur/x61toANcIaCqjUyS0wES7mbbq+Fbz5LzPkuzVVCWNd/OQ6VjNC0fSgWhqQGmGjTrrFjtjFN3zCB7t2C3/zwu3XPHpD6az3cEuHSex4lfGC0V9rIo9A4hAtj5YKVAIbFYhD2bUqfmS/TUwc4iq37c8ZaXQWrhSqE5dqleiGbAoAe/7gQiuNPWVvNpsKVHSWlpNyZ7XZ44sErEgwEg7pTpGL2vYzRry2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fcg+cF4Dd52STTQHfA8ZnlhW8qh6vLJamFmXycDNa3c=; b=fR4NQ/uyJAM8qo954lZMqdIOrX8ugWZWsNqcm7qre2WdNoslgSeLsHkGDmjm7LqEgWJdJ0lkdY4JzszCJC5QRJ0IHHvOpdcHA+y9pxfaTLa78kQN+rZ2HLisE6akfjsa7nXzG/mmvkeoxCRCHdUldYWbbQ/y97vMciB6AcM7qmp4U9YmcuzGuTGm48AUWSSSD1OBAzjAv0LtSW2LGaSkwQBZ/iOoySRwKWL55O8E/yWUOSZKdM7ntk51Nqo9gQT9rRaEtwN7bQKChIsMRcSdyXm3B3RXgMruGuRaPiNTF9dIvSguo5LlN/afIEZL8cS5Fh4REhR8KjgrZcaaTgHsXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fcg+cF4Dd52STTQHfA8ZnlhW8qh6vLJamFmXycDNa3c=; b=oopd6DGnP/RMUuUD7BvjAy24OXzqO16E+K0FIfUENadL15gAmiiO/LNV+nNJZXtzcLtKAJj+jKbxSxPvg0qvdTx7ms3G++4kxgOqaTKq660FtYYGrF/kKW6CCDsRbtedHZCSy74EkiHJo+qR1QMtNYu4mdODsgwmVwtEV3DaPNg= Received: from BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) by BN6PR11MB1379.namprd11.prod.outlook.com (2603:10b6:404:48::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26; Mon, 11 May 2020 23:42:10 +0000 Received: from BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0]) by BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0%7]) with mapi id 15.20.2979.033; Mon, 11 May 2020 23:42:10 +0000 From: "Liming Gao" To: "devel@edk2.groups.io" , "oleksiyy@ami.com" CC: "Feng, Bob C" , "Kinney, Michael D" , "Felixp@ami.com" Subject: Re: [edk2-devel] [PATCH v5 3/7] MdePkg: REST style formset Thread-Topic: [edk2-devel] [PATCH v5 3/7] MdePkg: REST style formset Thread-Index: AQHWJ9GlXbHYHjflkUyHc22GwxlaFaiji56w Date: Mon, 11 May 2020 23:42:09 +0000 Message-ID: References: <20200511201923.67744-1-oleksiyy@ami.com> <20200511201923.67744-4-oleksiyy@ami.com> In-Reply-To: <20200511201923.67744-4-oleksiyy@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a52d7f4-1ad1-415b-28b6-08d7f604ec5d x-ms-traffictypediagnostic: BN6PR11MB1379: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-forefront-prvs: 04004D94E2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DTodmkMsIMyWf+Ym4g+n3XT0SRs10RCmHVuYetsjVuIHvoCIMwGnJFCcVyCmH5gvXITx8Yha8ls/RyznCuyivheRzmeWQfeblMFvdgZ5yCMp7sFNj2WpiV9RRNV9cHaYT0/SL+jjgF+YvunSAohU51zoJYVZCZcSysxUFfajMfmwlGNfULI/U1kbquHTcSNKV4xgwgKTlD5KsOjJ4UAl4Xy5Lya7eIOMRRftv++cRfH+/heQajfA2YVVuSBiGoeOTS4WlEBHyICJBVGBvI4sE9dOfzjcLFQTZRcXiNBmBh3UrE1ljDtSqKQCtlhhQNwXcsOPVFMrQlV7Lzav1IKG3vo2+8QES4ervpbT1sDut2uEu9MYzaZnpqE62lSXExlx2MJuc1mBYPUUHZvPmGyv2oMmakBR+XH865En+mncjUMsH3ys/IldnGH7Imk3w/aK3AIzjkRnFFMgoFEMVB9HpqChILyvC8v048lJRn1hGc8pjSsdCkBuU/I/aX5obeKrISmiURezVW2Etn1ve5IFHuxXdoQNVNOu3OoCjSu5kUqaxPDzahUNc140kK55FBj+ZFyUDZg+EcjpuER7/2SC7jdNLjzSiXI1s37dvOhKjI0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3972.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(396003)(39860400002)(346002)(376002)(136003)(33430700001)(66946007)(26005)(66556008)(9686003)(110136005)(55016002)(478600001)(4326008)(2906002)(52536014)(8936002)(8676002)(316002)(54906003)(53546011)(6506007)(7696005)(86362001)(66476007)(186003)(5660300002)(71200400001)(66446008)(33656002)(76116006)(64756008)(33440700001)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 9Hlb9hj3ryAJ+hR7Vn0PvpMwlg+b88v+WPAq2KA3iqwyY9Wx56lw+O+sFlB2X7vyotlg3lnLI5+uheqE6bcO/JsnmGd1LWZwTnCK9eE52g5MaSZ/DB5+H+oQ/Imi0+6N+HIHOauXeao6btRcorri8NHHrAg3AmUR8nzFU7xTdEgnidtig51KCI3I6gLYUqTsosltBsMaD1q7QBHKQ4/ufDY3e8uVNYU6rib+tpHAKTja0z1f4SWBwWuleXdAZtL3PjS4eHl7/3UXPyY+PKOv0uY4kqJUdlqhs6LliF/YIFwzIRrmp0F+inLx6FwXrXKHzHM6EiafTVY/3MvkVHdMR9LlS0vdn93a4v66bJo8rhSB9C76ckvWlN1aOQfQC84bnHk1VLmZqEBrV13OUJHE1eS8m4XeNgdzjaBQyzUrQ0UO8A5x+PjOucQkj6XQ2rjc/ydUMZmEAvKhbsbLt1Jz9D5g9Yh3r1rG+jH4XK4yxwfRS2KLYPpL8Po/TqWnEKkJ MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2a52d7f4-1ad1-415b-28b6-08d7f604ec5d X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2020 23:42:09.9806 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: e4CRQzj44VW8Bzc7Bcz2upK67DjM5q8z3nG4TpTPik0Iac2i2H/IdPK9MUbr+veFoL/6UMu18FsHeM1a/X4s2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1379 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable One minor comment is to correct the style file path. With this change, Revi= ewed-by: Liming Gao + ## Include\Guid\HiiPlatformSetupFormset.h =3D=3D> Include/Guid/HiiPlat= formSetupFormset.h + gEfiHiiResetStyleFormsetGuid =3D { 0x790217bd, 0xbecf, 0x485b, { 0x= 91, 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8b, 0x27 }} + Thanks Liming -----Original Message----- From: devel@edk2.groups.io On Behalf Of Oleksiy Yak= ovlev Sent: 2020=1B$BG/=1B(B5=1B$B7n=1B(B12=1B$BF|=1B(B 4:19 To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming = ; Kinney, Michael D ; Felixp@ami.com; oleksiyy@= ami.com Subject: [edk2-devel] [PATCH v5 3/7] MdePkg: REST style formset New ClassGuid EFI_HII_REST_STYLE_FORMSET_GUID is defined. In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined. (UEFI 2.8 mantis 1853) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Guid/HiiPlatformSetupFormset.h | 4 ++++ MdePkg/Include/Uefi/UefiInternalFormRepresentation.h | 1 + MdePkg/MdePkg.dec | 5 +++++ 3 files changed, 10 insertions(+) diff --git a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h b/MdePkg/Includ= e/Guid/HiiPlatformSetupFormset.h index 540483d..db7b80b 100644 --- a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h +++ b/MdePkg/Include/Guid/HiiPlatformSetupFormset.h @@ -22,8 +22,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define E= FI_HII_USER_CREDENTIAL_FORMSET_GUID \ { 0x337f4407, 0x5aee, 0x4b83, { 0xb2, 0xa7, 0x4e, 0xad, 0xca, 0x30, 0x8= 8, 0xcd } } =20 +#define EFI_HII_REST_STYLE_FORMSET_GUID \ + { 0x790217bd, 0xbecf, 0x485b, { 0x91, 0x70, 0x5f, 0xf7, 0x11, 0x31,=20 +0x8b, 0x27 } } + extern EFI_GUID gEfiHiiPlatformSetupFormsetGuid; extern EFI_GUID gEfiHii= DriverHealthFormsetGuid; extern EFI_GUID gEfiHiiUserCredentialFormsetGuid; +extern EFI_GUID gEfiHiiRestStyleFormsetGuid; =20 #endif diff --git a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h b/MdePkg= /Include/Uefi/UefiInternalFormRepresentation.h index 4a1346a..40fcdb7 100644 --- a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h +++ b/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h @@ -825,6 +825,7 @@ typedef struct _EFI_IFR_QUESTION_HEADER { #define EFI_IFR_FLAG_READ_ONLY 0x01 #define EFI_IFR_FLAG_CALLBACK 0x04 #define EFI_IFR_FLAG_RESET_REQUIRED 0x10 +#define EFI_IFR_FLAG_REST_STYLE 0x20 #define EFI_IFR_FLAG_RECONNECT_REQUIRED 0x40 #define EFI_IFR_FLAG_OPTIONS_ONLY 0x80 =20 diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index 0b9c4bc..ce40b6f = 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -645,6 +645,11 @@ ## Include/Guid/Btt.h gEfiBttAbstractionGuid =3D { 0x18633bfc, 0x1735, 0x4217, { 0x8a= , 0xc9, 0x17, 0x23, 0x92, 0x82, 0xd3, 0xf8 }} =20 + # GUIDs defined in UEFI2.8 + # + ## Include\Guid\HiiPlatformSetupFormset.h + gEfiHiiResetStyleFormsetGuid =3D { 0x790217bd, 0xbecf, 0x485b, { 0x= 91, 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8b, 0x27 }} + # # GUID defined in PI1.0 # -- 2.9.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on.