From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Chang, Abner (HPS SW/FW Technologist)" <abner.chang@hpe.com>
Subject: Re: [edk2-devel] [PATCH v1 0/9] MdePkg changes for RISC-V edk2 port
Date: Tue, 21 Apr 2020 00:54:40 +0000 [thread overview]
Message-ID: <BN6PR11MB3972C86E433B5B249D66D08C80D50@BN6PR11MB3972.namprd11.prod.outlook.com> (raw)
In-Reply-To: <160466638D74146F.10131@groups.io>
Abner:
Here is my minor comments.
1. For RISC-V processor related definitions, have they been defined in public definitions?
2. For MdePkg/BaseSynchronizationLib, why name file SynchronizationAsm.S? Can it name to Synchronization.S?
Thanks
Liming
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang, Abner (HPS SW/FW Technologist)
Sent: 2020年4月10日 15:21
To: devel@edk2.groups.io
Cc: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Subject: [edk2-devel] [PATCH v1 0/9] MdePkg changes for RISC-V edk2 port
MdePkg modules and definitionsfor RISC-V architecture on edk2.
BZ for entire RISC-V edk2 port,
https://urldefense.proofpoint.com/v2/url?u=https-3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid-3D2672&d=DwIFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=i2pc5cGhlgc-Pd56r1673_LslTQbDe_XaFESUeh4tsE&s=m6Rw9jDskrzU3JlGDX4TQOji5DrEKO6wGXu5-OqkReY&e=
These commits are verified by below PR,
https://github.com/tianocore/edk2/pull/512
Abner Chang (9):
MdePkg: RISC-V RV64 binding in MdePkg
MdePkg/Include: RISC-V definitions.
MdePkg/BaseLib: BaseLib for RISC-V RV64 Processor.
MdePkg/BaseCacheMaintenanceLib: RISC-V cache maintenance
implementation.
MdePkg/BaseIoLibIntrinsic: Rename IoLibArm.c=>IoLibNoIo.c
MdePkg/BasePeCoff: Add RISC-V PE/Coff related code.
MdePkg/BaseCpuLib: RISC-V Base CPU library implementation.
MdePkg/BaseSynchronizationLib: RISC-V cache related code.
MdePkg/BaseSafeIntLib: Add RISCV64 arch for BaseSafeIntLib.
MdePkg/MdePkg.dec | 5 +-
MdePkg/MdePkg.dsc | 3 +-
.../BaseCacheMaintenanceLib.inf | 4 +
MdePkg/Library/BaseCpuLib/BaseCpuLib.inf | 6 +-
.../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 12 +-
MdePkg/Library/BaseLib/BaseLib.inf | 18 +-
.../Library/BasePeCoffLib/BasePeCoffLib.inf | 5 +
.../Library/BaseSafeIntLib/BaseSafeIntLib.inf | 6 +-
.../BaseSynchronizationLib.inf | 5 +
MdePkg/Include/IndustryStandard/PeImage.h | 12 +
MdePkg/Include/Library/BaseLib.h | 26 ++
MdePkg/Include/Protocol/DebugSupport.h | 55 ++++
MdePkg/Include/Protocol/PxeBaseCode.h | 4 +
MdePkg/Include/RiscV64/ProcessorBind.h | 173 ++++++++++++
MdePkg/Include/Uefi/UefiBaseType.h | 13 +
MdePkg/Include/Uefi/UefiSpec.h | 5 +
.../BasePeCoffLib/BasePeCoffLibInternals.h | 9 +
.../BaseCacheMaintenanceLib/RiscVCache.c | 250 ++++++++++++++++++
.../{IoLibArm.c => IoLibNoIo.c} | 4 +-
.../Library/BaseLib/RiscV64/CpuBreakpoint.c | 27 ++
MdePkg/Library/BaseLib/RiscV64/CpuPause.c | 29 ++
.../BaseLib/RiscV64/DisableInterrupts.c | 24 ++
.../BaseLib/RiscV64/EnableInterrupts.c | 25 ++
.../BaseLib/RiscV64/GetInterruptState.c | 35 +++
.../BaseLib/RiscV64/InternalSwitchStack.c | 55 ++++
MdePkg/Library/BaseLib/RiscV64/LongJump.c | 32 +++
MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 3 +-
.../BasePeCoffLib/RiscV/PeCoffLoaderEx.c | 133 ++++++++++
MdePkg/Library/BaseCpuLib/BaseCpuLib.uni | 5 +-
MdePkg/Library/BaseCpuLib/RiscV/Cpu.S | 19 ++
MdePkg/Library/BaseLib/RiscV64/FlushCache.S | 21 ++
.../BaseLib/RiscV64/RiscVCpuBreakpoint.S | 14 +
.../Library/BaseLib/RiscV64/RiscVCpuPause.S | 14 +
.../Library/BaseLib/RiscV64/RiscVInterrupt.S | 32 +++
.../BaseLib/RiscV64/RiscVSetJumpLongJump.S | 55 ++++
.../Library/BasePeCoffLib/BasePeCoffLib.uni | 2 +
.../RiscV64/SynchronizationAsm.S | 78 ++++++
37 files changed, 1204 insertions(+), 14 deletions(-) create mode 100644 MdePkg/Include/RiscV64/ProcessorBind.h
create mode 100644 MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c
rename MdePkg/Library/BaseIoLibIntrinsic/{IoLibArm.c => IoLibNoIo.c} (94%) create mode 100644 MdePkg/Library/BaseLib/RiscV64/CpuBreakpoint.c
create mode 100644 MdePkg/Library/BaseLib/RiscV64/CpuPause.c
create mode 100644 MdePkg/Library/BaseLib/RiscV64/DisableInterrupts.c
create mode 100644 MdePkg/Library/BaseLib/RiscV64/EnableInterrupts.c
create mode 100644 MdePkg/Library/BaseLib/RiscV64/GetInterruptState.c
create mode 100644 MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c
create mode 100644 MdePkg/Library/BaseLib/RiscV64/LongJump.c
create mode 100644 MdePkg/Library/BasePeCoffLib/RiscV/PeCoffLoaderEx.c
create mode 100644 MdePkg/Library/BaseCpuLib/RiscV/Cpu.S
create mode 100644 MdePkg/Library/BaseLib/RiscV64/FlushCache.S
create mode 100644 MdePkg/Library/BaseLib/RiscV64/RiscVCpuBreakpoint.S
create mode 100644 MdePkg/Library/BaseLib/RiscV64/RiscVCpuPause.S
create mode 100644 MdePkg/Library/BaseLib/RiscV64/RiscVInterrupt.S
create mode 100644 MdePkg/Library/BaseLib/RiscV64/RiscVSetJumpLongJump.S
create mode 100644 MdePkg/Library/BaseSynchronizationLib/RiscV64/SynchronizationAsm.S
--
2.25.0
next parent reply other threads:[~2020-04-21 0:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <160466638D74146F.10131@groups.io>
2020-04-21 0:54 ` Liming Gao [this message]
2020-04-21 1:04 ` [edk2-devel] [PATCH v1 0/9] MdePkg changes for RISC-V edk2 port Abner Chang
2020-04-22 9:17 ` Liming Gao
2020-04-22 14:45 ` Abner Chang
2020-04-22 14:48 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR11MB3972C86E433B5B249D66D08C80D50@BN6PR11MB3972.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox