From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.530.1587430501204316414 for ; Mon, 20 Apr 2020 17:55:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=gKUFG5o0; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: liming.gao@intel.com) IronPort-SDR: nvii4JovCCFNHMZu1CkBQ4e3l53jAjVabveGTt2k69FeM5NXLBCPhHsJRI3eLb+EhVnnwyCXYy V+C6wPkOlXQQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 17:55:00 -0700 IronPort-SDR: 744Lo4n68TDQ5kiDfpqQv7aOYagjzjEDvecAyTN0CF/A7giMBQK+voOAZUgaWEYaTeqnXVmQe5 lNmNoctihbNQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,408,1580803200"; d="scan'208";a="429335890" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 20 Apr 2020 17:55:00 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Apr 2020 17:54:59 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Apr 2020 17:54:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RLUMflvaR26ATj8UOQP6y/qRa7xVBD/p0gtchJwr/UhtRTg0X86MAXV8TNPvaKUbeVpM14kYwxDg/n8XYRKkchlA4c5VknDk3FpEmebiqIghuaGv7gIQMWsankSh5N7/sdLG1gg3kQ+ZMkYoV5+mIEHi/qOc5ofYXKD3JmYZCs3YPdE4/6y0QCgVEbohxaiOjUw6rHQcS9K1UMdth7Xc/uM2Igi6mAoQumQMiM9z45qRZ1EnDVTsyZQ6lrXOaPZzq0T0k2Sny+QrDyBvSKp0kR7v10AJkrGWB2+WX0l12C12d5sM0B45/X3VFtLsjeE6fClnBrZU9RJ5P414jVDHnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/InIfEqJ1yPGFQNZK9ndpwvF30iaVQ6ZNuq/KaM2Qm0=; b=Hr6pioEBUKy/6fE3D5kYo+N2NF168a8iCBqd1v7iVPdCpauregJ57Z8XEz61fRBT6J4BKL40nSLX1ijQVjCrB1zKJql8z0ClWwXAEa92SgeM8UF8HEPHHTJ1opOxFv1f//D21ljZjbcdIeFfzr+V8VuPRqKbCAdoJD9AKbstCxKf9Jhh8QCvu1fTUPC46Q0C95FEJunogXFPbwr3syTmFjZVCoa6nYegXQW+Ei9cm5Oh7PPnzMDJo1Q0ZHWeRUjqpg0xwXMMt73H6ROZ0+5VpMg8BxJXgTHULs41AQHWh8vt5ZWnE3tvF2j5LorUcKTb3Y5s4vWa9eLgU6vD0r+FIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/InIfEqJ1yPGFQNZK9ndpwvF30iaVQ6ZNuq/KaM2Qm0=; b=gKUFG5o0KzGtoqW+R6nVb1jtN6NdmJLSsTQxGCAGd0RKBBvlQHARkMzlgFEkMstAQLJ3uFAZLVRcBJljzxBiiXIsrmVxqxeMdwwa3S5GdKv7U6oo69LDUMjbBTMfxd4cphkilQw64oDcAE4DGPhgMKEE5eH02TGxpx7WQhomRfg= Received: from BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) by BN6PR11MB1409.namprd11.prod.outlook.com (2603:10b6:404:46::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Tue, 21 Apr 2020 00:54:40 +0000 Received: from BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::4dcc:bc5c:def:9ae9]) by BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::4dcc:bc5c:def:9ae9%5]) with mapi id 15.20.2921.027; Tue, 21 Apr 2020 00:54:40 +0000 From: "Liming Gao" To: "devel@edk2.groups.io" , "Chang, Abner (HPS SW/FW Technologist)" Subject: Re: [edk2-devel] [PATCH v1 0/9] MdePkg changes for RISC-V edk2 port Thread-Topic: [edk2-devel] [PATCH v1 0/9] MdePkg changes for RISC-V edk2 port Thread-Index: AQHWDw3s+pVfH2MXWk+1vPdg5CLjaqiCzFhw Date: Tue, 21 Apr 2020 00:54:40 +0000 Message-ID: References: <160466638D74146F.10131@groups.io> In-Reply-To: <160466638D74146F.10131@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: spf=none (sender IP is ) smtp.mailfrom=liming.gao@intel.com; x-originating-ip: [192.55.52.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aeae7d4f-dea5-41b6-47e1-08d7e58e92dc x-ms-traffictypediagnostic: BN6PR11MB1409: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:182; x-forefront-prvs: 038002787A x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3972.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(366004)(376002)(346002)(396003)(136003)(39860400002)(9686003)(26005)(966005)(186003)(316002)(2906002)(55016002)(6506007)(86362001)(478600001)(53546011)(33656002)(110136005)(5660300002)(66556008)(66476007)(64756008)(66446008)(66946007)(76116006)(8676002)(19627235002)(7696005)(52536014)(81156014)(8936002)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MbF+YRihYAmTScZOlvnBcU2i+oZ2PvtSzkqDOmcZKB2U6Fi6QWrETXpdRTaREm/vKp44uaXtzkv814TSu06GOQxOtR/hhN9YZ2rJeDMkGfUj/0wBBxyBFatfsGAp5VPRp4GDHThAdY3VaUnToY8YB2Gp/KE90WNQSeyU4hJ/6Jr8DrJo3BxApOp1YLJXFZhxpGMeeQm2meHEvHngG8Cz84aHWc13ALO6C1Pl6Fv1SwJFDIKq9kx3NhA0HmF20klVLQLM3+84+0Nr4vl9UZkMlAzW10G8IEElrwo8B9sG6bmA3jp8uWS+gypnoa6VYKQeFGNVgTUroeKMmwpJrvQQhnsSlOXn94EmmI1fbG6GvuUuIfTtqJhyeJyHKzlxp7pdsJNv5pByO96Iyt47hso9dCSRuVa4vaoDC/kGXaET4gNHnYm0N7wMfUjAuUEWZDZuMqGk5jHQh8TvVxVvsir1vhmE/LsEbYurWNIpI2E8e5ZRsB/bXqpHPiFK8DkE+E9qFeoOc5xAtQXH8AtRNbBQiw== x-ms-exchange-antispam-messagedata: Janh06f7ny4o+hI2IOTwcukWun5JqlK6EzDtv5ZVUGXpco8n2o16+n7QvdSfK/1hZOcq79Q04bdnFXo+0h5xoJKT3sArNIxzm5DIpnPex72ZPNBfrUL4ABmUoaO2tpdYcG/WO7rgpqkOeOmRxr67tg== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: aeae7d4f-dea5-41b6-47e1-08d7e58e92dc X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 00:54:40.6662 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ctsVVc7Tn4yR5LNeR+iauf7J9Ln64jJfkdk/LrBIGrzIACs9jl8UaBxFiRK2AXTUDUWBWFxs6Xw1yCEDIlAhZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1409 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Abner: Here is my minor comments.=20 1. For RISC-V processor related definitions, have they been defined in pu= blic definitions?=20 2. For MdePkg/BaseSynchronizationLib, why name file SynchronizationAsm.S?= Can it name to Synchronization.S? Thanks Liming -----Original Message----- From: devel@edk2.groups.io On Behalf Of Chang, Abne= r (HPS SW/FW Technologist) Sent: 2020=1B$BG/=1B(B4=1B$B7n=1B(B10=1B$BF|=1B(B 15:21 To: devel@edk2.groups.io Cc: Chang, Abner (HPS SW/FW Technologist) Subject: [edk2-devel] [PATCH v1 0/9] MdePkg changes for RISC-V edk2 port MdePkg modules and definitionsfor RISC-V architecture on edk2. BZ for entire RISC-V edk2 port, https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__bugzilla.tianocore.= org_show-5Fbug.cgi-3Fid-3D2672&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_S= N6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3Di2pc5cGhlgc-Pd56r1673_LslTQbD= e_XaFESUeh4tsE&s=3Dm6Rw9jDskrzU3JlGDX4TQOji5DrEKO6wGXu5-OqkReY&e=3D=20 These commits are verified by below PR, https://github.com/tianocore/edk2/pull/512 Abner Chang (9): MdePkg: RISC-V RV64 binding in MdePkg MdePkg/Include: RISC-V definitions. MdePkg/BaseLib: BaseLib for RISC-V RV64 Processor. MdePkg/BaseCacheMaintenanceLib: RISC-V cache maintenance implementation. MdePkg/BaseIoLibIntrinsic: Rename IoLibArm.c=3D>IoLibNoIo.c MdePkg/BasePeCoff: Add RISC-V PE/Coff related code. MdePkg/BaseCpuLib: RISC-V Base CPU library implementation. MdePkg/BaseSynchronizationLib: RISC-V cache related code. MdePkg/BaseSafeIntLib: Add RISCV64 arch for BaseSafeIntLib. MdePkg/MdePkg.dec | 5 +- MdePkg/MdePkg.dsc | 3 +- .../BaseCacheMaintenanceLib.inf | 4 + MdePkg/Library/BaseCpuLib/BaseCpuLib.inf | 6 +- .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 12 +- MdePkg/Library/BaseLib/BaseLib.inf | 18 +- .../Library/BasePeCoffLib/BasePeCoffLib.inf | 5 + .../Library/BaseSafeIntLib/BaseSafeIntLib.inf | 6 +- .../BaseSynchronizationLib.inf | 5 + MdePkg/Include/IndustryStandard/PeImage.h | 12 + MdePkg/Include/Library/BaseLib.h | 26 ++ MdePkg/Include/Protocol/DebugSupport.h | 55 ++++ MdePkg/Include/Protocol/PxeBaseCode.h | 4 + MdePkg/Include/RiscV64/ProcessorBind.h | 173 ++++++++++++ MdePkg/Include/Uefi/UefiBaseType.h | 13 + MdePkg/Include/Uefi/UefiSpec.h | 5 + .../BasePeCoffLib/BasePeCoffLibInternals.h | 9 + .../BaseCacheMaintenanceLib/RiscVCache.c | 250 ++++++++++++++++++ .../{IoLibArm.c =3D> IoLibNoIo.c} | 4 +- .../Library/BaseLib/RiscV64/CpuBreakpoint.c | 27 ++ MdePkg/Library/BaseLib/RiscV64/CpuPause.c | 29 ++ .../BaseLib/RiscV64/DisableInterrupts.c | 24 ++ .../BaseLib/RiscV64/EnableInterrupts.c | 25 ++ .../BaseLib/RiscV64/GetInterruptState.c | 35 +++ .../BaseLib/RiscV64/InternalSwitchStack.c | 55 ++++ MdePkg/Library/BaseLib/RiscV64/LongJump.c | 32 +++ MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 3 +- .../BasePeCoffLib/RiscV/PeCoffLoaderEx.c | 133 ++++++++++ MdePkg/Library/BaseCpuLib/BaseCpuLib.uni | 5 +- MdePkg/Library/BaseCpuLib/RiscV/Cpu.S | 19 ++ MdePkg/Library/BaseLib/RiscV64/FlushCache.S | 21 ++ .../BaseLib/RiscV64/RiscVCpuBreakpoint.S | 14 + .../Library/BaseLib/RiscV64/RiscVCpuPause.S | 14 + .../Library/BaseLib/RiscV64/RiscVInterrupt.S | 32 +++ .../BaseLib/RiscV64/RiscVSetJumpLongJump.S | 55 ++++ .../Library/BasePeCoffLib/BasePeCoffLib.uni | 2 + .../RiscV64/SynchronizationAsm.S | 78 ++++++ 37 files changed, 1204 insertions(+), 14 deletions(-) create mode 100644= MdePkg/Include/RiscV64/ProcessorBind.h create mode 100644 MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c rename MdePkg/Library/BaseIoLibIntrinsic/{IoLibArm.c =3D> IoLibNoIo.c} (9= 4%) create mode 100644 MdePkg/Library/BaseLib/RiscV64/CpuBreakpoint.c create mode 100644 MdePkg/Library/BaseLib/RiscV64/CpuPause.c create mode 100644 MdePkg/Library/BaseLib/RiscV64/DisableInterrupts.c create mode 100644 MdePkg/Library/BaseLib/RiscV64/EnableInterrupts.c create mode 100644 MdePkg/Library/BaseLib/RiscV64/GetInterruptState.c create mode 100644 MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c create mode 100644 MdePkg/Library/BaseLib/RiscV64/LongJump.c create mode 100644 MdePkg/Library/BasePeCoffLib/RiscV/PeCoffLoaderEx.c create mode 100644 MdePkg/Library/BaseCpuLib/RiscV/Cpu.S create mode 100644 MdePkg/Library/BaseLib/RiscV64/FlushCache.S create mode 100644 MdePkg/Library/BaseLib/RiscV64/RiscVCpuBreakpoint.S create mode 100644 MdePkg/Library/BaseLib/RiscV64/RiscVCpuPause.S create mode 100644 MdePkg/Library/BaseLib/RiscV64/RiscVInterrupt.S create mode 100644 MdePkg/Library/BaseLib/RiscV64/RiscVSetJumpLongJump.S create mode 100644 MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchron= izationAsm.S -- 2.25.0