From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.148.1587478910792208425 for ; Tue, 21 Apr 2020 07:21:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=wT0jjf2B; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: liming.gao@intel.com) IronPort-SDR: 1y5mvTulyVx0SdBbLZDQJ2O3MaspAoyd7nTYhUWgudsFhVURqeWAnw/PMkDBKjKEXkrmgUcY19 ZL/eaBJ+Et9A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2020 07:21:50 -0700 IronPort-SDR: n322ysbkVYG7rBA7//vvsf+FBQ9lMoCF212PsjV0nrjCBbiObDJD2jSNZ6l4lJtHkPBn7dLDL5 VBkoi9p2bMBg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,410,1580803200"; d="scan'208";a="255309823" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 21 Apr 2020 07:21:49 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 07:21:35 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 07:21:34 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 07:21:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mDsUFIvsbnZsifIA0cPlNDP+6NVpmIiKCcquVitMAzsreyuVFlyPxGXqvJvPVaIy6JMS6+yxZv5J/Rlwrg2cXhUd8/3RvFn+mfaaDraxCOcGqQBzoo0zVldBCJwwIJGa+rhGfLh2dnz1N6QyYlp/lzki6pamYxJnVPkO5fR4DQm7M+diR4yEH2CHkWhYfLu+qqahHkK8oP3QWUailLMtnyUoLZGqrcNebRLbQPtbc+BqCCRfpeg8bB1fMlO71gWixBsBdBOarnlDrzebjpxD7w+T7+D+shq4Woj0qQaW+23yQCW4odlP3+B9YWPcJjwp+WDl/apiCJU0XbBjHDdIpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0C8cN2iVcTI9pRu+BYRk60WsuG2PFFcTsz3wvzs55bk=; b=QjgiXJe5L7UjMVLZGB4DcLma2iLMdu+/HZjtnD5YgLyl0ZSJlAcm26lDnU/7HMNgpou59o5PPKvl1hizJhZejIawYwszdaNp8TIVlJ8zFzFJc1+vLpykE4PXr2kKvMSUsHILKeJOAitiuQJVufkhCuHjBSve667ukLZkH4IzvLJnnwsGqfP3gY7L/l2ltzHE3fj6U7Pm0Lf68GzR0yIwxcqTTkKWusCo/SNme8z7G6SJ33v7ehuT7IdJQuCRoQLsxPbHzBCcICYDTqPcN5RwaPO/lt1dsJxXILAFgpL7onIYr7zyeYggi50ej+XsjELeZNW59z6oGvrS0YvvywtxBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0C8cN2iVcTI9pRu+BYRk60WsuG2PFFcTsz3wvzs55bk=; b=wT0jjf2BG9Mtkxg2DX/gKWfeonJDleI990ht5gfA6++5OwOTLtz1kf7zCE7QYpttEUQ6Yfs1TrndFXRavvY4dCNlC+qCb9SoZLsujaatUO4GYQtRxhFo+GkNSKLIGn+iikBQj4ciVVb2vASrBWa8yzXhYuK+zRYRRXddIjHxrzA= Received: from BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) by BN6PR11MB4131.namprd11.prod.outlook.com (2603:10b6:405:80::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.27; Tue, 21 Apr 2020 14:21:32 +0000 Received: from BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::4dcc:bc5c:def:9ae9]) by BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::4dcc:bc5c:def:9ae9%5]) with mapi id 15.20.2921.030; Tue, 21 Apr 2020 14:21:32 +0000 From: "Liming Gao" To: "devel@edk2.groups.io" , "Jiang, Guomin" CC: "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v2 6/6] MdePkg/Security2: Mark the File parameter as OPTIONAL. Thread-Topic: [edk2-devel] [PATCH v2 6/6] MdePkg/Security2: Mark the File parameter as OPTIONAL. Thread-Index: AQHWE8GEz/iCb+YtP0mSgRYu73g0/KiDqDhQ Date: Tue, 21 Apr 2020 14:21:31 +0000 Message-ID: References: <20200416073354.2232-1-guomin.jiang@intel.com> <20200416073354.2232-7-guomin.jiang@intel.com> In-Reply-To: <20200416073354.2232-7-guomin.jiang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: spf=none (sender IP is ) smtp.mailfrom=liming.gao@intel.com; x-originating-ip: [192.55.52.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c823f670-68ab-48b3-bb73-08d7e5ff4a44 x-ms-traffictypediagnostic: BN6PR11MB4131: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 038002787A x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3972.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(39860400002)(346002)(136003)(376002)(396003)(366004)(81156014)(8936002)(316002)(15650500001)(76116006)(71200400001)(186003)(8676002)(53546011)(6506007)(7696005)(26005)(86362001)(6636002)(66446008)(64756008)(66556008)(66476007)(66946007)(107886003)(9686003)(478600001)(110136005)(19627235002)(55016002)(966005)(4326008)(52536014)(2906002)(5660300002)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oyuz7N2tL4igbc9AHHCtaiSRdHpl2Ks+R6cjlAp0bBH7oca6Bi5DcMJk/hkXEUQYJZiY5kXNzISoxJbpe5O3Cix8MA9tyQXxQZTbJFTIw+prpD7U/AWHx5XZBRI2TyP44ZMMAdf8yW0Xb5nrZeU3efhSV8W/yEIXNz4gqnzssxqXJWTklxqHHLQvXmK1Nfex3v1zpAxl07KsZn24s9hKQziNMuvTB8NHR7jdVhK7Kxl7tsYUnG/vv/A72EUs6Je1oNTBSUPTeM7WCRJUi4ImbZZ+cY9u4qGPVtuFlduz/EnKH72upxCVwYNMSYBjgmOp4yKcSDeiQ3bqe+cZWV/xlhdtwLbq9imCg1mwZEHhIOncsiWzDXfZjABQzW5WrAKhWYkq8VC7112E+I+YpfUOaoSfnt8q5SRqi0ZR2WxGlmjN1wVHieiUfUF9jwHC/q6rb1VblSxKFCRlg/Lix2TRziKdl5pZB/kpHaqOh96ikd1y7UXFKaVkv5h9yimqXH6TXeezuVi/eJgFY+/ntex73A== x-ms-exchange-antispam-messagedata: wUFt8VEQl2Xm1MwnR1GiEYEQf0jC6ExtWRPlGyzQdZrwlJRmskKbJLVOs/SJa+qruX5LRC1Ewp4do91Negy5z0/BX8bSZfycxyWZ2FLiSWR2yjuQWuObAXu7QZI54+50+5N9KpZHLG1eSg3CbtX4RA== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c823f670-68ab-48b3-bb73-08d7e5ff4a44 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 14:21:31.9125 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B9j1zwVwQH4GLqcbAJRpaFrBFjGfw6vVdA1KL26v8se69bOAW5LJBMEKVETv3hz7eTJLeHEaMRW4OPELYE+eiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4131 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Guomin: I find this parameter name doesn't match the one in function description.= Can you make them be same? With this change, Reviewed-by: Liming Gao @param File A pointer to the device path of the file that is being dispatched. This will optionally be used f= or logging. Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Guomin Jia= ng > Sent: Thursday, April 16, 2020 3:34 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > Subject: [edk2-devel] [PATCH v2 6/6] MdePkg/Security2: Mark the File para= meter as OPTIONAL. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2652 >=20 > According to the description, the File is OPTIONAL and can be NULL. >=20 > Signed-off-by: Guomin Jiang > Cc: Michael D Kinney > Cc: Liming Gao > --- > MdePkg/Include/Protocol/Security2.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdePkg/Include/Protocol/Security2.h b/MdePkg/Include/Protoco= l/Security2.h > index 2d85b4ba9f..6a63009956 100644 > --- a/MdePkg/Include/Protocol/Security2.h > +++ b/MdePkg/Include/Protocol/Security2.h > @@ -80,7 +80,7 @@ typedef struct _EFI_SECURITY2_ARCH_PROTOCOL EFI_SECU= RITY2_ARCH_PROTOCOL; > **/ >=20 > typedef EFI_STATUS (EFIAPI *EFI_SECURITY2_FILE_AUTHENTICATION) ( >=20 > IN CONST EFI_SECURITY2_ARCH_PROTOCOL *This, >=20 > - IN CONST EFI_DEVICE_PATH_PROTOCOL *DevicePath, >=20 > + IN CONST EFI_DEVICE_PATH_PROTOCOL *DevicePath, OPTIONAL >=20 > IN VOID *FileBuffer, >=20 > IN UINTN FileSize, >=20 > IN BOOLEAN BootPolicy >=20 > -- > 2.25.1.windows.1 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#57460): https://edk2.groups.io/g/devel/message/57460 > Mute This Topic: https://groups.io/mt/73050539/1759384 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming.gao@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D