From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.43134.1589812763026512276 for ; Mon, 18 May 2020 07:39:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=dWycNd8M; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: liming.gao@intel.com) IronPort-SDR: kh006et4HSZugxf2+EVmESSruJZmxVpUP9zToB6AFC8RuRr9Nb1Mrwk3zBpd5fJP+/0qDNH0Dy AQCdz+OfaQuw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2020 07:39:22 -0700 IronPort-SDR: 8XyRTWxBHNnwDujHyTy4sTX8k/hTumxbeu5vpfH2NprifSo7qetrrnV3SfMNEKHr4gFERNIZ6h v1AO3zfXtT1Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,407,1583222400"; d="scan'208,217";a="288596786" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 18 May 2020 07:39:22 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 May 2020 07:39:21 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 May 2020 07:39:21 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 May 2020 07:39:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dRDJAPzT1f3ehcNG/Qc3nS/523QVVkMkZ6f8KpXwGSFuWwCed/STCmwJ6YfXVcMDo5DagEWXR6F35QlG1jO7j4nT7m0Y9wRAWmWtgahw8eUiySkcnSY5UGQopkqkujNkZ+yScsYHroI1xT2mc7RXj82Gx2HKIMqkXGMBLhe6+7tTciEjGF5BwLA/jnoZhPtr6QWMmKZW+9IUEXCcMO7XF2TZ5CDEUba9AHSJdQ+xafKPx9dwkhc4g+//VBknpKd9S6UROPDBrVwB/a3c69Ow9ppHfvOwEzzAiPXuDFcsCqN4RTxFoNimd8XlF841FTPMf03WWqQpggQZrUwH3sAirA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y6yoMpa8wrICv4XM32i3g9BRUyjandiVr0f2bNUmQko=; b=fIXvCy+rDDBoltsVX1cNV0cxE6/5PMSAT9flkTSWM8pnnnzF24Fhd+pNs87AacVfsq/OUix6Q6ZXgD3L0HRRgp25Xo7ry3mD1+gbw0iOpvEBouCwILiL09XH5OmGdVnf+db2sG2O606jH/K1Yv6vlRwJkbpxruF+XvLRabf8dAxuRfKRoKm75MRpe2fGTspThhSyEMEd6p2QLZ9oRdONJEA6hHl7wm7iJ03oH70hv65IC+gwkFwMHVsxL/QaGDwChE/+tzn9orkzdASP7nqeNZW6PYyqNF/+nejKPVCLiJAQJyXxEwWAHVKtCSC50jp0alqJ9K8boZ8miD0xH+Ucxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y6yoMpa8wrICv4XM32i3g9BRUyjandiVr0f2bNUmQko=; b=dWycNd8M4kxBJ/PJ2RXfIMJxxaOBw0h6bKeQ8oEFjIbZSUSrMGmVPHL/9urCiE2itBZ0bb6xVEcKeX0QhEXODp5YMV7YEcuPvyeOaUyJhHnQQ3gc6PGwAtptE7gDBlz8PhBw1dWUc3Qo0q+sNgz0MEeq4VSfqCDpdaLFQS5589E= Received: from BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) by BN6PR11MB1267.namprd11.prod.outlook.com (2603:10b6:404:3d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Mon, 18 May 2020 14:39:19 +0000 Received: from BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0]) by BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0%7]) with mapi id 15.20.3000.034; Mon, 18 May 2020 14:39:19 +0000 From: "Liming Gao" To: Sami Mujawar , "devel@edk2.groups.io" , "Feng, Bob C" CC: Bret Barkelew , "leif@nuviainc.com" , Matteo Carlini , Laura Moretta , nd Subject: Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remove deprecated Visual Studio Option Thread-Topic: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remove deprecated Visual Studio Option Thread-Index: AQHWCeKOP+p0P1tkNUitjPfKIT88pKhtssCAgEBY0ICAACO3IA== Date: Mon, 18 May 2020 14:39:19 +0000 Message-ID: References: <20200403180547.26432-1-sami.mujawar@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-04-07T21:48:41.6769053Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.219] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ca94e2f8-6be2-4729-591a-08d7fb393fa5 x-ms-traffictypediagnostic: BN6PR11MB1267: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:862; x-forefront-prvs: 04073E895A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hA2WGAxx4CqW97cpMbwgYZuJj/GgyBXt8Mi6jA/SApJKFupMqF0WQqTsELGEZJtt5z+b+/6B7zeShnFjk71tRD0Vog8EQ6PW35sMAmZW2dh52kx8OxVPiQgUrWwEbVJj/vscH+bwxNY5tNQvW9R/ezSSwYjUw2VKxINUWCaaNVlQKKgoSBNQklI2ckohztrPOKwp6H7uxn1NE/nJ7sRNvT8e3adGgZ0KAdXc6dUob21QqAVU7onWOX5GJh6hJyBfnVj1e5RjF0cZzfkStU1N65xpnjMjERxYaDjZz6gzXSAVPaFghILZQQvcAH2LNjOU175VmyNLdkk/qwkuUiWU+ldAFLMoR0LHBdgL6mONXH9+2wiJQS8Sy7UiGMtPeIBuwWlBJIGSQyr4gAXPCsciQP9eD/yM9n1UtcMacwmkkZ7MyYsR2Fndp45SgMAYYnIRKjIgpE3IhkoVBw5ek7AWD/nOHc08VMOZhXX0iPdD3q/iT5CqO7PTC1M8ck6Fc3PKG3eiwkzAptqs0Q9N+G1C0N24v1TsWfSsSRoBcDdHMoCn5sQDMGTjm0r23TG/BPDrZWPHJ1tAx0yCxvjeaBo8YEafvW30S+CsGUiYI+5OBcY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3972.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(39860400002)(366004)(136003)(346002)(376002)(71200400001)(55016002)(966005)(26005)(8676002)(6506007)(53546011)(60390400001)(9686003)(76116006)(66946007)(66476007)(45080400002)(2906002)(33656002)(64756008)(66446008)(66556008)(478600001)(4326008)(52536014)(86362001)(5660300002)(7696005)(54906003)(110136005)(6636002)(316002)(8936002)(166002)(186003)(545624004)(460985005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: GmOHjAeXrRdnbbsy6yshKbJbmMTypYx/KcgHgappFUqHgqhmZl4gCUTL87WPLya8PQiwktSAcfdh8PhtstjJpIylMLd2pLw5MSKn677BDCUxYOGsEF9sl1dILFRp5gb8EDNA+TmtC1NtCvnl62uojBrvRRJntuIntN4kOkkMJJQu7u3zu3lPembVer0mtHVDAvVgKup+FCWnIr+QOyrvPqCV170PTiuZT9obWy+SqOiInHyDduzgw3l5MfRHVZMY3m/KN4HnyfrQxXJwLzDwEKTWqyBDSW1Mm9hkmiTL0rc4SKlNmzeAUf9LC/q3IbFZzVsfEuS5/0k6TPhk6Scsuj96LwSLWZTkufUPlLK16e1qfpyQ5C1NKZcL6PhlZslg2MlR6uR1mXjNrz1k2tc6bqjgYFjEQBSI3drj8usgEm3685oe0lBfRbJXrigsxOTFg2f4tPjHjyKDJl34Xx4mSay9YPgpWXqp126cK2gjLP5N34bcLUHXNk9TttB2SBfE MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ca94e2f8-6be2-4729-591a-08d7fb393fa5 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2020 14:39:19.5483 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h8E3LtHzkONWGeNFx39Lbz35pGyqypvjrZ0iqLAEVPlGRLjcNm2pPGyGXH7+P3Uc6sMRgMsxhiocL1d5Z1t8sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1267 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN6PR11MB3972D20152219BEE0A9928C180B80BN6PR11MB3972namp_" --_000_BN6PR11MB3972D20152219BEE0A9928C180B80BN6PR11MB3972namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sami: Sorry. I miss this patch. The change is good to me. Please create PR req= uest to verify the change. Seemly, the commit message it too long. Do you v= erify it by BaseTools\Scripts\PatchCheck.py? If the commit message passes RP, you can add my Reviewed-by: Liming Gao = Last, do you request to catch this change into edk2 stable tag 202005? Thanks Liming From: Sami Mujawar Sent: Monday, May 18, 2020 8:27 PM To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming = Cc: Bret Barkelew ; leif@nuviainc.com; Matteo= Carlini ; Laura Moretta ; n= d Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remove depr= ecated Visual Studio Option Hi Bob, Liming, Is there anything else needed before this patch can be merged? Regards, Sami Mujawar From: Bret Barkelew > Sent: 07 April 2020 10:49 PM To: devel@edk2.groups.io; Sami Mujawar > Cc: Sami Mujawar >; bob.= c.feng@intel.com; liming.gao@intel.com; leif@nuviainc.com; Matteo = Carlini >; Laura More= tta >; nd > Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remove depr= ecated Visual Studio Option Reviewed-by: Bret Barkelew > - Bret ________________________________ From: devel@edk2.groups.io > on behalf of Sami Mujawar via groups.io <= sami.mujawar=3Darm.com@groups.io> Sent: Friday, April 3, 2020 11:05:47 AM To: devel@edk2.groups.io > Cc: Sami Mujawar >; bob.= c.feng@intel.com >; liming.gao@intel.com <= liming.gao@intel.com>; leif@nuviainc.com >; Matteo.= Carlini@arm.com >; Laura.Moretta@arm.com >; nd@arm.com > Subject: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remove deprecat= ed Visual Studio Option The VS2017 compiler reports 'warning D9035 : option 'Gm' has been deprecated and will be removed in a future release' The documentation for the 'Gm' option at https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fdocs.m= icrosoft.com%2Fen-us%2Fcpp%2Fbuild%2Freference%2Fgm-enable-minimal-rebuild%= 3Fview%3Dvs-2019&data=3D02%7C01%7CBret.Barkelew%40microsoft.com%7C4a458= 8c4ee79488a3e5e08d7d7f9afc9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63= 7215339711617971&sdata=3DUl9UkaXpfC1o5SNP3FwuHGjkldZjh879tM2nsHqKzRU%3D= &reserved=3D0 indicates that this option can be safely removed from the project. Therefore, remove the deprecated 'Gm' Visual Studio Compiler option. Ref: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fb= ugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2660&data=3D02%7C01%7CBret.= Barkelew%40microsoft.com%7C4a4588c4ee79488a3e5e08d7d7f9afc9%7C72f988bf86f14= 1af91ab2d7cd011db47%7C1%7C0%7C637215339711617971&sdata=3DRi2yVGQs2JcNvZ= U0bMZ6FhZEWhkN8Jj6oR14%2F3oXYow%3D&reserved=3D0 Signed-off-by: Sami Mujawar > --- The changes can be seen at: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub= .com%2Fsamimujawar%2Fedk2%2Ftree%2F703_vs2017_deprecated_option_v1&data= = =3D02%7C01%7CBret.Barkelew%40microsoft.com%7C4a4588c4ee79488a3e5e08d7d7f9a= fc9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637215339711617971&sda= ta=3DV%2B9F3QrpY3tX%2B%2BChPK02wOZC0XizIRJI74LLqr9Lw54%3D&reserved=3D0 Notes: V1: - Remove deprecated VS2017 and VS2019 option [SAMI] BaseTools/Conf/tools_def.template | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.= template index 2b17d3b2979a83144444b4d543b383af3198cdd0..67368f5013519a2d7397cbc975= 6acb6ff152727a 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -1,7 +1,7 @@ # # Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
# Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved. -# Portions copyright (c) 2011 - 2014, ARM Ltd. All rights reserved.
+# Portions copyright (c) 2011 - 2019, ARM Ltd. All rights reserved.
# Copyright (c) 2015, Hewlett-Packard Development Company, L.P.
# (C) Copyright 2016 Hewlett Packard Enterprise Development LP
# Copyright (c) Microsoft Corporation @@ -1682,9 +1682,9 @@ NOOPT_VS2017_X64_DLINK_FLAGS =3D /NOLOGO /NODEFAU= LTLIB /IGNORE:4001 /IGNORE:428 *_VS2017_ARM_ASLDLINK_PATH =3D DEF(VS2017_BIN_ARM)\link.exe *_VS2017_ARM_MAKE_FLAGS =3D /nologo - DEBUG_VS2017_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm /Gw /Oi- + DEBUG_VS2017_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gw /Oi- RELEASE_VS2017_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gw /Oi- -NOOPT_VS2017_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm /Od /Oi- +NOOPT_VS2017_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Od /Oi- DEBUG_VS2017_ARM_ASM_FLAGS =3D /nologo /g RELEASE_VS2017_ARM_ASM_FLAGS =3D /nologo @@ -1709,9 +1709,9 @@ NOOPT_VS2017_ARM_DLINK_FLAGS =3D /NOLOGO /NODEF= AULTLIB /IGNORE:4001 /OPT:REF *_VS2017_AARCH64_ASLDLINK_PATH =3D DEF(VS2017_BIN_AARCH64)\link.exe *_VS2017_AARCH64_MAKE_FLAGS =3D /nologo - DEBUG_VS2017_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm /Gw /Oi- + DEBUG_VS2017_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gw /Oi- RELEASE_VS2017_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gw /Oi- -NOOPT_VS2017_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm /Od /Oi- +NOOPT_VS2017_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Od /Oi- DEBUG_VS2017_AARCH64_ASM_FLAGS =3D /nologo /g RELEASE_VS2017_AARCH64_ASM_FLAGS =3D /nologo @@ -1845,9 +1845,9 @@ NOOPT_VS2019_X64_DLINK_FLAGS =3D /NOLOGO /NODEFAU= LTLIB /IGNORE:4001 /IGNORE:428 *_VS2019_ARM_ASLDLINK_PATH =3D DEF(VS2019_BIN_ARM)\link.exe *_VS2019_ARM_MAKE_FLAGS =3D /nologo - DEBUG_VS2019_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm /Gw /Oi- + DEBUG_VS2019_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gw /Oi- RELEASE_VS2019_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gw /Oi- -NOOPT_VS2019_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm /Od /Oi- +NOOPT_VS2019_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Od /Oi- DEBUG_VS2019_ARM_ASM_FLAGS =3D /nologo /g RELEASE_VS2019_ARM_ASM_FLAGS =3D /nologo @@ -1872,9 +1872,9 @@ NOOPT_VS2019_ARM_DLINK_FLAGS =3D /NOLOGO /NODEF= AULTLIB /IGNORE:4001 /OPT:REF *_VS2019_AARCH64_ASLDLINK_PATH =3D DEF(VS2019_BIN_AARCH64)\link.exe *_VS2019_AARCH64_MAKE_FLAGS =3D /nologo - DEBUG_VS2019_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm /Gw /Oi- + DEBUG_VS2019_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gw /Oi- RELEASE_VS2019_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gw /Oi- -NOOPT_VS2019_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm /Od /Oi- +NOOPT_VS2019_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Od /Oi- DEBUG_VS2019_AARCH64_ASM_FLAGS =3D /nologo /g RELEASE_VS2019_AARCH64_ASM_FLAGS =3D /nologo -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' --_000_BN6PR11MB3972D20152219BEE0A9928C180B80BN6PR11MB3972namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Sami:

  Sorry. I miss this patch. The change is good= to me. Please create PR request to verify the change. Seemly, the commit m= essage it too long. Do you verify it by BaseTools\Scripts\PatchCheck.py?

 

  If the commit message passes RP, you ca= n add my Reviewed-by: Liming Gao <liming.gao@intel.com>

 

  Last, do you request to catch this change in= to edk2 stable tag 202005?

 

Thanks

Liming

From: Sami Mujawar <Sami.Mujawar@arm.com&= gt;
Sent: Monday, May 18, 2020 8:27 PM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>;= Gao, Liming <liming.gao@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; leif@nuviain= c.com; Matteo Carlini <Matteo.Carlini@arm.com>; Laura Moretta <Lau= ra.Moretta@arm.com>; nd <nd@arm.com>
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remo= ve deprecated Visual Studio Option

 

Hi Bob, Liming,

 

Is there anything else needed before this patch can be merged?<= /o:p>

 

Regards,

 

Sami Mujawar

 

From: Bret Barkelew <Bret.Barkelew@microsoft.com>
Sent: 07 April 2020 10:49 PM
To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@ar= m.com>
Cc: Sami Mujawar <Sami.M= ujawar@arm.com>; bob.c.feng@intel.com; liming.gao@intel.com; leif@nuviai= nc.com; Matteo Carlini <Ma= tteo.Carlini@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; nd <nd@arm.com>
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remo= ve deprecated Visual Studio Option

 

Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>

 

- Bret

 

From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf o= f Sami Mujawar via groups.io <sami.mujawar=3Darm.com@groups.io>
Sent: Friday, April 3, 2020 11:05:47 AM
To: devel@edk2.groups.io <devel@edk2.groups.io><= br> Cc: Sami Mujawar <sami.m= ujawar@arm.com>; bob.c.feng@intel.com <bob.c.feng@intel.com>; liming.gao@intel.com <liming.gao@intel.com>; leif@nuviainc.com <leif@nuviainc.com>; Matteo.Carlini@arm.com <<= a href=3D"mailto:Matteo.Carlini@arm.com">Matteo.Carlini@arm.com>; Laura.Moretta@arm.com <Laura.Moretta@arm.com>; nd@arm.com <nd@arm.com>
Subject: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remove d= eprecated Visual Studio Option

 

The VS2017 compiler = reports 'warning D9035 : option
'Gm' has been deprecated and will be removed in a
future release'

The documentation for the 'Gm' option at
https://nam06.safelinks.protectio= n.outlook.com/?url=3Dhttps%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fcpp%2Fbuild= %2Freference%2Fgm-enable-minimal-rebuild%3Fview%3Dvs-2019&amp;data=3D02= %7C01%7CBret.Barkelew%40microsoft.com%7C4a4588c4ee79488a3e5e08d7d7f9afc9%7C= 72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637215339711617971&amp;sdata= = =3DUl9UkaXpfC1o5SNP3FwuHGjkldZjh879tM2nsHqKzRU%3D&amp;reserved=3D0=
indicates that this option can be safely removed
from the project.

Therefore, remove the deprecated 'Gm' Visual Studio
Compiler option.

Ref: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzil= la.tianocore.org%2Fshow_bug.cgi%3Fid%3D2660&amp;data=3D02%7C01%7CBret.B= arkelew%40microsoft.com%7C4a4588c4ee79488a3e5e08d7d7f9afc9%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637215339711617971&amp;sdata=3DRi2yVGQs2Jc= NvZU0bMZ6FhZEWhkN8Jj6oR14%2F3oXYow%3D&amp;reserved=3D0

Signed-off-by: Sami Mujawar <sa= mi.mujawar@arm.com>
---

The changes can be seen at:
https://nam06.safelinks.protection.outlook.com/?url= =3Dhttps%3A%2F%2Fgithub.com%2Fsamimujawar%2Fedk2%2Ftree%2F703_vs2017_depre= cated_option_v1&amp;data=3D02%7C01%7CBret.Barkelew%40microsoft.com%7C4a= 4588c4ee79488a3e5e08d7d7f9afc9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7= C637215339711617971&amp;sdata=3DV%2B9F3QrpY3tX%2B%2BChPK02wOZC0XizIRJI7= 4LLqr9Lw54%3D&amp;reserved=3D0

Notes:
    V1:
    - Remove deprecated VS2017 and VS2019 option  = ;            &n= bsp;     [SAMI]

 BaseTools/Conf/tools_def.template | 18 ++++++= ;+++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.= template
index 2b17d3b2979a83144444b4d543b383af3198cdd0..67368f5013519a2d7397cbc975= 6acb6ff152727a 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -1,7 +1,7 @@
 #
 #  Copyright (c) 2006 - 2018, Intel Corporation. All rights res= erved.<BR>
 #  Portions copyright (c) 2008 - 2009, Apple Inc. All rights re= served.<BR>
-#  Portions copyright (c) 2011 - 2014, ARM Ltd. All rights reserved.= <BR>
+#  Portions copyright (c) 2011 - 2019, ARM Ltd. All rights reser= ved.<BR>
 #  Copyright (c) 2015, Hewlett-Packard Development Company, L.P= .<BR>
 #  (C) Copyright 2016 Hewlett Packard Enterprise Development LP= <BR>
 #  Copyright (c) Microsoft Corporation
@@ -1682,9 +1682,9 @@ NOOPT_VS2017_X64_DLINK_FLAGS    = =3D /NOLOGO /NODEFAULTLIB /IGNORE:4001 /IGNORE:428
 *_VS2017_ARM_ASLDLINK_PATH       = =3D DEF(VS2017_BIN_ARM)\link.exe
 
       *_VS2017_ARM_MAKE_FLAGS  &n= bsp;  =3D /nologo
-  DEBUG_VS2017_ARM_CC_FLAGS       =3D = /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- = /GR- /GF /Gy /Zi /Gm /Gw /Oi-
+  DEBUG_VS2017_ARM_CC_FLAGS       = = =3D /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EH= s-c- /GR- /GF /Gy /Zi /Gw /Oi-
 RELEASE_VS2017_ARM_CC_FLAGS       =3D = /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- = /GR- /GF /Gw /Oi-
-NOOPT_VS2017_ARM_CC_FLAGS        = =3D /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /FIAutoGen.h /EHs-c- /GR- = /GF /Gy /Zi /Gm /Od /Oi-
+NOOPT_VS2017_ARM_CC_FLAGS       &n= bsp; =3D /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /FIAutoGen.h /EHs-c- /= GR- /GF /Gy /Zi /Od /Oi-
 
   DEBUG_VS2017_ARM_ASM_FLAGS      =3D = /nologo /g
 RELEASE_VS2017_ARM_ASM_FLAGS      =3D /nolo= go
@@ -1709,9 +1709,9 @@ NOOPT_VS2017_ARM_DLINK_FLAGS   &n= bsp;  =3D /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF
 *_VS2017_AARCH64_ASLDLINK_PATH     =3D DEF(VS201= 7_BIN_AARCH64)\link.exe
 
       *_VS2017_AARCH64_MAKE_FLAGS  =3D= /nologo
-  DEBUG_VS2017_AARCH64_CC_FLAGS    =3D /nologo /c /WX= /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /= Zi /Gm /Gw /Oi-
+  DEBUG_VS2017_AARCH64_CC_FLAGS    =3D /nologo /c= /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /= Gy /Zi /Gw /Oi-
 RELEASE_VS2017_AARCH64_CC_FLAGS    =3D /nologo /c /WX= /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gw /= Oi-
-NOOPT_VS2017_AARCH64_CC_FLAGS      =3D /nologo /= c /WX /GS- /W4 /Gs32768 /D UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /G= m /Od /Oi-
+NOOPT_VS2017_AARCH64_CC_FLAGS      =3D /nolo= go /c /WX /GS- /W4 /Gs32768 /D UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Z= i /Od /Oi-
 
   DEBUG_VS2017_AARCH64_ASM_FLAGS   =3D /nologo /g
 RELEASE_VS2017_AARCH64_ASM_FLAGS   =3D /nologo
@@ -1845,9 +1845,9 @@ NOOPT_VS2019_X64_DLINK_FLAGS    = =3D /NOLOGO /NODEFAULTLIB /IGNORE:4001 /IGNORE:428
 *_VS2019_ARM_ASLDLINK_PATH       = =3D DEF(VS2019_BIN_ARM)\link.exe
 
       *_VS2019_ARM_MAKE_FLAGS  &n= bsp;  =3D /nologo
-  DEBUG_VS2019_ARM_CC_FLAGS       =3D = /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- = /GR- /GF /Gy /Zi /Gm /Gw /Oi-
+  DEBUG_VS2019_ARM_CC_FLAGS       = = =3D /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EH= s-c- /GR- /GF /Gy /Zi /Gw /Oi-
 RELEASE_VS2019_ARM_CC_FLAGS       =3D = /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- = /GR- /GF /Gw /Oi-
-NOOPT_VS2019_ARM_CC_FLAGS        = =3D /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /FIAutoGen.h /EHs-c- /GR- = /GF /Gy /Zi /Gm /Od /Oi-
+NOOPT_VS2019_ARM_CC_FLAGS       &n= bsp; =3D /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /FIAutoGen.h /EHs-c- /= GR- /GF /Gy /Zi /Od /Oi-
 
   DEBUG_VS2019_ARM_ASM_FLAGS      =3D = /nologo /g
 RELEASE_VS2019_ARM_ASM_FLAGS      =3D /nolo= go
@@ -1872,9 +1872,9 @@ NOOPT_VS2019_ARM_DLINK_FLAGS   &n= bsp;  =3D /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF
 *_VS2019_AARCH64_ASLDLINK_PATH     =3D DEF(VS201= 9_BIN_AARCH64)\link.exe
 
       *_VS2019_AARCH64_MAKE_FLAGS  =3D= /nologo
-  DEBUG_VS2019_AARCH64_CC_FLAGS    =3D /nologo /c /WX= /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /= Zi /Gm /Gw /Oi-
+  DEBUG_VS2019_AARCH64_CC_FLAGS    =3D /nologo /c= /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /= Gy /Zi /Gw /Oi-
 RELEASE_VS2019_AARCH64_CC_FLAGS    =3D /nologo /c /WX= /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gw /= Oi-
-NOOPT_VS2019_AARCH64_CC_FLAGS      =3D /nologo /= c /WX /GS- /W4 /Gs32768 /D UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /G= m /Od /Oi-
+NOOPT_VS2019_AARCH64_CC_FLAGS      =3D /nolo= go /c /WX /GS- /W4 /Gs32768 /D UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Z= i /Od /Oi-
 
   DEBUG_VS2019_AARCH64_ASM_FLAGS   =3D /nologo /g
 RELEASE_VS2019_AARCH64_ASM_FLAGS   =3D /nologo
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


--_000_BN6PR11MB3972D20152219BEE0A9928C180B80BN6PR11MB3972namp_--