From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.6280.1589244712926923627 for ; Mon, 11 May 2020 17:51:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=G2bNp2+B; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: liming.gao@intel.com) IronPort-SDR: KGI13eoUaGyTYFrry4bzeWLWtK+ipOZliFSRS6z154KVzAF5EQntEZhTVVXCVWyGq4HQIfvt2a zfOiSn8z4tDg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 17:51:52 -0700 IronPort-SDR: 1/iFOqJneTKsHTNDAZkoNWCluT8bZIijXQRXpduBV3m7q+ydKvvbfdK6roFAy8nKrPk/z9Blo1 1E69Dpwa/xmg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,381,1583222400"; d="scan'208";a="340723521" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 11 May 2020 17:51:51 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 17:51:50 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 11 May 2020 17:51:47 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 11 May 2020 17:51:47 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 17:51:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RqFYd8acQ9THEZGv6wFisoQE5PZb3BKcCGttjB04Psj/TU4iMxgwlEF371Ce/lCnHWwMhjWxF2qumSUEs+XgFB8cC9pVlS6MIKPG9GMmzPgbH4QAPwWz7uwV4LhYX1Huc+/KUTEECwB/3tVDxow6xBXbAoPFAOD1qcLiVyz6WO/i2En1taMbQ4HskPamiRGuVrTrZ6KfGizWr/zQM70s1UdCTqp2TcDei35u8r/3U+zPCXcCRCwBkjmODo5RLDb5N1pq8gdhUY9TlKAJ1codJAB1WCDAt0MmSzCyBQZyhDI+/xb6SD5lll2Ke3tPD6c2TfN5kcMpbX4J4QSaDqp5zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BLdekfxRGcG2Q06lNE73KUkGLBqCxzS0liM4Q6qfxMQ=; b=ldPhK1cWynNBiBWp1K279E4F6y/e7kCMJmgsZpyDj8N9JsCUdZuLs1J4ZenDtmSrEk9h3Q93pY56DjOCu6G99M/rtSDZryOBAk+C5hTwG4O140taaERZ5w+UXU0s3ZTSZQUNgfQv9cSd+W63MrClXCvIjJAPdKejb1I2sXuX6hLaJxl21nu2WN/7zKiRYOwzm6P6HJUzH+G7GGYm0+rsChQiZJFZAtOOlFlopAu6xL4XuxOKXjo/nAzId9kGo7UQYUTr51wljE27okTmI2UEqkoCmhbcpEkR+QujkrehMaWVRXgez4+6Io+LRByJJadtAgVdUbShlTBbaCq+TxWL5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BLdekfxRGcG2Q06lNE73KUkGLBqCxzS0liM4Q6qfxMQ=; b=G2bNp2+BZ1sKyfbpUbiPgX3d4bIi8o0B2pU70qvhOIlbLqP75dL8eufM2k6tV5YaGzA30/msOllhKoEZ0GtDv1aSYFznoKCVG50fRZEFXdtN7xBSpAYEmoBU5bCcnZInVrR4nKtpRtSHJrQy4Xa+xn1PAwIejTbo38v5YoC06Mw= Received: from BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) by BN6PR11MB3876.namprd11.prod.outlook.com (2603:10b6:405:77::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.33; Tue, 12 May 2020 00:51:44 +0000 Received: from BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0]) by BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0%7]) with mapi id 15.20.2979.033; Tue, 12 May 2020 00:51:44 +0000 From: "Liming Gao" To: "devel@edk2.groups.io" , "oleksiyy@ami.com" CC: "Feng, Bob C" , "Kinney, Michael D" , "Felixp@ami.com" Subject: Re: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Topic: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Thread-Index: AQHWJ9GfJiEkhVI+TUajoXAebfY/J6ijnnnw Date: Tue, 12 May 2020 00:51:44 +0000 Message-ID: References: <20200511201923.67744-1-oleksiyy@ami.com> <20200511201923.67744-2-oleksiyy@ami.com> In-Reply-To: <20200511201923.67744-2-oleksiyy@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 441aec3e-0d1e-4e71-1373-08d7f60ea44f x-ms-traffictypediagnostic: BN6PR11MB3876: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0401647B7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tsgGhT7HbYP9jhTMDOUuUMUz4j1LXbLnniNehOZ3LaXJ8pdpZG1b77R6jtmhOTO3M8OYUdQxTYm+tPWxJBnOATjyV/jNSwOgJAbCYt9qydauPN5SHn1dfs+6I+0/SHlmKb+YQZcycj+1GjUtND0XmoVlR7lIB0yBRR8dBCsitNn/7Da9dpLY/FsgReuF+v9nDjDca3hc2ToJh+RIBPJtY1H3mhQgq7AJL+bWsH4EyiBo+IQ42MwJqF09tSQLOm8Hylk4St7EJk4519D6OwYaiog/DQWxVCbo8ibYLzgK2b2ZvqSYP0Mnzsn55QmPjinJPpBoziRQfMz3ZgENzT7trOsSy9f7g5clrVFNZHNVtxjfFlSyYAeEcOATHyPQB9KJfkkO/EdKg6xtfw/kAoStjAI+AUDTBkE1w052vMoR5M8DDvaxpHRvzssm0h6Cebr6yh9Tu2DcIz+oUTjU4dnORMhUgph4qpq3e4tKfYdED0j2cRkyM5TzMbCzM7bS6GeIxdopgMeAETzvOAcunPkMDwuDW48C/Q+gnIiv4UjPkhPANf5FpBElQR1532RZmPQp9uZIFtq9A14xpa9+tnhqgD3ICE7OPzOsaeiB4Jp/FP4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3972.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(366004)(376002)(346002)(39860400002)(396003)(33430700001)(5660300002)(33440700001)(8936002)(4326008)(55016002)(9686003)(7696005)(71200400001)(966005)(33656002)(478600001)(86362001)(54906003)(8676002)(2906002)(66946007)(186003)(66476007)(64756008)(66446008)(53546011)(76116006)(26005)(6506007)(66556008)(316002)(110136005)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: GPa/H7O8m3d3x2S645OYpCWcYs+DsgfUzoed79WRX9omLf78azXhW121DjMJdCAvYgWndGSpf13ixj1V8XDAOl7JFviTnHs+rCfBOWhVERhDWQFtwllKa8KRGu7lNByM7Y/Zm5n5sXxXPdoA/fb2n9UiStNtgyuYlN05Sxv3Knld9FStiBi/Nazo+MbLcZWf8ZhzE4asN66o7o11B3JTCBZLqqJAE3+l2WutKbPscPzN44q1M9zmwicz2/7y2JKoigkZwGDrNw6QFshv31YT3Qi4kTmkMOmRxuS2veURXfY1OC8S+Mtkvk1px8/B3/3BW+LurIdwKTF9UU/8wjRAhDLuzt1WB89VBoRBkK0cAV/j8mMT3DMF0CqXnl0ZBAdotRHbCQvrS/MCw2IQIy0theXRDKqO7z1WYgK82XJdUaOaAhGHOTJY6Z+Z3eblqLY6nMuCTNHJgDwPPrhZSen+gZxoISeJ1wk4Odo4Rz4opZhElaLHChSXZv+D3eTrCpCc MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 441aec3e-0d1e-4e71-1373-08d7f60ea44f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2020 00:51:44.1086 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WXKxgJQS4upRhlpPp9ExSa0XOeAE3cTXmLJoHtsEpIN5CRY7l6oamiWeG8pzKHNILtfSWcAJVA3SqC6rzl1SWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3876 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Oleksiy: Seemly, this patch doesn't response to my comment. Is there the comments= to be added for new field DeviceTypeGuid? Can its value be NULL? And, are = MdeModulePkg\Universal\SerialDxe and MdeModulePkg\Bus\Pci\PciSioSerialDxe r= equired to be updated together?=20 Thanks Liming -----Original Message----- From: devel@edk2.groups.io On Behalf Of Oleksiy Yak= ovlev Sent: 2020=1B$BG/=1B(B5=1B$B7n=1B(B12=1B$BF|=1B(B 4:19 To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming = ; Kinney, Michael D ; Felixp@ami.com; oleksiyy@= ami.com Subject: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceT= ypeGuid EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001. CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure. UEFI 2.8 mantis 1832. Signed-off-by: Oleksiy Yakovlev Reviewed-by: Liming Gao --- MdePkg/Include/Protocol/SerialIo.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Protocol/SerialIo.h b/MdePkg/Include/Protocol/= SerialIo.h index 51eaa53..b2398c2 100644 --- a/MdePkg/Include/Protocol/SerialIo.h +++ b/MdePkg/Include/Protocol/SerialIo.h @@ -262,7 +262,7 @@ typedef struct { UINT32 StopBits; } EFI_SERIAL_IO_MODE; =20 -#define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010000 +#define EFI_SERIAL_IO_PROTOCOL_REVISION 0x00010001 #define SERIAL_IO_INTERFACE_REVISION EFI_SERIAL_IO_PROTOCOL_REVISION =20 /// @@ -287,6 +287,7 @@ struct _EFI_SERIAL_IO_PROTOCOL { /// Pointer to SERIAL_IO_MODE data. /// EFI_SERIAL_IO_MODE *Mode; + CONST EFI_GUID *DeviceTypeGuid; // Revision 1.1 }; =20 extern EFI_GUID gEfiSerialIoProtocolGuid; --=20 2.9.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on.