From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.7795.1589518604303144518 for ; Thu, 14 May 2020 21:56:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=iv0HsgTR; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: liming.gao@intel.com) IronPort-SDR: k6nbZ4VL4H0uAxcHja0Iif2g06rnEvYl4U0Cqkz/oPDLS/AP4PYc6g+5GjvuCbz5uwh0Vekjr7 TdV2u2TFAMzg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2020 21:56:42 -0700 IronPort-SDR: nZunVWYlVUeNhW6cHQczNDOgbSHAGNQjTZ/B2ccdl+E5qhWCJ71tUsQvDtTC7a+ZmXU9LsBRyY rRGEOJ3QnESw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,394,1583222400"; d="scan'208";a="341860629" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 14 May 2020 21:56:42 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 May 2020 21:56:41 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 May 2020 21:56:41 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 May 2020 21:56:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f3/v68MJPqns2uuo3KMRqfAOjLFXDccHA98ASFwx3f9xt7U8QiRPxQIcO2H1uiF8kNOqa7bjlZwiQ+OvHG28Jdq7/ajze9e+HLx8RxFnDC1SulDCHi+vYw8Inc8Pk8cP4RSwBa5VuwcmKgb+ze5pXjavtqaew1fPKwmsXIowhGrjbmlxwa3Zyiwrhs23jLp8iLPAbPj8AVWBVb6BH78YKLu4eEXA7VQ0Z/TSd9eyQJivUgI/Bj/FstyFBA8asP/FHscH4Fv7LngJm8GnFdc60RjnOgPOQ5Cx4C+WaLxJsoqOlHKWm7vs3psQBxk0Hb3saxchcPg+sMRdYMUgteiuDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3RetKOaNPHptbvy1YT5Edzhe2i30yn/xdsopfd3t3WA=; b=S8WJkLLc93w0tclmKJ+uBZ0/7bFHJO5lNBkQyf7ucVMR2m8vXfLHl38MByNpbZw1i6uruT/sHrzT0BHUXFvbYidym8xfABLFqoM9Z/IhFgjb3ZQdIq4OCstYg7UVvgx47P6iCLon9AG4omntWSfu65t4c4iNA5WJ4PL+0lLn7JERMIcvmhN4vp7g0CzMAGmaGnQKHm3VmIRuBTQQ+EHq668l6+Ej+dieOdk8vOkswoweFNYYLqkh0TDCTrFbLlmA+VU+rrSHKVXr3DcWDbi3iWUYoson/Ky9pkkxqxY4ZerMhnaIIXOtmQBYmWpuA2lN3r6aciVKVEK7KFgmwXS48A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3RetKOaNPHptbvy1YT5Edzhe2i30yn/xdsopfd3t3WA=; b=iv0HsgTRKWGKiJ5iSvoXl4LKc7O5hN6R4pYP/i8Ly9/GJuheYwpr8fn4wy/ca8+3FNnr5YeFC01BbE4GdNlW0SPDgf17SqaDStDTFqs4tZbTC7kNZuqDg0c1L2452ToRly5Qf+zwna4pCokLJ2khvsMsXsSjNnPKCWspPtqPfwU= Received: from BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) by BN6PR11MB3954.namprd11.prod.outlook.com (2603:10b6:405:79::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Fri, 15 May 2020 04:56:39 +0000 Received: from BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0]) by BN6PR11MB3972.namprd11.prod.outlook.com ([fe80::3c03:da06:5345:bfa0%7]) with mapi id 15.20.3000.022; Fri, 15 May 2020 04:56:39 +0000 From: "Liming Gao" To: "Ni, Ray" , "devel@edk2.groups.io" , "oleksiyy@ami.com" CC: "Kinney, Michael D" , "Felixp@ami.com" , "robert@ami.com" Subject: Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol Thread-Topic: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol Thread-Index: AQHWJKJ4SI133BIPGEunZcXvbxoad6iiWOoAgAZHAAA= Date: Fri, 15 May 2020 04:56:38 +0000 Message-ID: References: <20200507190310.38968-1-oleksiyy@ami.com> <20200507190310.38968-6-oleksiyy@ami.com> <734D49CCEBEEF84792F5B80ED585239D5C5356E7@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C5356E7@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.207] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cf7a3222-5269-44cd-5efd-08d7f88c5a5e x-ms-traffictypediagnostic: BN6PR11MB3954: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:913; x-forefront-prvs: 04041A2886 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yt+Sdctk2LFxiSn7GSLMoOcfTDoNqSl3/kyrsIr2zF/jTvO4slyGFsXNP9ZMi7YOeylUngA/OwXOqVh6D9cqq9MKhkjNL0ZEJh+jWeXYzG3UgmlxxOS4Ip3/6ky3jfrf4Pq5wGYJgOL0L+NlEVEhs6L0tnD5qcZhFndF1Mnht9LPapVblq2pqAVGnXEee7g9Jz2uSqZx6Kpn5D6yOpnL0udwTg4r81GhmBMjI+lQqxIPWlZR9C/3FwAiPbSnTE8kQ18UVVqYUiaASgTjRN6qapcW0NxD1lv7ajVJYwk6SnzmAzn0POmyYmRuDuF0hVaV9xUZiuyMp6Rcgab8dwdwSK3jrxXV3r15SLUtDTQTmqLOit6XlZGEH6MjBGFl4OoMtXEo7Na08FyW1Heum4H4FynnbS2QiwU5JyhTrTcPbx1tlXo9YvsCFBndU4wE2ZlkklH2rbkZa+lB1uxKzNt9vWjtUwVD7C2E3SV9gqnwnc6zA3uuvAcFB0hCITavxOlhBmzxcPeI6ojJSFmRHsaxlw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB3972.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(346002)(39860400002)(366004)(136003)(376002)(396003)(5660300002)(478600001)(6506007)(66556008)(76116006)(8936002)(15650500001)(55016002)(8676002)(2906002)(66946007)(86362001)(4326008)(9686003)(966005)(186003)(66476007)(7696005)(33656002)(52536014)(66446008)(110136005)(54906003)(26005)(53546011)(316002)(64756008)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: hkKwgdtEo9TjjjyjgxxnQMese5HrRvEpNsliT4oMDCklY4GhXXoa1W3dkYnRiCStmUW8kYlqK+Jo8wL0fzDMnKhFpFodBfEuigBBO5a2iMOT7ksG5vtvlLfzILkkprODec1Xgfzk3pbSAv23glxIoe+p2THFabrgqn4iNpVnCp3V3dyRKJhihUzJB/olsjj64zSaymMAZyUvbLPUYtvF6X1C5oB1taUMSuo+bN8//IdabWt/4dFmYTIAWSDvmYnbfuZh8z0pYns4g2eS4gV6xZt8edOAJPEcjv3SDwZwLmnL+CMmvDzFhchl2TeKvb3c2A4VEPFmYpNerYvUnRxAsw458ZeAOq5ayZr0HFoi9GJhSBOOw0VlRzghgzmvMSZ6Jn+FtkEyU3eUcHyqMaa5uMvTypI67Ym49XKGzP3K2JZ0mLF1EgwNrazXbEfa0f9Cf/x6K7FEIxcTHliqCZs8CETVbzKRlPCArSBwqAnZieb6ZJs6lFje93KaWdbV/P+B MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: cf7a3222-5269-44cd-5efd-08d7f88c5a5e X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2020 04:56:38.8170 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AnJjsSOU/IlpfyNc0LsIj/id0zndr+uMyzi6yH9vEeGcJ8JMycwdPXOL1ev51D+lzadtz3kOTd1KO47Gp0QuHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3954 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ray: I see https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0= fd101b2ad706575f82e2fc also includes the code change in UefiCpuPkg/Library/= MpInitLib/MpLib.c. The change has passed review.=20 Can you send the separate patch for the change in UefiCpuPkg?=20 Thanks Liming > -----Original Message----- > From: Ni, Ray > Sent: Monday, May 11, 2020 1:01 PM > To: devel@edk2.groups.io; oleksiyy@ami.com > Cc: Gao, Liming ; Kinney, Michael D ; Felixp@ami.com; robert@ami.com > Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpSer= vices Protocol >=20 > Robert, > I did similar change to MpService.h in > https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd101b= 2ad706575f82e2fc. >=20 > My plan was to move the change to edk2 once the spec is published. > It seems your change doesn't conflict with my change. More comments are a= dded in your change > which I think is better than mine. >=20 > A minor comment to the comment in below. >=20 > > + > > +/// Location2 The 6-level physical location of the processor, includ= ing the > > +/// physical package number that identifies the cartridge, the phy= sical > > +/// module number within package, the physical tile number within = the > > module, > > +/// the physical die number within the tile, the physical core num= ber within > > +/// package, and logical thread number within core. >=20 > Can you move the above comment to the line before "Location2" field and r= emove > the "Location2 "? It aligns to existing comments style. >=20 > > +typedef union { > > + EFI_CPU_PHYSICAL_LOCATION2 Location2; > > +} EXTENDED_PROCESSOR_INFORMATION; > > + > > + >=20 > With that, Reviewed-by: Ray Ni >=20