From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 55F7EAC0C45 for ; Thu, 7 Sep 2023 09:41:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=EC21JSrvt4FXFSe/XwhP25TL3c/fWCJcRBUTPxLFNrM=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694079665; v=1; b=dnkFlVAUuahBRV/zp6gWs3fxqVllkzQkiKxB5hnyM4EaYyNIftDHcr+MJUiufZXsCvjK03rI 6f75Qh2KdS5UOsVLMB4yO9ZuVRzraxo8DBytLYx0d0wQPtYrIMrsFvgkPhiLu2PCHRNbjwDRRPs KmumphQ4ETBcVRm8O89UKxBM= X-Received: by 127.0.0.2 with SMTP id HLTjYY7687511x1YMLPrSmzc; Thu, 07 Sep 2023 02:41:05 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.9252.1694079663773404576 for ; Thu, 07 Sep 2023 02:41:04 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10825"; a="408310556" X-IronPort-AV: E=Sophos;i="6.02,234,1688454000"; d="scan'208";a="408310556" X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 02:41:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10825"; a="885090432" X-IronPort-AV: E=Sophos;i="6.02,234,1688454000"; d="scan'208";a="885090432" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Sep 2023 02:40:49 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 7 Sep 2023 02:41:01 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Thu, 7 Sep 2023 02:41:01 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 7 Sep 2023 02:41:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ay/0COa/3dgqPpcHXhKg+DgizVqv2z7e1fLVy26Jt/ynimUMup1aZ6Mt0xvCzoJEPZgkjdl+B756uHKhNpL2nVYOF7dnrdZiDsNvHcVbrZY2i4KuRVKsLfh08tJT+z4zMCqkPeZtquWzQYFAH8TExBpREEgpGWf3Zj7sM2RlSbTKNvTRFIx3oiwl8LXvu3uFOy4yOMzA+pknAlrp/7V8b6qlR5tPpTC7yEPgDL1DbfHAUlAC61d8QV1LK1KFV2GWR80D2onFhtGQ14LYVfI/4WOAcbhxlsuhTOlcFly9ngUJVdvMtSsaOZ+SPw1GFsF/fMFwA6GE72d578fyQNRwmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IjewZYInF6s6E0oi7wCWOYUAlDBeRmy7UuHdv3ckmJQ=; b=JZnBQsAPZp0iFLbNoZN8KVljIPDKFhXVoK5NDvkCejeuGBREpBu6hViX86VrD4JClaDz1bBSgpqbJ4kRuKy+yGL1VamNskalKDje2BTEXzh5qxB4ZcgVGYVPvAQy6C1m3pBYpKlZxM47dSBzEuPg+Kz4p5DKUaYBuO9fo8bM5/wLxIH36AYpMqYpZrRlThftuW/eSdPFvUACtWETChwRiXGzpsjMwHyILUKhrDErjc/Dln03vJdGDDRMVazUC5WHtHCwRVSMo2JQLGNaq+BQJUt0bZmLxdNuNd4jad06fva0yxXE8eLj0jMZdwde9F+kh/zPBO5lEqoQRLm7WUoAZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from BN6PR11MB4004.namprd11.prod.outlook.com (2603:10b6:405:7c::24) by PH7PR11MB6956.namprd11.prod.outlook.com (2603:10b6:510:207::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.34; Thu, 7 Sep 2023 09:40:52 +0000 X-Received: from BN6PR11MB4004.namprd11.prod.outlook.com ([fe80::3f76:18aa:81cb:a64]) by BN6PR11MB4004.namprd11.prod.outlook.com ([fe80::3f76:18aa:81cb:a64%6]) with mapi id 15.20.6745.034; Thu, 7 Sep 2023 09:40:52 +0000 From: "Lien, HoraceX" To: "devel@edk2.groups.io" , "Kinney, Michael D" , "Gao, Liming" CC: "Liu, Zhiguang" , "Bi, Dandan" , "Zeng, Star" , "Gao, Zhichao" , "Lien, HoraceX" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version Thread-Index: AQHZ2yI5ZipEk9zZa0SyA8s1H3WJpLAEkQEAgAD4/jCACZy7oA== Date: Thu, 7 Sep 2023 09:40:52 +0000 Message-ID: References: <0439b4b435989b2604d325451ae0fa6b70bb0a20.1693386097.git.horacex.lien@intel.com> <1780B48BF009A270.23790@groups.io> In-Reply-To: <1780B48BF009A270.23790@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN6PR11MB4004:EE_|PH7PR11MB6956:EE_ x-ms-office365-filtering-correlation-id: 284623c6-c97e-4c7f-a817-08dbaf8686d9 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Dvo3QvbXmbNNZq+TG4kM+ccYBoyBKRBCEXMSAJFiWocqX2Y/IpOOO2jMYK3tY8uVEPnX5z3WwtRHe9y23/uUeHRv0pvh6FdmjMyCuUfD/WaHzZlO2BAvFQcN6KAiHrIbz3tJmtXRrkynIshuZhgwpDsbFOHB/UTAXr1FAG/Ajstoq7LKEBCB2e5MVy3zcSOu8kNaF2fl/+4PqJS2EM3azg2KYoQpQJAMdWrKaAuczc+374VYhgeRYgIodr5svy5mknhoNScPznmvoGxk8w9xgTu/DSSLisMPSObtL8ukgMKRJBHtt7s+7ZsNsSk5PBa5/JuJwcaCJ+mJrVbXDsOe7JZ8kcp3iEtXElIDxrxYex0RqLt4p4yLZIbo+HCDCBUiuiGg3IFILGTD0G9Lwtz0JbfEFzZZ7feNzCdqMKcpcWYPyHsxRnTkjD0af8XqivZBFTSqqCJH0cBSz6X9LrlehOFLsZvgrBXYEWqQmgyNaxG+l5yVsc1kIPOAYpPwFjDQwHQ6rg1PGc7oDDRv7cGH9aKHUXbCB+lXSrdIPIL0gwPArp23OqR5z9I2HgR9nkgExh4PdR+kF2sh3sN82RqnRon/cek7chpMoYj7ZAuq1UHzOCxHCAmxegmkyuOFlLzSrfx93Zivt2MHVaTcBynIZwD8b5roKP3N+6xYLq/WDmY= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qRSknFY7IbFCYl3IRYNSWuiymeFdtZshIQsE6Gs9AS65s9jP1YBiPCIeSg15?= =?us-ascii?Q?8vY7Lz9xZg68RBld6QVAxP2O6LS70Pu7xcOKd4g4xAYrdm6Ly0uqvAnvULfx?= =?us-ascii?Q?gy2+2MQn0vhyvKxE6nHHkR1Lx76gTltjl+JO2qBP4AQurrD3sZnQJtD/0UtN?= =?us-ascii?Q?Phq/IK/nuKHTxTnKtY5dunF8iTCy/7T/t8+8OmCw+6Q/v4B1rFXfIAzKDflH?= =?us-ascii?Q?wvAYSCGmZLgpvp1XWWUeMiN5aeWK2ez1TbEyVxbcSXq694NY9LCcbFsGEdIU?= =?us-ascii?Q?o8cFj4BRvduw1PrDur9PCcYqhfK1M8AlJlSXiiSsoW9MebRdqxs3/jBgjMpW?= =?us-ascii?Q?ZLmi8P+Ohi0jS/kaBLhjTFQo6KPLkU+2ZbF0gnYXR6UtSJexpFE/9m7R34TT?= =?us-ascii?Q?uBSAe0uT6Apz2UkCaKVVJkY9SALu7jAaml5eHX674tGeSjkl6CMz6iw6YOor?= =?us-ascii?Q?j/M3AatOjfHmnYfuomHf3MCMo1j1rcgVFRG27hR/yN5KJgpbtEHkOidLUuV6?= =?us-ascii?Q?tgbCbsV+NCbTNAwEkSl/LfaQKnmT+pJSKdr3Dt2mbKb9j+ZIxuT5QStwDkJE?= =?us-ascii?Q?MhvRLYMEoaAEWaMz7oNfcwskjNNNqWZ1H/54wSZSSHnYoIIcbiidK/90x1wM?= =?us-ascii?Q?SLoHW2R7dAkKyhVFMKubm+i4w6eDEsQpm7OBjmVF/Dt70V+FVp2npaTmXiVA?= =?us-ascii?Q?oVVxXBFyymLm+EvRNk5uwPVmtM69eEFdMgDkRyOFQJVIDUPpNWkyGymrtyjR?= =?us-ascii?Q?S0JsF6aFLRvXP1uzyPkTyseoeG1SRN+dLXnOS9PQrNPaDMiL0+Ho1WMAgcqn?= =?us-ascii?Q?Kec6lY73MgscsGuD0VeSiizFUMND9FcytHGpR1CyNCjc7QgaAQGPgodB95HE?= =?us-ascii?Q?qxMKkvSF7lrwee5NR/pfE2JH+0DR5IYrm04cHnHcKb42LVvYb33zEGw4fWAS?= =?us-ascii?Q?SnwVDjp01xuRCGGlQnq+cMw6lw5EkpxDZhLAZLy0Wgi1K8/Mq+pUJDiL/nlM?= =?us-ascii?Q?oOLPVwLlFHsmIh+nj4qhvOwBOTP7Yvsg/m1dCS0VBfnBVYZJYhJQUqpA/QqR?= =?us-ascii?Q?SKZkeXmY+qsSlewLUgY4UKkrT5TTgj9lnof1zEBYCKJ/AGb6ff8NYg7FFEDj?= =?us-ascii?Q?9YAm0YqgQO8YY4hmjBb8ZJQnOCQ4P9ob/PZs459hs8pluBJJMi0djhh6kRwj?= =?us-ascii?Q?Dn2C3XjcYAEGtqfhZYhw1u7WsyvY3TSSeQUgiiiCYR0lChv88iL0/ONfKvl2?= =?us-ascii?Q?YbetdKlb2+fHNYEh0HAy5IbRAoGSurxD65zbJV88JD6aVA3u6Xbl2MQQaRtZ?= =?us-ascii?Q?EJ8mUyVdF+jb8lAM5yDE9dj2g5GQrfYRMMk/XlG6sC3hIGll4oyZqZGp/zFk?= =?us-ascii?Q?hGpFehtjaeMYb2vq6WXj52Y8CHNL4zLl/XbDx4lEbHruyIGJPVID9sVqN0eG?= =?us-ascii?Q?FWdAQ4Ez3nbj0L1wtiIudTxH4shMCueCQDiwB55LAjv7Gvq4z0/XZE4kfIPi?= =?us-ascii?Q?lhajysHhPEJWU6U44CKHnJ3qFmaOGpOKWnP8Xwb7v8utezAynoJW7qY9R6t/?= =?us-ascii?Q?pxn1H/hM+bBkDuzhngu53JNjUc7Uv+MzPyMaUAn0?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB4004.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 284623c6-c97e-4c7f-a817-08dbaf8686d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2023 09:40:52.5327 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8SuaH70C7JoczSIjPYM69AsRAk6HhTqsYo1d4e5IgSjO2R+6/boqOw4KC8um0zOapMcQDqPnENohAzaRNQlH6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6956 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,horacex.lien@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: JUCt7xFqvByssWSpD8Vi2kXOx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=dnkFlVAU; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Mike, Could you please reply for me? If you want to filter range 0-9, then I will send PR again. Thanks, Horace Lien -----Original Message----- From: devel@edk2.groups.io On Behalf Of Lien, Horace= X Sent: Friday, September 1, 2023 3:06 PM To: Kinney, Michael D ; devel@edk2.groups.io Cc: Liu, Zhiguang ; Bi, Dandan ; Zeng, Star ; Gao, Zhichao Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision i= s not match with SMBIOS version Hi Mike, I have change code to EntryPointStructureData.SmbiosBcdRevision =3D ((mPrivateData.Smbios.MajorVe= rsion & 0x0f) << 4) | (mPrivateData.Smbios.MinorVersion & 0x0f); Add &0x0F = to mask upper nibble bit, do we still need to guarantee that range is betwe= en 0-9? Because the old code only filtered 4 bits, instead of accurately fi= ltering the number range 0-9. Thanks, Horace Lien -----Original Message----- From: Kinney, Michael D Sent: Thursday, August 31, 2023 11:56 PM To: devel@edk2.groups.io; Lien, HoraceX Cc: Liu, Zhiguang ; Bi, Dandan ; Zeng, Star ; Gao, Zhichao ; = Kinney, Michael D Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision i= s not match with SMBIOS version Are mPrivateData.Smbios.MajorVersion and mPrivateData.Smbios.MinorVersion g= uaranteed to be in range 0..9? Mike > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of=20 > horacex.lien@intel.com > Sent: Wednesday, August 30, 2023 2:13 AM > To: devel@edk2.groups.io > Cc: Lien, HoraceX ; Liu, Zhiguang=20 > ; Bi, Dandan ; Zeng, Star=20 > ; Gao, Zhichao > Subject: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision=20 > is not match with SMBIOS version >=20 > From: HoraceX Lien >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4544 >=20 > These value of Major/Minor version are updated from SMBIOS memory=20 > data, but BCD Revision is updated from PCD PcdSmbiosVersion. > We should also update PCD PcdSmbiosVersion from SMBIOS memory data, to=20 > ensure that get consistent version value. >=20 > Cc: Zhiguang Liu > Cc: Dandan Bi > Cc: Star Zeng > Cc: Zhichao Gao > Signed-off-by: HoraceX Lien > --- > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > index 1a86e69d3c..e3f6215033 100644 > --- a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > +++ b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > @@ -1072,7 +1072,7 @@ SmbiosCreateTable ( > DEBUG ((DEBUG_INFO, "SmbiosCreateTable: Initialize 32-bit entry=20 > point structure\n")); >=20 > EntryPointStructureData.MajorVersion =3D > mPrivateData.Smbios.MajorVersion; >=20 > EntryPointStructureData.MinorVersion =3D > mPrivateData.Smbios.MinorVersion; >=20 > - EntryPointStructureData.SmbiosBcdRevision =3D (UINT8)((PcdGet16 > (PcdSmbiosVersion) >> 4) & 0xf0) | (UINT8)(PcdGet16 (PcdSmbiosVersion)=20 > & 0x0f); >=20 > + EntryPointStructureData.SmbiosBcdRevision =3D > (mPrivateData.Smbios.MajorVersion << 4) |=20 > mPrivateData.Smbios.MinorVersion; >=20 > PhysicalAddress =3D 0xffffffff; >=20 > Status =3D gBS->AllocatePages ( >=20 > =20 > AllocateMaxAddress, >=20 > -- > 2.31.1.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#108150):=20 > https://edk2.groups.io/g/devel/message/108150 > Mute This Topic: https://groups.io/mt/101057293/1643496 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [michael.d.kinney@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108370): https://edk2.groups.io/g/devel/message/108370 Mute This Topic: https://groups.io/mt/101057293/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-