From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 13A337803E8 for ; Fri, 8 Sep 2023 09:35:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6XuesY6EIRDtIb+7FNxPbq0vofhNbP/GTQnc5yEB52c=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694165728; v=1; b=OtS55ijBIBrzploIFlhmA4ZDmHEnubO/IiuxzXAiXLxA96+8G5R+rG/RsKawXv3N8u2RlUM3 frEXMfciReq+DrxFrpvAIZFCD/xOP7KXEknfvwEjK8el1mZpzjnbLMdo/q05davIsfJbQGIZolz xorEt03KziZvfQ2REnJSnHFE= X-Received: by 127.0.0.2 with SMTP id 8AwMYY7687511xtcggxL5d3e; Fri, 08 Sep 2023 02:35:28 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.35558.1694165727978542638 for ; Fri, 08 Sep 2023 02:35:28 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="374989295" X-IronPort-AV: E=Sophos;i="6.02,236,1688454000"; d="scan'208";a="374989295" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2023 02:35:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="742447555" X-IronPort-AV: E=Sophos;i="6.02,236,1688454000"; d="scan'208";a="742447555" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Sep 2023 02:35:23 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 8 Sep 2023 02:35:22 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Fri, 8 Sep 2023 02:35:22 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 8 Sep 2023 02:35:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mMAqH5AHq4x6Qo+ofnHWSWNcaxbkI7p5aHULeGPfo7Zm1FSXAtVVsjJ3pS2ODVTg1Ke7jZzs1W/250U9PWmHNk15ZFKSbwE2+4hFTUyUE3gNWezMvT6xXCjo+XGJ3mPZhS1eiCdqhjpQ80g33Io/6/Ohme/pp/ZABPYUiwm5PP/6xfA7gzC2bRfq9IvTR/GgCCLyWZomYTPygnIB7o7P1ratxEzogc0sWgjhkKjAWSKzxTK8zCKa6P7Agzs4cYEFv0c4QYP+xvu5l/PlUMLcsZV4Qjkr6mRvjyJIy+NOW3S3fxXERx4lOMN14g0gl3vQRB8psfmx/4jAktzQxbV5mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Df/qYgMRImTb/6srvefl8aVXqMpRtJ/yeVJHxunGLAY=; b=GKtAdj5dp+OTxyrJD5bd4+WUWkolCS9pfBCklL+1LQVKKygPKAlFV9X26f/96jZiv9iktTfORuEv8s224BAaADtU1uG/mFZ1Qh7Xr/aNZz37UxDEPuTTW0er5tdb/+SxQmzRay5pEQ8Xlu7iCPwS1dMQO6w2WdLC8f01jM3j1V1ecSud7kryFKmjb6uWFkBW35xCV0liV6JPFcBZG7hwyaBPzE88N35chk379sd11rbB0i4FsqaSAUFpVrxEgBF1CFXoe7jd+pUFauevn/+/kM7ef2AcsBB1k7pBF1sUiWq+RKUwyPtHtyi0xMuU21wF6CDIcySxSzokha7sSxLDrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from BN6PR11MB4004.namprd11.prod.outlook.com (2603:10b6:405:7c::24) by MW3PR11MB4522.namprd11.prod.outlook.com (2603:10b6:303:2d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.31; Fri, 8 Sep 2023 09:35:15 +0000 X-Received: from BN6PR11MB4004.namprd11.prod.outlook.com ([fe80::3f76:18aa:81cb:a64]) by BN6PR11MB4004.namprd11.prod.outlook.com ([fe80::3f76:18aa:81cb:a64%6]) with mapi id 15.20.6768.029; Fri, 8 Sep 2023 09:35:14 +0000 From: "Lien, HoraceX" To: "Kinney, Michael D" , "devel@edk2.groups.io" , "Gao, Liming" CC: "Liu, Zhiguang" , "Bi, Dandan" , "Zeng, Star" , "Gao, Zhichao" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version Thread-Index: AQHZ2yI5ZipEk9zZa0SyA8s1H3WJpLAEkQEAgAD4/jCACZy7oIAA0c4AgACrGTA= Date: Fri, 8 Sep 2023 09:35:13 +0000 Message-ID: References: <0439b4b435989b2604d325451ae0fa6b70bb0a20.1693386097.git.horacex.lien@intel.com> <1780B48BF009A270.23790@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN6PR11MB4004:EE_|MW3PR11MB4522:EE_ x-ms-office365-filtering-correlation-id: aa40fd5f-2b65-49d8-91aa-08dbb04ee731 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: XsXRiyT+qwOHKCR0sSFf9IFqBW894swWiNHRLwMSVXMuTcdMr+dcLg57BNkdfamJYkdJXNfGOJrfKBLOr60/j2HNpHGiPAndfrau6xu8dw/xH30sGQXqo2gcD2/+HzsWF3XlQNQBM/58q1vzESdYrUPrHo6K9cOdzl+5D1yA51ggmkx4DBXnecuF00u6zMTgJL83UhMzojm7/qQa9oAghfr2A6Dah2S2DKSOcpBt30oPwOqcTOLzVxWf/xItNOMDayZ+cpblkmUN4DljXMO33eUV4xNs1JBXUm2mzXFSyDRkdvnJA8Odv6JU4toktgp0ULUHru8JOuoE+ZPCu7fsNWbbgrgtdEpQXOKq6Lh27QRWKN3t1ydjKKuZRkpStyDTQJ9u+XRJ/hobM3sQcgj37cGGmZ+4jyhsgh+AfkXZ0WGOnxUBs1/4AUC32bH3BUts1cr4Oi43JypUSfyTt/kLvbf3FFGR2zRQCsm+Q7WJT78gByb73+xYdGuOez6t/IvKxfh4RVqo7mywvOgxgAl1SPbJvE+Oiz/IQE05kK79NcZGwLfMRMuLM+ICVof55vRhFDWOKEFtT7HBArEmC0EQ7NmAkqsU0a2hNMQWZ3DE+N57bw0aMWnlt1xNLXlKxjLf74RkRBBT2B9G4n6Wu3/BFoXee0Pwv2XSWh2SGGYIN/I= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?//YHB5FS2Em3aKgDwh9mAARyO9CYbbEKh/cYBEWL9T1uUtwXjz7uAy7nHZuO?= =?us-ascii?Q?p+SqpNyZPUVjfil3al48e5Z35OwtOqMVQFA5js1wBdt+lA/tHENMae0RiVHQ?= =?us-ascii?Q?7eOAGOtGtwC91G+lzDaESBja1IAya4cMyLJzZRPbchSsw+KX1mNvVgu10OIy?= =?us-ascii?Q?Q+2rgfrVtQ5Qtxu3jK2iC8dqE2FYVpc9USBvnlbABdKUgH/xQlJjtLwT0/Pj?= =?us-ascii?Q?6L7+NE+PVUJcb+VRjtyDACvyMAdDOgpcKjY74ZObszoZx3ebYAqK0fN0gRUN?= =?us-ascii?Q?S+pufDOQB1u1tHgymkLt0jwyeQezBRFkNRo94qD3DPAR6RHPKu996JYq5n3/?= =?us-ascii?Q?ttg0vfddf9y4h3GZpM/qyP8qpMBAzDTNREfdv1I9xMJ25I62Iy4HqnFHGuBC?= =?us-ascii?Q?8MCBKgwBD0wpdNUu+vBGMBrKvukROmBibK84oKkX/JVOI/OIaBSeVXVdo9oz?= =?us-ascii?Q?fypKBffQVoIYmv139LMKyN7lCJBsZ8Rt2UcgVyTvW0liUV8wWFlYHJ9g6g27?= =?us-ascii?Q?COzP236B2bDEAgx9fm1gKujE68qk325Sqbh0J0CWBIW6XTgDqYZgYU97RXol?= =?us-ascii?Q?ZAMbtoDPGBD6/c9DSVBjgHB7HnKA/9x3QqbhQG17z8QUDvjqHKWItaNAulEh?= =?us-ascii?Q?KaX9qTCggBsalevQReV7eofwO9y1mk2Bgffl0lko58S/Fln95H+4LQofwH78?= =?us-ascii?Q?n6lLaTkSCEcRZJ7A0vrs5qW/1TS/PyiLgKixLV9tZbe91OHUED4RlCihZH53?= =?us-ascii?Q?IZcJFWNXJAuS7BgVHCxSHMrxaRR82U+gevVsV558+NhICUY8AQkhEl+m5cGz?= =?us-ascii?Q?heiXN5/hAmcBzQrJm6cR6OPsrX8a4Uebcg2C/R05CTl0/6FGaYGf+t7L7/6K?= =?us-ascii?Q?Gez8gB9XjxFR2zxONEuzps6H05rwraTqBdizUk4hvf9KMiR9PSQ021duoidv?= =?us-ascii?Q?/ba/kF1D7JEOf+IRcxtyur4TTNC0hBFnPzxCHuCaCAk9te2I5xiBezaqLImR?= =?us-ascii?Q?fpP29yemBBgQUwBAOPAlpKDvA69zjo/5FQoTo2pvhaBrQEQbZijcKOMjeNy4?= =?us-ascii?Q?dhS6V+2BR0mMDB6tp9t1a3GbOj/23VTT5lMwvdYEqWcWWn2pvz+KnYErRIQH?= =?us-ascii?Q?9x4FP6NYE1xTvLOhGB8hpuJa8v/K6N3bmQoeDtJ0LOeoucM4csyiWmYEhpRT?= =?us-ascii?Q?Ma/78HLFr9N8j5Vlyk2iAiDPROfHn/ri/x7pP81Pq0HoBTX6gF+rS8KOuBT3?= =?us-ascii?Q?MazV2xaakC8/46CJDQniZdO88DgKlUi+jY9F2J3+95+ZZJlMZEIikh4RgaL3?= =?us-ascii?Q?JnjYwHAgauti0pa+DSZsJtV/zaeEv9pcfL1voobG4lE0KJT2EAp0vMMB9HAC?= =?us-ascii?Q?a8fcjRNbqyDTFuQqDq16y2TVBPhDnEU29EB/JP/lZaJ4jo70qokEDfrV6SRA?= =?us-ascii?Q?JGoN651FWUG9WjR9QtmzBcYUDzSlo3QzstzamcghefQxsHX6ok9icBo8f9Du?= =?us-ascii?Q?eSh17pv8q+bnXkStj9PMWlLwL2hKPUprdbJpkxbZ4y+wXDCdZ/+kACb2Dc1Z?= =?us-ascii?Q?XhbvWhsmEwNwdMY1nh3vf8+VjsWNbx095RZZOTqk?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB4004.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa40fd5f-2b65-49d8-91aa-08dbb04ee731 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2023 09:35:13.5472 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: k9IYqhJ4nrazQ2bnFEziYAtNURas819trXju5BHnFA2n4Wu4vyCccrdDo8NFzRf5ZT7pyq5XjK3FtbvD0MUT2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4522 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,horacex.lien@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: adneF6nydu2NY9awgDXh8wy4x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=OtS55ijB; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Mike, No, we didn't guarantee this before. Add comments to descript BCD field is = good point. I have reviewed SMBIOS spec for SmbiosBcdRevision field, it mentions "If th= e value is 00h, only the Major and Minor Versions in offsets 6 and 7 of the= Entry Point Structure provide the version information. ". So, I have new i= dea to implement this, I will filter range 0-9 for Major/Minor version to f= ill in SmbiosBcdRevision, if one of Major or Minor is greater than 9 then f= ill in 00h. Do you think it is ok? Thanks for your reply. Thanks, Horace Lien -----Original Message----- From: Kinney, Michael D =20 Sent: Friday, September 8, 2023 6:05 AM To: Lien, HoraceX ; devel@edk2.groups.io; Gao, Limi= ng Cc: Liu, Zhiguang ; Bi, Dandan ; Zeng, Star ; Gao, Zhichao ; = Kinney, Michael D Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision i= s not match with SMBIOS version I was asking about the property of the global variables being used in this = patch. Are they already guaranteed to be in BSD format and in range 0..9. = If so, then no additional code changes would be required. However, it wou= ld be good to add comments about the properties of those global variables a= nd why they can be used to directly assign to fields that are required to b= e in BSD format. Mike > -----Original Message----- > From: Lien, HoraceX > Sent: Thursday, September 7, 2023 2:41 AM > To: devel@edk2.groups.io; Kinney, Michael D=20 > ; Gao, Liming > Cc: Liu, Zhiguang ; Bi, Dandan=20 > ; Zeng, Star ; Gao, Zhichao=20 > ; Lien, HoraceX > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix=20 > BcdRevision is not match with SMBIOS version >=20 > Hi Mike, >=20 > Could you please reply for me? > If you want to filter range 0-9, then I will send PR again. >=20 > Thanks, > Horace Lien >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Lien,=20 > HoraceX > Sent: Friday, September 1, 2023 3:06 PM > To: Kinney, Michael D ;=20 > devel@edk2.groups.io > Cc: Liu, Zhiguang ; Bi, Dandan=20 > ; Zeng, Star ; Gao, Zhichao=20 > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix=20 > BcdRevision is not match with SMBIOS version >=20 > Hi Mike, >=20 > I have change code to > EntryPointStructureData.SmbiosBcdRevision =3D=20 > ((mPrivateData.Smbios.MajorVersion & 0x0f) << 4) |=20 > (mPrivateData.Smbios.MinorVersion & 0x0f); Add &0x0F to mask upper=20 > nibble bit, do we still need to guarantee that range is between 0-9?=20 > Because the old code only filtered 4 bits, instead of accurately=20 > filtering the number range 0-9. >=20 > Thanks, > Horace Lien >=20 > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, August 31, 2023 11:56 PM > To: devel@edk2.groups.io; Lien, HoraceX > Cc: Liu, Zhiguang ; Bi, Dandan=20 > ; Zeng, Star ; Gao, Zhichao=20 > ; Kinney, Michael D=20 > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix=20 > BcdRevision is not match with SMBIOS version >=20 > Are mPrivateData.Smbios.MajorVersion and=20 > mPrivateData.Smbios.MinorVersion guaranteed to be in range 0..9? >=20 > Mike >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of=20 > > horacex.lien@intel.com > > Sent: Wednesday, August 30, 2023 2:13 AM > > To: devel@edk2.groups.io > > Cc: Lien, HoraceX ; Liu, Zhiguang=20 > > ; Bi, Dandan ; Zeng,=20 > > Star ; Gao, Zhichao > > Subject: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix=20 > > BcdRevision is not match with SMBIOS version > > > > From: HoraceX Lien > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4544 > > > > These value of Major/Minor version are updated from SMBIOS memory=20 > > data, but BCD Revision is updated from PCD PcdSmbiosVersion. > > We should also update PCD PcdSmbiosVersion from SMBIOS memory data,=20 > > to ensure that get consistent version value. > > > > Cc: Zhiguang Liu > > Cc: Dandan Bi > > Cc: Star Zeng > > Cc: Zhichao Gao > > Signed-off-by: HoraceX Lien > > --- > > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > > b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > > index 1a86e69d3c..e3f6215033 100644 > > --- a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > > +++ b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > > @@ -1072,7 +1072,7 @@ SmbiosCreateTable ( > > DEBUG ((DEBUG_INFO, "SmbiosCreateTable: Initialize 32-bit entry=20 > > point structure\n")); > > > > EntryPointStructureData.MajorVersion =3D > > mPrivateData.Smbios.MajorVersion; > > > > EntryPointStructureData.MinorVersion =3D > > mPrivateData.Smbios.MinorVersion; > > > > - EntryPointStructureData.SmbiosBcdRevision =3D (UINT8)((PcdGet16 > > (PcdSmbiosVersion) >> 4) & 0xf0) | (UINT8)(PcdGet16=20 > > (PcdSmbiosVersion) & 0x0f); > > > > + EntryPointStructureData.SmbiosBcdRevision =3D > > (mPrivateData.Smbios.MajorVersion << 4) |=20 > > mPrivateData.Smbios.MinorVersion; > > > > PhysicalAddress =3D 0xffffffff; > > > > Status =3D gBS->AllocatePages ( > > > > > > AllocateMaxAddress, > > > > -- > > 2.31.1.windows.1 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#108150): > > https://edk2.groups.io/g/devel/message/108150 > > Mute This Topic: https://groups.io/mt/101057293/1643496 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > [michael.d.kinney@intel.com] > > -=3D-=3D-=3D-=3D-=3D-=3D > > >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108442): https://edk2.groups.io/g/devel/message/108442 Mute This Topic: https://groups.io/mt/101057293/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-