From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.47521.1584946625623718223 for ; Sun, 22 Mar 2020 23:57:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ALvNOM3A; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: rangasai.v.chaganty@intel.com) IronPort-SDR: Dw9hI0lNhsL7e8EMPaTcN5E0k7Z6xtkChh/4hg/hBNGTqcmcy3hoVU4nRnVD5O2ttiNN7yhUyX y+HJzwhhIxUg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2020 23:57:05 -0700 IronPort-SDR: V4K8n08FQ3M6nM3pOvauCV2O7sHYxZmfD6dqMqNoWLc5aeZsqU8uDotqf9Q5BmTBMeI1fZLuz9 5dg1n1JIO1wQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,295,1580803200"; d="scan'208";a="325481808" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga001.jf.intel.com with ESMTP; 22 Mar 2020 23:57:04 -0700 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 22 Mar 2020 23:57:04 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX116.amr.corp.intel.com (10.22.240.14) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 22 Mar 2020 23:57:04 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 22 Mar 2020 23:56:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GWfdcqcI87o8nvyFlaDzPA4G8nKhCmpxiHERu0ahlRHWNbxz0AYm3NBFlXr0SEe8vVFHRXpAYcuWP9rIbkCdRaDuRbVjg3h5TtxfNPYpPADJbBcOSg5qPYFQsB+3lLIxqOUG1WOszHWICWuKHZCReu5fXO88Ww3jFvXSCwfGwoVQ4+vltb8s7VSdl42k2JHrVBMkHZeGAHQXAuW7dsIz+5Kmy5iov+wdKJbWJ/J3rcAGASz1Ew2f+yKL9QQ/oIQoFgmTrSFBnTlhpZebNPpqy8Z4zKOuwPDt1W/k3JPOO2lPRCAclfO5FYZsZ/3ZIdDL68m2LBM3eM92d51JeRcCLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4R7e6vzhTWnFPrWsiWxnO/AYcwB8hY2ljVFnQuQMgBI=; b=Jf4ZQNNxkt8BiMQFuw7mnMsxjiWiPvELf9LqBIzUYgfyVUyoHZ+jb9SsrJiKKMENZ+nXG8GehnRrAmTbAq8hq+yFGTjK/Xj2RA5TVVGcYLnXqAHuFgdxImSDvNV7LI8TJh8lRAGTZvaxgigD/hTvr1II7/QlF3W3FjcR7XbqsRqzSjOGyliqfzY9h7oAj3g0oy4jceWduYIAzVIJ+thmo+EhfPmFOZ2EQCYixgTl/9MLprD+djdo9y2ou1QnqDWizmWdAiz6Z7J5zOPI5uDLiquRQI594tLtgWViqrFZZ0ufQun4GeIxqG+sTFnIQfMDtLv50oUgABrktH2+pkeo7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4R7e6vzhTWnFPrWsiWxnO/AYcwB8hY2ljVFnQuQMgBI=; b=ALvNOM3Ai6fANSWQqZNCfGyl2ItOxxUbyPM7ERaOpJ+yJ1dCyVwOuuo5qOj7kiyNuHekaCFFMvzGO5IOVEz2lGgBsE/6i5cPmnykdOabdZ7CodKKtfN+OuHYMSo4MlO7V/K/JAa+oB5cXGF5LxtDgdp/ATkpDDikJabEXJjHLg0= Received: from BN6PR11MB4147.namprd11.prod.outlook.com (2603:10b6:405:80::10) by BN6PR11MB1698.namprd11.prod.outlook.com (2603:10b6:404:42::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.22; Mon, 23 Mar 2020 06:56:37 +0000 Received: from BN6PR11MB4147.namprd11.prod.outlook.com ([fe80::7867:c849:55fe:8926]) by BN6PR11MB4147.namprd11.prod.outlook.com ([fe80::7867:c849:55fe:8926%4]) with mapi id 15.20.2835.017; Mon, 23 Mar 2020 06:56:37 +0000 From: "Chaganty, Rangasai V" To: "Jiang, Guomin" , "devel@edk2.groups.io" , "Zhang, Shenglei" , "newexplorerj@gmail.com" CC: "Ni, Ray" Subject: Re: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments Thread-Topic: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments Thread-Index: AQHV8rHVLzmyDlSohUWxIO50OTsRCKg+9pmAgBbYgqCAAAvJUA== Date: Mon, 23 Mar 2020 06:56:37 +0000 Message-ID: References: <77c905ac53e7ea3cf113a223cb0a47dc6beaef9b.1583387221.git.newexplorerj@gmail.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=rangasai.v.chaganty@intel.com; x-originating-ip: [50.45.159.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b89f34d0-8dd6-416a-4c9b-08d7cef7550c x-ms-traffictypediagnostic: BN6PR11MB1698: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2582; x-forefront-prvs: 0351D213B3 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(39860400002)(136003)(366004)(346002)(376002)(199004)(966005)(52536014)(186003)(66556008)(66476007)(478600001)(5660300002)(64756008)(53546011)(6506007)(26005)(66946007)(66446008)(33656002)(4326008)(107886003)(2906002)(76116006)(71200400001)(316002)(7696005)(8936002)(81156014)(81166006)(110136005)(8676002)(86362001)(55016002)(9686003);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR11MB1698;H:BN6PR11MB4147.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pPSOm4rwrKzUoMsQk8POvt016RbiH6JUIC5P6afjdgYmIxRmCCGgn+BDh4NfGvH9++oouq31iFcxEQyv55GeUHcQZKZagkrMMNIju1EXKK6c+FgojrthDAahH9lCkTWi6udbx3GQUjcczIKDjiPw3LoyhXUCOuoYi/K4dB793FkHjKcos027sMM4pW2a3iWUKr2EmpsN0Gwacy90tEVqk2+JmxowO+6kWVzzMCzvcTzdmILRNWY9TC2fTha6D8cU+8uQ1iqTragC9qSd5NZ27K9OvPDMYDa+ltK48EzpA2Ah3h9k1MaiTtPihAUJEvcgSHm/GsoURnGU7uwcZRZRBvrcQmeZGo9k0N9qvrzlth2sizG425iIMs5Hp8F2VPqmUyo37h8ScAsp7nts5IvGeMxkVR1MzXwAkezf7Df6mAYvG3aW1+yhqUIIKOUZdYAwg3hold2VUAWylYsNaWC+1VxUlJQ1T4/7MftOBo9Ih+QYGAQUWi1F84nS0Ydf/AfWLP5a/CMOP5wiwBw1XJG75Q== x-ms-exchange-antispam-messagedata: 9BE6Zg5f6zwvA4R02RvJNsHX2yjOdRYKw/DXUGE2y/DJMx93AS5BKKLyNqt3jqxyvaXF3vmV4jpmott84u/LIvTwoJFpN18H+NoMLN6lZ2k+QRm9hwH//ySigaZNriS3uRpgNC7ZwWxgAvPcAIi4pA== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: b89f34d0-8dd6-416a-4c9b-08d7cef7550c X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2020 06:56:37.4348 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AfnndrUA8yNMW1i1dquAGuanhi2fXP+y1xL6qheZIyH/va7r0k4IqPPQKlz5W5Zzfky3IXGFzRFrieeo5MLwYizosimDAYQHB2ZNoXwtUxU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1698 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty -----Original Message----- From: Jiang, Guomin =20 Sent: Sunday, March 22, 2020 11:15 PM To: devel@edk2.groups.io; Zhang, Shenglei ; newe= xplorerj@gmail.com Cc: Ni, Ray ; Chaganty, Rangasai V Subject: RE: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add p= eriods in comments Hi Ray, Rangasai, Could you help review the patch. Thanks. > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of=20 > Zhang, Shenglei > Sent: Monday, March 9, 2020 9:21 AM > To: devel@edk2.groups.io; newexplorerj@gmail.com > Subject: Re: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg:=20 > Add periods in comments >=20 > Reviewed-By: Shenglei Zhang >=20 > Thanks, > Shenglei >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf=20 > > Of GuoMinJ > > Sent: Thursday, March 5, 2020 1:47 PM > > To: devel@edk2.groups.io > > Cc: GuoMinJ > > Subject: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add= =20 > > periods in comments > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2518 > > > > ECC need '.' character at the end of line. > > > > Ray Ni > > Rangasai V Chaganty > > Signed-off-by: GuoMinJ > > --- > > .../Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 6 +++--= - > > .../Library/BaseConfigBlockLib/BaseConfigBlockLib.c | 6 +++--= - > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git > > a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > index 99b8ae4b5a..37a3968168 100644 > > --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > @@ -10,7 +10,7 @@ > > #define _CONFIG_BLOCK_LIB_H_ > > > > /** > > - Create config block table > > + Create config block table. > > > > @param[in] TotalSize - Max size to be alloca= ted for the Config > > Block Table > > @param[out] ConfigBlockTableAddress - On return, points to = a > pointer > > to the beginning of Config Block Table Address @@ -27,7 +27,7 @@=20 > > CreateConfigBlockTable ( > > ); > > > > /** > > - Add config block into config block table structure > > + Add config block into config block table structure. > > > > @param[in] ConfigBlockTableAddress - A pointer to the begi= nning of > > Config Block Table Address > > @param[out] ConfigBlockAddress - On return, points to = a pointer > to > > the beginning of Config Block Address @@ -44,7 +44,7 @@=20 > > AddConfigBlock ( > > ); > > > > /** > > - Retrieve a specific Config Block data by GUID > > + Retrieve a specific Config Block data by GUID. > > > > @param[in] ConfigBlockTableAddress - A pointer to the beg= inning of > > Config Block Table Address > > @param[in] ConfigBlockGuid - A pointer to the GUI= D uses to > > search specific Config Block > > diff --git > > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfi > > gB > > lockLi > > b.c > > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfi > > gB > > lockLi > > b.c > > index 33e0c81e9d..c89699ea46 100644 > > --- > > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfi > > gB > > lockLi > > b.c > > +++ > > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfi > > gB > > lockLi > > b.c > > @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent=20 > > #include > > > > /** > > - Create config block table > > + Create config block table. > > > > @param[in] TotalSize - Max size to be alloca= ted for the Config > > Block Table > > @param[out] ConfigBlockTableAddress - On return, points to = a > pointer > > to the beginning of Config Block Table Address @@ -51,7 +51,7 @@=20 > > CreateConfigBlockTable ( } > > > > /** > > - Add config block into config block table structure > > + Add config block into config block table structure. > > > > @param[in] ConfigBlockTableAddress - A pointer to the begi= nning of > > Config Block Table Address > > @param[out] ConfigBlockAddress - On return, points to = a pointer > to > > the beginning of Config Block Address @@ -94,7 +94,7 @@=20 > > AddConfigBlock ( } > > > > /** > > - Retrieve a specific Config Block data by GUID > > + Retrieve a specific Config Block data by GUID. > > > > @param[in] ConfigBlockTableAddress - A pointer to the beg= inning of > > Config Block Table Address > > @param[in] ConfigBlockGuid - A pointer to the GUI= D uses to > > search specific Config Block > > -- > > 2.17.1 > > > > > > >=20 >=20 >=20