From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=helo; client-ip=104.47.32.68; helo=nam01-sn1-obe.outbound.protection.outlook.com; envelope-from=leo.duran@amd.com; receiver=edk2-devel@lists.01.org Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0068.outbound.protection.outlook.com [104.47.32.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1B87821959707 for ; Mon, 20 Nov 2017 08:34:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=E0Yr0bLm06dkuJJPuF7SIrwjyN8BfsJ/CyyNQda/GvU=; b=0ybZNjQD8Cr/67j+8tRgV/xXMt32HoUutdDGuC0igcGWjBBCROMr4Hr0UupudIzHNq/fZzehyMhEYzwm+ut6yLLqdnRDYdSOWHiaiI0rQRPwQnyHsp9rLR2EZR2vOg9jZZ5TcJOQjGbT568KhPoGTfJjDuRh/tsuAXkMewdcRuA= Received: from BN6PR12MB1188.namprd12.prod.outlook.com (10.168.227.10) by BN6PR12MB1187.namprd12.prod.outlook.com (10.168.227.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.239.5; Mon, 20 Nov 2017 16:39:02 +0000 Received: from BN6PR12MB1188.namprd12.prod.outlook.com ([10.168.227.10]) by BN6PR12MB1188.namprd12.prod.outlook.com ([10.168.227.10]) with mapi id 15.20.0239.009; Mon, 20 Nov 2017 16:39:02 +0000 From: "Duran, Leo" To: "'Ni, Ruiyu'" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 1/2] PcAtChipsetPkg: Define FixePCD's for RTC register values Thread-Index: AQHTUnFiIkvBI5/WtkmZo84x8OIHYKMKESmAgBOFdsA= Date: Mon, 20 Nov 2017 16:39:01 +0000 Message-ID: References: <1509472493-19062-1-git-send-email-leo.duran@amd.com> <1509472493-19062-2-git-send-email-leo.duran@amd.com> <734D49CCEBEEF84792F5B80ED585239D5BAB6B82@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BAB6B82@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leo.duran@amd.com; x-originating-ip: [165.204.77.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BN6PR12MB1187; 20:PzSxWCCxq8GnvP66G2EEb9/H4Ke2ejn49DxNuQx0JYgrjQdRiJbqlp3lLsKT4KqBu3BogIaTUAjn/6Hhi8W7K7GPMIB+DkxrB5VsCN9IYJif/+j2WazEYIGCdIojtGnRKe8EKNGtlgGRaZfnDs8OtmL6v/8ufUuIpNqWC09v6ZFqPzylA+mN4z8y3UhacsWDjaatl9IJG22gqYYLwBNy1DRMw6XgVk+W28vtiqrmooN34NBgWZF/QLjg9kzHzmkW x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 6df3b315-29f0-4999-cebd-08d5303534ec x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603258); SRVR:BN6PR12MB1187; x-ms-traffictypediagnostic: BN6PR12MB1187: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(767451399110)(788757137089)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231022)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123558100)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR12MB1187; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR12MB1187; x-forefront-prvs: 04976078F0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(6009001)(6029001)(346002)(376002)(39860400002)(13464003)(199003)(189002)(2950100002)(8936002)(99286004)(6246003)(106356001)(5660300001)(105586002)(9686003)(25786009)(3846002)(102836003)(14454004)(316002)(6436002)(55016002)(478600001)(3660700001)(6116002)(229853002)(6506006)(77096006)(7696004)(53936002)(189998001)(2906002)(101416001)(97736004)(81156014)(7736002)(110136005)(305945005)(81166006)(54356999)(76176999)(66066001)(8676002)(3280700002)(50986999)(33656002)(74316002)(2900100001)(68736007)(2501003)(53546010)(86362001)(575784001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR12MB1187; H:BN6PR12MB1188.namprd12.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6df3b315-29f0-4999-cebd-08d5303534ec X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2017 16:39:01.9784 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1187 Subject: Re: [PATCH 1/2] PcAtChipsetPkg: Define FixePCD's for RTC register values X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Nov 2017 16:34:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Are we OK with pushing this patch-set? If so, is that something you can do, Ray? Thanks, Leo. > -----Original Message----- > From: Ni, Ruiyu [mailto:ruiyu.ni@intel.com] > Sent: Wednesday, November 08, 2017 12:30 AM > To: Duran, Leo ; edk2-devel@lists.01.org > Subject: RE: [PATCH 1/2] PcAtChipsetPkg: Define FixePCD's for RTC registe= r > values >=20 > Reviewed-by: Ruiyu Ni >=20 > Thanks/Ray >=20 > > -----Original Message----- > > From: Leo Duran [mailto:leo.duran@amd.com] > > Sent: Wednesday, November 1, 2017 1:55 AM > > To: edk2-devel@lists.01.org > > Cc: Leo Duran ; Ni, Ruiyu > > Subject: [PATCH 1/2] PcAtChipsetPkg: Define FixePCD's for RTC register > > values > > > > Define FixedPCD's to replace macros in RTC driver, to allow for > > platform- specific configurations. > > > > Cc: Ruiyu Ni > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Leo Duran > > --- > > PcAtChipsetPkg/PcAtChipsetPkg.dec | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec > > b/PcAtChipsetPkg/PcAtChipsetPkg.dec > > index b0b2b62..f11d204 100644 > > --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec > > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec > > @@ -5,6 +5,7 @@ > > # PcAt defacto standard. > > # > > # Copyright (c) 2009 - 2015, Intel Corporation. All rights > > reserved.
> > +# Copyright (c) 2017, AMD Inc. All rights reserved.
> > # > > # This program and the accompanying materials # are licensed and > > made available under the terms and conditions of the BSD License @@ > > -181,5 > > +182,17 @@ > > # @Prompt Reset Control Register value for cold reset > > > > > gPcAtChipsetPkgTokenSpaceGuid.PcdResetControlValueColdReset|0xFE|UI > > NT8|0x0000001A > > > > + ## Specifies the initial value for Register_A in RTC. > > + # @Prompt Initial value for Register_A in RTC. > > + > > + > > > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterA|0x26|UINT8| > > 0 > > + x0000001B > > + > > + ## Specifies the initial value for Register_B in RTC. > > + # @Prompt Initial value for Register_B in RTC. > > + > > + > > > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterB|0x02|UINT8| > > 0 > > + x0000001C > > + > > + ## Specifies the initial value for Register_D in RTC. > > + # @Prompt Initial value for Register_D in RTC. > > + > > + > > > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8| > > 0 > > + x0000001D > > + > > [UserExtensions.TianoCore."ExtraFiles"] > > PcAtChipsetPkgExtra.uni > > -- > > 2.7.4