From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.80]) by mx.groups.io with SMTP id smtpd.web10.9398.1582729912277736700 for ; Wed, 26 Feb 2020 07:11:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=1QK31NvO; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.223.80, mailfrom: leo.duran@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B5rfbtsKVns+vl58L6GHXZCKP1RRxARrsSssn7PPL7DJThEtpwHs4ZvyZpKISx3QZJiysqWD8h4IIJyALhcxmQR8+Goe1RJLSUw2R5NwbsemwF8Slt35yCPdfGO0OSBEQWwyRYrwJXxm6ZWSMlJLSvoWrBCkyLKDWNJR/BHZ7tnngJ54DmgrzW2ls37l4WW/eE4rf0gqw4+CcRC1Utff2hbm9bAULNsO5sqz8CdmpKtvt+4EDr5zHmg2zN5+NUXl/W2ph9DSdIhlHgYEvns9vvhWjrNHoUXhZZpfR6GW4fMMz6x8nwmVTqE1J8JPSnfiTlYfpITzXq1s8ujk4SP5jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N9aFCvOZQUDEQ3o/Zd/qVcbkFx/5SxU3IvEklj1WFT0=; b=ZX6RZz9+LEtZ4K0qdm37u14/DYNa9VM8/iZtAhyYVT3X1KnhDY8u8YUebNRk/gxfGgtQMdHLNWB0xudNz+ybY2XjON6xOrNkQk7fG3qzMwn4xNaR61Z0TUapg7Iw8+wORL5lRERSsttIQt4sXFXScfS7Bh2v2ncaOuvy9vgzyYdXxlmabiBwXkWFtc4K6DKCb4qTfIS5k+Z1mOAeqRjKKlGZ5/vnc5SkgTlb6xPRW59LiPJNkxZPf3Z9IIpTs1Z8LMN3ujHjGSjRJiY2rvD1oRj998DDu3FB83nxtVwHtVs05UxrQBuMs2t+vYfqwRn/QYdPsX1NzlayX4+44PzwKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N9aFCvOZQUDEQ3o/Zd/qVcbkFx/5SxU3IvEklj1WFT0=; b=1QK31NvOhjX4MTI+Yj8aJF2rAfMEtERG2I03e9z1LxpyJLp7BIp8i9ePaHn0QvW73UjbkhIJb8qp3bGQVeMIWamAnMDIF3RJv5VDTVKyl6Tak4vA0op/H2beGeD6Z0WKZvLJjuugurV8PgU7+KohskH5TIIW4SrmpOGNSZjaqhg= Received: from BN6PR12MB1922.namprd12.prod.outlook.com (2603:10b6:404:106::14) by BN6PR12MB1793.namprd12.prod.outlook.com (2603:10b6:404:108::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.21; Wed, 26 Feb 2020 15:11:50 +0000 Received: from BN6PR12MB1922.namprd12.prod.outlook.com ([fe80::d931:1942:a6b5:d74c]) by BN6PR12MB1922.namprd12.prod.outlook.com ([fe80::d931:1942:a6b5:d74c%7]) with mapi id 15.20.2750.021; Wed, 26 Feb 2020 15:11:50 +0000 From: "Duran, Leo" To: "Gao, Liming" , "devel@edk2.groups.io" , "Ni, Ray" , Laszlo Ersek , "Wu, Hao A" , "Fu, Siyuan" CC: "Dong, Eric" , "leif@nuviainc.com" , "Kinney, Michael D" , "afish@apple.com" Subject: Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib Thread-Topic: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib Thread-Index: AQHV7BNuZBsSC+kbJkGHn9DFW2NUaKgspoeAgAB2EYCAABBxAIAAZrRQ Date: Wed, 26 Feb 2020 15:11:50 +0000 Message-ID: References: <1582659566-9893-1-git-send-email-leo.duran@amd.com> <734D49CCEBEEF84792F5B80ED585239D5C4542DA@SHSMSX104.ccr.corp.intel.com> <58ccd1485c0a409691e542247699fe58@intel.com> In-Reply-To: <58ccd1485c0a409691e542247699fe58@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leo.duran@amd.com; x-originating-ip: [173.170.80.115] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 066d8652-bebe-4e73-b9c1-08d7bace3470 x-ms-traffictypediagnostic: BN6PR12MB1793: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0325F6C77B x-forefront-antispam-report: SFV:NSPM;SFS:(10001)(10009020)(6029001)(4636009)(136003)(396003)(376002)(346002)(366004)(39860400002)(189003)(199004)(8676002)(33656002)(86362001)(2906002)(9686003)(71200400001)(55016002)(81166006)(81156014)(7696005)(8936002)(54906003)(966005)(76116006)(66946007)(186003)(110136005)(66476007)(316002)(66556008)(5660300002)(52536014)(64756008)(66446008)(478600001)(53546011)(6506007)(4326008)(26005)(7416002)(45080400002)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1793;H:BN6PR12MB1922.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nBqCExkQrH2ij1H3i9PDqlNVulGf7hMiqhQd9jfFIECvSbVv/in85EPzxjXMKywlV+PEw6vD3u8oDTmw0g042fGYozVnDpeZchuL/lDcOeOkcLZTOPy/A86UhiYNkvMDp3EEWDwWNMrosluSMy25KSxUVMBmP4SlsSuspLAPJzFK0itFuxFQanQFNu0VOFhdPtwsMl2cdeGEA0T159iBdPViuYs8dDIJxYwlZmQZrO1aTZuEY6amT5dpk253SsKKZ+Mqu8OJpfLnGrtEu25xsxUr0B+uQSUra7tqfLnriawWI+DICqg1g/JCAHuesSnrdGnQvgBxwm+v3Zb0iJyJ4reMFZJE48ht6NuSEhmJxWwOJniJO1OpqTfGYREwpW36Bf44VhAGal30N5rw5sVvIE0M2mV+JOXB9sf2MvdPTX+s+NrpcnNac/Vh6Xg624Rt1GvS9HwB484CPff0K37kbeyrL63CSJHBhhR5f8RDpXe40HLIwZ56/IeesmUZpfb3+yGIR9uDeSjvWPvFrTTenFoQbiA/HO+3CJ4ozHavDR0r8NLTy5Vm3BTZ151eojBbrOCaEbIHXHQ/ad8ss3uZPBJvOGvm5+98F0ErMQ8OfFhsbBfiD6H3vQ9NnNqZPJcGOtHCBNWvoo8Pjxb8NUTMcZiSv24CFCzHZTSD6A9imDz0ZZqY2QVD1NI6gMvlzhdj x-ms-exchange-antispam-messagedata: sB/5b+nifbSydqVLqHOSC6QF+WOl5YYRTx3gRjIMw5iB9xGGKIMXzZTcpOZF9oe8/9fais6AFhpvy/PlJDFrgBY8nbZ7a0eOOxiBlD3gScJR4DU2sbSJsHVP1nxsjvfwvLh3VkPrbbVi6rjSbkimvA== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 066d8652-bebe-4e73-b9c1-08d7bace3470 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2020 15:11:50.1706 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v88420LZS+50qmfPqwwIznWWVQPzWQJMY+jgphSSuoh9EXcssVn6sFgqTAeSaGZ7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1793 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Gao, Liming [mailto:liming.gao@intel.com] > Sent: Wednesday, February 26, 2020 3:56 AM > To: devel@edk2.groups.io; Ni, Ray ; Laszlo Ersek > ; Duran, Leo ; Wu, Hao A > ; Fu, Siyuan > Cc: Dong, Eric ; leif@nuviainc.com; Kinney, Michael= D > ; afish@apple.com; Gao, Liming > > Subject: RE: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in > MpInitLib >=20 > Leo: > Now, we enter into Hard Feature Freeze phase until edk2-stable202002 t= ag > is created at 2020-02-28. Only critical bug fix is still allowed. >=20 > Do you request to catch this fix into this stable tag? If yes, please = work closely > with UefiCpuPkg maintainers to catch the stable tag release schedule 202= 0- > 02-28. >=20 > Thanks > Liming [Duran, Leo]=20 I'm not sure I understand what my next steps are, perhaps I need to go bac= k to the BUGZILLA? (This issue is a "must-fix", so perhaps I can tag it as such in the BUG re= port.). Thanks, Leo. > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Ni, Ray > > Sent: Wednesday, February 26, 2020 3:57 PM > > To: Laszlo Ersek ; devel@edk2.groups.io; > > leo.duran@amd.com; Wu, Hao A ; Fu, Siyuan > > > > Cc: Dong, Eric > > Subject: Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in > > MpInitLib > > > > Leo, > > > > > > BTW, reading the PlatformId MSR was already being done by > > > > MicrocodeDetect(), but it never affected AMD-based platforms as > > > > the flow never gets that far, since the Detect routine bails out e= arly > when it finds the size of the patch is zero. > > > > You are saying that PlatformId MSR access is not performed by CPU in o= ld > code because of the zero size uCode. > > But now with Hao or Siyuan's change, the PlatformId MSR access is > > always performed even when there is no uCode. It sounds like a regress= ion > to optimization to me. > > Did you evaluate the path to avoid accessing PlatformID MSR when uCode > > doesn't exist? So that the API to detect AMD processor is not needed a= t all. > > > > Thanks, > > Ray > > > >=20