From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.49]) by mx.groups.io with SMTP id smtpd.web12.10963.1582735616894781522 for ; Wed, 26 Feb 2020 08:46:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=PFJNfbpA; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.237.49, mailfrom: leo.duran@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=np8EFMKnT8oQGX20wC6LcJvP1YczKWGab1dd8TD6kntmGNAP5o7Xa/i3K7eudo11IbLCV3K0gTFKpRPVO+qrgYFgObVoo5ik4Ubzbbon4qM+6dwKyO2x1UvLuAEV1XxoXclqGepOxeAKZ4xuYBlh0QYplaoeSAkGt0JU3Vv+od7XF+p57ydOJRJxutihSabM8XiVwT7AUjnnLwdJQ+f8ko7m1FLhR6Fre7PtzQ3aET0n77H1N+U3CZiGBSeRq0TljGEY/DzHF6asFWRIxVtd2jhb7uKgbsHSsYcg7WCF1uQkO3+/DSdvhbx8IorPw1bG/vGBTgLDu+6GbRitfBdCgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dKLWJxd24Di7vK0n0rVfxdb0V2sSKod8dzo4wWIoTOM=; b=k94aGR6CWS5eusXKhRlaUFaIqm19bNBEKRH4zStmN/saaWeiKjvK2I/SGVJS1Ei6xRfjaxX3JK0AcSN1CE4uTXFr6+cHWsFRyG71Fm1HuwMl8Y974qhPBIxcIaL4mdp1qATR5d6x+4dUyUrPzrGtxZePUBbegk7i0SLE9GNBGByCCMvWeX3K9XJybTVylhUnfeR7S33l0e7TBZMwAEZQl/CTLg2V7Z402Z5ET2f2eLWenKG8wUdRHQy5kQtk36/qAHf9YAsszVlKaZ0ppGeZikvxqKPb53gJo5ClMokIq6+qx2LYtPU4vsXNA9WjyyPgy0I13pjMOanr1Lukpb3rdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dKLWJxd24Di7vK0n0rVfxdb0V2sSKod8dzo4wWIoTOM=; b=PFJNfbpAhqIWueDO8j5VhNhn8A3ZtrgRZbdAuJuvrVk9WdAOXdfxfU/PLA2tIYcyjwd9e6Ty7D9pA7Ltn82OUgAiqH5R7Bu3T12Ce6vP01+5KOpVLNweqXcWsvI10PjMV78TIcS3QVowJQcJvrHuwG++hkk8sCTNczVsdUvlJMU= Received: from BN6PR12MB1922.namprd12.prod.outlook.com (2603:10b6:404:106::14) by BN6PR12MB1281.namprd12.prod.outlook.com (2603:10b6:404:1b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.14; Wed, 26 Feb 2020 16:46:54 +0000 Received: from BN6PR12MB1922.namprd12.prod.outlook.com ([fe80::d931:1942:a6b5:d74c]) by BN6PR12MB1922.namprd12.prod.outlook.com ([fe80::d931:1942:a6b5:d74c%7]) with mapi id 15.20.2750.021; Wed, 26 Feb 2020 16:46:54 +0000 From: "Duran, Leo" To: Laszlo Ersek , "Ni, Ray" , "devel@edk2.groups.io" , "Wu, Hao A" , "Fu, Siyuan" CC: "Dong, Eric" Subject: Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib Thread-Topic: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib Thread-Index: AQHV7BNuZBsSC+kbJkGHn9DFW2NUaKgspoeAgAB2EYCAAHmSsIAABrIAgAAMX4CAAAR2sIAAARdg Date: Wed, 26 Feb 2020 16:46:54 +0000 Message-ID: References: <1582659566-9893-1-git-send-email-leo.duran@amd.com> <734D49CCEBEEF84792F5B80ED585239D5C4542DA@SHSMSX104.ccr.corp.intel.com> <444c59ea-70dc-0edd-d680-add054dad2c5@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leo.duran@amd.com; x-originating-ip: [165.204.25.250] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2ad8b5c2-f345-4108-5744-08d7badb7c86 x-ms-traffictypediagnostic: BN6PR12MB1281: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0325F6C77B x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6029001)(4636009)(396003)(136003)(39860400002)(346002)(376002)(366004)(199004)(189003)(81156014)(2940100002)(110136005)(33656002)(8676002)(8936002)(316002)(81166006)(6506007)(7696005)(53546011)(86362001)(5660300002)(2906002)(4326008)(55016002)(9686003)(478600001)(71200400001)(52536014)(66476007)(64756008)(66556008)(66446008)(26005)(66946007)(19627235002)(186003)(76116006);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1281;H:BN6PR12MB1922.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1EU2/iN0XAwvvb7veNRsPKQUsn6tNiwalSrovs3wTSTlu+HP6JjPEHnoRbRk3IYP7QZoV+RjST/avx2UpHbecVE7yaD739DuPYSpR9dx3QLEUaU2j4j9XkEirEbwL+6T3XQdEVahR5KJ3wtZ02dMy+X9G1+isD9+Dg5MSKdnU8GSv+2Tz/Cm0hgSQ8lApTq5iwr62Cdm3LryQfu2FL4wNTBSpky8x7w/hB5CY7Jp9vrLpQQD4RicZqhfCWe5ejEOY0sxr3bMC8wmLmxML+VNIU7NBM5x/HChiubNnY2Z0kPzvMp8ZcQ03UFhDOcUqjgdH227zhfN80WjFnkyhYRAAbSihZmhf7TcfvnOjC5hMkV4nlrJJ2cC4uNOr4ghslTkhv41Kg9tDmSKYRGiNMcEfPaeqs69lcw1/tm6GYtXS2TvWWkiKDXiQZrGPdVKUdwt x-ms-exchange-antispam-messagedata: DYOR+08hQ+HA7OXbMtDIFC60qKTdd9+Uu+i9vklvwfdQ2fMWCMP0+haaQrOjbFW54TWgLYGxVUJjPU4I1y/DgK+BiFPswH+vEnVgBVnzgmT3n5SqnmsRvpL0dSrtdnntYCPvpOdmVX7OCaznh0H1Sw== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ad8b5c2-f345-4108-5744-08d7badb7c86 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2020 16:46:54.3578 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m+Hppc/pZnaZlcM3hOHs0U9LJkvT1UN9JqHjpwtKMTEj084iMNlZwP/VrrV8uY1p X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1281 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo, et al, I suppose the same can be said about the actual "PlatformId"... it should b= e a single/global read, correct? But I'd prefer not tackling that in this patch-set (I'll defer to someone t= hat may want to take that on as an optimization/clean-up.). Leo. > -----Original Message----- > From: Duran, Leo > Sent: Wednesday, February 26, 2020 11:40 AM > To: Laszlo Ersek ; Ni, Ray ; > devel@edk2.groups.io; Wu, Hao A ; Fu, Siyuan > > Cc: Dong, Eric > Subject: RE: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in > MpInitLib >=20 >=20 >=20 > > -----Original Message----- > > From: Laszlo Ersek [mailto:lersek@redhat.com] > > Sent: Wednesday, February 26, 2020 11:21 AM > > To: Duran, Leo ; Ni, Ray ; > > devel@edk2.groups.io; Wu, Hao A ; Fu, Siyuan > > > > Cc: Dong, Eric > > Subject: Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in > > MpInitLib > > > > On 02/26/20 16:46, Duran, Leo wrote: > > > BTW, > > > > > > I also considered adding a flag to CPU_MP_DATA to make the usage of > > PlatformId a bit more explicit. > > > E.g., something like CpuMpData- > > >CpuData[ProcessorNumber].IsValidPlatformId... So the init code would > > >look > > like this: > > >> > > // > > > // NOTE: PlatformId is not relevant on AMD platforms. > > > // > > > if (StandardSignatureIsAuthenticAMD ()) { > > > CpuMpData->CpuData[ProcessorNumber].IsValidPlatformId =3D FALSE; > > > else { > > > PlatformIdMsr.Uint64 =3D AsmReadMsr64 (MSR_IA32_PLATFORM_ID); > > > CpuMpData->CpuData[ProcessorNumber].PlatformId =3D > > (UINT8)PlatformIdMsr.Bits.PlatformId; > > > CpuMpData->CpuData[ProcessorNumber].IsValidPlatformId =3D TRUE; > > > } > > > > > > This way "IsValidPlatformId" could be checked prior to using "Platfor= mId". > > > Anyway, that seemed a bit overkill, so I opted against it... thoughts= ? > > > > I think a global flag is justified; in the above approach, "IsValidPlat= formId" > > would not vary across "ProcessorNumber", so it does look like useless > > generality. > [Duran, Leo] > Great point, Laszlo. > Indeed, global makes senses in the case! > I can prepare a v2-set to incorporate that. >=20 > Thanks, > Leo >=20 > > > > Thanks > > Laszlo