From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.69]) by mx.groups.io with SMTP id smtpd.web09.133.1582739493831143562 for ; Wed, 26 Feb 2020 09:51:34 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=Azh1Caeu; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.244.69, mailfrom: leo.duran@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QXyMTqv4IfVmHCBUpSKpULADbiBcZUL5Jok8+6E2Iwtc/CFGHBBkMz/eaCxoAheShUkYcP/nQNrBKFZC6nZUEv2+MV0WizOzMyKyV6Boub1088t+0x3wqfjd8A2cefJFNs6E1oqOa6I/8EJ7nqvWjE83B3RSpQX5e+6pGQuHHT+errC9cRq+QZIA+Qa6omyLHtvN1GLqmgwncNkwNxDsvW/6VE8ZYp6o7Y0+bUP0rX2qVYnh62greyofDD7ztDTJTHIXevaafktlXP5R1kcnRtnfyWonBYahIEgDCfoys8mTZsdiTzy+BRMki6jsEwHPc9P1n3xO9Vzeg91ut235aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=92TPXELKqR1feCrt+8D3gwFkcxCMzdSuu4P68sOGPgs=; b=d35kR1zOYba5tGvEDAgobNAiB6YXd46OyBWBcz7m6Gc1z2QavWOZw2+64HIUr7SlYP5PH8vuc2bAX4gqNcCPjmVHWwaRw50AQrvLMapoxy9/huPAa9YFowJXrNWAsfu5jnFmrFX0DerLs0Qv5s1WWzcTYTP0evHXzWi77eBBvtO/JVRugfeYaIrajySsD1E22Gs3PRB7iJCE78sVvUemE7MXqunPirAIe9x2PGI7fZI2g/zdcKwuAJoIQrXn0fDDibsjuYoWOr/0wAsXNL+FV0JqRDSupoxemxQ+qBf/VAfGNS0X4ZoLV+8HIKGAQb4lFFPliomox2dF17MJUeXCeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=92TPXELKqR1feCrt+8D3gwFkcxCMzdSuu4P68sOGPgs=; b=Azh1CaeuEzJ1O08XqL/StKn+w4J65mQwc2iayyqEq8yBu7xvYy6M2Mh1Kg7rvrjuzzmNHnK+AUdGo0sTV1W7zqdUWj8t76atlbzwYRSpz+3GgAZL1knPPdJPuDUQbw/NpygWd7o+1p8bgif3zb4J27xqVQmtde2xnE12hwj2M0Y= Received: from BN6PR12MB1922.namprd12.prod.outlook.com (2603:10b6:404:106::14) by BN6PR12MB1907.namprd12.prod.outlook.com (2603:10b6:404:107::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.21; Wed, 26 Feb 2020 17:51:31 +0000 Received: from BN6PR12MB1922.namprd12.prod.outlook.com ([fe80::d931:1942:a6b5:d74c]) by BN6PR12MB1922.namprd12.prod.outlook.com ([fe80::d931:1942:a6b5:d74c%7]) with mapi id 15.20.2750.021; Wed, 26 Feb 2020 17:51:31 +0000 From: "Duran, Leo" To: Laszlo Ersek , "Ni, Ray" , "devel@edk2.groups.io" , "Wu, Hao A" , "Fu, Siyuan" CC: "Dong, Eric" Subject: Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib Thread-Topic: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib Thread-Index: AQHV7BNuZBsSC+kbJkGHn9DFW2NUaKgspoeAgAB2EYCAAHmSsIAABrIAgAAMX4CAAAR2sIAAEzCAgAAAykA= Date: Wed, 26 Feb 2020 17:51:30 +0000 Message-ID: References: <1582659566-9893-1-git-send-email-leo.duran@amd.com> <734D49CCEBEEF84792F5B80ED585239D5C4542DA@SHSMSX104.ccr.corp.intel.com> <444c59ea-70dc-0edd-d680-add054dad2c5@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leo.duran@amd.com; x-originating-ip: [165.204.25.250] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1a934e66-e57a-4b16-5b63-08d7bae48319 x-ms-traffictypediagnostic: BN6PR12MB1907: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0325F6C77B x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6029001)(4636009)(136003)(376002)(346002)(39860400002)(396003)(366004)(189003)(199004)(86362001)(110136005)(8676002)(81156014)(316002)(19627235002)(2906002)(4326008)(81166006)(64756008)(33656002)(52536014)(9686003)(478600001)(55016002)(186003)(53546011)(7696005)(6506007)(66446008)(8936002)(71200400001)(66946007)(76116006)(66556008)(66476007)(5660300002)(26005);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1907;H:BN6PR12MB1922.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nzL4/hrKy7PmM9cdTm4aK0mfAgmFWrJN1sORD/5CpE16STmXbukpXZHAzhEUHlGHKTKuOs8nkBHD3g66Zmi/gdBq/SIlSsPzCowwfXzYZ+qAoonhtEYtbmr0FLiuOjxeZ1SoPY9QFg47sIUmoG8oBvrYRy9ldk+u+UfCsQhzRzlNcJnRemOOYGFdUADlDGU3L3uOT9wWAb/4j0TIDk5V0DGdZ4FMHbLmYEgWDKqj+/ER7AErf65ya7pK4Eg25agpYp/HFMx8R1HfC495kin6boeYLOmVrrAt3FE0+8jT/iwBaP8z5pD0rOlRcb/hOx1RLvxMHuw1lGH2C9DcfJxvPRa/Jmquza0MgOCjgqBWxaLRLMBIRrIaX8PO2J2ER/C086BPAJ6qD+4F+Ptk1EVFipvMN+2Q1QDvzJW2btMMSzW6hSEW2Xde5uxcWHfrqAIC x-ms-exchange-antispam-messagedata: XafZze6695GCBB0nXfkh+WX8vihyAw16e7wQ4NUfMWB8mLEK7WlRdbPz2XEIV0k1M99hwnKQ5fV/hJ5neGw80k2G4i2yOwW5kyvqjjbzu3pxfdIhVK7yPJ2+O/909sufHQ/8fyhvQgg3hBJFdIMi+Q== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a934e66-e57a-4b16-5b63-08d7bae48319 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2020 17:51:30.9561 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mCnIzD7A6MT3S2VzZVkaWZDFhSlpzVDa8bSicgR/Yui3oaSX8TjyAwX+67QpeIfm X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1907 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Wednesday, February 26, 2020 12:45 PM > To: Duran, Leo ; Ni, Ray ; > devel@edk2.groups.io; Wu, Hao A ; Fu, Siyuan > > Cc: Dong, Eric > Subject: Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in > MpInitLib >=20 > On 02/26/20 17:39, Duran, Leo wrote: > > > > > >> -----Original Message----- > >> From: Laszlo Ersek [mailto:lersek@redhat.com] > >> Sent: Wednesday, February 26, 2020 11:21 AM > >> To: Duran, Leo ; Ni, Ray ; > >> devel@edk2.groups.io; Wu, Hao A ; Fu, Siyuan > >> > >> Cc: Dong, Eric > >> Subject: Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in > >> MpInitLib > >> > >> On 02/26/20 16:46, Duran, Leo wrote: > >>> BTW, > >>> > >>> I also considered adding a flag to CPU_MP_DATA to make the usage of > >> PlatformId a bit more explicit. > >>> E.g., something like CpuMpData- > >>> CpuData[ProcessorNumber].IsValidPlatformId... So the init code would > >>> look > >> like this: > >>> > >>> // > >>> // NOTE: PlatformId is not relevant on AMD platforms. > >>> // > >>> if (StandardSignatureIsAuthenticAMD ()) { > >>> CpuMpData->CpuData[ProcessorNumber].IsValidPlatformId =3D FALSE; > >>> else { > >>> PlatformIdMsr.Uint64 =3D AsmReadMsr64 (MSR_IA32_PLATFORM_ID); > >>> CpuMpData->CpuData[ProcessorNumber].PlatformId =3D > >> (UINT8)PlatformIdMsr.Bits.PlatformId; > >>> CpuMpData->CpuData[ProcessorNumber].IsValidPlatformId =3D TRUE; > >>> } > >>> > >>> This way "IsValidPlatformId" could be checked prior to using "Platfor= mId". > >>> Anyway, that seemed a bit overkill, so I opted against it... thoughts= ? > >> > >> I think a global flag is justified; in the above approach, "IsValidPla= tformId" > >> would not vary across "ProcessorNumber", so it does look like useless > >> generality. > > [Duran, Leo] > > Great point, Laszlo. > > Indeed, global makes senses in the case! > > I can prepare a v2-set to incorporate that. >=20 > No, sorry, that wasn't what I meant. I didn't try to suggest a global var= iable. > Instead, I meant that a "global check" (conceptually, i.e. > regardless of particular processor number) made sense. >=20 > I'm also not particularly *against* a global variable. In other words, I = didn't try > to comment on using a global variable *at all*. >=20 > Using a global variable might as well work, I just feel that your current= patches > are good enough. [Duran, Leo]=20 Great... I hear you. Then, I'd prefer not refactoring further at this point.... I hope Ray & Eri= c agree. Thanks for your feedback! Leo. >=20 > Thanks > Laszlo