From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.44]) by mx.groups.io with SMTP id smtpd.web12.9081.1582729398835942365 for ; Wed, 26 Feb 2020 07:03:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=BK0sCidl; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.93.44, mailfrom: leo.duran@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=csl0kp6S2UahE7a+fV2MsHrMjNY/VbQ/Lulk/Z/Uth5cfML/MKnnG1e0fVkw6H+C9mkBc+Za7H9C96Q3uPQpcjPNzLlrZstaI56/H20zeWH2HSl471Y6gLr+PfPUN7DOecAH5Sa3WFeG2ux7rb0ogNeI2yBaLv84DRdC1vt3A9/A4as36i8biCOxRB7wLIqLqKZrnYO6+RnGS5W2REvIe5ge/3gS9FIJJsVedGvXfMN7/uh+9V5/YuZD7fCiyQhIM/S+mZUH1oRv38xDb8O6bQIq/pJx9YKAUvYYI8bcVyUijhcKe6C5aDyCjPh/TS+XBBrI172DG2uq64t8s3saUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H+JzPUr4eQVICuwzseht1CM0MCTkoa12wnXbZAIp8A4=; b=D7EiooR32cCoXENBhi40SjV+ijRPJrUQp81SvTiZBTUAENg8c0hif1wEaDeoCBv5ULRMc9qwdsFKs2dZMtPOLr+hQPYjfSMVu7kcAl462LqYurzwKbY9n7n2UIsLQ3p3Ylg9927NKhGOQVv28Xgy9pd9I3s2Ki7lOfJIuKMd0IYn1u6BfBdWKpTx6sFD1rldZt7M978p0ymzZS76farCOUeKWAlpj3Ij0QK+0iQyHOLmpUhFNbEb1MDnJsjjdRiSCBTUTyALoBj2d6Og3svmSs4eM036vbzF814ojVt05S492tfGHSuGzWfWAlBPh8DHSRyDmozZsONySIdUI0zgGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H+JzPUr4eQVICuwzseht1CM0MCTkoa12wnXbZAIp8A4=; b=BK0sCidl9cTrVns2yoIVgMYNpLxJ/xy0BN/Zf+OHEfROFtu4U37lyBnt8RDp+WrJ4k2JLGFL0EEgdxXbY7H1scteld+P8J0o9bgSs24ld2mIXuuB5uAMDZagW+cC6e12l4tyOsYeYLTeieESFQx9v2/O1JKwZoS6PmGWW5v4ss0= Received: from BN6PR12MB1922.namprd12.prod.outlook.com (2603:10b6:404:106::14) by BN6PR12MB1492.namprd12.prod.outlook.com (2603:10b6:405:11::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.14; Wed, 26 Feb 2020 15:03:17 +0000 Received: from BN6PR12MB1922.namprd12.prod.outlook.com ([fe80::d931:1942:a6b5:d74c]) by BN6PR12MB1922.namprd12.prod.outlook.com ([fe80::d931:1942:a6b5:d74c%7]) with mapi id 15.20.2750.021; Wed, 26 Feb 2020 15:03:17 +0000 From: "Duran, Leo" To: Laszlo Ersek , "devel@edk2.groups.io" , "eric.dong@intel.com" CC: "Ni, Ray" Subject: Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg: LocalApicLib: Export StandardSignatureIsAuthenticAMD function Thread-Topic: [edk2-devel] [PATCH 1/2] UefiCpuPkg: LocalApicLib: Export StandardSignatureIsAuthenticAMD function Thread-Index: AQHV7BNzW5NTADVc5E2Fs4Spy7z77qgsq76AgAAWQpCAACqnAIAAVeSAgABKdYA= Date: Wed, 26 Feb 2020 15:03:16 +0000 Message-ID: References: <1582659566-9893-1-git-send-email-leo.duran@amd.com> <1582659566-9893-2-git-send-email-leo.duran@amd.com> <7748cd85-7255-6319-e1a4-c6d12260b4b0@redhat.com> In-Reply-To: <7748cd85-7255-6319-e1a4-c6d12260b4b0@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leo.duran@amd.com; x-originating-ip: [173.170.80.115] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 61d052f4-67a8-47ed-121e-08d7bacd02a3 x-ms-traffictypediagnostic: BN6PR12MB1492: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:565; x-forefront-prvs: 0325F6C77B x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6029001)(4636009)(346002)(396003)(366004)(136003)(376002)(39860400002)(189003)(199004)(8676002)(66476007)(71200400001)(8936002)(478600001)(66946007)(86362001)(66446008)(5660300002)(66556008)(81156014)(81166006)(110136005)(76116006)(64756008)(316002)(6506007)(52536014)(53546011)(186003)(33656002)(26005)(2906002)(4326008)(7696005)(9686003)(55016002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1492;H:BN6PR12MB1922.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UC02IjhQIYD9ERLBeeu//9SuTwhG7h95BQ1hf0tYcjEFQ0rvLzWJ17CwqBdW/zapXGHBXYH1wz7RRJEwOI6VwQRKqXgakGzQvlvGGE2FmpPh7My5pBfQPfLsJePygstu/J3Lvrn5opiylCZeKRWMoL/9OPvV2KyyavdOKygUquo8DMCSukJ0Sur5ZeGF21C65pBel0QXjxL7VQ3V2yodTM3dS5UWHdFzrZ5WlUq9crb1A8Vat7SBQRyTsuG9GFrwGOwvDMttEftgge013VBvzWTW7pir0K6uhZxdQXV5NnybNCMS/lE3+5Cyzj8kp2WPBnMQJJl+ETF/NyienqB5+EL3gB8yNChT/IR5Qm6vuQ8Mzn6EOfkwypeDpdG5VFYcapqk4POkEPelBamKgYzZcr57cZ8OIGVoSEe7aIXNwDaCq72SrttrNsfdPYXDBt6v x-ms-exchange-antispam-messagedata: lrBDnZMGdo+WLtk2xTX/ES2k4yj3AwzxN8C6gASXoQSk1tOsy1KtDkeoq+Bzd/oy54kitEa6hUMgvYJAsqUuPdYgKQTyNRKuc8ad/k9YPePHJBqObUVt/uaofKgCOkqLnkNYk3412ikR1GN02R5P/w== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61d052f4-67a8-47ed-121e-08d7bacd02a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2020 15:03:17.0218 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: x3xNFTzcXts2u6RsYVYVanWJ1FfoCCrQm9gixluxVAz5F1+L8DTcgNfFeocuxsGl X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1492 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Wednesday, February 26, 2020 5:13 AM > To: devel@edk2.groups.io; eric.dong@intel.com; Duran, Leo > > Cc: Ni, Ray > Subject: Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg: LocalApicLib: Export > StandardSignatureIsAuthenticAMD function >=20 > On 02/26/20 06:05, Dong, Eric wrote: > > Hi Leo, > > > > Yes, I means you also change the cod position in the c file, so in the = patch > file, it seems like it has other changes. > > My recommendation is to refine the patch to not change the code postion= . >=20 > Indeed I noticed that too. I figured this change -- moving the code aroun= d, > beyond purely making it public -- was intentional. I assumed the new posi= tion > of the function within the source code made more sense to Leo. [Duran, Leo] You're exactly right, Laszlo, let me explain: The function was moved down because the top spots are reserved for internal= functions, according to this comment in the source:: // // Library internal functions // In this case, there were two internal (local) functions at the top of the f= ile: BOOLEAN StandardSignatureIsAuthenticAMD ( VOID ) { } BOOLEAN LocalApicBaseAddressMsrSupported ( VOID ) { } So I moved them like this: BOOLEAN LocalApicBaseAddressMsrSupported ( VOID ) { } BOOLEAN EFIAPI StandardSignatureIsAuthenticAMD ( VOID ) { } Other functions that follow are external functions, using the EFIAPI prefix= . Leo. >=20 > I agree the code movement should be explained at least in the commit > message. >=20 > Thanks > Laszlo