From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.82]) by mx.groups.io with SMTP id smtpd.web12.10843.1582735192591872620 for ; Wed, 26 Feb 2020 08:39:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=IM9MbRK3; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.244.82, mailfrom: leo.duran@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M1mrxwRJkpvQBxlPkVB9YlfXdlk0IhZH+6sCDpam9D6iRbCznRaaPSmGzksax+LxNqH+hifVbBiOzuTRl52+25afYsZ4R/TXAn9wcj0XmiWtLYleioif0lHHczEe655y17ImfumIV2YDKVxTfctLlYV6OU91Qegmzs9PIBwIOj0nq6N40ju2/RHy24Z86wK3MSlb51xGUsNaI8FXSoNcKU1PNv45qVA+qATyyc2fcdd2LBFL/My6gwow9cDPlLXAQHKlFN9QJ+j5InECu3xaaS9O3VXSjACUWSKqMN5ekeqbr48CSO9ox+/U1Yo4aaMsF0giaP/E5XI2k238b5Gz5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EXHkgS486l6oY1LJcm1hXkNyHZQupzamNxEaFK0PtlA=; b=f6FbkYPU57O2UggIe0YXjodWdNR7FTRqrRbKmj0bJcaArc8i/c4pDpySGhBNtIcBQdpXKifhdkxRVW85+gCT1MyyRV0WUwVCN59E3tnFEEfle8j2e7FtnMLsByNLU2Cry9966oCIF3XV8Rrz2f7w/vpRAD76dvLnHGPEHx1V+NYfA4+fUybc77+5zcyAyw1PFMv0724/qjiQpUi9SuYvtEfrqxlqpFulutTTwgqwXJTKl1EA9N83IMGywRFb3q3suwLgSy5g3rx9OeYC+lZkMuzoA+HXOugC8jU/92PcE96VtFXmO9vzutfYFYup5uY5EqeuPoJcvwG0Ccv96O1UVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EXHkgS486l6oY1LJcm1hXkNyHZQupzamNxEaFK0PtlA=; b=IM9MbRK3TpkSJyMQmKeggpJLd3Re9PYY9poHt5zzSVSEji+xe/P1KuqdK/zoBB1Q2B1NUPYneicENZX9rHjDn1oxurAsKL5XtpJs9I2zDp3hQWJvHgwzIkZM4qyLRKe5tnTD3eH9tu57wql0qXI5MDh4DS68v/1wOlnyT1iuySk= Received: from BN6PR12MB1922.namprd12.prod.outlook.com (2603:10b6:404:106::14) by BN6PR12MB1281.namprd12.prod.outlook.com (2603:10b6:404:1b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.14; Wed, 26 Feb 2020 16:39:51 +0000 Received: from BN6PR12MB1922.namprd12.prod.outlook.com ([fe80::d931:1942:a6b5:d74c]) by BN6PR12MB1922.namprd12.prod.outlook.com ([fe80::d931:1942:a6b5:d74c%7]) with mapi id 15.20.2750.021; Wed, 26 Feb 2020 16:39:51 +0000 From: "Duran, Leo" To: Laszlo Ersek , "Ni, Ray" , "devel@edk2.groups.io" , "Wu, Hao A" , "Fu, Siyuan" CC: "Dong, Eric" Subject: Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib Thread-Topic: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib Thread-Index: AQHV7BNuZBsSC+kbJkGHn9DFW2NUaKgspoeAgAB2EYCAAHmSsIAABrIAgAAMX4CAAAR2sA== Date: Wed, 26 Feb 2020 16:39:51 +0000 Message-ID: References: <1582659566-9893-1-git-send-email-leo.duran@amd.com> <734D49CCEBEEF84792F5B80ED585239D5C4542DA@SHSMSX104.ccr.corp.intel.com> <444c59ea-70dc-0edd-d680-add054dad2c5@redhat.com> In-Reply-To: <444c59ea-70dc-0edd-d680-add054dad2c5@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leo.duran@amd.com; x-originating-ip: [165.204.25.250] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 895ad767-7c47-4b3c-919b-08d7bada8039 x-ms-traffictypediagnostic: BN6PR12MB1281: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0325F6C77B x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6029001)(4636009)(396003)(136003)(39860400002)(346002)(376002)(366004)(199004)(189003)(81156014)(110136005)(33656002)(8676002)(8936002)(316002)(81166006)(6506007)(7696005)(53546011)(86362001)(5660300002)(2906002)(4326008)(55016002)(9686003)(478600001)(71200400001)(52536014)(66476007)(64756008)(66556008)(66446008)(26005)(66946007)(19627235002)(186003)(76116006);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1281;H:BN6PR12MB1922.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NXfXdzxT9uQGX9omlqpk47+ia+bmZUJKNndOcfRu2kTJrau93Z/mQZ3G/vfUS3WFsqxMr9VxDF7GWy2hZLDfxhp4bWv77XEe2v4ubwaArTfAnTI9j2qjNcXiUdtZ16qzQ5Iy2xw4CoNxzUdJZOgBS671Evc8AMHY5YbZFXd3u83xoKZHCSP3SdlrMSkGqrFqpHiOgYKDH24dn9suBkgvzdyLybCP/ErciMYvRTLV+PtcedXaVz7UdD2mZSf3PeJnn/lqfoJFr+hrZSlAMUT6NeimTL0mMo7e0KIXJHt6iKe2wHcvUeISQdMsDkLeuk9o6xll2aEATxztLU5hlPBTCZzhPaM7TdNdmLHSxAWpXabIVIqLffBUfNv5BytHcoKTjprUp4njb7pGVUjgnwTZKnoE1ufP/tkkS5dRFAwH/fujipTV4WHxBkBOwZ3eCNRi x-ms-exchange-antispam-messagedata: 56dodLrWeDfdZlFcvqnzhc09W8afIkVDBu8nN/kNkOzwnzDpX9D21PSfKbGi8G3jhhy2SaVDaPsgP9gdghA3JNusugMK82nd8eBNHJ1NiH6EzaVQSWkGZGL2Nh7Xe2U19EkS7Yy44/YrzYBgey28EQ== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 895ad767-7c47-4b3c-919b-08d7bada8039 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2020 16:39:51.1358 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: C6h+32I/nQePBDtL98adX9Y4d61tSuvn7fiX+X0BxnKn9t1ysvMyO1YMFDEfTBEk X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1281 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Wednesday, February 26, 2020 11:21 AM > To: Duran, Leo ; Ni, Ray ; > devel@edk2.groups.io; Wu, Hao A ; Fu, Siyuan > > Cc: Dong, Eric > Subject: Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in > MpInitLib >=20 > On 02/26/20 16:46, Duran, Leo wrote: > > BTW, > > > > I also considered adding a flag to CPU_MP_DATA to make the usage of > PlatformId a bit more explicit. > > E.g., something like CpuMpData- > >CpuData[ProcessorNumber].IsValidPlatformId... So the init code would loo= k > like this: > > > > // > > // NOTE: PlatformId is not relevant on AMD platforms. > > // > > if (StandardSignatureIsAuthenticAMD ()) { > > CpuMpData->CpuData[ProcessorNumber].IsValidPlatformId =3D FALSE; > > else { > > PlatformIdMsr.Uint64 =3D AsmReadMsr64 (MSR_IA32_PLATFORM_ID); > > CpuMpData->CpuData[ProcessorNumber].PlatformId =3D > (UINT8)PlatformIdMsr.Bits.PlatformId; > > CpuMpData->CpuData[ProcessorNumber].IsValidPlatformId =3D TRUE; > > } > > > > This way "IsValidPlatformId" could be checked prior to using "PlatformI= d". > > Anyway, that seemed a bit overkill, so I opted against it... thoughts? >=20 > I think a global flag is justified; in the above approach, "IsValidPlatfo= rmId" > would not vary across "ProcessorNumber", so it does look like useless > generality. [Duran, Leo]=20 Great point, Laszlo. Indeed, global makes senses in the case! I can prepare a v2-set to incorporate that. Thanks, Leo =20 >=20 > Thanks > Laszlo