From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.114]) by mx.groups.io with SMTP id smtpd.web10.745.1586298898358996824 for ; Tue, 07 Apr 2020 15:34:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=UOpzif6D; spf=pass (domain: microsoft.com, ip: 40.107.237.114, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fs8Xc9WB8SgFtTS7su/CUBid7jr11Wtor8eIwJZZWiEq8Dt5gw7kIo4h6FkZWnf4T0FH9QUtx7KlX0g0X3OHBOE0IXnYi4ThtQueKCMmOV62UtPiquaZnFrigLw28CekeMShia87A9QXYnBG2pAK0ikiDZCv5cR9sx8/u/7+aG8vykG7LfLBQ/0Kjz/nskfqMBhN9LRqy6mZJGzq700DnmO6g0EHRTv5byIX46VrsdZPg0cqbPQR8L6RqjhfvipEbhsNpaOgWngYi/sdoAAhg+VzWjHX9+j/ohUHLPZE/t3+BS8J3UASHXgurzghnKJ5b4tEpinGztLTij6oAf8lWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BkE/bcRBJDpsBG5L6rSJ8OKQ9W5E6FtE7yIKEdbTydk=; b=ksIhhb0a0N6OhaX41vRsFuipmwk7O7m92OBhkkGZUkvvr/0DO9+y2WApZ3duaXyLcoLd7cIoFZsbXeNI1Z6e9W1SiLeKyLzcK5Lk9W6ruhfED+3LyFrLxVO7ALhpJOOvy174xSnjY+66fPlBu5hKaDzPO0DCznXEBxhyslQbomOrEdvgxIqBBqSfX624RI13kyJ5rR3TpjULVrd4Q7uw7d/7c7kkbvHEqlBtIvzBKUfTMNc8taE4j863enPFaLj3lXs3kofn8n19LLMg8Gvzpwctp1FqQGQfEAMPvo89xp2JjjEF2nmXe2sWyuvU7EabV2s3eQ5lDl9ZcUOK7rkM0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BkE/bcRBJDpsBG5L6rSJ8OKQ9W5E6FtE7yIKEdbTydk=; b=UOpzif6DC7ujPCSyG+bU7dPfTkEsRsPAMlcBipyT/el349qOs81+HIlkdnIRWWfcw9O3VJ4P1BG8J/tL4wSCKVIS6fzrZgpqlCatzZJXOMQYxV53rijZzOFUyI8iIyNOhqhxMaHLshkNGDidFnZIMNg0SC6v/bZDiTaDswll+5U= Received: from BN6PR21MB0739.namprd21.prod.outlook.com (2603:10b6:404:93::9) by BN6PR21MB0849.namprd21.prod.outlook.com (2603:10b6:404:9e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.4; Tue, 7 Apr 2020 22:34:51 +0000 Received: from BN6PR21MB0739.namprd21.prod.outlook.com ([fe80::8d95:26f7:2c1e:e80a]) by BN6PR21MB0739.namprd21.prod.outlook.com ([fe80::8d95:26f7:2c1e:e80a%13]) with mapi id 15.20.2921.000; Tue, 7 Apr 2020 22:34:51 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , "michael.kubacki@outlook.com" CC: Kun Qin , Jian J Wang , Jiewen Yao , Chao Zhang Subject: Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/2] SecurityPkg: Add PCD for SW SMI Command port Thread-Topic: [EXTERNAL] [edk2-devel] [PATCH v1 1/2] SecurityPkg: Add PCD for SW SMI Command port Thread-Index: AQHWDEIgfOUOKxZJfkWqCWcRnLseeqhuQOk8 Date: Tue, 7 Apr 2020 22:34:51 +0000 Message-ID: References: <20200406183422.37140-1-michael.kubacki@outlook.com>, In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-04-07T22:34:34.6101151Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bret.Barkelew@microsoft.com; x-originating-ip: [71.212.145.195] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9d597af1-b4fb-4eba-529d-08d7db43e333 x-ms-traffictypediagnostic: BN6PR21MB0849:|BN6PR21MB0849: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-forefront-prvs: 036614DD9C x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR21MB0739.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(4636009)(39860400002)(136003)(396003)(376002)(346002)(366004)(110136005)(10290500003)(8990500004)(52536014)(33656002)(316002)(53546011)(478600001)(71200400001)(5660300002)(966005)(7696005)(186003)(86362001)(6506007)(82950400001)(9686003)(64756008)(15650500001)(55016002)(66476007)(8936002)(76116006)(54906003)(82960400001)(81156014)(81166006)(4326008)(66556008)(91956017)(26005)(66946007)(66446008)(8676002)(2906002)(21314003);DIR:OUT;SFP:1102; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XUTM/HM9SvAaBMEwyIWDYaxxHUNAkabpDOnEbUo/MmNBD7hEPtG+oMj3jwTbBAUG1Nh1i8pHklXh/STTfDdAHfnbVwyuT5ccPdtfUr9+vkEUh88p/d9pikE/vrzXz0jX2aiWOn3eH+LNOaMZ3NC5d4JWjBcbcRQHNUIlB9nZL1RM2glRmEXIAaoriukpnT4rUHnAceE1yoZIbUe9XdD3bDXNDT3Z3Y7D+Qrj9JcqIg0f6CFzOZkEpzJ/sGrUf2KEvV8/vEsDPweUnyMPryae5DnbMWDfxS7Ofc+JJEyaahIJ24SWhQuCE9CqI/qPG4JkymYTRUtHJbPk38uqxt0/wewL7/DbDhuBIroYYEGr7PybYfSpCkbmv+TeVUTjZd0wWR+lMcHKLtaWLkCEMqELubjSFt5vg+zR3Lkgo/dBxXpln4zP4k/SZzPYfkOUXaFZiI5hWTisOHU/hG4ZBT4bxR6Ga1DGlca7m7Y1q6I05BQOLUxf6xaFy5EgGyuDOeFGxyoGKVlaOW3dA6Cr32dFhNhqO/xoG08ffZYcDGpK6cM8pYSdRNybmUxsMeNOuT4q x-ms-exchange-antispam-messagedata: 0MitiJ2Ocf/zxs71DjVWzmTtBEVWytdB3XFKf+SyDxeogXlf445R5AMsdD1/IKdWwDr4QBuP4PuJEdEcsL7WIFvTmnvPRNNgyF7Ibf5TBjaO4urnSpFu/WppdsEm33lvtY12i8XSmFILDXW/UGyKAg== MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d597af1-b4fb-4eba-529d-08d7db43e333 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2020 22:34:51.5578 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JdUhG+NdnES9mdOvAeWI5jmZ5zRfL9IJLQpt6VTPI+Uh99EvyfC3j5W/0762I7qQCJ45krS73q4DJHkrhXhwUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR21MB0849 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN6PR21MB07392FDFBDB886988346D1F1EFC30BN6PR21MB0739namp_" --_000_BN6PR21MB07392FDFBDB886988346D1F1EFC30BN6PR21MB0739namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bret Barkelew - Bret ________________________________ From: devel@edk2.groups.io on behalf of Michael Kub= acki via groups.io Sent: Monday, April 6, 2020 11:34:21 AM To: devel@edk2.groups.io Cc: Kun Qin ; Jian J Wang ; = Jiewen Yao ; Chao Zhang Subject: [EXTERNAL] [edk2-devel] [PATCH v1 1/2] SecurityPkg: Add PCD for S= W SMI Command port From: Michael Kubacki REF:https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbu= gzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2416&data=3D02%7C01%7CBret.B= arkelew%40microsoft.com%7Cbc0a9b59de37406bb30708d7da594167%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637217949197836672&sdata=3DIoTwuyyUc6ZLxHp= yMCfWwtvnJb50g9bxfMoM4cl8O4s%3D&reserved=3D0 Adds a PCD to SecurityPkg used to specify the SW SMI Command port. This value may vary across platforms and is current hardcoded to 0xB2 in package code. Cc: Kun Qin Cc: Jian J Wang Cc: Jiewen Yao Cc: Chao Zhang Signed-off-by: Michael Kubacki --- SecurityPkg/SecurityPkg.dec | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec index 2cdfb02cc5a2..87b1fbad8056 100644 --- a/SecurityPkg/SecurityPkg.dec +++ b/SecurityPkg/SecurityPkg.dec @@ -7,7 +7,7 @@ # # Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.
# (C) Copyright 2015 Hewlett Packard Enterprise Development LP
-# Copyright (c) 2017, Microsoft Corporation. All rights reserved.
+# Copyright (c) Microsoft Corporation.
# SPDX-License-Identifier: BSD-2-Clause-Patent # ## @@ -272,6 +272,12 @@ # @ValidList 0x80000003 | 0x010D0000 gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeSubClassTpmDevice|0x010D0000= |UINT32|0x00000007 + ## Defines the IO port used to trigger a software System Management Int= errupt (SMI).

+ # Used as the SMI Command IO port by security functionality that trigg= ers a software SMI such + # as Physical Presence Interface (PPI).
+ # @Prompt SMI Command IO port. + gEfiSecurityPkgTokenSpaceGuid.PcdSmiCommandIoPort|0xB2|UINT16|0x0000000= 9 + ## Progress Code for FV verification result.

# (EFI_SOFTWARE_PEI_MODULE | EFI_SUBCLASS_SPECIFIC | XXX) # @Prompt Status Code for FV verification result -- 2.16.3.windows.1 --_000_BN6PR21MB07392FDFBDB886988346D1F1EFC30BN6PR21MB0739namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bret Barkelew <bret.barkelew@micros= oft.com>

 

- Bret

 

From: devel@edk2.groups.io= <devel@edk2.groups.io> on behalf of Michael Kubacki via groups.io &l= t;michael.kubacki=3Doutlook.com@groups.io>
Sent: Monday, April 6, 2020 11:34:21 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Kun Qin <Kun.Qin@microsoft.com>; Jian J Wang <jian.j.w= ang@intel.com>; Jiewen Yao <jiewen.yao@intel.com>; Chao Zhang <= chao.b.zhang@intel.com>
Subject: [EXTERNAL] [edk2-devel] [PATCH v1 1/2] SecurityPkg: Add PC= D for SW SMI Command port
 
From: Michael Kubacki <michael.kubacki@microso= ft.com>

REF:https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbu= gzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2416&amp;data=3D02%7C01%7CBr= et.Barkelew%40microsoft.com%7Cbc0a9b59de37406bb30708d7da594167%7C72f988bf86= f141af91ab2d7cd011db47%7C1%7C0%7C637217949197836672&amp;sdata=3DIoTwuyy= Uc6ZLxHpyMCfWwtvnJb50g9bxfMoM4cl8O4s%3D&amp;reserved=3D0

Adds a PCD to SecurityPkg used to specify the SW SMI Command port. This value may vary across platforms and is current hardcoded to 0xB2 in
package code.

Cc: Kun Qin <Kun.Qin@microsoft.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 SecurityPkg/SecurityPkg.dec | 8 +++++++-=
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
index 2cdfb02cc5a2..87b1fbad8056 100644
--- a/SecurityPkg/SecurityPkg.dec
+++ b/SecurityPkg/SecurityPkg.dec
@@ -7,7 +7,7 @@
 #
 # Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.= <BR>
 # (C) Copyright 2015 Hewlett Packard Enterprise Development LP <B= R>
-# Copyright (c) 2017, Microsoft Corporation.  All rights reserved. &= lt;BR>
+# Copyright (c) Microsoft Corporation.<BR>
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
 ##
@@ -272,6 +272,12 @@
   # @ValidList  0x80000003 | 0x010D0000
   gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeSubClassTpmDevice|= 0x010D0000|UINT32|0x00000007
 
+  ## Defines the IO port used to trigger a software System Manag= ement Interrupt (SMI).<BR><BR>
+  #  Used as the SMI Command IO port by security functional= ity that triggers a software SMI such
+  #  as Physical Presence Interface (PPI).<BR>
+  # @Prompt SMI Command IO port.
+  gEfiSecurityPkgTokenSpaceGuid.PcdSmiCommandIoPort|0xB2|UINT16|= 0x00000009
+
   ## Progress Code for FV verification result.<BR><BR&= gt;
   #  (EFI_SOFTWARE_PEI_MODULE | EFI_SUBCLASS_SPECIFIC | XX= X)
   # @Prompt Status Code for FV verification result
--
2.16.3.windows.1




--_000_BN6PR21MB07392FDFBDB886988346D1F1EFC30BN6PR21MB0739namp_--