From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.15215.1589213110539878040 for ; Mon, 11 May 2020 09:05:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=mPpU2Wnl; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: wei6.xu@intel.com) IronPort-SDR: PipMuNOuPjllMouToZRP6DXYoj4aAZ4is5R3u5dAKIOnoZHGHGmg3Kjlkukm5nGnp+wvweaUtq s5OcT9YsekIQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 09:05:09 -0700 IronPort-SDR: SC4Su2A6QiNnpkO6zxdsFoD+AKZBsn4mYiVYyFyQOooYn+OthfOtLU5y4d+l4VAttqAveLLEWO kBuzfaw5svtw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,380,1583222400"; d="scan'208";a="251197765" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga007.fm.intel.com with ESMTP; 11 May 2020 09:05:08 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 09:05:08 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 11 May 2020 09:05:07 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 11 May 2020 09:05:07 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 09:04:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UwqPbkSZMm85iDfZLBfW9SrBlB1Q7V+lSRK2pNMSRJRSiQKdDcPV1viVcyKTzr/F0dd77R8RJwkyKRkkEFNKEW3BJ2qh9KW6QXhf7S2imvZKTzinu6eqzChLROvUCQg79AVIMod9R5xiofaPfgLj26LCXTeqbxfuZ+n9NHibpWeup2fUBdV5JXHBMYr0RTK/bLbk2LaydK/GZr4yqRhyl/rK811oc28S9mLAv73I3R8GGIZTTHHfY8csXZjij5Qf8m2kmSKiForyk819Sww0z2J5sJ/Nyts13VH7AneMYhCyoPjyk7Y4lEtlHDElXjKfb36nPuQ+ayXpwZPdxWb3Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TnueBtzmS7G+zkdx9gbmAqq5JTx1mWFifwRj3u6R2JU=; b=SQ19aSQBdEzSnMbIMo7okC5scBpulQVAWXGzVDIr2OajLRRqTevzqTQ+V2s8dAbZ8y78NTSbKxdW6mu4TACEHxQwO84Egyrn6qpPIBZ8MvVm+CCQXCKutzCFYBOrY1f2kIImmqRLet645lYkoSoYWGFrzhdPFhHXlJO/it60ON2h/KNfEN4MTAc2D1MJij6hYmbgWxjqvThjQY+90uwZW2vp96ZeGbUVTcDdXI2bFtkMipgy9Mw6ehNIat4nDQZa3rS0FFqLGh2GBn8wm2kCz6+HuuEpMbSA4QU5+HxnGq3z+iNyjKGtmWDkd6gnLWhhUF2vdli6kBspecDbKHDU2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TnueBtzmS7G+zkdx9gbmAqq5JTx1mWFifwRj3u6R2JU=; b=mPpU2WnlWzh+HgkhAVJumU+oZfVgU/Q4+mRK17yj7eTTeBw06TrYTuuOZ+bLzhkF0+yIyjYyYiaXVUsQPvNpkGLzH1wQhzgufJB1VXgu1Jbqr0WZgeKcUswunobxb+nb+VAaAlcJPDEV8XJdYspuAUExsRfKAPL+Mg5wGZrvelk= Received: from BN7PR11MB2770.namprd11.prod.outlook.com (2603:10b6:406:b4::20) by BN7PR11MB2852.namprd11.prod.outlook.com (2603:10b6:406:a9::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.33; Mon, 11 May 2020 16:04:55 +0000 Received: from BN7PR11MB2770.namprd11.prod.outlook.com ([fe80::2929:ecd:8139:6a56]) by BN7PR11MB2770.namprd11.prod.outlook.com ([fe80::2929:ecd:8139:6a56%4]) with mapi id 15.20.2979.033; Mon, 11 May 2020 16:04:55 +0000 From: "Xu, Wei6" To: "devel@edk2.groups.io" , "Liu, Zhiguang" , "oleksiyy@ami.com" CC: "Gao, Liming" , "Kinney, Michael D" , "Felixp@ami.com" Subject: Re: [edk2-devel] [PATCH 4/4] MdePkg: Add FMP Capsule Image Header extension Thread-Topic: [edk2-devel] [PATCH 4/4] MdePkg: Add FMP Capsule Image Header extension Thread-Index: AQHWD3KJDyFmyoaCQ0egBQVcDIFL2aiil+kAgAChfuA= Date: Mon, 11 May 2020 16:04:55 +0000 Message-ID: References: <20200410195803.19972-1-oleksiyy@ami.com> <20200410195803.19972-5-oleksiyy@ami.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c48fb6f6-13d9-45a2-88c8-08d7f5c50c19 x-ms-traffictypediagnostic: BN7PR11MB2852: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-forefront-prvs: 04004D94E2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pX4+YPK7wRm4Esy4LioNskrBiXoPSC+QYObjUVoeqgUp9OVp4s3A0sUAqPCgLLZkfyyR9Ot5WGiUrF6NpWG12vcuKOaCpK9xkxagUbB3Ons4u9kOsIru4DZ00Ath86dVFz7MTvxNyni2N0gAf3dq3Zd6qDvmUNAvxcHcEI+vDArjewLvS7VB6i8iCviSERN8dJ7at0tQQfVfanhfFGXvIqRfaPuv9FDs+1p7UlBFGSNpSo9aW1YhoSYWoSD1vUC9NIXpJ/fWk+itPavuPadNUyjuLkcipcoXVM1zBq7XloRVe3E4yZPyg3ciF9AEbkOnOlTV2c8dEJSOMNrlmeF8q7MlV/XVQy0qcixCpl03xxR9wR97H4JJYmmzM00TU9Rd/YJFR1QLtlye3ItxoX2Pxf28c1NC/Rn/C0S3TUfbvh9G92ii6bvm0zD8HAVo6tNLhXSfRCqqdVDb3NTdzPFrbuA0yrmSfYojxZnYzmJZjkemT2GGv/4Amr+7yvIa++GdXNUl3Ps0B5UAVydi63VtKd1BljwE0dMmSEqLB9sW5+2iIRFDcZFRkkIxS4JiNcP+TCK2+AmiGzjB9YoHqXri8VwsBbzJZA3c1qcTZmwDTTQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR11MB2770.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(39860400002)(366004)(376002)(396003)(136003)(346002)(33430700001)(478600001)(86362001)(33440700001)(9686003)(7696005)(55016002)(71200400001)(966005)(33656002)(4326008)(5660300002)(8676002)(8936002)(2906002)(316002)(26005)(66476007)(66556008)(186003)(76116006)(66946007)(64756008)(110136005)(53546011)(66446008)(54906003)(52536014)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: czI0dXR+Bf4valx7UASwZGzktE6YYikzi3Q+TqAFxnPBTjE4Cma2at8jx9EbS9GllPv0TIxsxnreOaF3yq+1ZHDfUXvxxXDNuVDhKRfguAHVFdphsfCff1oP2VpRvqJ4YG+Vf7TQ0pQY33qyYf9jEpr29VKU9rUb1nKdAfJuJEk78sqYJSQ5zDm9Vk9+xHl+GQo8coqNBhuOqf4D9f5Qs1bJhRhOBYxrhJKo3FgGONUoHtjVopSACQvEeLHH8+zFxsRDIKeDp/GwXI6R0QhMpD+MEE3KwK9b82OuRFhDk19+c7dmkLU0hy9rUGnWFoEOyA/xjjJYoD/XVEj59iqowrN3Ag94zmVSQJYuebQuuSzVuQCQzcZ5gUSbOMQPSWzWOyRVMMbHHdmtinNEiilAICm2NBYMyX+Ha4uSJ+6QjoEB2ZM6T4JH+4ZvnTbEdGUnrBLZ2POgiLjvCKF+Z8DHyIG1KE5e29aKcFQJaAyPiRni3zG/M7usPNSqj9+9XaOb MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c48fb6f6-13d9-45a2-88c8-08d7f5c50c19 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2020 16:04:55.4947 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lIkEjZJUtBkphLXvxt0qNbVU6KkTE5BOScvlW/5kNKgD353INvb5j8yWZIiPYTlS6RX1woe4oCXJazH/LZLShQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2852 Return-Path: wei6.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Oleksiy, Please help to update the related header version check as well. Thanks. For example, https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Li= brary/DxeCapsuleLibFmp/DxeCapsuleLib.c#L288 Without updating the version check, it will cause header size miscalculati= on and lead to capsule update failure. BR, Wei -----Original Message----- From: devel@edk2.groups.io On Behalf Of Zhiguang Li= u Sent: Monday, May 11, 2020 2:14 PM To: devel@edk2.groups.io; oleksiyy@ami.com Cc: Gao, Liming ; Kinney, Michael D ; Felixp@ami.com Subject: Re: [edk2-devel] [PATCH 4/4] MdePkg: Add FMP Capsule Image Header= extension Reviewed-by: Zhiguang Liu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oleksiy= =20 > Yakovlev > Sent: Saturday, April 11, 2020 3:58 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D=20 > ; Felixp@ami.com; oleksiyy@ami.com > Subject: [edk2-devel] [PATCH 4/4] MdePkg: Add FMP Capsule Image Header= =20 > extension >=20 > Add bitmask to structure which gives a binary-inspectable mechanism to= =20 > determine if a capsule contains an authentication section or depex secti= on. > (UEFI 2.8 errata a, mantis 2026) >=20 > Signed-off-by: Oleksiy Yakovlev > --- > MdePkg/Include/Guid/FmpCapsule.h | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) >=20 > diff --git a/MdePkg/Include/Guid/FmpCapsule.h > b/MdePkg/Include/Guid/FmpCapsule.h > index fb8c346..6bbdf0e 100644 > --- a/MdePkg/Include/Guid/FmpCapsule.h > +++ b/MdePkg/Include/Guid/FmpCapsule.h > @@ -79,13 +79,22 @@ typedef struct { > /// therefore can be modified without changing the Auth data. > /// > UINT64 UpdateHardwareInstance; > + > + /// > + /// A 64-bit bitmask that determines what sections are added to the > payload. > + /// #define CAPSULE_SUPPORT_AUTHENTICATION 0x0000000000000001 > /// > + #define CAPSULE_SUPPORT_DEPENDENCY 0x0000000000000002 /// > + UINT64 ImageCapsuleSupport; > } EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER; >=20 > #pragma pack() >=20 >=20 > #define EFI_FIRMWARE_MANAGEMENT_CAPSULE_HEADER_INIT_VERSION > 0x00000001 > -#define > EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER_INIT_VERSION > 0x00000002 > +#define > EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER_INIT_VERSION > 0x00000003 > +#define CAPSULE_SUPPORT_AUTHENTICATION 0x0000000000000001 > +#define CAPSULE_SUPPORT_DEPENDENCY 0x0000000000000002 >=20 > extern EFI_GUID gEfiFmpCapsuleGuid; >=20 > -- > 2.9.0.windows.1 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and=20 > proprietary to American Megatrends (AMI). This communication is=20 > intended to be read only by the individual or entity to whom it is=20 > addressed or by their designee. If the reader of this message is not=20 > the intended recipient, you are on notice that any distribution of=20 > this message, in any form, is strictly prohibited. Please promptly=20 > notify the sender by reply e-mail or by telephone at 770-246-8600, and= =20 > then delete or destroy all copies of the transmission. >=20 >=20