Re: [edk2-devel] [PATCH 2/5] MdePkg: Updates to PI 1.7 Revision numbers for

["Zhiguang Liu" <zhiguang.liu@intel.com>]

Hi Robert,
In PI spec 1.7 A, page 2-16
#define DXE_SPECIFICATION_MINOR_REVISION 60

This is not consistent with you code change, am I using the latest spec? Or, does spec need updated?

Thanks
Zhiguang

 

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> Yakovlev
> Sent: Friday, May 8, 2020 3:03 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com;
> robert@ami.com
> Subject: [edk2-devel] [PATCH 2/5] MdePkg: Updates to PI 1.7 Revision
> numbers for
> 
> From: Robert Phelps <robert@ami.com>
> 
> Revision number defines and MACROs were incorrect for the current version
> of the Specification (PI 1.7 Mantis 1892)
> 
> Signed-off-by: Robert Phelps <robert@ami.com>
> ---
>  MdePkg/Include/Pi/PiDxeCis.h | 4 ++--
>  MdePkg/Include/Pi/PiPeiCis.h | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/MdePkg/Include/Pi/PiDxeCis.h b/MdePkg/Include/Pi/PiDxeCis.h
> index e44744654f..1682211d92 100644
> --- a/MdePkg/Include/Pi/PiDxeCis.h
> +++ b/MdePkg/Include/Pi/PiDxeCis.h
> @@ -5,7 +5,7 @@ Copyright (c) 2006 - 2018, Intel Corporation. All rights
> reserved.<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>    @par Revision Reference:
> -  PI Version 1.6
> +  PI Version 1.7
> 
>  **/
> 
> @@ -690,7 +690,7 @@ EFI_STATUS
>  //
>  #define DXE_SERVICES_SIGNATURE            0x565245535f455844ULL
>  #define DXE_SPECIFICATION_MAJOR_REVISION  1 -#define
> DXE_SPECIFICATION_MINOR_REVISION  60
> +#define DXE_SPECIFICATION_MINOR_REVISION  70
>  #define DXE_SERVICES_REVISION
> ((DXE_SPECIFICATION_MAJOR_REVISION<<16) |
> (DXE_SPECIFICATION_MINOR_REVISION))
> 
>  typedef struct {
> diff --git a/MdePkg/Include/Pi/PiPeiCis.h b/MdePkg/Include/Pi/PiPeiCis.h
> index d9d4ed7d41..ebfe598172 100644
> --- a/MdePkg/Include/Pi/PiPeiCis.h
> +++ b/MdePkg/Include/Pi/PiPeiCis.h
> @@ -5,7 +5,7 @@ Copyright (c) 2006 - 2019, Intel Corporation. All rights
> reserved.<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>    @par Revision Reference:
> -  PI Version 1.6.
> +  PI Version 1.7.
> 
>  **/
> 
> @@ -850,7 +850,7 @@ EFI_STATUS
>  // PEI Specification Revision information  //  #define
> PEI_SPECIFICATION_MAJOR_REVISION  1 -#define
> PEI_SPECIFICATION_MINOR_REVISION  60
> +#define PEI_SPECIFICATION_MINOR_REVISION  70
>  ///
>  /// Specification inconsistency here:
>  /// In the PI1.0 spec, PEI_SERVICES_SIGNATURE is defined as
> 0x5652455320494550. But
> --
> 2.24.1.windows.2
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).  This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
> 
>