From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.2318.1587978263467614033 for ; Mon, 27 Apr 2020 02:04:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=UnjpCv9C; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: zhiguang.liu@intel.com) IronPort-SDR: nb/xz2TJnb/322es1QG2B0rcn1Nbog5DY70ogmfEc+I2p24DKnFlmIwRMRo753mM7ADritj9N/ VRnsx4Y59cMg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2020 02:04:21 -0700 IronPort-SDR: pLHFuJQXlu18ZSAmsdnTJLXc4FZ4A3IycyupqoQJXtqZqTvq6+BOgVc0zweap1ml0QqQXWQ9hM 3jAgRk5HZXEQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,323,1583222400"; d="scan'208";a="275390071" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 27 Apr 2020 02:04:21 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 02:04:21 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 27 Apr 2020 02:04:20 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 27 Apr 2020 02:04:20 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 02:04:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M7kQ7FCP0gROWWi89XPybCjPVmRDtFbAA08SwznN30tsDkGY24safJJ52ok3+gkeeCMohLRA84LO1UOCOmp9BBI7iHuSdNxiZQbqDWnxsdOaLWv80JjxsH6dvaee0Y9x8pJYjiNEMpoB0Una0m7ZjpRSIJncmZEAWcNzdA3pX4Gp7iBRVVJqvpYDfvaytHwUfgYI8hZfP52g8jOnWDio6dqYcIf8BHFk+uR/fLQQZ8s0NyxKv7CEombLh3liJ+N4SQApGtS6sjExC/ZFp966xyKnXwwqwCAk2i+L7HgQtWM941aWoxeNg4qDIgfwZfbE/FEIM/6Wydvra1xz+AdTsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ThO9NrRBi+3DEQUfXSRS2TRDTXbv78zkhQhNQSypnY=; b=FPCuPDEJ7fNY9jVrdWclfwUo34xPK42IP8zh3THdNKbZK2x5oBTpS0lDaHuO3ts8zQYWK9abcX+FvWkH28ML4V+4R93AaY1FOcAKb4VA2nn7zb9q788vbyfLbi5UPuJeLQR9jF50OP6ng6oWTIsPutxtmByFs6eY8DgaPsdisLcqnANuNOhEldJ3FZv7x/KOKiwaXsalSFvojbUYLn6bh2WWPSFcHpISZYo6Ut7SH65tC5/iZQt3VFvjODk+QkI7r0utPd+bEMaj3KwRH8RbiMiJNnLiIfIIpIPeeHJwGMl8rWgF+0Wcz+W4ohqGFyfLud9F9Q0h46UqXuDNj2Ar0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ThO9NrRBi+3DEQUfXSRS2TRDTXbv78zkhQhNQSypnY=; b=UnjpCv9CTyEGLRxUMzMNbBvYPa3G8OIE7nbe39OhcTG4CQZXZibUCMzYfhE0lTzHfqLz8Jt88wRjzSlnoBRAW/BH4uxDpTFIcE4Id3sQufdscav+bFWkrYBkSkTnzLHLE+icL35/h/8zRNafTQugpqsvOHNR50H52MvywJAKUEI= Received: from BN7PR11MB2804.namprd11.prod.outlook.com (2603:10b6:406:ac::12) by BN7PR11MB2660.namprd11.prod.outlook.com (2603:10b6:406:b2::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Mon, 27 Apr 2020 09:04:03 +0000 Received: from BN7PR11MB2804.namprd11.prod.outlook.com ([fe80::79e2:ed1f:4d6b:532c]) by BN7PR11MB2804.namprd11.prod.outlook.com ([fe80::79e2:ed1f:4d6b:532c%7]) with mapi id 15.20.2937.023; Mon, 27 Apr 2020 09:04:03 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "oleksiyy@ami.com" CC: "Gao, Liming" , "Kinney, Michael D" , "Felixp@ami.com" Subject: Re: [edk2-devel] [PATCH 3/4] MdePkg: Add EFI_PROPERTIES_TABLE Thread-Topic: [edk2-devel] [PATCH 3/4] MdePkg: Add EFI_PROPERTIES_TABLE Thread-Index: AQHWD3KGqYOGulZnukeXhgQKITCyqaiMw40w Date: Mon, 27 Apr 2020 09:04:03 +0000 Message-ID: References: <20200410195803.19972-1-oleksiyy@ami.com> <20200410195803.19972-4-oleksiyy@ami.com> In-Reply-To: <20200410195803.19972-4-oleksiyy@ami.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=zhiguang.liu@intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d7430e37-e409-4212-ca45-08d7ea89eee1 x-ms-traffictypediagnostic: BN7PR11MB2660: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0386B406AA x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR11MB2804.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(39860400002)(346002)(396003)(366004)(376002)(81156014)(186003)(8676002)(64756008)(8936002)(76116006)(66946007)(66556008)(66446008)(66476007)(966005)(26005)(478600001)(9686003)(33656002)(86362001)(71200400001)(54906003)(316002)(2906002)(6506007)(53546011)(52536014)(4326008)(55016002)(110136005)(7696005)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: F2cHW+EzFVqMEd3g1o8mJcQ4VYpi2lOtYpf8nXUXNdL09xtjSuQ6x9GAs5f75UWEwZCS4UjTjNUv36QsBodJTsbix6GVrclmM4E9QlX+O1yPFqN6PaekvAu79ZsOLr7O0lDk5E5iCRaF1N0CE6fQBat2PX2PMwPFqiPiZF4cbGzlENtNHbjjTELdgx6oGUbGIpQZm7fRZFO68Ba88jqPo1fizxSOyiUrvl/GAxPra5aS6snf609yJ3s5ovNP3oQGf6xc+cgF24o2hTnPZT3Ho12uyKgy2Hy3UDBNPlydgaHt3n+juRlugnZfpju1oxm3a2L53D6q0JFqaQ63vCjDvyDvWL4VSx1rvvowGSiCetmQVQdKwGhfG9LbbwTsU9DGxd6r1rs+t7fmkIxFcVGROhhlDB+Qg58fY8lHuTf6LCfk2ctwKFGHXsf1DwE/D7aex8RQBB0Nd1//hEWnquZf3VFhp3Tj6FLl5hCxHube2X0VcRwPcMx0xz84TXSD/X5DFNOwIOFzVkGMak6kZeyZQg== x-ms-exchange-antispam-messagedata: hK6UJIWGHnub4Ub7Of7d8j3XYOmelKDsPJER1+rbQYN4S5xqU4HKUpoE3Jvaod4R54958yyQN896VW8bZ1mNyXpxNfrn+g/Eh8vQZTup4gndjrezwItqe26vzNvxlly/n5QmzegL7/jvg1KTXkX9WaLtk+kxCGE6TzCq/q0WSEgWvpqoWsftbn2SMCpspNsfdklpqlvuOtFx8Rbnp/bMtRZvDmowx4AbL9CK9KCOgm/Tu0o7WAnuXFIXdRxB8q2JM3jOagt9eQqiV7Ka8wcLlAXJzJJuo1bSZiHS5iQtmxKqJaFmVz5HTG4pRwjLabZ8+BRJ74Mng0NAicnrG9wBgT2GY/QVgg4rRgO/kTUv313CI28Werx/IEzXuAVSntE2swXwIWrzjouCkSxwOoMMyDXHX/HPda5W7JnwR+X3thudLB1iA8QQxnITq2pbQFfCb2h9+ygtCRg414wM8fQTwhif7UEViknq226CebpsglvkgTCF8cxFFUPBO19qZBy473Y90gPHrwLmcNaWcFnF0yuuIoZakUBxKYzL0ZMNSg/70HalWHs8nP2AB9Z9xMOX3HSE2dFpWgbpjZcd01T0fkBZkx0mOWziWNWzMxy5Es0IUfYWQdlfcZDE3lApPpf6v8NLk/tQYm6c3kZxqBFuWEkuXTNE8h90cnYMu7kr3F96GRqZ8N1a0YKZFx/1XPnwVYLiZ2snjLva+BUsi7STaFeGrbh00J49s2+RnVjuvKIqbUdoBf0qMCmY7DBhaF8uRD2GAVIOcehu0rSzvxK9dASeGEG1y6MkBofJStsSQvE= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d7430e37-e409-4212-ca45-08d7ea89eee1 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2020 09:04:03.4029 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 146UloNaU6ohcbe+fbN76eXJKY/QjGq2+CjO0Lv5bRgxmFxI8osZlyHZWD8gyBwBiDwnNYrOyhaA1yHY/GpLAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2660 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Oleksiy, I have added my comment inline. And as I mentioned before, please use ECC check tool or PatchCheck.py to m= ake sure your patch is align with edk2 coding style. Thanks You can also refer to https://github.com/tianocore/tianocore.github.io/wik= i/Code-Style-C to check edk2 C code style. Thanks Zhiguang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oleksiy > Yakovlev > Sent: Saturday, April 11, 2020 3:58 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; Felixp@ami.com; oleksiyy@ami.com > Subject: [edk2-devel] [PATCH 3/4] MdePkg: Add EFI_PROPERTIES_TABLE >=20 > Define Guid & data structure for EFI_RT _PROPERTIES_TABLE, designed to b= e The space in "EFI_RT _PROPERTIES_TABLE" is unnecessary. > published by a > platform if it no longer supports all EFI runtime services once > ExitBootServices() > has been called by the OS. > (UEFI 2.8 errata a, mantis 2049) >=20 > Signed-off-by: Oleksiy Yakovlev > --- > MdePkg/Include/Guid/RtPropertiesTable.h | 71 > +++++++++++++++++++++++++++++++++ > MdePkg/MdePkg.dec | 6 +++ > 2 files changed, 77 insertions(+) > create mode 100644 MdePkg/Include/Guid/RtPropertiesTable.h >=20 > diff --git a/MdePkg/Include/Guid/RtPropertiesTable.h > b/MdePkg/Include/Guid/RtPropertiesTable.h > new file mode 100644 > index 0000000..a5b6c14 > --- /dev/null > +++ b/MdePkg/Include/Guid/RtPropertiesTable.h > @@ -0,0 +1,71 @@ > +/** @file > +Guid & data structure for EFI_RT _PROPERTIES_TABLE, designed to be The space in "EFI_RT _PROPERTIES_TABLE" is unnecessary. > published by a > +platform if it no longer supports all EFI runtime services once > ExitBootServices() > +has been called by the OS. > + > + > +Copyright (c) 2020, American Megatrends International LLC. All rights > reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef _RT _PROPERTIES_TABLE_GUID_H__ > +#define _RT _PROPERTIES_TABLE_GUID_H__ > + > +// > +// Table, defined here, should be published by a platform if it no long= er > supports all EFI runtime > +// services once ExitBootServices() has been called by the OS. Note tha= t this > is merely a hint > +// to the OS, which it is free to ignore, and so the platform is still = required to > provide callable > +// implementations of unsupported runtime services that simply return > EFI_UNSUPPORTED. > +// > +#define EFI_RT_PROPERTIES_TABLE_GUID \ > + { 0xeb66918a, 0x7eef, 0x402a, \ > + { 0x84, 0x2e, 0x93, 0x1d, 0x21, 0xc3, 0x8a, 0xe9 }} > + > + > + > + > +#pragma pack(1) > + > +typedef struct { > + /// > + /// Version of the structure, must be 0x1. > + /// > + UINT16 Version; > + > + /// > + /// Size in bytes of the entire EFI_RT_PROPERTIES_TABLE, must be 8. > + /// > + UINT16 Length; > + > + /// > + /// The length of the JSON payload immediately following this header,= in > bytes. > + /// The upper comments is incorrect. > + UINT32 RuntimeServicesSupported; > + > + /// > + /// Bitmask of which calls are or are not supported, where a bit set = to 1 > indicates > + /// that the call is supported, and 0 indicates that it is not. > + /// Move the comment up to describe RuntimeServicesSupported > +} EFI_RT_PROPERTIES_TABLE; > + > +#pragma pack() > + I think " #define EFI_RT_PROPERTIES_TABLE_VERSION 0x1" should be added > +#define EFI_RT_SUPPORTED_GET_TIME 0x0001 > +#define EFI_RT_SUPPORTED_SET_TIME 0x0002 > +#define EFI_RT_SUPPORTED_GET_WAKEUP_TIME 0x0004 > +#define EFI_RT_SUPPORTED_SET_WAKEUP_TIME 0x0008 > +#define EFI_RT_SUPPORTED_GET_VARIABLE 0x0010 > +#define EFI_RT_SUPPORTED_GET_NEXT_VARIABLE_NAME 0x0020 > +#define EFI_RT_SUPPORTED_SET_VARIABLE 0x0040 > +#define EFI_RT_SUPPORTED_SET_VIRTUAL_ADDRESS_MAP 0x0080 > +#define EFI_RT_SUPPORTED_CONVERT_POINTER 0x0100 > +#define EFI_RT_SUPPORTED_GET_NEXT_HIGH_MONOTONIC_COUNT > 0x0200 > +#define EFI_RT_SUPPORTED_RESET_SYSTEM 0x0400 > +#define EFI_RT_SUPPORTED_UPDATE_CAPSULE 0x0800 > +#define EFI_RT_SUPPORTED_QUERY_CAPSULE_CAPABILITIES 0x1000 > +#define EFI_RT_SUPPORTED_QUERY_VARIABLE_INFO 0x2000 > + > +extern EFI_GUID gEfiRtPropertiesTableGuid; > + > +#endif > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index 99e75f7..d5340c5 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -655,6 +655,12 @@ > gEfiBttAbstractionGuid =3D { 0x18633bfc, 0x1735, 0x4217, { 0x= 8a, 0xc9, > 0x17, 0x23, 0x92, 0x82, 0xd3, 0xf8 }} >=20 > # > + # GUIDs defined in UEFI2.8a > + # > + ## Include/Guid/RtPropertiesTable.h > + gEfiRtPropertiesTableGuid =3D { 0xeb66918a, 0x7eef, 0x402a, { 0x= 84, 0x2e, > 0x93, 0x1d, 0x21, 0xc3, 0x8a, 0xe9 }} > + > + # > # GUID defined in PI1.0 > # > ## Include/Guid/AprioriFileName.h > -- > 2.9.0.windows.1 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intende= d > to be read only by the individual or entity to whom it is addressed or b= y their > designee. If the reader of this message is not the intended recipient, y= ou are > on notice that any distribution of this message, in any form, is strictl= y > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission. >=20 >=20