From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.4385.1588908217456931018 for ; Thu, 07 May 2020 20:23:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=yH95LAP3; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: zhiguang.liu@intel.com) IronPort-SDR: xJtwGwGI94KJp0vAv8f6D7V9TM6z+/ZixSOISyLysUsXaugtnR3hDH5PaMTPCmiUHGzLj4IBRN 1Vgl9yuEfVTQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 20:23:36 -0700 IronPort-SDR: OVqL778cV0MwI4cVee9+bcq169xO5E/3IB6NxDvz0yftCpLcT9rp/PqXOVEFtfPBlR6bR5Csfx Qht3dDacm5ew== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,366,1583222400"; d="scan'208";a="296737001" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 07 May 2020 20:23:36 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 20:23:36 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 20:23:36 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 20:23:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ToYZOs1TN2OMl01gNq3Wq6GrchLrl5VMK2Vwj3cFGqq2Y//llZosSk6M99LBuEsnUGdwuzFTBSwzrl5NEovNNRhQuvBYEoRTdgRydo54qBdv/wJBBn78PiRLiRNcB3bY4t8nJU1W47uu7f081gBXbA8i9hNM6IadpJLFGMRB8LvRv1QjnC+esEipomAn1AHBV0sWc5IhO0X2VPrNuSe5DUdekPaPcHzNN8oHs/fjzeCnZ3DfzXXVo0Ctxlw+6RAPWVtRw/0PW7QxDSr0SULzRGZ4jv8rRpIygiPiRROOIiEb8oiZCAhCMBG/Zw3PHA09+OXpuVBgGD4MKSq6yqDHmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NrI0eZCzcnXSXQKW5T+wYhGly5sVSmALP6CjwkIxo2A=; b=OGdf3zevzX+uJITvitfaDvkWU34MjvR6jmkVZpJSl/Od6Y04EXP6z65V/ThE30XfUtSOyNRgLF8OBi0ue9T11JaGa3SrDb4QmNRS5NYfDn71Md5Q2wGbhsTrM25PLruZUjdt9r6uIIv1DeloPtQpb8KTGLPRhocbW/ZZXlSka6uRjJaTTglUHZsV/6bYw8LQhxHmZ4Svi4OspHeIm8bZEF9LNdJkR/O8z4JmWaWOkA5ywKL6zbj+VA99Amieu3g1OIpnrDry/0Fzz7noUNH9y3LqzdOqVlseq8yoQ/vSJOP/U2e+yV62TqENZ/o0fmYb1aZ3rqRgqZVnwo/jZoxHhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NrI0eZCzcnXSXQKW5T+wYhGly5sVSmALP6CjwkIxo2A=; b=yH95LAP3zf8MxBfQcJWCU1okZVZo+hlI4Rwqe+IAsnuGNefSpNQqZUgY9Vi0f8zVaum7urflcnPE5MaNoP6+l6mQF3ZWijHtnaoAEHpPsVt0rwW/UlC2apFVDiJf7ziTJGP793qFUvl0IFZahlJzimJE+R/OSFd7Auuwnz4eOvI= Received: from BN7PR11MB2804.namprd11.prod.outlook.com (2603:10b6:406:ac::12) by BN7PR11MB2865.namprd11.prod.outlook.com (2603:10b6:406:ac::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.29; Fri, 8 May 2020 03:23:33 +0000 Received: from BN7PR11MB2804.namprd11.prod.outlook.com ([fe80::79e2:ed1f:4d6b:532c]) by BN7PR11MB2804.namprd11.prod.outlook.com ([fe80::79e2:ed1f:4d6b:532c%7]) with mapi id 15.20.2958.033; Fri, 8 May 2020 03:23:33 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "oleksiyy@ami.com" CC: "Feng, Bob C" , "Gao, Liming" , "Kinney, Michael D" , "Felixp@ami.com" Subject: Re: [edk2-devel] [PATCH v3 3/7] MdePkg: REST style formset Thread-Topic: [edk2-devel] [PATCH v3 3/7] MdePkg: REST style formset Thread-Index: AQHWJKPwGbaqdKRjfESqt9PJlmb5lqidhfNw Date: Fri, 8 May 2020 03:23:32 +0000 Message-ID: References: <20200507191358.74904-1-oleksiyy@ami.com> <20200507191358.74904-4-oleksiyy@ami.com> In-Reply-To: <20200507191358.74904-4-oleksiyy@ami.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c0bb12b0-0e9a-4665-4e76-08d7f2ff2ff4 x-ms-traffictypediagnostic: BN7PR11MB2865: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:235; x-forefront-prvs: 039735BC4E x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PZkyl56Vn4nPaqaoqd74rmvz5inb7fxep1MsDCUUygzHxxUVn3hYyOa3rbpQZfVUF3KQTmZC64dozlopnjB7JeGdV7poORLMc3o1aby3zeyMLWEnIRqQRhPr+E4IXgawuvQPa3A2BDQy3Ukag8JSBqno/A7U2nYqLYrkwRRCVbmwWwo2Y5PvV58Q9qebsuJ+aBfzNlJv+AU7XsXCNbB3le6SlwhOg22rbbJNL8DKasQCvb9Clo6UydlpRC5E+GSuR4bSPU2o41fXQRoSQtqUpsdxsFeqoGsOgZUpn7LGEOHO+SIpEFqO0hjxlXq8ALhhTqwb/ZKBVIziCTipZo+3uFla9HpB7cmVFB/LtL+Ong3QABIVJk2Fge7i8tU/p/Mdl44unbVSrEXILEzks4gTrQgPtFOhw7wZg7juLwQGSUDalZB2znRqbvoc4yru8H8amUVT04R5mCLnt+C/OjGVF9Spd4Ws1VgXo+NA5ThEnnilNkZo7Hb8YTHLD5tOwsMsjnF4AKDdX7nPytesIuRMwjribvkQ2951pMMsGgf1EfDbJjSpzIfNYU9Pk5tjN/11TcvL6eaVfAuDAQZfZx/8T3YDP42lHukF67Y3NLe0a7E= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR11MB2804.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(39860400002)(366004)(136003)(396003)(376002)(346002)(33430700001)(2906002)(4326008)(478600001)(55016002)(33440700001)(26005)(53546011)(6506007)(83300400001)(83290400001)(83320400001)(83280400001)(83310400001)(186003)(7696005)(5660300002)(52536014)(966005)(66446008)(66556008)(8676002)(33656002)(316002)(86362001)(66476007)(54906003)(66946007)(8936002)(110136005)(9686003)(71200400001)(64756008)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 1tR9j5CIB/zxUAJRdXTgJ/wC3JVq36stynSU6IlrkHMyMAyRBWNMb0ngcgqsyh5MeBQKB2MiFI/CElmrfkFUweiAny8W2RYs+LvmIy9vQ7EHtLZLhqghUy69R6ISZV8ouPBffa+sYxKCJtbLV/A0b7lQKXB5etHOykyIjN5dUFwe1jZpDOVgBAfVeSrIsPjfN6fK7iWWQbfKIprFTqSZN96Zya9KDv72CqXvEvoFFZbtvQtB+RsL4U0MTaDCfdlRQLTMx+LV2XXiGf17+sZkMVFhD6q3zhcAsnCLl7lk+k6nyjl4OYZ5LXzq0eNABMMlskqQR6Fk/vTH32bHmV0hM6CT/i8ciQ5DiXccQyqo6PdIs1yP7RVR0tCwg9wG/oYsJ0Tw4btxuKvP1x6zBSFycCwgYy0EL8ebzFv/syVVWkjpVvv/adCAwx2zufWMYj+T9ZFxkh0PcjfQHL39X30loIJylFO75jO0gZ9DZVQ013WzREGkLCkizgltgHB+L0cz MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c0bb12b0-0e9a-4665-4e76-08d7f2ff2ff4 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2020 03:23:32.9677 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: evfCRkzCuak7P4tl0Tcm1uP6ttv3SzQIxIoCMXXrYZcpSXGZdwN92BXWoP+oFvxguwojtSzU+GmyLV6rzeuhnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2865 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Oleksiy, Some lines in commit message is too long , from https://github.com/tianoco= re/tianocore.github.io/wiki/Commit-Message-Format, line length should be le= ss than 76 characters when possible. Other parts are fine to me. Thanks Zhiguang Reviewed-by: Zhiguang Liu -----Original Message----- From: devel@edk2.groups.io On Behalf Of Oleksiy Yak= ovlev Sent: Friday, May 8, 2020 3:14 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming = ; Kinney, Michael D ; Felixp@ami.com; oleksiyy@= ami.com Subject: [edk2-devel] [PATCH v3 3/7] MdePkg: REST style formset New ClassGuid EFI_HII_REST_STYLE_FORMSET_GUID is defined. A formset with this class GUID indicates all the questions in the formset support REST=20 style operation and can be exposed to a REST service point. In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined.=20 An Opcode with this flag indicates this question support REST style operat= ion=20 and can be exposed to a REST service point.=20 (UEFI 2.8 mantis 1853) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Guid/HiiPlatformSetupFormset.h | 4 ++++ MdePkg/Include/Uefi/UefiInternalFormRepresentation.h | 1 + 2 files changed, 5 insertions(+) diff --git a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h b/MdePkg/Includ= e/Guid/HiiPlatformSetupFormset.h index 540483d..a6ba55b 100644 --- a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h +++ b/MdePkg/Include/Guid/HiiPlatformSetupFormset.h @@ -22,8 +22,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define EFI_HII_USER_CREDENTIAL_FORMSET_GUID \ { 0x337f4407, 0x5aee, 0x4b83, { 0xb2, 0xa7, 0x4e, 0xad, 0xca, 0x30, 0x8= 8, 0xcd } } =20 +#define EFI_HII_REST_STYLE_FORMSET_GUID \ + { 0x790217bd, 0xbecf, 0x485b, { 0x91, 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8= b, 0x27 } } + extern EFI_GUID gEfiHiiPlatformSetupFormsetGuid; extern EFI_GUID gEfiHiiDriverHealthFormsetGuid; extern EFI_GUID gEfiHiiUserCredentialFormsetGuid; +extern EFI_GUID gEfiHiiRestStyleFormsetGuid; =20 #endif diff --git a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h b/MdePkg= /Include/Uefi/UefiInternalFormRepresentation.h index 4a1346a..40fcdb7 100644 --- a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h +++ b/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h @@ -825,6 +825,7 @@ typedef struct _EFI_IFR_QUESTION_HEADER { #define EFI_IFR_FLAG_READ_ONLY 0x01 #define EFI_IFR_FLAG_CALLBACK 0x04 #define EFI_IFR_FLAG_RESET_REQUIRED 0x10 +#define EFI_IFR_FLAG_REST_STYLE 0x20 #define EFI_IFR_FLAG_RECONNECT_REQUIRED 0x40 #define EFI_IFR_FLAG_OPTIONS_ONLY 0x80 =20 --=20 2.9.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on.