Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol

["Zhiguang Liu" <zhiguang.liu@intel.com>]

Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> Yakovlev
> Sent: Friday, May 8, 2020 3:03 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com;
> robert@ami.com
> Subject: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for
> MpServices Protocol
> 
> From: Robert Phelps <robert@ami.com>
> 
> Added EXTENDED_PROCESSOR_INFORMATION structure and supporting
> structures and definitions.  The intent is to support updated topology layout
> for CPUs.  (PI 1.7a Mantis 2071)
> 
> Signed-off-by: Robert Phelps <robert@ami.com>
> ---
>  MdePkg/Include/Protocol/MpService.h | 50
> +++++++++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
> 
> diff --git a/MdePkg/Include/Protocol/MpService.h
> b/MdePkg/Include/Protocol/MpService.h
> index 10e2405daf..d7d0a115f3 100644
> --- a/MdePkg/Include/Protocol/MpService.h
> +++ b/MdePkg/Include/Protocol/MpService.h
> @@ -47,6 +47,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>      0x3fdda605, 0xa76e, 0x4f46, {0xad, 0x29, 0x12, 0xf4, 0x53, 0x1b, 0x3d, 0x08}
> \
>    }
> 
> +///
> +/// Value used in the NumberProcessors parameter of the
> +GetProcessorInfo function /// #define CPU_V2_EXTENDED_TOPOLOGY
> BIT24
> +
>  ///
>  /// Forward declaration for the EFI_MP_SERVICES_PROTOCOL.
>  ///
> @@ -96,6 +101,47 @@ typedef struct {
>    UINT32  Thread;
>  } EFI_CPU_PHYSICAL_LOCATION;
> 
> +///
> +///  Structure that defines the 6-level physical location of the
> +processor /// typedef struct { ///
> +///    Package     Zero-based physical package number that identifies the
> cartridge of the processor.
> +///
> +UINT32  Package;
> +///
> +///    Module      Zero-based physical module number within package of the
> processor.
> +///
> +UINT32  Module;
> +///
> +///    Tile        Zero-based physical tile number within module of the
> processor.
> +///
> +UINT32  Tile;
> +///
> +///    Die         Zero-based physical die number within tile of the processor.
> +///
> +UINT32  Die;
> +///
> +///     Core        Zero-based physical core number within die of the processor.
> +///
> +UINT32  Core;
> +///
> +///     Thread      Zero-based logical thread number within core of the
> processor.
> +///
> +UINT32  Thread;
> +} EFI_CPU_PHYSICAL_LOCATION2;
> +
> +
> +/// Location2   The 6-level physical location of the processor, including the
> +///     physical package number that identifies the cartridge, the physical
> +///     module number within package, the physical tile number within the
> module,
> +///     the physical die number within the tile, the physical core number
> within
> +///     package, and logical thread number within core.
> +typedef union {
> +     EFI_CPU_PHYSICAL_LOCATION2  Location2; }
> +EXTENDED_PROCESSOR_INFORMATION;
> +
> +
>  ///
>  /// Structure that describes information about a logical CPU.
>  ///
> @@ -132,6 +178,10 @@ typedef struct {
>    /// logical thread number within core.
>    ///
>    EFI_CPU_PHYSICAL_LOCATION  Location;
> +  ///
> +  /// The extended information of the processor. This field is filled
> + only when  /// CPU_V2_EXTENDED_TOPOLOGY is set in parameter
> ProcessorNumber.
> +  EXTENDED_PROCESSOR_INFORMATION ExtendedInformation;
>  } EFI_PROCESSOR_INFORMATION;
> 
>  /**
> --
> 2.24.1.windows.2
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).  This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
> 
>