[PATCH 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a

[PATCH 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a

[Oleksiy Yakovlev]

From: Robert Phelps <robert@ami.com>

The following patches add and update the current structures and
definitions that were introduced by the PI 1.7 and PI 1.7a
specifications

Signed-off-by: Robert Phelps <robert@ami.com>

Robert Phelps (5):
  MdePkg: New Status Codes
  MdePkg: Updates to PI 1.7 Revision numbers for PEI and DXE
  MdePkg: EFI_MM_COMUNICATION2_PROTOCOL
  MdePkg: Added header file for Delayed Dispatch PPI
  MdePkg: Updates to structures in the MP Services Protocol

 MdePkg/Include/Pi/PiDxeCis.h               |  4 +-
 MdePkg/Include/Pi/PiPeiCis.h               |  4 +-
 MdePkg/Include/Pi/PiStatusCode.h           | 17 ++++-
 MdePkg/Include/Ppi/DelayedDispatch.h       | 79 ++++++++++++++++++++++
 MdePkg/Include/Protocol/MmCommunication2.h | 66 ++++++++++++++++++
 MdePkg/Include/Protocol/MpService.h        | 50 ++++++++++++++
 MdePkg/MdePkg.dec                          | 10 +++
 7 files changed, 224 insertions(+), 6 deletions(-)
 create mode 100644 MdePkg/Include/Ppi/DelayedDispatch.h
 create mode 100644 MdePkg/Include/Protocol/MmCommunication2.h

-- 
2.24.1.windows.2


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[PATCH 1/5] MdePkg: New Status Codes

[Oleksiy Yakovlev]

From: Robert Phelps <robert@ami.com>

Updated PiStatusCodes to reflect changes to PI 1.7 Specification
(PI 1.7 Mantis 1889)

Signed-off-by: Robert Phelps <robert@ami.com>
---
 MdePkg/Include/Pi/PiStatusCode.h | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/Pi/PiStatusCode.h b/MdePkg/Include/Pi/PiStatusCode.h
index 0ffd29a714..81fd24c9ea 100644
--- a/MdePkg/Include/Pi/PiStatusCode.h
+++ b/MdePkg/Include/Pi/PiStatusCode.h
@@ -340,6 +340,7 @@ typedef struct {
 #define EFI_CHIPSET_EC_BAD_BATTERY      (EFI_SUBCLASS_SPECIFIC | 0x00000000)
 #define EFI_CHIPSET_EC_DXE_NB_ERROR     (EFI_SUBCLASS_SPECIFIC | 0x00000001)
 #define EFI_CHIPSET_EC_DXE_SB_ERROR     (EFI_SUBCLASS_SPECIFIC | 0x00000002)
+#define EFI_CHIPSET_EC_INTRUDER_DETECT  (EFI_SUBCLASS_SPECIFIC | 0x00000003)
 ///@}
 
 ///
@@ -361,6 +362,7 @@ typedef struct {
 #define EFI_PERIPHERAL_AUDIO_OUTPUT     (EFI_PERIPHERAL | 0x000A0000)
 #define EFI_PERIPHERAL_LCD_DEVICE       (EFI_PERIPHERAL | 0x000B0000)
 #define EFI_PERIPHERAL_NETWORK          (EFI_PERIPHERAL | 0x000C0000)
+#define EFI_PERIPHERAL_DOCKING          (EFI_PERIPHERAL | 0x000D0000)
 ///@}
 
 ///
@@ -375,6 +377,7 @@ typedef struct {
 #define EFI_P_PC_ENABLE           0x00000004
 #define EFI_P_PC_RECONFIG         0x00000005
 #define EFI_P_PC_DETECTED         0x00000006
+#define EFI_P_PC_REMOVED          0x00000007
 ///@}
 
 //
@@ -464,8 +467,9 @@ typedef struct {
 /// Peripheral Class Keyboard Subclass Error Code definitions.
 ///
 ///@{
-#define EFI_P_KEYBOARD_EC_LOCKED    (EFI_SUBCLASS_SPECIFIC | 0x00000000)
-#define EFI_P_KEYBOARD_EC_STUCK_KEY (EFI_SUBCLASS_SPECIFIC | 0x00000001)
+#define EFI_P_KEYBOARD_EC_LOCKED      (EFI_SUBCLASS_SPECIFIC | 0x00000000)
+#define EFI_P_KEYBOARD_EC_STUCK_KEY   (EFI_SUBCLASS_SPECIFIC | 0x00000001)
+#define EFI_P_KEYBOARD_EC_BUFFER_FULL (EFI_SUBCLASS_SPECIFIC | 0x00000002)
 ///@}
 
 ///
@@ -762,6 +766,7 @@ typedef struct {
 #define EFI_SW_PEI_PC_RECOVERY_AUTO   (EFI_SUBCLASS_SPECIFIC | 0x00000004)
 #define EFI_SW_PEI_PC_S3_BOOT_SCRIPT  (EFI_SUBCLASS_SPECIFIC | 0x00000005)
 #define EFI_SW_PEI_PC_OS_WAKE         (EFI_SUBCLASS_SPECIFIC | 0x00000006)
+#define EFI_SW_PEI_PC_S3_STARTED      (EFI_SUBCLASS_SPECIFIC | 0x00000007)
 ///@}
 
 ///
@@ -784,7 +789,11 @@ typedef struct {
 #define EFI_SW_DXE_BS_PC_LEGACY_BOOT_EVENT            (EFI_SUBCLASS_SPECIFIC | 0x00000002)
 #define EFI_SW_DXE_BS_PC_EXIT_BOOT_SERVICES_EVENT     (EFI_SUBCLASS_SPECIFIC | 0x00000003)
 #define EFI_SW_DXE_BS_PC_VIRTUAL_ADDRESS_CHANGE_EVENT (EFI_SUBCLASS_SPECIFIC | 0x00000004)
+#define EFI_SW_DXE_BS_PC_VARIABLE_SERVICES_INIT       (EFI_SUBCLASS_SPECIFIC | 0x00000005)
+#define EFI_SW_DXE_BS_PC_VARIABLE_RECLAIM             (EFI_SUBCLASS_SPECIFIC | 0x00000006)
 #define EFI_SW_DXE_BS_PC_ATTEMPT_BOOT_ORDER_EVENT     (EFI_SUBCLASS_SPECIFIC | 0x00000007)
+#define EFI_SW_DXE_BS_PC_CONFIG_RESET                 (EFI_SUBCLASS_SPECIFIC | 0x00000008)
+#define EFI_SW_DXE_BS_PC_CSM_INIT                     (EFI_SUBCLASS_SPECIFIC | 0x00000009)
 ///@}
 
 //
@@ -974,6 +983,8 @@ typedef struct {
 #define EFI_SW_EC_PWD_CLR_REQUEST         0x0000000F
 #define EFI_SW_EC_PWD_CLEARED             0x00000010
 #define EFI_SW_EC_EVENT_LOG_FULL          0x00000011
+#define EFI_SW_EC_WRITE_PROTECTED         0x00000012
+#define EFI_SW_EC_FV_CORRUPTED            0x00000013
 ///@}
 
 //
@@ -1005,6 +1016,8 @@ typedef struct {
 #define EFI_SW_PEI_EC_S3_RESUME_FAILED             (EFI_SUBCLASS_SPECIFIC | 0x00000005)
 #define EFI_SW_PEI_EC_RECOVERY_PPI_NOT_FOUND       (EFI_SUBCLASS_SPECIFIC | 0x00000006)
 #define EFI_SW_PEI_EC_RECOVERY_FAILED              (EFI_SUBCLASS_SPECIFIC | 0x00000007)
+#define EFI_SW_PEI_EC_RESUME_ERROR                 (EFI_SUBCLASS_SPECIFIC | 0x00000008)
+#define EFI_SW_PEI_EC_INVALID_CAPSULE              (EFI_SUBCLASS_SPECIFIC | 0x00000009)
 ///@}
 
 ///
-- 
2.24.1.windows.2


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[PATCH 2/5] MdePkg: Updates to PI 1.7 Revision numbers for

[Oleksiy Yakovlev]

From: Robert Phelps <robert@ami.com>

Revision number defines and MACROs were incorrect for the current
version of the Specification (PI 1.7 Mantis 1892)

Signed-off-by: Robert Phelps <robert@ami.com>
---
 MdePkg/Include/Pi/PiDxeCis.h | 4 ++--
 MdePkg/Include/Pi/PiPeiCis.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/MdePkg/Include/Pi/PiDxeCis.h b/MdePkg/Include/Pi/PiDxeCis.h
index e44744654f..1682211d92 100644
--- a/MdePkg/Include/Pi/PiDxeCis.h
+++ b/MdePkg/Include/Pi/PiDxeCis.h
@@ -5,7 +5,7 @@ Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent
 
   @par Revision Reference:
-  PI Version 1.6
+  PI Version 1.7
 
 **/
 
@@ -690,7 +690,7 @@ EFI_STATUS
 //
 #define DXE_SERVICES_SIGNATURE            0x565245535f455844ULL
 #define DXE_SPECIFICATION_MAJOR_REVISION  1
-#define DXE_SPECIFICATION_MINOR_REVISION  60
+#define DXE_SPECIFICATION_MINOR_REVISION  70
 #define DXE_SERVICES_REVISION             ((DXE_SPECIFICATION_MAJOR_REVISION<<16) | (DXE_SPECIFICATION_MINOR_REVISION))
 
 typedef struct {
diff --git a/MdePkg/Include/Pi/PiPeiCis.h b/MdePkg/Include/Pi/PiPeiCis.h
index d9d4ed7d41..ebfe598172 100644
--- a/MdePkg/Include/Pi/PiPeiCis.h
+++ b/MdePkg/Include/Pi/PiPeiCis.h
@@ -5,7 +5,7 @@ Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent
 
   @par Revision Reference:
-  PI Version 1.6.
+  PI Version 1.7.
 
 **/
 
@@ -850,7 +850,7 @@ EFI_STATUS
 // PEI Specification Revision information
 //
 #define PEI_SPECIFICATION_MAJOR_REVISION  1
-#define PEI_SPECIFICATION_MINOR_REVISION  60
+#define PEI_SPECIFICATION_MINOR_REVISION  70
 ///
 /// Specification inconsistency here:
 /// In the PI1.0 spec, PEI_SERVICES_SIGNATURE is defined as 0x5652455320494550. But
-- 
2.24.1.windows.2


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[PATCH 3/5] MdePkg: EFI_MM_COMUNICATION2_PROTOCOL

[Oleksiy Yakovlev]

From: Robert Phelps <robert@ami.com>

Created a new header to support the new EFI_MM_COMMUNICATION2_PROTOCOL
Protocol  as defined in the PI 1.7a Specification
(PI 1.7a Mantis 1993)

Signed-off-by: Robert Phelps <robert@ami.com>
---
 MdePkg/Include/Protocol/MmCommunication2.h | 66 ++++++++++++++++++++++
 MdePkg/MdePkg.dec                          |  7 +++
 2 files changed, 73 insertions(+)
 create mode 100644 MdePkg/Include/Protocol/MmCommunication2.h

diff --git a/MdePkg/Include/Protocol/MmCommunication2.h b/MdePkg/Include/Protocol/MmCommunication2.h
new file mode 100644
index 0000000000..b6fe5069e1
--- /dev/null
+++ b/MdePkg/Include/Protocol/MmCommunication2.h
@@ -0,0 +1,66 @@
+/** @file
+    Provides a runtime service for communicating between DXE drivers and a registered MMI handler
+**/
+#ifndef _MM_COMMUNICATION2_H_
+#define _MM_COMMUNICATION2_H_
+
+///
+/// Global ID for EFI_MM_COMUNICATION@_PROTOCOL_GUID
+///
+#define EFI_MM_COMMUNICATION2_PROTOCOL_GUID \
+        { 0x378daedc, 0xf06b, 0x4446, { 0x83, 0x14, 0x40, 0xab, 0x93, 0x3c, 0x87, 0xa3 }}
+
+
+///
+/// The forward declaration for EFI_MM_COMMUNICATION2_PROTOCOL_GUID
+///
+typedef struct _EFI_MM_COMMUNICATION2_PROTOCOL EFI_MM_COMMUNICATION2_PROTOCOL;
+
+
+/**
+ Communicates with a registered handler.
+
+    Usage is identical to EFI_MM_COMMUNICATION_PROTOCOL.Communicate() except for the notes below:
+    - Instead of passing just the physical address via the CommBuffer parameter, the caller must pass both the physical and the virtual addresses of the communication buffer.
+    - If no virtual remapping has taken place, the physical address will be equal to the virtual address, and so the caller is required to pass the same value for both parameters.
+
+    @param This                 The EFI_MM_COMMUNICATION2_PROTOCOL instance.
+    @param mBufferPhysical      Physical address of the buffer to convey into MMRAM.
+    @param CommBufferVirtual    Virtual address of the buffer to convey into MMRAM.
+    @param CommSize             The size of the data buffer being passed in. On exit, the
+                                size of data being returned. Zero if the handler does not
+                                wish to reply with any data. This parameter is optional and may be NULL.
+
+
+    @retval EFI_SUCCESS             The message was successfully posted.
+    @retval EFI_INVALID_PARAMETER   The CommBuffer** parameters do not refer to the same location in memory.
+    @retval EFI_BAD_BUFFER_SIZE     The buffer is too large for the MM implementation.
+                                    If this error is returned, the MessageLength field
+                                    in the CommBuffer header or the integer pointed by
+                                    CommSize, are updated to reflect the maximum payload
+                                    size the implementation can accommodate.
+    @retval EFI_ACCESS_DENIED       The CommunicateBuffer parameter or CommSize parameter,
+                                    if not omitted, are in address range that cannot be
+                                    accessed by the MM environment.
+**/
+
+typedef
+EFI_STATUS
+(EFIAPI *EFI_MM_COMMUNICATE2)(
+IN CONST EFI_MM_COMMUNICATION2_PROTOCOL    *This,
+IN OUT VOID                    *CommBufferPhysical,
+IN OUT VOID                    *CommBufferVirtual,
+IN OUT UINTN                    *CommSize OPTIONAL
+);
+
+
+/// This protocol provides a means of communicating between drivers outside
+/// of MM and MMI handlers inside of MM, in a way that hides the implementation
+/// details regarding whether traditional or standalone MM is being used.
+
+typedef struct _EFI_MM_COMMUNICATION2_PROTOCOL {
+EFI_MM_COMMUNICATE2        Communicate;
+} EFI_MM_COMMUNICATION2_PROTOCOL;
+
+
+#endif
diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index 6c37c2181c..c64cad75dd 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -1277,6 +1277,13 @@
   ## Include/Protocol/SpiSmmNorFlash.h
   gEfiSpiSmmNorFlashProtocolGuid         = { 0xaab18f19, 0xfe14, 0x4666, { 0x86, 0x04, 0x87, 0xff, 0x6d, 0x66, 0x2c, 0x9a }}
 
+  #
+  # Protocols defined in PI 1.7
+  #
+
+  ## Include/Protocol/MmComunication2.h
+  gEfiMmCommunication2ProtocolGuid       = { 0x378daedc, 0xf06b, 0x4446, { 0x83, 0x14, 0x40, 0xab, 0x93, 0x3c, 0x87, 0xa3 }}
+
   #
   # Protocols defined in UEFI2.1/UEFI2.0/EFI1.1
   #
-- 
2.24.1.windows.2


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[PATCH 4/5] MdePkg: Added header file for Delayed Dispatch PPI

[Oleksiy Yakovlev]

From: Robert Phelps <robert@ami.com>

Created new header file for the new EFI_DELAYED_DISPATCH_PPI  PPI
(PI 1.7 Mantis 1891)

Signed-off-by: Robert Phelps <robert@ami.com>
---
 MdePkg/Include/Ppi/DelayedDispatch.h | 79 ++++++++++++++++++++++++++++
 MdePkg/MdePkg.dec                    |  3 ++
 2 files changed, 82 insertions(+)
 create mode 100644 MdePkg/Include/Ppi/DelayedDispatch.h

diff --git a/MdePkg/Include/Ppi/DelayedDispatch.h b/MdePkg/Include/Ppi/DelayedDispatch.h
new file mode 100644
index 0000000000..4f8b11bcf6
--- /dev/null
+++ b/MdePkg/Include/Ppi/DelayedDispatch.h
@@ -0,0 +1,79 @@
+/** @file
+    Provide timed event service in PEI
+**/
+#ifndef __DELAYED_DISPATCH_PPI_H__
+#define __DELAYED_DISPATCH_PPI_H__
+
+///
+/// Global ID for EFI_DELAYED_DISPATCH_PPI_GUID
+///
+#define EFI_DELAYED_DISPATCH_PPI_GUID \
+  { \
+    0x869c711d, 0x649c, 0x44fe, { 0x8b, 0x9e, 0x2c, 0xbb, 0x29, 0x11, 0xc3, 0xe6} } \
+  }
+
+
+/**
+  Delayed Dispatch function.  This routine is called sometime after the required
+  delay.  Upon return, if NewDelay is 0, the function is unregistered.  If NewDelay
+  is not zero, this routine will be called again after the new delay period.
+
+  @param[in,out] Context         Pointer to Context. Can be updated by routine.
+  @param[out]    NewDelay        The new delay in us.  Leave at 0 to unregister callback.
+
+**/
+
+typedef
+VOID
+(EFIAPI *EFI_DELAYED_DISPATCH_FUNCTION) (
+  IN OUT UINT64 *Context,
+     OUT UINT32 *NewDelay
+  );
+
+
+///
+/// The forward declaration for EFI_DELAYED_DISPATCH_PPI
+///
+
+typedef  struct _EFI_DELAYED_DISPATCH_PPI  EFI_DELAYED_DISPATCH_PPI;
+
+
+/**
+Register a callback to be called after a minimum delay has occurred.
+
+This service is the single member function of the EFI_DELAYED_DISPATCH_PPI
+
+  @param This           Pointer to the EFI_DELAYED_DISPATCH_PPI instance
+  @param Function       Function to call back
+  @param Context        Context data
+  @param Delay          Delay interval
+
+  @retval EFI_SUCCESS               Function successfully loaded
+  @retval EFI_INVALID_PARAMETER     One of the Arguments is not supported
+  @retval EFI_OUT_OF_RESOURCES      No more entries
+
+**/
+typedef
+EFI_STATUS
+(EFIAPI *EFI_DELAYED_DISPATCH_REGISTER)(
+  IN  EFI_DELAYED_DISPATCH_PPI      *This,
+  IN  EFI_DELAYED_DISPATCH_FUNCTION  Function,
+  IN  UINT64                     Context,
+  OUT UINT32                     Delay
+  );
+
+
+///
+/// This PPI is a pointer to the Delayed Dispatch Service.
+/// This service will be published by the Pei Foundation. The PEI Foundation
+/// will use this service to relaunch a known function that requests a delayed
+/// execution.
+///
+struct _EFI_DELAYED_DISPATCH_PPI {
+  EFI_DELAYED_DISPATCH_REGISTER      Register;
+};
+
+
+extern EFI_GUID gEfiPeiDelayedDispatchPpiGuid;
+
+#endif
diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index c64cad75dd..6ab42b4bb5 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -942,6 +942,9 @@
   ## Include/Ppi/PeiCoreFvLocation.h
   gEfiPeiCoreFvLocationPpiGuid   = { 0x52888eae, 0x5b10, 0x47d0, { 0xa8, 0x7f, 0xb8, 0x22, 0xab, 0xa0, 0xca, 0xf4 }}
 
+  ## Include/Ppi/DelayedDispatch.h
+  gEfiPeiDelayedDispatchPpiGuid  = { 0x869c711d, 0x649c, 0x44fe, { 0x8b, 0x9e, 0x2c, 0xbb, 0x29, 0x11, 0xc3, 0xe6 }}
+
 [Protocols]
   ## Include/Protocol/Pcd.h
   gPcdProtocolGuid               = { 0x11B34006, 0xD85B, 0x4D0A, { 0xA2, 0x90, 0xD5, 0xA5, 0x71, 0x31, 0x0E, 0xF7 }}
-- 
2.24.1.windows.2


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[PATCH 5/5] MdePkg: Update structures for MpServices Protocol

[Oleksiy Yakovlev]

From: Robert Phelps <robert@ami.com>

Added EXTENDED_PROCESSOR_INFORMATION structure and supporting
structures and definitions.  The intent is to support updated
topology layout for CPUs.  (PI 1.7a Mantis 2071)

Signed-off-by: Robert Phelps <robert@ami.com>
---
 MdePkg/Include/Protocol/MpService.h | 50 +++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/MdePkg/Include/Protocol/MpService.h b/MdePkg/Include/Protocol/MpService.h
index 10e2405daf..d7d0a115f3 100644
--- a/MdePkg/Include/Protocol/MpService.h
+++ b/MdePkg/Include/Protocol/MpService.h
@@ -47,6 +47,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
     0x3fdda605, 0xa76e, 0x4f46, {0xad, 0x29, 0x12, 0xf4, 0x53, 0x1b, 0x3d, 0x08} \
   }
 
+///
+/// Value used in the NumberProcessors parameter of the GetProcessorInfo function
+///
+#define CPU_V2_EXTENDED_TOPOLOGY BIT24
+
 ///
 /// Forward declaration for the EFI_MP_SERVICES_PROTOCOL.
 ///
@@ -96,6 +101,47 @@ typedef struct {
   UINT32  Thread;
 } EFI_CPU_PHYSICAL_LOCATION;
 
+///
+///  Structure that defines the 6-level physical location of the processor
+///
+typedef struct {
+///
+///    Package     Zero-based physical package number that identifies the cartridge of the processor.
+///
+UINT32  Package;
+///
+///    Module      Zero-based physical module number within package of the processor.
+///
+UINT32  Module;
+///
+///    Tile        Zero-based physical tile number within module of the processor.
+///
+UINT32  Tile;
+///
+///    Die         Zero-based physical die number within tile of the processor.
+///
+UINT32  Die;
+///
+///     Core        Zero-based physical core number within die of the processor.
+///
+UINT32  Core;
+///
+///     Thread      Zero-based logical thread number within core of the processor.
+///
+UINT32  Thread;
+} EFI_CPU_PHYSICAL_LOCATION2;
+
+
+/// Location2   The 6-level physical location of the processor, including the
+///     physical package number that identifies the cartridge, the physical
+///     module number within package, the physical tile number within the module,
+///     the physical die number within the tile, the physical core number within
+///     package, and logical thread number within core.
+typedef union {
+     EFI_CPU_PHYSICAL_LOCATION2  Location2;
+} EXTENDED_PROCESSOR_INFORMATION;
+
+
 ///
 /// Structure that describes information about a logical CPU.
 ///
@@ -132,6 +178,10 @@ typedef struct {
   /// logical thread number within core.
   ///
   EFI_CPU_PHYSICAL_LOCATION  Location;
+  ///
+  /// The extended information of the processor. This field is filled only when
+  /// CPU_V2_EXTENDED_TOPOLOGY is set in parameter ProcessorNumber.
+  EXTENDED_PROCESSOR_INFORMATION ExtendedInformation;
 } EFI_PROCESSOR_INFORMATION;
 
 /**
-- 
2.24.1.windows.2


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol

[Ni, Ray]

Robert,
I did similar change to MpService.h in 
https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd101b2ad706575f82e2fc.

My plan was to move the change to edk2 once the spec is published.
It seems your change doesn't conflict with my change. More comments are added in your change
which I think is better than mine.

A minor comment to the comment in below.

> +
> +/// Location2   The 6-level physical location of the processor, including the
> +///     physical package number that identifies the cartridge, the physical
> +///     module number within package, the physical tile number within the
> module,
> +///     the physical die number within the tile, the physical core number within
> +///     package, and logical thread number within core.

Can you move the above comment to the line before "Location2" field and remove
the "Location2  "? It aligns to existing comments style.

> +typedef union {
> +     EFI_CPU_PHYSICAL_LOCATION2  Location2;
> +} EXTENDED_PROCESSOR_INFORMATION;
> +
> +

With that, Reviewed-by: Ray Ni <ray.ni@intel.com>

Re: [edk2-devel] [PATCH 1/5] MdePkg: New Status Codes

[Zhiguang Liu]

Hi Oleksiy,
Give my comments inline.

Thanks
Zhiguang

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> Yakovlev
> Sent: Friday, May 8, 2020 3:03 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com;
> robert@ami.com
> Subject: [edk2-devel] [PATCH 1/5] MdePkg: New Status Codes
> 
> From: Robert Phelps <robert@ami.com>
> 
> Updated PiStatusCodes to reflect changes to PI 1.7 Specification (PI 1.7
> Mantis 1889)
> 
> Signed-off-by: Robert Phelps <robert@ami.com>
> ---
>  MdePkg/Include/Pi/PiStatusCode.h | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/Pi/PiStatusCode.h
> b/MdePkg/Include/Pi/PiStatusCode.h
> index 0ffd29a714..81fd24c9ea 100644
> --- a/MdePkg/Include/Pi/PiStatusCode.h
> +++ b/MdePkg/Include/Pi/PiStatusCode.h
> @@ -340,6 +340,7 @@ typedef struct {
>  #define EFI_CHIPSET_EC_BAD_BATTERY      (EFI_SUBCLASS_SPECIFIC |
> 0x00000000)
>  #define EFI_CHIPSET_EC_DXE_NB_ERROR     (EFI_SUBCLASS_SPECIFIC |
> 0x00000001)
>  #define EFI_CHIPSET_EC_DXE_SB_ERROR     (EFI_SUBCLASS_SPECIFIC |
> 0x00000002)
> +#define EFI_CHIPSET_EC_INTRUDER_DETECT  (EFI_SUBCLASS_SPECIFIC |
> +0x00000003)
>  ///@}
> 
>  ///
> @@ -361,6 +362,7 @@ typedef struct {
>  #define EFI_PERIPHERAL_AUDIO_OUTPUT     (EFI_PERIPHERAL | 0x000A0000)
>  #define EFI_PERIPHERAL_LCD_DEVICE       (EFI_PERIPHERAL | 0x000B0000)
>  #define EFI_PERIPHERAL_NETWORK          (EFI_PERIPHERAL | 0x000C0000)
> +#define EFI_PERIPHERAL_DOCKING          (EFI_PERIPHERAL | 0x000D0000)
>  ///@}
> 
>  ///
> @@ -375,6 +377,7 @@ typedef struct {
>  #define EFI_P_PC_ENABLE           0x00000004
>  #define EFI_P_PC_RECONFIG         0x00000005
>  #define EFI_P_PC_DETECTED         0x00000006
> +#define EFI_P_PC_REMOVED          0x00000007
>  ///@}
> 
>  //
> @@ -464,8 +467,9 @@ typedef struct {
>  /// Peripheral Class Keyboard Subclass Error Code definitions.
>  ///
>  ///@{
> -#define EFI_P_KEYBOARD_EC_LOCKED    (EFI_SUBCLASS_SPECIFIC |
> 0x00000000)
> -#define EFI_P_KEYBOARD_EC_STUCK_KEY (EFI_SUBCLASS_SPECIFIC |
> 0x00000001)
> +#define EFI_P_KEYBOARD_EC_LOCKED      (EFI_SUBCLASS_SPECIFIC |
> 0x00000000)
> +#define EFI_P_KEYBOARD_EC_STUCK_KEY   (EFI_SUBCLASS_SPECIFIC |
> 0x00000001)
> +#define EFI_P_KEYBOARD_EC_BUFFER_FULL (EFI_SUBCLASS_SPECIFIC |
> +0x00000002)
>  ///@}
> 
>  ///
> @@ -762,6 +766,7 @@ typedef struct {
>  #define EFI_SW_PEI_PC_RECOVERY_AUTO   (EFI_SUBCLASS_SPECIFIC |
> 0x00000004)
>  #define EFI_SW_PEI_PC_S3_BOOT_SCRIPT  (EFI_SUBCLASS_SPECIFIC |
> 0x00000005)
>  #define EFI_SW_PEI_PC_OS_WAKE         (EFI_SUBCLASS_SPECIFIC |
> 0x00000006)
> +#define EFI_SW_PEI_PC_S3_STARTED      (EFI_SUBCLASS_SPECIFIC |
> 0x00000007)
>  ///@}
> 
>  ///
> @@ -784,7 +789,11 @@ typedef struct {
>  #define EFI_SW_DXE_BS_PC_LEGACY_BOOT_EVENT
> (EFI_SUBCLASS_SPECIFIC | 0x00000002)
>  #define EFI_SW_DXE_BS_PC_EXIT_BOOT_SERVICES_EVENT
> (EFI_SUBCLASS_SPECIFIC | 0x00000003)
>  #define EFI_SW_DXE_BS_PC_VIRTUAL_ADDRESS_CHANGE_EVENT
> (EFI_SUBCLASS_SPECIFIC | 0x00000004)
> +#define EFI_SW_DXE_BS_PC_VARIABLE_SERVICES_INIT
> (EFI_SUBCLASS_SPECIFIC | 0x00000005)
> +#define EFI_SW_DXE_BS_PC_VARIABLE_RECLAIM
> (EFI_SUBCLASS_SPECIFIC | 0x00000006)
>  #define EFI_SW_DXE_BS_PC_ATTEMPT_BOOT_ORDER_EVENT
> (EFI_SUBCLASS_SPECIFIC | 0x00000007)
> +#define EFI_SW_DXE_BS_PC_CONFIG_RESET
> (EFI_SUBCLASS_SPECIFIC | 0x00000008)
> +#define EFI_SW_DXE_BS_PC_CSM_INIT                     (EFI_SUBCLASS_SPECIFIC
> | 0x00000009)
>  ///@}
> 
>  //
> @@ -974,6 +983,8 @@ typedef struct {
>  #define EFI_SW_EC_PWD_CLR_REQUEST         0x0000000F
>  #define EFI_SW_EC_PWD_CLEARED             0x00000010
>  #define EFI_SW_EC_EVENT_LOG_FULL          0x00000011
> +#define EFI_SW_EC_WRITE_PROTECTED         0x00000012
> +#define EFI_SW_EC_FV_CORRUPTED            0x00000013
>  ///@}
> 
>  //
> @@ -1005,6 +1016,8 @@ typedef struct {
>  #define EFI_SW_PEI_EC_S3_RESUME_FAILED
> (EFI_SUBCLASS_SPECIFIC | 0x00000005)
>  #define EFI_SW_PEI_EC_RECOVERY_PPI_NOT_FOUND
> (EFI_SUBCLASS_SPECIFIC | 0x00000006)
>  #define EFI_SW_PEI_EC_RECOVERY_FAILED              (EFI_SUBCLASS_SPECIFIC
> | 0x00000007)
> +#define EFI_SW_PEI_EC_RESUME_ERROR                 (EFI_SUBCLASS_SPECIFIC
> | 0x00000008)


The spec defines  EFI_SW_PEI_EC_S3_RESUME_ERROR not define EFI_SW_PEI_EC_RESUME_ERROR                 

> +#define EFI_SW_PEI_EC_INVALID_CAPSULE
> (EFI_SUBCLASS_SPECIFIC | 0x00000009)
>  ///@}
> 
>  ///
> --
> 2.24.1.windows.2
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).  This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
> 
> 

Re: [edk2-devel] [PATCH 2/5] MdePkg: Updates to PI 1.7 Revision numbers for

[Zhiguang Liu]

Hi Robert,
In PI spec 1.7 A, page 2-16
#define DXE_SPECIFICATION_MINOR_REVISION 60

This is not consistent with you code change, am I using the latest spec? Or, does spec need updated?

Thanks
Zhiguang

 

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> Yakovlev
> Sent: Friday, May 8, 2020 3:03 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com;
> robert@ami.com
> Subject: [edk2-devel] [PATCH 2/5] MdePkg: Updates to PI 1.7 Revision
> numbers for
> 
> From: Robert Phelps <robert@ami.com>
> 
> Revision number defines and MACROs were incorrect for the current version
> of the Specification (PI 1.7 Mantis 1892)
> 
> Signed-off-by: Robert Phelps <robert@ami.com>
> ---
>  MdePkg/Include/Pi/PiDxeCis.h | 4 ++--
>  MdePkg/Include/Pi/PiPeiCis.h | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/MdePkg/Include/Pi/PiDxeCis.h b/MdePkg/Include/Pi/PiDxeCis.h
> index e44744654f..1682211d92 100644
> --- a/MdePkg/Include/Pi/PiDxeCis.h
> +++ b/MdePkg/Include/Pi/PiDxeCis.h
> @@ -5,7 +5,7 @@ Copyright (c) 2006 - 2018, Intel Corporation. All rights
> reserved.<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>    @par Revision Reference:
> -  PI Version 1.6
> +  PI Version 1.7
> 
>  **/
> 
> @@ -690,7 +690,7 @@ EFI_STATUS
>  //
>  #define DXE_SERVICES_SIGNATURE            0x565245535f455844ULL
>  #define DXE_SPECIFICATION_MAJOR_REVISION  1 -#define
> DXE_SPECIFICATION_MINOR_REVISION  60
> +#define DXE_SPECIFICATION_MINOR_REVISION  70
>  #define DXE_SERVICES_REVISION
> ((DXE_SPECIFICATION_MAJOR_REVISION<<16) |
> (DXE_SPECIFICATION_MINOR_REVISION))
> 
>  typedef struct {
> diff --git a/MdePkg/Include/Pi/PiPeiCis.h b/MdePkg/Include/Pi/PiPeiCis.h
> index d9d4ed7d41..ebfe598172 100644
> --- a/MdePkg/Include/Pi/PiPeiCis.h
> +++ b/MdePkg/Include/Pi/PiPeiCis.h
> @@ -5,7 +5,7 @@ Copyright (c) 2006 - 2019, Intel Corporation. All rights
> reserved.<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>    @par Revision Reference:
> -  PI Version 1.6.
> +  PI Version 1.7.
> 
>  **/
> 
> @@ -850,7 +850,7 @@ EFI_STATUS
>  // PEI Specification Revision information  //  #define
> PEI_SPECIFICATION_MAJOR_REVISION  1 -#define
> PEI_SPECIFICATION_MINOR_REVISION  60
> +#define PEI_SPECIFICATION_MINOR_REVISION  70
>  ///
>  /// Specification inconsistency here:
>  /// In the PI1.0 spec, PEI_SERVICES_SIGNATURE is defined as
> 0x5652455320494550. But
> --
> 2.24.1.windows.2
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).  This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
> 
> 

Re: [edk2-devel] [PATCH 2/5] MdePkg: Updates to PI 1.7 Revision numbers for

[Zhiguang Liu]

Sorry, I missed your commit message.
Code change is ok.

Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>



> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Zhiguang Liu
> Sent: Monday, May 11, 2020 1:20 PM
> To: devel@edk2.groups.io; oleksiyy@ami.com; robert@ami.com
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Felixp@ami.com; robert@ami.com
> Subject: Re: [edk2-devel] [PATCH 2/5] MdePkg: Updates to PI 1.7 Revision
> numbers for
> 
> Hi Robert,
> In PI spec 1.7 A, page 2-16
> #define DXE_SPECIFICATION_MINOR_REVISION 60
> 
> This is not consistent with you code change, am I using the latest spec? Or,
> does spec need updated?
> 
> Thanks
> Zhiguang
> 
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Oleksiy
> > Yakovlev
> > Sent: Friday, May 8, 2020 3:03 AM
> > To: devel@edk2.groups.io
> > Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com;
> > robert@ami.com
> > Subject: [edk2-devel] [PATCH 2/5] MdePkg: Updates to PI 1.7 Revision
> > numbers for
> >
> > From: Robert Phelps <robert@ami.com>
> >
> > Revision number defines and MACROs were incorrect for the current
> > version of the Specification (PI 1.7 Mantis 1892)
> >
> > Signed-off-by: Robert Phelps <robert@ami.com>
> > ---
> >  MdePkg/Include/Pi/PiDxeCis.h | 4 ++--  MdePkg/Include/Pi/PiPeiCis.h |
> > 4 ++--
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/MdePkg/Include/Pi/PiDxeCis.h
> > b/MdePkg/Include/Pi/PiDxeCis.h index e44744654f..1682211d92 100644
> > --- a/MdePkg/Include/Pi/PiDxeCis.h
> > +++ b/MdePkg/Include/Pi/PiDxeCis.h
> > @@ -5,7 +5,7 @@ Copyright (c) 2006 - 2018, Intel Corporation. All
> > rights reserved.<BR>
> >  SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >    @par Revision Reference:
> > -  PI Version 1.6
> > +  PI Version 1.7
> >
> >  **/
> >
> > @@ -690,7 +690,7 @@ EFI_STATUS
> >  //
> >  #define DXE_SERVICES_SIGNATURE            0x565245535f455844ULL
> >  #define DXE_SPECIFICATION_MAJOR_REVISION  1 -#define
> > DXE_SPECIFICATION_MINOR_REVISION  60
> > +#define DXE_SPECIFICATION_MINOR_REVISION  70
> >  #define DXE_SERVICES_REVISION
> > ((DXE_SPECIFICATION_MAJOR_REVISION<<16) |
> > (DXE_SPECIFICATION_MINOR_REVISION))
> >
> >  typedef struct {
> > diff --git a/MdePkg/Include/Pi/PiPeiCis.h
> > b/MdePkg/Include/Pi/PiPeiCis.h index d9d4ed7d41..ebfe598172 100644
> > --- a/MdePkg/Include/Pi/PiPeiCis.h
> > +++ b/MdePkg/Include/Pi/PiPeiCis.h
> > @@ -5,7 +5,7 @@ Copyright (c) 2006 - 2019, Intel Corporation. All
> > rights reserved.<BR>
> >  SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >    @par Revision Reference:
> > -  PI Version 1.6.
> > +  PI Version 1.7.
> >
> >  **/
> >
> > @@ -850,7 +850,7 @@ EFI_STATUS
> >  // PEI Specification Revision information  //  #define
> > PEI_SPECIFICATION_MAJOR_REVISION  1 -#define
> > PEI_SPECIFICATION_MINOR_REVISION  60
> > +#define PEI_SPECIFICATION_MINOR_REVISION  70
> >  ///
> >  /// Specification inconsistency here:
> >  /// In the PI1.0 spec, PEI_SERVICES_SIGNATURE is defined as
> > 0x5652455320494550. But
> > --
> > 2.24.1.windows.2
> >
> >
> > Please consider the environment before printing this email.
> >
> > The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI).  This communication is
> > intended to be read only by the individual or entity to whom it is
> > addressed or by their designee. If the reader of this message is not
> > the intended recipient, you are on notice that any distribution of
> > this message, in any form, is strictly prohibited.  Please promptly
> > notify the sender by reply e-mail or by telephone at 770-246-8600, and
> > then delete or destroy all copies of the transmission.
> >
> >
> 
> 
> 

Re: [edk2-devel] [PATCH 3/5] MdePkg: EFI_MM_COMUNICATION2_PROTOCOL

[Zhiguang Liu]

Hi Robert,

Give my comments inline

Thanks
Zhiguang

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> Yakovlev
> Sent: Friday, May 8, 2020 3:03 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com;
> robert@ami.com
> Subject: [edk2-devel] [PATCH 3/5] MdePkg:
> EFI_MM_COMUNICATION2_PROTOCOL
> 
> From: Robert Phelps <robert@ami.com>
> 
> Created a new header to support the new
> EFI_MM_COMMUNICATION2_PROTOCOL Protocol  as defined in the PI 1.7a
> Specification (PI 1.7a Mantis 1993)
> 
> Signed-off-by: Robert Phelps <robert@ami.com>
> ---
>  MdePkg/Include/Protocol/MmCommunication2.h | 66
> ++++++++++++++++++++++
>  MdePkg/MdePkg.dec                          |  7 +++
>  2 files changed, 73 insertions(+)
>  create mode 100644 MdePkg/Include/Protocol/MmCommunication2.h
> 
> diff --git a/MdePkg/Include/Protocol/MmCommunication2.h
> b/MdePkg/Include/Protocol/MmCommunication2.h
> new file mode 100644
> index 0000000000..b6fe5069e1
> --- /dev/null
> +++ b/MdePkg/Include/Protocol/MmCommunication2.h
> @@ -0,0 +1,66 @@
> +/** @file
> +    Provides a runtime service for communicating between DXE drivers
> +and a registered MMI handler **/ #ifndef _MM_COMMUNICATION2_H_
> #define
> +_MM_COMMUNICATION2_H_
> +
> +///
> +/// Global ID for EFI_MM_COMUNICATION@_PROTOCOL_GUID
> +///
> +#define EFI_MM_COMMUNICATION2_PROTOCOL_GUID \
> +        { 0x378daedc, 0xf06b, 0x4446, { 0x83, 0x14, 0x40, 0xab, 0x93,
> +0x3c, 0x87, 0xa3 }}
> +
> +
> +///
> +/// The forward declaration for
> EFI_MM_COMMUNICATION2_PROTOCOL_GUID
> +///
> +typedef struct _EFI_MM_COMMUNICATION2_PROTOCOL
> +EFI_MM_COMMUNICATION2_PROTOCOL;
> +
> +
> +/**
> + Communicates with a registered handler.
> +
> +    Usage is identical to
> EFI_MM_COMMUNICATION_PROTOCOL.Communicate() except for the
> notes below:
> +    - Instead of passing just the physical address via the CommBuffer
> parameter, the caller must pass both the physical and the virtual addresses
> of the communication buffer.
> +    - If no virtual remapping has taken place, the physical address will be
> equal to the virtual address, and so the caller is required to pass the same
> value for both parameters.
> +
> +    @param This                 The EFI_MM_COMMUNICATION2_PROTOCOL
> instance.
> +    @param mBufferPhysical      Physical address of the buffer to convey into
> MMRAM.

Shouldn't it be @param CommBufferPhysical

> +    @param CommBufferVirtual    Virtual address of the buffer to convey into
> MMRAM.

> +    @param CommSize             The size of the data buffer being passed in. On
> exit, the
> +                                size of data being returned. Zero if the handler does not
> +                                wish to reply with any data. This parameter is optional and
> may be NULL.
> +
> +
> +    @retval EFI_SUCCESS             The message was successfully posted.
> +    @retval EFI_INVALID_PARAMETER   The CommBuffer** parameters do
> not refer to the same location in memory.
> +    @retval EFI_BAD_BUFFER_SIZE     The buffer is too large for the MM
> implementation.
> +                                    If this error is returned, the MessageLength field
> +                                    in the CommBuffer header or the integer pointed by
> +                                    CommSize, are updated to reflect the maximum payload
> +                                    size the implementation can accommodate.
> +    @retval EFI_ACCESS_DENIED       The CommunicateBuffer parameter or
> CommSize parameter,
> +                                    if not omitted, are in address range that cannot be
> +                                    accessed by the MM environment.
> +**/
> +
> +typedef
> +EFI_STATUS
> +(EFIAPI *EFI_MM_COMMUNICATE2)(
> +IN CONST EFI_MM_COMMUNICATION2_PROTOCOL    *This,
> +IN OUT VOID                    *CommBufferPhysical,
> +IN OUT VOID                    *CommBufferVirtual,
> +IN OUT UINTN                    *CommSize OPTIONAL

Please intent the parameter names

> +);
> +
> +
> +/// This protocol provides a means of communicating between drivers
> +outside /// of MM and MMI handlers inside of MM, in a way that hides
> +the implementation /// details regarding whether traditional or standalone
> MM is being used.
> +
> +typedef struct _EFI_MM_COMMUNICATION2_PROTOCOL {
> +EFI_MM_COMMUNICATE2        Communicate;
> +} EFI_MM_COMMUNICATION2_PROTOCOL;
> +
> +
> +#endif
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> 6c37c2181c..c64cad75dd 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -1277,6 +1277,13 @@
>    ## Include/Protocol/SpiSmmNorFlash.h
>    gEfiSpiSmmNorFlashProtocolGuid         = { 0xaab18f19, 0xfe14, 0x4666, { 0x86,
> 0x04, 0x87, 0xff, 0x6d, 0x66, 0x2c, 0x9a }}
> 
> +  #
> +  # Protocols defined in PI 1.7
> +  #
> +
> +  ## Include/Protocol/MmComunication2.h
> +  gEfiMmCommunication2ProtocolGuid       = { 0x378daedc, 0xf06b, 0x4446,
> { 0x83, 0x14, 0x40, 0xab, 0x93, 0x3c, 0x87, 0xa3 }}
> +
>    #
>    # Protocols defined in UEFI2.1/UEFI2.0/EFI1.1
>    #
> --
> 2.24.1.windows.2
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).  This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
> 
> 

Re: [edk2-devel] [PATCH 4/5] MdePkg: Added header file for Delayed Dispatch PPI

[Zhiguang Liu]

Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> Yakovlev
> Sent: Friday, May 8, 2020 3:03 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com;
> robert@ami.com
> Subject: [edk2-devel] [PATCH 4/5] MdePkg: Added header file for Delayed
> Dispatch PPI
> 
> From: Robert Phelps <robert@ami.com>
> 
> Created new header file for the new EFI_DELAYED_DISPATCH_PPI  PPI (PI 1.7
> Mantis 1891)
> 
> Signed-off-by: Robert Phelps <robert@ami.com>
> ---
>  MdePkg/Include/Ppi/DelayedDispatch.h | 79
> ++++++++++++++++++++++++++++
>  MdePkg/MdePkg.dec                    |  3 ++
>  2 files changed, 82 insertions(+)
>  create mode 100644 MdePkg/Include/Ppi/DelayedDispatch.h
> 
> diff --git a/MdePkg/Include/Ppi/DelayedDispatch.h
> b/MdePkg/Include/Ppi/DelayedDispatch.h
> new file mode 100644
> index 0000000000..4f8b11bcf6
> --- /dev/null
> +++ b/MdePkg/Include/Ppi/DelayedDispatch.h
> @@ -0,0 +1,79 @@
> +/** @file
> +    Provide timed event service in PEI
> +**/
> +#ifndef __DELAYED_DISPATCH_PPI_H__
> +#define __DELAYED_DISPATCH_PPI_H__
> +
> +///
> +/// Global ID for EFI_DELAYED_DISPATCH_PPI_GUID /// #define
> +EFI_DELAYED_DISPATCH_PPI_GUID \
> +  { \
> +    0x869c711d, 0x649c, 0x44fe, { 0x8b, 0x9e, 0x2c, 0xbb, 0x29, 0x11,
> +0xc3, 0xe6} } \
> +  }
> +
> +
> +/**
> +  Delayed Dispatch function.  This routine is called sometime after the
> +required
> +  delay.  Upon return, if NewDelay is 0, the function is unregistered.
> +If NewDelay
> +  is not zero, this routine will be called again after the new delay period.
> +
> +  @param[in,out] Context         Pointer to Context. Can be updated by
> routine.
> +  @param[out]    NewDelay        The new delay in us.  Leave at 0 to unregister
> callback.
> +
> +**/
> +
> +typedef
> +VOID
> +(EFIAPI *EFI_DELAYED_DISPATCH_FUNCTION) (
> +  IN OUT UINT64 *Context,
> +     OUT UINT32 *NewDelay
> +  );
> +
> +
> +///
> +/// The forward declaration for EFI_DELAYED_DISPATCH_PPI ///
> +
> +typedef  struct _EFI_DELAYED_DISPATCH_PPI  EFI_DELAYED_DISPATCH_PPI;
> +
> +
> +/**
> +Register a callback to be called after a minimum delay has occurred.
> +
> +This service is the single member function of the
> +EFI_DELAYED_DISPATCH_PPI
> +
> +  @param This           Pointer to the EFI_DELAYED_DISPATCH_PPI instance
> +  @param Function       Function to call back
> +  @param Context        Context data
> +  @param Delay          Delay interval
> +
> +  @retval EFI_SUCCESS               Function successfully loaded
> +  @retval EFI_INVALID_PARAMETER     One of the Arguments is not
> supported
> +  @retval EFI_OUT_OF_RESOURCES      No more entries
> +
> +**/
> +typedef
> +EFI_STATUS
> +(EFIAPI *EFI_DELAYED_DISPATCH_REGISTER)(
> +  IN  EFI_DELAYED_DISPATCH_PPI      *This,
> +  IN  EFI_DELAYED_DISPATCH_FUNCTION  Function,
> +  IN  UINT64                     Context,
> +  OUT UINT32                     Delay
> +  );
> +
> +
> +///
> +/// This PPI is a pointer to the Delayed Dispatch Service.
> +/// This service will be published by the Pei Foundation. The PEI
> +Foundation /// will use this service to relaunch a known function that
> +requests a delayed /// execution.
> +///
> +struct _EFI_DELAYED_DISPATCH_PPI {
> +  EFI_DELAYED_DISPATCH_REGISTER      Register;
> +};
> +
> +
> +extern EFI_GUID gEfiPeiDelayedDispatchPpiGuid;
> +
> +#endif
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> c64cad75dd..6ab42b4bb5 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -942,6 +942,9 @@
>    ## Include/Ppi/PeiCoreFvLocation.h
>    gEfiPeiCoreFvLocationPpiGuid   = { 0x52888eae, 0x5b10, 0x47d0, { 0xa8, 0x7f,
> 0xb8, 0x22, 0xab, 0xa0, 0xca, 0xf4 }}
> 
> +  ## Include/Ppi/DelayedDispatch.h
> +  gEfiPeiDelayedDispatchPpiGuid  = { 0x869c711d, 0x649c, 0x44fe, {
> + 0x8b, 0x9e, 0x2c, 0xbb, 0x29, 0x11, 0xc3, 0xe6 }}
> +
>  [Protocols]
>    ## Include/Protocol/Pcd.h
>    gPcdProtocolGuid               = { 0x11B34006, 0xD85B, 0x4D0A, { 0xA2, 0x90,
> 0xD5, 0xA5, 0x71, 0x31, 0x0E, 0xF7 }}
> --
> 2.24.1.windows.2
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).  This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
> 
> 

Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol

[Zhiguang Liu]

Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> Yakovlev
> Sent: Friday, May 8, 2020 3:03 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com;
> robert@ami.com
> Subject: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for
> MpServices Protocol
> 
> From: Robert Phelps <robert@ami.com>
> 
> Added EXTENDED_PROCESSOR_INFORMATION structure and supporting
> structures and definitions.  The intent is to support updated topology layout
> for CPUs.  (PI 1.7a Mantis 2071)
> 
> Signed-off-by: Robert Phelps <robert@ami.com>
> ---
>  MdePkg/Include/Protocol/MpService.h | 50
> +++++++++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
> 
> diff --git a/MdePkg/Include/Protocol/MpService.h
> b/MdePkg/Include/Protocol/MpService.h
> index 10e2405daf..d7d0a115f3 100644
> --- a/MdePkg/Include/Protocol/MpService.h
> +++ b/MdePkg/Include/Protocol/MpService.h
> @@ -47,6 +47,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>      0x3fdda605, 0xa76e, 0x4f46, {0xad, 0x29, 0x12, 0xf4, 0x53, 0x1b, 0x3d, 0x08}
> \
>    }
> 
> +///
> +/// Value used in the NumberProcessors parameter of the
> +GetProcessorInfo function /// #define CPU_V2_EXTENDED_TOPOLOGY
> BIT24
> +
>  ///
>  /// Forward declaration for the EFI_MP_SERVICES_PROTOCOL.
>  ///
> @@ -96,6 +101,47 @@ typedef struct {
>    UINT32  Thread;
>  } EFI_CPU_PHYSICAL_LOCATION;
> 
> +///
> +///  Structure that defines the 6-level physical location of the
> +processor /// typedef struct { ///
> +///    Package     Zero-based physical package number that identifies the
> cartridge of the processor.
> +///
> +UINT32  Package;
> +///
> +///    Module      Zero-based physical module number within package of the
> processor.
> +///
> +UINT32  Module;
> +///
> +///    Tile        Zero-based physical tile number within module of the
> processor.
> +///
> +UINT32  Tile;
> +///
> +///    Die         Zero-based physical die number within tile of the processor.
> +///
> +UINT32  Die;
> +///
> +///     Core        Zero-based physical core number within die of the processor.
> +///
> +UINT32  Core;
> +///
> +///     Thread      Zero-based logical thread number within core of the
> processor.
> +///
> +UINT32  Thread;
> +} EFI_CPU_PHYSICAL_LOCATION2;
> +
> +
> +/// Location2   The 6-level physical location of the processor, including the
> +///     physical package number that identifies the cartridge, the physical
> +///     module number within package, the physical tile number within the
> module,
> +///     the physical die number within the tile, the physical core number
> within
> +///     package, and logical thread number within core.
> +typedef union {
> +     EFI_CPU_PHYSICAL_LOCATION2  Location2; }
> +EXTENDED_PROCESSOR_INFORMATION;
> +
> +
>  ///
>  /// Structure that describes information about a logical CPU.
>  ///
> @@ -132,6 +178,10 @@ typedef struct {
>    /// logical thread number within core.
>    ///
>    EFI_CPU_PHYSICAL_LOCATION  Location;
> +  ///
> +  /// The extended information of the processor. This field is filled
> + only when  /// CPU_V2_EXTENDED_TOPOLOGY is set in parameter
> ProcessorNumber.
> +  EXTENDED_PROCESSOR_INFORMATION ExtendedInformation;
>  } EFI_PROCESSOR_INFORMATION;
> 
>  /**
> --
> 2.24.1.windows.2
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).  This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
> 
> 

Re: [edk2-devel] [PATCH 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a

[Liming Gao]

Robert and Oleksiy:

New added file should include license (SPDX-License-Identifier: BSD-2-Clause-Patent) and copyright (your company). Below is one example. And, file header description also needs to specify the spec version for new definition. 

EFI MM Communication Protocol 2 as defined in the PI 1.7 errata A specification.

Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent

Thanks
Liming
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy Yakovlev
> Sent: Friday, May 8, 2020 3:03 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com;
> robert@ami.com
> Subject: [edk2-devel] [PATCH 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a
> 
> From: Robert Phelps <robert@ami.com>
> 
> The following patches add and update the current structures and
> definitions that were introduced by the PI 1.7 and PI 1.7a
> specifications
> 
> Signed-off-by: Robert Phelps <robert@ami.com>
> 
> Robert Phelps (5):
>   MdePkg: New Status Codes
>   MdePkg: Updates to PI 1.7 Revision numbers for PEI and DXE
>   MdePkg: EFI_MM_COMUNICATION2_PROTOCOL
>   MdePkg: Added header file for Delayed Dispatch PPI
>   MdePkg: Updates to structures in the MP Services Protocol
> 
>  MdePkg/Include/Pi/PiDxeCis.h               |  4 +-
>  MdePkg/Include/Pi/PiPeiCis.h               |  4 +-
>  MdePkg/Include/Pi/PiStatusCode.h           | 17 ++++-
>  MdePkg/Include/Ppi/DelayedDispatch.h       | 79 ++++++++++++++++++++++
>  MdePkg/Include/Protocol/MmCommunication2.h | 66 ++++++++++++++++++
>  MdePkg/Include/Protocol/MpService.h        | 50 ++++++++++++++
>  MdePkg/MdePkg.dec                          | 10 +++
>  7 files changed, 224 insertions(+), 6 deletions(-)
>  create mode 100644 MdePkg/Include/Ppi/DelayedDispatch.h
>  create mode 100644 MdePkg/Include/Protocol/MmCommunication2.h
> 
> --
> 2.24.1.windows.2
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication
> is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is
> not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please
> promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
> 
> 

Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol

[Liming Gao]

Ray:
  I see https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd101b2ad706575f82e2fc also includes the code change in UefiCpuPkg/Library/MpInitLib/MpLib.c. The change has passed review. 

  Can you send the separate patch for the change in UefiCpuPkg? 

Thanks
Liming
> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Monday, May 11, 2020 1:01 PM
> To: devel@edk2.groups.io; oleksiyy@ami.com
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com; robert@ami.com
> Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol
> 
> Robert,
> I did similar change to MpService.h in
> https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd101b2ad706575f82e2fc.
> 
> My plan was to move the change to edk2 once the spec is published.
> It seems your change doesn't conflict with my change. More comments are added in your change
> which I think is better than mine.
> 
> A minor comment to the comment in below.
> 
> > +
> > +/// Location2   The 6-level physical location of the processor, including the
> > +///     physical package number that identifies the cartridge, the physical
> > +///     module number within package, the physical tile number within the
> > module,
> > +///     the physical die number within the tile, the physical core number within
> > +///     package, and logical thread number within core.
> 
> Can you move the above comment to the line before "Location2" field and remove
> the "Location2  "? It aligns to existing comments style.
> 
> > +typedef union {
> > +     EFI_CPU_PHYSICAL_LOCATION2  Location2;
> > +} EXTENDED_PROCESSOR_INFORMATION;
> > +
> > +
> 
> With that, Reviewed-by: Ray Ni <ray.ni@intel.com>
> 

Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol

[Ni, Ray]

sure I will.

> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Friday, May 15, 2020 12:57 PM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; oleksiyy@ami.com
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com; robert@ami.com
> Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol
> 
> Ray:
>   I see https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd101b2ad706575f82e2fc also includes the
> code change in UefiCpuPkg/Library/MpInitLib/MpLib.c. The change has passed review.
> 
>   Can you send the separate patch for the change in UefiCpuPkg?
> 
> Thanks
> Liming
> > -----Original Message-----
> > From: Ni, Ray <ray.ni@intel.com>
> > Sent: Monday, May 11, 2020 1:01 PM
> > To: devel@edk2.groups.io; oleksiyy@ami.com
> > Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com;
> robert@ami.com
> > Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol
> >
> > Robert,
> > I did similar change to MpService.h in
> > https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd101b2ad706575f82e2fc.
> >
> > My plan was to move the change to edk2 once the spec is published.
> > It seems your change doesn't conflict with my change. More comments are added in your change
> > which I think is better than mine.
> >
> > A minor comment to the comment in below.
> >
> > > +
> > > +/// Location2   The 6-level physical location of the processor, including the
> > > +///     physical package number that identifies the cartridge, the physical
> > > +///     module number within package, the physical tile number within the
> > > module,
> > > +///     the physical die number within the tile, the physical core number within
> > > +///     package, and logical thread number within core.
> >
> > Can you move the above comment to the line before "Location2" field and remove
> > the "Location2  "? It aligns to existing comments style.
> >
> > > +typedef union {
> > > +     EFI_CPU_PHYSICAL_LOCATION2  Location2;
> > > +} EXTENDED_PROCESSOR_INFORMATION;
> > > +
> > > +
> >
> > With that, Reviewed-by: Ray Ni <ray.ni@intel.com>
> >
> 

Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol

[Ni, Ray]

I just sent out the change to update GetProcessorInfo() to return 6-level topology info.

The patch has been reviewed by Eric before pushing to edk2-staging repo.

Please tell me when the MdePkg/MpServices.h is merged.
I will trigger the merge after that.

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
> Sent: Friday, May 15, 2020 1:34 PM
> To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; oleksiyy@ami.com
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com; robert@ami.com
> Subject: Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol
> 
> sure I will.
> 
> > -----Original Message-----
> > From: Gao, Liming <liming.gao@intel.com>
> > Sent: Friday, May 15, 2020 12:57 PM
> > To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; oleksiyy@ami.com
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com; robert@ami.com
> > Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol
> >
> > Ray:
> >   I see https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd101b2ad706575f82e2fc also includes
> the
> > code change in UefiCpuPkg/Library/MpInitLib/MpLib.c. The change has passed review.
> >
> >   Can you send the separate patch for the change in UefiCpuPkg?
> >
> > Thanks
> > Liming
> > > -----Original Message-----
> > > From: Ni, Ray <ray.ni@intel.com>
> > > Sent: Monday, May 11, 2020 1:01 PM
> > > To: devel@edk2.groups.io; oleksiyy@ami.com
> > > Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com;
> > robert@ami.com
> > > Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol
> > >
> > > Robert,
> > > I did similar change to MpService.h in
> > > https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd101b2ad706575f82e2fc.
> > >
> > > My plan was to move the change to edk2 once the spec is published.
> > > It seems your change doesn't conflict with my change. More comments are added in your change
> > > which I think is better than mine.
> > >
> > > A minor comment to the comment in below.
> > >
> > > > +
> > > > +/// Location2   The 6-level physical location of the processor, including the
> > > > +///     physical package number that identifies the cartridge, the physical
> > > > +///     module number within package, the physical tile number within the
> > > > module,
> > > > +///     the physical die number within the tile, the physical core number within
> > > > +///     package, and logical thread number within core.
> > >
> > > Can you move the above comment to the line before "Location2" field and remove
> > > the "Location2  "? It aligns to existing comments style.
> > >
> > > > +typedef union {
> > > > +     EFI_CPU_PHYSICAL_LOCATION2  Location2;
> > > > +} EXTENDED_PROCESSOR_INFORMATION;
> > > > +
> > > > +
> > >
> > > With that, Reviewed-by: Ray Ni <ray.ni@intel.com>
> > >
> >
> 
> 
> 

Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol

[Liming Gao]

https://github.com/tianocore/edk2/pull/625 is created for MdePkg change.

> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Friday, May 15, 2020 3:49 PM
> To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Gao, Liming <liming.gao@intel.com>; oleksiyy@ami.com
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com; robert@ami.com
> Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol
> 
> I just sent out the change to update GetProcessorInfo() to return 6-level topology info.
> 
> The patch has been reviewed by Eric before pushing to edk2-staging repo.
> 
> Please tell me when the MdePkg/MpServices.h is merged.
> I will trigger the merge after that.
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
> > Sent: Friday, May 15, 2020 1:34 PM
> > To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; oleksiyy@ami.com
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com; robert@ami.com
> > Subject: Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol
> >
> > sure I will.
> >
> > > -----Original Message-----
> > > From: Gao, Liming <liming.gao@intel.com>
> > > Sent: Friday, May 15, 2020 12:57 PM
> > > To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; oleksiyy@ami.com
> > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com; robert@ami.com
> > > Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol
> > >
> > > Ray:
> > >   I see https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd101b2ad706575f82e2fc also includes
> > the
> > > code change in UefiCpuPkg/Library/MpInitLib/MpLib.c. The change has passed review.
> > >
> > >   Can you send the separate patch for the change in UefiCpuPkg?
> > >
> > > Thanks
> > > Liming
> > > > -----Original Message-----
> > > > From: Ni, Ray <ray.ni@intel.com>
> > > > Sent: Monday, May 11, 2020 1:01 PM
> > > > To: devel@edk2.groups.io; oleksiyy@ami.com
> > > > Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com;
> > > robert@ami.com
> > > > Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol
> > > >
> > > > Robert,
> > > > I did similar change to MpService.h in
> > > > https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd101b2ad706575f82e2fc.
> > > >
> > > > My plan was to move the change to edk2 once the spec is published.
> > > > It seems your change doesn't conflict with my change. More comments are added in your change
> > > > which I think is better than mine.
> > > >
> > > > A minor comment to the comment in below.
> > > >
> > > > > +
> > > > > +/// Location2   The 6-level physical location of the processor, including the
> > > > > +///     physical package number that identifies the cartridge, the physical
> > > > > +///     module number within package, the physical tile number within the
> > > > > module,
> > > > > +///     the physical die number within the tile, the physical core number within
> > > > > +///     package, and logical thread number within core.
> > > >
> > > > Can you move the above comment to the line before "Location2" field and remove
> > > > the "Location2  "? It aligns to existing comments style.
> > > >
> > > > > +typedef union {
> > > > > +     EFI_CPU_PHYSICAL_LOCATION2  Location2;
> > > > > +} EXTENDED_PROCESSOR_INFORMATION;
> > > > > +
> > > > > +
> > > >
> > > > With that, Reviewed-by: Ray Ni <ray.ni@intel.com>
> > > >
> > >
> >
> >
> > 
>