From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.2049.1588984160652611005 for ; Fri, 08 May 2020 17:29:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=riFvNtL4; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: zhiguang.liu@intel.com) IronPort-SDR: qGHYJk+URPX+tLp/Qsz0e549KVw1uwjMxcaB/Tg0IuGynK9rJLSrlsbg5K8KZNnoGC19TlvEDc 1zbXUpRn9hkQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 17:29:20 -0700 IronPort-SDR: L/6XvDMLGcKuOWhbHbUycCV2UyRGa91FZncvDGpGKON5PI22zemPAC8j8bapPsei2Ejf0jm/yY ok+6vuBedwNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,369,1583222400"; d="scan'208";a="285644793" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga004.fm.intel.com with ESMTP; 08 May 2020 17:29:19 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 17:29:19 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 17:29:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZzT/fE8eoqUms6/t10GeNg6Kv14JrgSobOmenukSksb21may9olVvJWjnwrLuwmbfmEgqIE2A3bIfREzLN6cFgfKAr268Vl40/eCtXyEWTIq7wzj0ypv1qO75zxcal99lmfB1hR0SqyljsSdGR0bYYGeqAYuPjOfYSTb0L4qH20PfdJtxTMx5V9Rug1x/M33m/thMTkvk89pVMFvqM9YppWPFHFXKCiocCjqwygFG7/y8FN5KCHIWHZGumjbPhdHgsrT5Wk/UpwgCLVBy1yaDeFunLJAwsheVobTKV3eXH1DSzCB8dQ9bKUCk2Ny/kUjM8g27t8U4zCv/Hn8LzRTeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DG57d28q2cDBY963aUh1DK7DTwtu5z1iGFAaDkLS3mA=; b=OwL6hq/3itxvtM4xayhBpyz7y/VT62SYONiPjJuLj6DiQYWTHsutKuDGFAWlLEwcXljOm3aTjKlpSSTgjmqvIxHlZWO+dIaCUsgbVGykq4B7672onkMA7/FDIaX4UBz5a2kG0qTXW5CtwNCMzCqDzbsQU/VvaNx3D6YLEQeIQujWbq1JlsWc+JdE2jTJx/QLxH2lJ14kYgckm5H/Lma5Rbkrc/qoS4XwrUYNyUWLlrGBnDwKBZSgJ/iiy0BlOBP7Oirxz5yGxI2QfzBQmOPjlnEA3QHv0O5oHFue1Ise9ajZq7Hf3bNmmJp65L2FrM3WR0lyAeu0v+tflYN+EMgG4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DG57d28q2cDBY963aUh1DK7DTwtu5z1iGFAaDkLS3mA=; b=riFvNtL4snRMUmUuYEdC6Ig+1JunL/t+/OBkIhdVGr2enPL/YZG+fnoXM2UcxLvlCru8vp/LAuDTeqlmY3/AifQme4uFGeUWQ2fARfZShcTqou5laBvHE1+kJkSl0jonAKFYdDloqgh3f1CLgLEcHHxxhmRRgtBXotnUQSdE9xU= Received: from BN7PR11MB2804.namprd11.prod.outlook.com (2603:10b6:406:ac::12) by BN7PR11MB2577.namprd11.prod.outlook.com (2603:10b6:406:b1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19; Sat, 9 May 2020 00:29:17 +0000 Received: from BN7PR11MB2804.namprd11.prod.outlook.com ([fe80::79e2:ed1f:4d6b:532c]) by BN7PR11MB2804.namprd11.prod.outlook.com ([fe80::79e2:ed1f:4d6b:532c%7]) with mapi id 15.20.2958.033; Sat, 9 May 2020 00:29:17 +0000 From: "Zhiguang Liu" To: Oleksiy Yakovlev , "devel@edk2.groups.io" CC: "Gao, Liming" , "Kinney, Michael D" , Felix Polyudov Subject: Re: [edk2-devel] [PATCH v2 3/4] MdePkg: Add EFI_PROPERTIES_TABLE Thread-Topic: [edk2-devel] [PATCH v2 3/4] MdePkg: Add EFI_PROPERTIES_TABLE Thread-Index: AQHWJKbdTkKtssY/eUuBLzX/w8AIf6ids7pQgACd3wCAAJXCIA== Date: Sat, 9 May 2020 00:29:17 +0000 Message-ID: References: <20200507193443.76728-1-oleksiyy@ami.com> <20200507193443.76728-4-oleksiyy@ami.com> <6BD875C24FFE2A4E8D6EFC142C67836F03FFFF9C25@atlms1.us.megatrends.com> In-Reply-To: <6BD875C24FFE2A4E8D6EFC142C67836F03FFFF9C25@atlms1.us.megatrends.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: ami.com; dkim=none (message not signed) header.d=none;ami.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d4560a6a-c910-491f-44b2-08d7f3b00277 x-ms-traffictypediagnostic: BN7PR11MB2577: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 03982FDC1D x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nMAprffF1OLA3NCIUWmo9/3AEa7augyVBgsjTTY8Z9p70WbvX9Fr+I7Ve2FlZDhvym+G6PdZs1bXnDqTZp4GdnsVHYSo5qvrkJJ5YYWmUdZ4f4VcLhG/RsmGh4fUE8fHJhesEuAfdDR/9LZsJ63Iscz1lgiHCDKp18fuG1KmSwVgZuSHxEZ/tezN/2YgMIpzzyYu7BQO89jbeYphqORQWnw/SjI3buZmmLW36znsZidd0RqbI/P3elD0O0oLbndE77kemuGLgEnoo3NchycqC5i8lbHdneL2ZSzQncWpZ4wGHY7DoucCQn/x78QmrGln7hdkrqim80PuCsow18R/YGyck8Px4O3U20QtYyTMYznm6VlfH/zi79Izw8eidUoMMhoJg8CJxM008gUKktg9g2IQIoZ32j8Ghz3rWEx7nhsqGUAj0n9P9aEvFPGBSAsDj3SRu5sdMEU8EumqYAaZS7KJryawsJAXi70dHU9mhWzEmz9h+nrbwmEB49nV+50v55Ej7nxrQzkqfCxdyRneQgzenWz8i9HV0GQZREaWYygKUCBbQOMZoJtXVngZChzwPYXBPPW1HtUZ3ex4Eaf0cEJYAvlyONXo4ARdC4YCoW8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR11MB2804.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(39860400002)(346002)(376002)(366004)(136003)(33430700001)(54906003)(76116006)(966005)(66556008)(66446008)(64756008)(66946007)(66476007)(4326008)(53546011)(8676002)(6506007)(5660300002)(478600001)(8936002)(33440700001)(7696005)(110136005)(55016002)(316002)(9686003)(33656002)(2906002)(186003)(52536014)(26005)(86362001)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: fa/bP+W9Hgea3Ce3+wRPfrHoZTjz5MBsWRrxdwwUJfa1cqxIOBrNUKg8XuFwRBn6I/u9HYugDfHWhkoB2AVtOarLJN55bGa2xwkD/GDZJAA/6VTtxz+P7OEH5qPz0j8gNCm0PXMnCqPGhyJS8W2GvqCdRECqnfupslOaR8R7G+LlnSI0GfZjuTE6y4Yg88aaDNY4o0AQ4eJVAw4H7WofzZcT1eIFIJ9PJhP2VvSes5QiQhjzWGA5rUztYCjeyjzQvNaTo7TqfzBbMfepaZubfmsJfr2xGpO5aJ9hDj00M0DM2dgsOh98JhwV428rXBwnSMwwo0CShdTmT6r63qV6QaZAYxH2PIaqAPDBJsKcRYgSrWnIM7wvkVKWc4scMnrLqgj2LWYYYnmwkHsutHErM14UzneROc0f1CLk7kfFkrMwKHw+IlqZ8cnqktJUi1Pjz9rS+H/4Vq9Lcxaxgzj2wyQy8Jz0Mk5xoZvz8UO6Yr324zNDtr93rCxHarecMOwc MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d4560a6a-c910-491f-44b2-08d7f3b00277 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2020 00:29:17.5649 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6I7qI7u9LpHb5zX1wKDeXnRkpW7ru/9chXpFThHUoohWkEw2k+7Dz9Ycv2xDQSZCKU7Z+Gwf9v0rOEjph9U0cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2577 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Oleksiy, It's about the new added file RtPropertiesTable.h? >MdePkg/Include/Guid/RtPropertiesTable.h | 68 ++++++++++++++++++++++++++++= +++ This mean it has 68 lines added. >+++ b/MdePkg/Include/Guid/RtPropertiesTable.h >@@ -0,0 +1,71 @@ And this means the total line number is 71. The two numbers are not consistent. Can you check the reason? Thanks Zhiguang > -----Original Message----- > From: Oleksiy Yakovlev > Sent: Friday, May 8, 2020 11:29 PM > To: Liu, Zhiguang ; devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; Felix Polyudov > Subject: RE: [edk2-devel] [PATCH v2 3/4] MdePkg: Add > EFI_PROPERTIES_TABLE >=20 > Hi Zhiguang. >=20 > Is this about MdePkg.dec or about new added file RtPropertiesTable.h? >=20 > Regards, Oleksiy. > -----Original Message----- > From: Liu, Zhiguang [mailto:zhiguang.liu@intel.com] > Sent: Friday, May 08, 2020 2:08 AM > To: devel@edk2.groups.io; Oleksiy Yakovlev > Cc: Gao, Liming; Kinney, Michael D; Felix Polyudov > Subject: RE: [edk2-devel] [PATCH v2 3/4] MdePkg: Add > EFI_PROPERTIES_TABLE >=20 > Hi Oleksiy, > This patch is not correct and can't be applied to master branch. > Can you confirm? > The line number seems not consistent. >=20 > Thanks > Zhiguang >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > Oleksiy > > Yakovlev > > Sent: Friday, May 8, 2020 3:35 AM > > To: devel@edk2.groups.io > > Cc: Gao, Liming ; Kinney, Michael D > > ; Felixp@ami.com; oleksiyy@ami.com > > Subject: [edk2-devel] [PATCH v2 3/4] MdePkg: Add > EFI_PROPERTIES_TABLE > > > > Define Guid & data structure for EFI_RT_PROPERTIES_TABLE, designed to > > be published by a platform if it no longer supports all EFI runtime > > services once > > ExitBootServices() > > has been called by the OS. > > (UEFI 2.8 errata a, mantis 2049) > > > > Signed-off-by: Oleksiy Yakovlev > > --- > > MdePkg/Include/Guid/RtPropertiesTable.h | 68 > > +++++++++++++++++++++++++++++++ > > MdePkg/MdePkg.dec | 6 +++ > > 2 files changed, 74 insertions(+) > > create mode 100644 MdePkg/Include/Guid/RtPropertiesTable.h > > > > diff --git a/MdePkg/Include/Guid/RtPropertiesTable.h > > b/MdePkg/Include/Guid/RtPropertiesTable.h > > new file mode 100644 > > index 0000000..a5b6c14 > > --- /dev/null > > +++ b/MdePkg/Include/Guid/RtPropertiesTable.h > > @@ -0,0 +1,71 @@ > > +/** @file > > +Guid & data structure for EFI_RT_PROPERTIES_TABLE, designed to be > > published by a > > +platform if it no longer supports all EFI runtime services once > > ExitBootServices() > > +has been called by the OS. > > + > > + > > +Copyright (c) 2020, American Megatrends International LLC. All rights > > reserved.
> > +SPDX-License-Identifier: BSD-2-Clause-Patent > > + > > +**/ > > + > > +#ifndef _RT_PROPERTIES_TABLE_GUID_H__ #define > > +_RT_PROPERTIES_TABLE_GUID_H__ > > + > > +// > > +// Table, defined here, should be published by a platform if it no > > +longer > > supports all EFI runtime > > +// services once ExitBootServices() has been called by the OS. Note > > +that this > > is merely a hint > > +// to the OS, which it is free to ignore, and so the platform is > > +still required to > > provide callable > > +// implementations of unsupported runtime services that simply return > > EFI_UNSUPPORTED. > > +// > > +#define EFI_RT_PROPERTIES_TABLE_GUID \ > > + { 0xeb66918a, 0x7eef, 0x402a, \ > > + { 0x84, 0x2e, 0x93, 0x1d, 0x21, 0xc3, 0x8a, 0xe9 }} > > + > > + > > + > > +#pragma pack(1) > > + > > +typedef struct { > > + /// > > + /// Version of the structure, must be 0x1. > > + /// > > + UINT16 Version; > > + > > + /// > > + /// Size in bytes of the entire EFI_RT_PROPERTIES_TABLE, must be 8. > > + /// > > + UINT16 Length; > > + > > + /// > > + /// Bitmask of which calls are or are not supported, where a bit > > + set to 1 > > indicates > > + /// that the call is supported, and 0 indicates that it is not. > > + /// > > + UINT32 RuntimeServicesSupported; > > +} EFI_RT_PROPERTIES_TABLE; > > + > > +#pragma pack() > > + > > +#define EFI_RT_PROPERTIES_TABLE_VERSION 0x1 > > + > > +#define EFI_RT_SUPPORTED_GET_TIME 0x0001 > > +#define EFI_RT_SUPPORTED_SET_TIME 0x0002 > > +#define EFI_RT_SUPPORTED_GET_WAKEUP_TIME 0x0004 > > +#define EFI_RT_SUPPORTED_SET_WAKEUP_TIME 0x0008 > > +#define EFI_RT_SUPPORTED_GET_VARIABLE 0x0010 > > +#define EFI_RT_SUPPORTED_GET_NEXT_VARIABLE_NAME 0x0020 > > +#define EFI_RT_SUPPORTED_SET_VARIABLE 0x0040 > > +#define EFI_RT_SUPPORTED_SET_VIRTUAL_ADDRESS_MAP 0x0080 > > +#define EFI_RT_SUPPORTED_CONVERT_POINTER 0x0100 > > +#define EFI_RT_SUPPORTED_GET_NEXT_HIGH_MONOTONIC_COUNT > > 0x0200 > > +#define EFI_RT_SUPPORTED_RESET_SYSTEM 0x0400 > > +#define EFI_RT_SUPPORTED_UPDATE_CAPSULE 0x0800 > > +#define EFI_RT_SUPPORTED_QUERY_CAPSULE_CAPABILITIES 0x1000 > > +#define EFI_RT_SUPPORTED_QUERY_VARIABLE_INFO 0x2000 > > + > > +extern EFI_GUID gEfiRtPropertiesTableGuid; > > + > > +#endif > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > > 99e75f7..d5340c5 100644 > > --- a/MdePkg/MdePkg.dec > > +++ b/MdePkg/MdePkg.dec > > @@ -655,6 +655,12 @@ > > gEfiBttAbstractionGuid =3D { 0x18633bfc, 0x1735, 0x4217, { = 0x8a, 0xc9, > > 0x17, 0x23, 0x92, 0x82, 0xd3, 0xf8 }} > > > > # > > + # GUIDs defined in UEFI2.8a > > + # > > + ## Include/Guid/RtPropertiesTable.h > > + gEfiRtPropertiesTableGuid =3D { 0xeb66918a, 0x7eef, 0x402a, { = 0x84, > 0x2e, > > 0x93, 0x1d, 0x21, 0xc3, 0x8a, 0xe9 }} > > + > > + # > > # GUID defined in PI1.0 > > # > > ## Include/Guid/AprioriFileName.h > > -- > > 2.9.0.windows.1 > > > > > > Please consider the environment before printing this email. > > > > The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is > > intended to be read only by the individual or entity to whom it is > > addressed or by their designee. If the reader of this message is not > > the intended recipient, you are on notice that any distribution of > > this message, in any form, is strictly prohibited. Please promptly > > notify the sender by reply e-mail or by telephone at 770-246-8600, and > > then delete or destroy all copies of the transmission. > > > >=20 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intende= d > to be read only by the individual or entity to whom it is addressed or b= y their > designee. If the reader of this message is not the intended recipient, y= ou are > on notice that any distribution of this message, in any form, is strictl= y > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission.