public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhiguang Liu" <zhiguang.liu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"oleksiyy@ami.com" <oleksiyy@ami.com>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Felixp@ami.com" <Felixp@ami.com>
Subject: Re: [edk2-devel] [PATCH v1 0/7] Add definitions introduced in UEFI 2.8
Date: Wed, 22 Apr 2020 08:51:10 +0000	[thread overview]
Message-ID: <BN7PR11MB280471E3610CE8FE30E4257A90D20@BN7PR11MB2804.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200409202550.35116-1-oleksiyy@ami.com>

Hi Oleksiy,

There are tabs and Trailing whitespace in this patch set, which is not consistent with edk2 coding type. 
Please run ECC tool to check your code.
https://github.com/tianocore/tianocore.github.io/wiki/ECC-tool

Thanks
Zhiguang

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy Yakovlev
Sent: Friday, April 10, 2020 4:26 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com
Subject: [edk2-devel] [PATCH v1 0/7] Add definitions introduced in UEFI 2.8

Following patches add/update structures/definitions, that was introduced/modified by UEFI Spec v.2.8.
Oleksiy Yakovlev (7):
  MdePkg: Extend SERIAL_IO with DeviceTypeGuid (UEFI 2.8 mantis 1832)
  BaseTools:  REST style formset (UEFI 2.8 mantis 1853)
  MdePkg:  REST style formset (UEFI 2.8 mantis 1853)
  BaseTools: Bootable NVDIMM namespaces (UEFI 2.8 mantis 1858)
  MdePkg: Bootable NVDIMM namespaces (UEFI 2.8 mantis 1858)
  MdePkg: Add UEFI Spec Revision 2.8 (UEFI 2.8 mantis 1926)
  MdePkg: UEFI JSON Capsule Support (UEFI 2.8 mantis 1935)

 .../Common/UefiInternalFormRepresentation.h        |  1 +
 BaseTools/Source/C/Include/Protocol/DevicePath.h   | 12 +++
 MdePkg/Include/Guid/CapsuleReport.h                | 32 ++++++-
 MdePkg/Include/Guid/HiiPlatformSetupFormset.h      |  4 +
 MdePkg/Include/Guid/JsonCapsule.h                  | 99 ++++++++++++++++++++++
 MdePkg/Include/Protocol/DevicePath.h               | 12 +++
 MdePkg/Include/Protocol/SerialIo.h                 |  3 +-
 .../Include/Uefi/UefiInternalFormRepresentation.h  |  1 +
 MdePkg/Include/Uefi/UefiSpec.h                     |  2 +
 MdePkg/MdePkg.dec                                  | 12 +++
 10 files changed, 176 insertions(+), 2 deletions(-)  create mode 100644 MdePkg/Include/Guid/JsonCapsule.h

--
2.9.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.




      parent reply	other threads:[~2020-04-22  8:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09 20:25 [PATCH v1 0/7] Add definitions introduced in UEFI 2.8 Oleksiy Yakovlev
2020-04-09 20:25 ` [PATCH v1 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid Oleksiy Yakovlev
2020-04-09 20:25 ` [PATCH v1 2/7] BaseTools: REST style formset Oleksiy Yakovlev
2020-04-09 20:25 ` [PATCH v1 3/7] MdePkg: " Oleksiy Yakovlev
2020-04-09 20:25 ` [PATCH v1 4/7] BaseTools: Bootable NVDIMM namespaces Oleksiy Yakovlev
2020-04-09 20:25 ` [PATCH v1 5/7] MdePkg: " Oleksiy Yakovlev
2020-04-09 20:25 ` [PATCH v1 6/7] MdePkg: Add UEFI Spec Revision 2.8 Oleksiy Yakovlev
2020-04-09 20:25 ` [PATCH v1 7/7] MdePkg: UEFI JSON Capsule Support Oleksiy Yakovlev
2020-04-22  8:50   ` [edk2-devel] " Zhiguang Liu
2020-04-22 20:41     ` Oleksiy Yakovlev
2020-04-23  2:30       ` Zhiguang Liu
2020-04-23  2:38         ` Rothman, Michael A
2020-04-23  5:45           ` Liming Gao
2020-04-23 13:54             ` Oleksiy Yakovlev
2020-04-22  8:51 ` Zhiguang Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN7PR11MB280471E3610CE8FE30E4257A90D20@BN7PR11MB2804.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox