From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.3892.1587450983733940631 for ; Mon, 20 Apr 2020 23:36:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=jKoyqQWA; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: zhiguang.liu@intel.com) IronPort-SDR: TcS7ik7wAqleumTOMCz0W31UeNQQc7c8d3wZNsnwaqyLwFZuRmg3GVxeOxQ/w2fnsUUC7EdUp2 iZLzUzv9QtCg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 23:36:23 -0700 IronPort-SDR: thc5m1+VGq/QbklvYIkQRdgsKhEUXiZMLsanouDbpt7+ylqA7vmkYh2/Iuf57HaG03M8Qgh4j4 2bdS4ZDupkxQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,409,1580803200"; d="scan'208";a="244075932" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga007.jf.intel.com with ESMTP; 20 Apr 2020 23:36:23 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Apr 2020 23:36:22 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 20 Apr 2020 23:36:22 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 20 Apr 2020 23:36:22 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Apr 2020 23:36:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CtwASjwquH3bXS1BQbVd8VAMoKPAyf2j+cVHbB0zB2sL3CwoZbXXru8p8OugtF6inM3Y5+aeMmmzVi83iG/b7cW6CcsMB+VY7iqp4fzCKd/7SSaxFnlrAjKVj6qCRF7cghF5drMUb5Gg8yNtTWeMySF1CvscVcq5OnFT8dBVX5fWg605CDCXExWxIAvMQGfGbGbH/mxzOsLNsEUhHLPJjFqyGMvcVZeqs6xHQUe0OKUFiPFlFK5B8IcbL42BQll+c9oDy9ULzAQBZfFzZnRE+ALS+IrlaDhDpY24H1OVoE68lQ2Pn8m8GwgDGK+f9diyXCXa1WgwC16AfnwdSEX5LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=klOAKKw9xhkBna9kbFtK1VWyH96RYeUiceJCCdj2Q3k=; b=OgpyO9aqCX8S12RwvxC4+VJ8JqgK9WLlWdCI5Tx7HPnR5bGT+3hX87UZiBodJh6nGp+7o2kDGTXS+JqnPbElUc6TfT6Nz6RKYp0T5VZ0kU4LYVUVyjtKdFZUsnX1WrdtJTHt/vWm8DhIwk+NCBW2D/OCkEfhRyutRDwNnQiN3EGa0NIi6snmEnEFC1Pn4Z6OdWSm8MT5j2rnTk9q+d/IaxtfXuUdFEvlp70ibkLXUSCRPnBh7VCdpXailRmNCzHj1f5AB5o9mYbM6lEFHWyLgU8zr9f7AkmKdxnbU3m8e8/J2iD1NbLx1E8CklpmGFEU0vOtDh9IASHNfdeO1+XP8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=klOAKKw9xhkBna9kbFtK1VWyH96RYeUiceJCCdj2Q3k=; b=jKoyqQWAs9YOV4z3ypz4DdW06tLxZGPG086XSNO5wdIyPh3gxYlgaW8nHjkTHnVNjwBIEty1afmIK8b6bZBC9mLqB0Gx0ACF5/dSCeNe2DBhb6wrxJB9IRMpn9poelOXVe+OA9+lieAs01tFTXBvNXyiFb3KN7hR1tPbwhdkxSY= Received: from BN7PR11MB2804.namprd11.prod.outlook.com (2603:10b6:406:ac::12) by BN7PR11MB2722.namprd11.prod.outlook.com (2603:10b6:406:b8::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.26; Tue, 21 Apr 2020 06:36:14 +0000 Received: from BN7PR11MB2804.namprd11.prod.outlook.com ([fe80::79e2:ed1f:4d6b:532c]) by BN7PR11MB2804.namprd11.prod.outlook.com ([fe80::79e2:ed1f:4d6b:532c%7]) with mapi id 15.20.2921.030; Tue, 21 Apr 2020 06:36:14 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "abner.chang@hpe.com" CC: Gilbert Chen , Leif Lindholm , "Kinney, Michael D" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v1 5/9] MdePkg/BaseIoLibIntrinsic: Rename IoLibArm.c=>IoLibNoIo.c Thread-Topic: [edk2-devel] [PATCH v1 5/9] MdePkg/BaseIoLibIntrinsic: Rename IoLibArm.c=>IoLibNoIo.c Thread-Index: AQHWDw35MhDnZoKvw0Sv5fnvYZNA5aiDLzqw Date: Tue, 21 Apr 2020 06:36:14 +0000 Message-ID: References: <20200410072112.7310-1-abner.chang@hpe.com> <20200410072112.7310-6-abner.chang@hpe.com> In-Reply-To: <20200410072112.7310-6-abner.chang@hpe.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=zhiguang.liu@intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b2691966-50f8-4e40-5fa6-08d7e5be49e3 x-ms-traffictypediagnostic: BN7PR11MB2722: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 038002787A x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR11MB2804.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(6029001)(396003)(366004)(376002)(39860400002)(136003)(346002)(4326008)(316002)(55016002)(110136005)(53546011)(9686003)(26005)(2906002)(5660300002)(6506007)(86362001)(107886003)(54906003)(7696005)(81156014)(8936002)(186003)(76116006)(52536014)(71200400001)(33656002)(966005)(478600001)(66946007)(66446008)(66476007)(64756008)(66556008)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QE6W5ZYq3mPK0RbI373MWAD5BVz6h2el/87EDbLtTtHH1ZE6UwLvYodol6+kdYOHTvpLi/nXSCDZ8yntaZjqx8/7UhcIelTMYm+chWmyAL//iEBwS5xhBV+mSwuoC8nthPRJaos0PdkDvc9FeyKvLEv+QLiV1kMfhLafzjG+qZWh3Kmc8iP8vq1vZeC70G8HWzGWDOmZmFS6V/joTG/n5nLX0lM+TCFin4oomHyQ5OF29mB45hV37lu1qQVt65O12YVQbbT8hfEHpH7u8yHzEwWQnwtT4oAZkObRuesTbmd5jBLOEia+kfGbn3VddPOQmkhvBPbNLEF1O0DzcNtC38e/2BHx4wCt6Y88QtIMh79HwW9Mz2qikGhZ12TuGEAHzARU+lJhBRNh1wN0wzxdQIMxBmvhDQ8+BG3iph7cby/2M4vP5BCvMuP+bw91wd0KC8PfzCFovzTUKbp8XS6wLdqtzKDLHTp5shmSGux9VquJg3VLDowNtUFF/26niLj1H4R3JjST5dWvD4D0WkVdeg== x-ms-exchange-antispam-messagedata: rZ+NgtItWwKhcWjSIlFX49enWq3sgVLBodHE1F1zrk5w1TmKCs50j97qDS7SPWsvKzcmJPTBWVL9J74y3+HdF7pMqL4FmsmnfhNzEREtIP///bV807K0yN6WqnR76GMJvEr6sDTv4RMxSLaLtG75yQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: b2691966-50f8-4e40-5fa6-08d7e5be49e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 06:36:14.0260 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TohIUFveMewU8rEpcmkH/PSRMkjNIr8M2U/iXCJJdWKZfSKx3UW+xemovM0wyBdgsq5wTHjamA8qoj2bqR+w1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2722 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Abner, In BaseIoLibIntrinsic.inf, you add the line "This I/O library only provides= non I/O read and write." I supposed this is a description for ARM and RISC-V but not for other arch.= If so, please specify it because this is an inf files all arch are using. Thanks Zhiguang -----Original Message----- From: devel@edk2.groups.io On Behalf Of Abner Chang Sent: Friday, April 10, 2020 3:21 PM To: devel@edk2.groups.io Cc: abner.chang@hpe.com; Gilbert Chen ; Leif Lindholm= ; Kinney, Michael D = ; Gao, Liming Subject: [edk2-devel] [PATCH v1 5/9] MdePkg/BaseIoLibIntrinsic: Rename IoLi= bArm.c=3D>IoLibNoIo.c RISC-V MMIO library instance. IoLibArm.c in fact implements a generic Mmio-only (and ANSI C compliant), so rename it to better reflect this. Signed-off-by: Abner Chang Co-authored-by: Gilbert Chen Reviewed-by: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Cc: Leif Lindholm Cc: Gilbert Chen --- .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 12 ++++++++---- .../BaseIoLibIntrinsic/{IoLibArm.c =3D> IoLibNoIo.c} | 4 +++- 2 files changed, 11 insertions(+), 5 deletions(-) rename MdePkg/Library/BaseIoLibIntrinsic/{IoLibArm.c =3D> IoLibNoIo.c} (94= %) diff --git a/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf b/Mde= Pkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf index 457cce9378..cc23b6b227 100644 --- a/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf +++ b/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf @@ -4,11 +4,12 @@ # I/O Library that uses compiler intrinsics to perform IN and OUT instruc= tions # for IA-32 and x64. On IPF, I/O port requests are translated into MMIO = requests. # MMIO requests are forwarded directly to memory. For EBC, I/O port requ= ests -# ASSERT(). +# ASSERT(). This I/O library only provides non I/O read and write. # # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
# Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
# Copyright (c) 2017, AMD Incorporated. All rights reserved.
+# Portions Copyright (c) 2020, Hewlett Packard Enterprise Development LP.= All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -25,7 +26,7 @@ =20 =20 # -# VALID_ARCHITECTURES =3D IA32 X64 EBC ARM AARCH64 +# VALID_ARCHITECTURES =3D IA32 X64 EBC ARM AARCH64 RISCV64 # =20 [Sources] @@ -50,10 +51,13 @@ IoLib.c =20 [Sources.ARM] - IoLibArm.c + IoLibNoIo.c =20 [Sources.AARCH64] - IoLibArm.c + IoLibNoIo.c + +[Sources.RISCV64] + IoLibNoIo.c =20 [Packages] MdePkg/MdePkg.dec diff --git a/MdePkg/Library/BaseIoLibIntrinsic/IoLibArm.c b/MdePkg/Library/= BaseIoLibIntrinsic/IoLibNoIo.c similarity index 94% rename from MdePkg/Library/BaseIoLibIntrinsic/IoLibArm.c rename to MdePkg/Library/BaseIoLibIntrinsic/IoLibNoIo.c index c6b822461d..a107136a74 100644 --- a/MdePkg/Library/BaseIoLibIntrinsic/IoLibArm.c +++ b/MdePkg/Library/BaseIoLibIntrinsic/IoLibNoIo.c @@ -1,9 +1,11 @@ /** @file - I/O Library for ARM. + I/O library for non I/O read and write access (memory map I/O read and + write only) architecture, such as ARM and RISC-V processor. =20 Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
Copyright (c) 2017, AMD Incorporated. All rights reserved.
+ Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All right= s reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 --=20 2.25.0 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57196): https://edk2.groups.io/g/devel/message/57196 Mute This Topic: https://groups.io/mt/72916363/1779286 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [zhiguang.liu@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D