From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.6488.1589174021567973144 for ; Sun, 10 May 2020 22:13:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ugKy67aU; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: zhiguang.liu@intel.com) IronPort-SDR: W45dFjZ+vhO8+atWNwi/xhEJ/cSR0zCQbYRyc9owT6kL6uHTVXHvZF7pTQCFKjqFXQSRsgGoDK KYvaI1JxHASA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2020 22:13:41 -0700 IronPort-SDR: p5h1cDG8qJ3/2q9txqHup/8ONt62ceLpnaPldrqnFKaBY3zyOF07MVWGU8Yg/p4J66+sktqrv2 hvbKqaEA4jPw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,378,1583222400"; d="scan'208";a="252499988" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 10 May 2020 22:13:38 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 10 May 2020 22:13:38 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 10 May 2020 22:13:37 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 10 May 2020 22:13:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nLEpXZ4SA0fIbIbrugV+re7AS+etBxS+H11zC0H0WbHNGJiDsWZ6kF4dRRMLUH0SwJh5Ny4BbW3SFJtNJ/Uux+AQL4YWxoRgrQYyPYKmdwxj/iAbIFWwtFObxizMnXETsQqkRk68KqOB2kBSr6q+A+CXN3DnziOqTANRQrqGqpaQBpztEVtLLw2BHX+lmDA0rasf5SCLLNrmEXS3REXAr+VnpPMcfpJS7eFqaBXec4OS3hl+491oesUlCqKEO3MOQENJSAoU7DbzyTb/IM614vt7C54xKAjYGPUEgTJu2rmyFnLEypQD4OnIoTbGP9dckXelDBh76enIWGs+bgQAog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n7CkGbvsLEWoaHJwjq+4F4hcvi+57OG5GVKvMjc95Ls=; b=M1fvP43e3V7cmT4rKMIu2zmeBavo/EocT24zBTM2fUAFPys1jNJ2bYPIDqqRC7/2p0CAIVR9XlV0NXrGG1dJp2Ljci81i0TAgfQeVIOjGGlQFkqUtknZG7B/I+Ct8p2o7Fhco6AamrVEyRMa/od5atX/KQj13jFrK1AdQKkAh65tefUQunKcJtp5r1QDE9PGt78/n+Q3yvG//vH9md+o+P+xLUifYs1FYaL1eIw3zpQN4A3UU8i/lYxwEfqWhkN/PcKhD/Zx9nxBCkSUbdWRiuYnYo+E9R38x2NDxSN413ArtsegEusCAtbtHLh2hKDCMvSSHJGPKgkspv/xaXbcWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n7CkGbvsLEWoaHJwjq+4F4hcvi+57OG5GVKvMjc95Ls=; b=ugKy67aUEyBTW0dFA/YMM6x67gazL4s4MNgnZTW1GpFHwBuLFSjK5GQLoJqlWCJ8cRvgYYfhCKf4n4BpGXQZEIhdHM/sX3gQdk3M5pLLg2mD5pT2MbZS86VnldlZRVDDygolI62rPD6vGoPvIavDI65LuX4vHWhF5Ew/IJfOnZI= Received: from BN7PR11MB2804.namprd11.prod.outlook.com (2603:10b6:406:ac::12) by BN7PR11MB2819.namprd11.prod.outlook.com (2603:10b6:406:b4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Mon, 11 May 2020 05:13:36 +0000 Received: from BN7PR11MB2804.namprd11.prod.outlook.com ([fe80::79e2:ed1f:4d6b:532c]) by BN7PR11MB2804.namprd11.prod.outlook.com ([fe80::79e2:ed1f:4d6b:532c%7]) with mapi id 15.20.2979.033; Mon, 11 May 2020 05:13:36 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "oleksiyy@ami.com" CC: "Gao, Liming" , "Kinney, Michael D" , "Felixp@ami.com" , "robert@ami.com" Subject: Re: [edk2-devel] [PATCH 1/5] MdePkg: New Status Codes Thread-Topic: [edk2-devel] [PATCH 1/5] MdePkg: New Status Codes Thread-Index: AQHWJKJxhxTdou7eLUGXnZk/IHSgWaiiW+Ug Date: Mon, 11 May 2020 05:13:35 +0000 Message-ID: References: <20200507190310.38968-1-oleksiyy@ami.com> <20200507190310.38968-2-oleksiyy@ami.com> In-Reply-To: <20200507190310.38968-2-oleksiyy@ami.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: edddeb94-0748-4edc-aa39-08d7f56a0ede x-ms-traffictypediagnostic: BN7PR11MB2819: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1728; x-forefront-prvs: 04004D94E2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dxZ6OrPu3AqhRSydYd6rSXlqEKAHAVlZ57FUxkROQD+/WXHPNVydHFzlXcwyqNlzgdfy1O/KSHgxdHFMic4hsFkSi7ma/kn3YoS61AAOw/HNQEk7xQwH5QSWXMQIe98llUymkFKZj0A4bwYAjqpNAFUusi1l5xQWXdksXUJDD7ey3PkU+QDcZKvKcTx7xHrVmQFDX/4wTdStqcsOxY+0+/n6YdqefZ2SkT/cIPvMOIe6g4g9161aS/bRmRUw2OFgJqYX/+zI8FOG61nb+KetgDU7I0jISGZkaO13HC+z1dOD89sV2cUj1SthnjtvLwyDHYHfqC6zNcq0pFy533h0PgbwBUU5+OEqdvPPf45jAI/Vr1sV8DP/MV2ySiD53UPCI0y+r0BmI0ZXcEiipLi6Es/zTElSIz8MvMrlyWh7wuxAU1PnlFiuSuS+DUyinDS9L6edZVKqsunvkIr6CYJfp0pfKc4ylJCAfMO//u32mL8aU9DQKkc5tzar2qp90x7ew8KJHO58gCZ82gm2VqoqnzlKP0UxUBDpduHgZeVX0cNZ1T0q6GCAm3jddCEUEH4w/8u1Pq1l9M7U5yUu0wZkyxkZlwB4t+xPSdemajzdPDc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR11MB2804.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(376002)(346002)(39860400002)(396003)(136003)(33430700001)(186003)(316002)(9686003)(52536014)(66556008)(64756008)(478600001)(33656002)(66446008)(2906002)(55016002)(33440700001)(4326008)(66476007)(8936002)(26005)(110136005)(86362001)(8676002)(6506007)(53546011)(5660300002)(76116006)(71200400001)(966005)(7696005)(66946007)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 0YCSM4VIxH0SKveE7u2vPgG26TFfI8apXI4+n1vC2KDldyI3YRhqbpFPbFxpiFERhBBcbXykYmEsGqta96XE3jEtkadJ1OaChr9lMMKgXAEmxkH2aaXpQfeAqVgmiHKMdguUjMBIjqHWfiUj1E3JkMcaS2ZTjIkZ/vef+Gx9FKVzmdicHMeMD0m2dFkqhqE+Qoi70fE7+KwIWQx+Oo6k5sVjK6nihUvx9k/53tsA1uvoxxiPSHL/jtt3pcrKq0KFHoeOQv29H+3WZ5LxYfFUD/KmyVbeD/FDjjYC7oRJG4+QKN8/4k0l3CQR3tZha/0US+6IigBpfcAZx2dmCkcE77AYjnI0754s0u+FiPclgqlIcmG5JVhtCFdHA35kImpCzcZyUoV4e2+1TgVViz1Dwf8wXe6DdnPwSpHVeqHa1mK2mCVEii83k3zY4ezQWl9zHevkQOXZvhCABIzAHC0S1NEerL0qWiLQ15wsp9icjhh71EEHzej1MZ259MEGC+5j MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: edddeb94-0748-4edc-aa39-08d7f56a0ede X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2020 05:13:35.8408 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BEr8EkqJDQMZbwCVq7vIlI+z6f8apWswVz3wsct8+ysif4lr2igmi8cRUJ/oTUYciL8IUq5Qw8O5eY6YINv/4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2819 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Oleksiy, Give my comments inline. Thanks Zhiguang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oleksiy > Yakovlev > Sent: Friday, May 8, 2020 3:03 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; Felixp@ami.com; oleksiyy@ami.com; > robert@ami.com > Subject: [edk2-devel] [PATCH 1/5] MdePkg: New Status Codes >=20 > From: Robert Phelps >=20 > Updated PiStatusCodes to reflect changes to PI 1.7 Specification (PI 1.7 > Mantis 1889) >=20 > Signed-off-by: Robert Phelps > --- > MdePkg/Include/Pi/PiStatusCode.h | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Include/Pi/PiStatusCode.h > b/MdePkg/Include/Pi/PiStatusCode.h > index 0ffd29a714..81fd24c9ea 100644 > --- a/MdePkg/Include/Pi/PiStatusCode.h > +++ b/MdePkg/Include/Pi/PiStatusCode.h > @@ -340,6 +340,7 @@ typedef struct { > #define EFI_CHIPSET_EC_BAD_BATTERY (EFI_SUBCLASS_SPECIFIC | > 0x00000000) > #define EFI_CHIPSET_EC_DXE_NB_ERROR (EFI_SUBCLASS_SPECIFIC | > 0x00000001) > #define EFI_CHIPSET_EC_DXE_SB_ERROR (EFI_SUBCLASS_SPECIFIC | > 0x00000002) > +#define EFI_CHIPSET_EC_INTRUDER_DETECT (EFI_SUBCLASS_SPECIFIC | > +0x00000003) > ///@} >=20 > /// > @@ -361,6 +362,7 @@ typedef struct { > #define EFI_PERIPHERAL_AUDIO_OUTPUT (EFI_PERIPHERAL | 0x000A0000) > #define EFI_PERIPHERAL_LCD_DEVICE (EFI_PERIPHERAL | 0x000B0000) > #define EFI_PERIPHERAL_NETWORK (EFI_PERIPHERAL | 0x000C0000) > +#define EFI_PERIPHERAL_DOCKING (EFI_PERIPHERAL | 0x000D0000) > ///@} >=20 > /// > @@ -375,6 +377,7 @@ typedef struct { > #define EFI_P_PC_ENABLE 0x00000004 > #define EFI_P_PC_RECONFIG 0x00000005 > #define EFI_P_PC_DETECTED 0x00000006 > +#define EFI_P_PC_REMOVED 0x00000007 > ///@} >=20 > // > @@ -464,8 +467,9 @@ typedef struct { > /// Peripheral Class Keyboard Subclass Error Code definitions. > /// > ///@{ > -#define EFI_P_KEYBOARD_EC_LOCKED (EFI_SUBCLASS_SPECIFIC | > 0x00000000) > -#define EFI_P_KEYBOARD_EC_STUCK_KEY (EFI_SUBCLASS_SPECIFIC | > 0x00000001) > +#define EFI_P_KEYBOARD_EC_LOCKED (EFI_SUBCLASS_SPECIFIC | > 0x00000000) > +#define EFI_P_KEYBOARD_EC_STUCK_KEY (EFI_SUBCLASS_SPECIFIC | > 0x00000001) > +#define EFI_P_KEYBOARD_EC_BUFFER_FULL (EFI_SUBCLASS_SPECIFIC | > +0x00000002) > ///@} >=20 > /// > @@ -762,6 +766,7 @@ typedef struct { > #define EFI_SW_PEI_PC_RECOVERY_AUTO (EFI_SUBCLASS_SPECIFIC | > 0x00000004) > #define EFI_SW_PEI_PC_S3_BOOT_SCRIPT (EFI_SUBCLASS_SPECIFIC | > 0x00000005) > #define EFI_SW_PEI_PC_OS_WAKE (EFI_SUBCLASS_SPECIFIC | > 0x00000006) > +#define EFI_SW_PEI_PC_S3_STARTED (EFI_SUBCLASS_SPECIFIC | > 0x00000007) > ///@} >=20 > /// > @@ -784,7 +789,11 @@ typedef struct { > #define EFI_SW_DXE_BS_PC_LEGACY_BOOT_EVENT > (EFI_SUBCLASS_SPECIFIC | 0x00000002) > #define EFI_SW_DXE_BS_PC_EXIT_BOOT_SERVICES_EVENT > (EFI_SUBCLASS_SPECIFIC | 0x00000003) > #define EFI_SW_DXE_BS_PC_VIRTUAL_ADDRESS_CHANGE_EVENT > (EFI_SUBCLASS_SPECIFIC | 0x00000004) > +#define EFI_SW_DXE_BS_PC_VARIABLE_SERVICES_INIT > (EFI_SUBCLASS_SPECIFIC | 0x00000005) > +#define EFI_SW_DXE_BS_PC_VARIABLE_RECLAIM > (EFI_SUBCLASS_SPECIFIC | 0x00000006) > #define EFI_SW_DXE_BS_PC_ATTEMPT_BOOT_ORDER_EVENT > (EFI_SUBCLASS_SPECIFIC | 0x00000007) > +#define EFI_SW_DXE_BS_PC_CONFIG_RESET > (EFI_SUBCLASS_SPECIFIC | 0x00000008) > +#define EFI_SW_DXE_BS_PC_CSM_INIT (EFI_SUBCLASS_SPE= CIFIC > | 0x00000009) > ///@} >=20 > // > @@ -974,6 +983,8 @@ typedef struct { > #define EFI_SW_EC_PWD_CLR_REQUEST 0x0000000F > #define EFI_SW_EC_PWD_CLEARED 0x00000010 > #define EFI_SW_EC_EVENT_LOG_FULL 0x00000011 > +#define EFI_SW_EC_WRITE_PROTECTED 0x00000012 > +#define EFI_SW_EC_FV_CORRUPTED 0x00000013 > ///@} >=20 > // > @@ -1005,6 +1016,8 @@ typedef struct { > #define EFI_SW_PEI_EC_S3_RESUME_FAILED > (EFI_SUBCLASS_SPECIFIC | 0x00000005) > #define EFI_SW_PEI_EC_RECOVERY_PPI_NOT_FOUND > (EFI_SUBCLASS_SPECIFIC | 0x00000006) > #define EFI_SW_PEI_EC_RECOVERY_FAILED (EFI_SUBCLASS_SPECIF= IC > | 0x00000007) > +#define EFI_SW_PEI_EC_RESUME_ERROR (EFI_SUBCLASS_SPECIF= IC > | 0x00000008) The spec defines EFI_SW_PEI_EC_S3_RESUME_ERROR not define EFI_SW_PEI_EC_R= ESUME_ERROR =20 > +#define EFI_SW_PEI_EC_INVALID_CAPSULE > (EFI_SUBCLASS_SPECIFIC | 0x00000009) > ///@} >=20 > /// > -- > 2.24.1.windows.2 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intende= d > to be read only by the individual or entity to whom it is addressed or b= y their > designee. If the reader of this message is not the intended recipient, y= ou are > on notice that any distribution of this message, in any form, is strictl= y > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission. >=20 >=20