Re: [edk2-devel] [PATCH v3 3/7] MdePkg: REST style formset

["Zhiguang Liu" <zhiguang.liu@intel.com>]

Hi Oleksiy,

Sorry I didn't explain myself clearly. It is about the below line.
An Opcode with this flag indicates this question support REST style operation

It has 79 characters, but Commit-Message-Format wiki recommend to have less than 76 characters.
I don't know if breaking this rule slightly will affect pull request or not 

Thanks
Zhiguang

> -----Original Message-----
> From: Oleksiy Yakovlev <Oleksiyy@ami.com>
> Sent: Friday, May 8, 2020 10:12 PM
> To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Felix Polyudov <Felixp@ami.com>
> Subject: RE: [edk2-devel] [PATCH v3 3/7] MdePkg: REST style formset
> 
> Hi Zhiguang.
> 
> Commit messages are formatted correctly in patches when I view them in
> editor (notepad ++). Looks like sending them via emails resulted in
> eliminating all EOL before dot (making single sentences inline).
> 
> I am using "git send-email --suppress-from --to ..." command. Is there any
> key to avoid such behavior?
> 
> Regards, Oleksiy.
> 
> -----Original Message-----
> From: Liu, Zhiguang [mailto:zhiguang.liu@intel.com]
> Sent: Thursday, May 07, 2020 11:24 PM
> To: devel@edk2.groups.io; Oleksiy Yakovlev
> Cc: Feng, Bob C; Gao, Liming; Kinney, Michael D; Felix Polyudov
> Subject: RE: [edk2-devel] [PATCH v3 3/7] MdePkg: REST style formset
> 
> Hi Oleksiy,
> Some lines in commit message is too long , from
> https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-
> Format, line length should be less than 76 characters when possible.
> Other parts are fine to me.
> 
> Thanks
> Zhiguang
> 
> Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> 
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> Yakovlev
> Sent: Friday, May 8, 2020 3:14 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Felixp@ami.com; oleksiyy@ami.com
> Subject: [edk2-devel] [PATCH v3 3/7] MdePkg: REST style formset
> 
> New ClassGuid EFI_HII_REST_STYLE_FORMSET_GUID is defined. A formset
> with this class GUID indicates all the questions in the formset support REST
> style operation and can be exposed to a REST service point.
> In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined.
> An Opcode with this flag indicates this question support REST style operation
> and can be exposed to a REST service point.
> (UEFI 2.8 mantis 1853)
> 
> Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
> ---
>  MdePkg/Include/Guid/HiiPlatformSetupFormset.h        | 4 ++++
>  MdePkg/Include/Uefi/UefiInternalFormRepresentation.h | 1 +
>  2 files changed, 5 insertions(+)
> 
> diff --git a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h
> b/MdePkg/Include/Guid/HiiPlatformSetupFormset.h
> index 540483d..a6ba55b 100644
> --- a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h
> +++ b/MdePkg/Include/Guid/HiiPlatformSetupFormset.h
> @@ -22,8 +22,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent  #define
> EFI_HII_USER_CREDENTIAL_FORMSET_GUID \
>    { 0x337f4407, 0x5aee, 0x4b83, { 0xb2, 0xa7, 0x4e, 0xad, 0xca, 0x30, 0x88,
> 0xcd } }
> 
> +#define EFI_HII_REST_STYLE_FORMSET_GUID \
> +  { 0x790217bd, 0xbecf, 0x485b, { 0x91, 0x70, 0x5f, 0xf7, 0x11, 0x31,
> +0x8b, 0x27 } }
> +
>  extern EFI_GUID gEfiHiiPlatformSetupFormsetGuid;  extern EFI_GUID
> gEfiHiiDriverHealthFormsetGuid;  extern EFI_GUID
> gEfiHiiUserCredentialFormsetGuid;
> +extern EFI_GUID gEfiHiiRestStyleFormsetGuid;
> 
>  #endif
> diff --git a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h
> b/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h
> index 4a1346a..40fcdb7 100644
> --- a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h
> +++ b/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h
> @@ -825,6 +825,7 @@ typedef struct _EFI_IFR_QUESTION_HEADER {
>  #define EFI_IFR_FLAG_READ_ONLY          0x01
>  #define EFI_IFR_FLAG_CALLBACK           0x04
>  #define EFI_IFR_FLAG_RESET_REQUIRED     0x10
> +#define EFI_IFR_FLAG_REST_STYLE         0x20
>  #define EFI_IFR_FLAG_RECONNECT_REQUIRED 0x40
>  #define EFI_IFR_FLAG_OPTIONS_ONLY       0x80
> 
> --
> 2.9.0.windows.1
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).  This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
> 
> 
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).  This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.