From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.2231.1588984747521225581 for ; Fri, 08 May 2020 17:39:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=BujUlQqf; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: zhiguang.liu@intel.com) IronPort-SDR: 7Y3pk7uPfll6yIqwWUhxRM3pABqZ+QSyZUU5rZdj0+cEONoTP3rSOsv3AMl4JFTUJVxFGEvIlB FjhX2+UWbNYg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 17:39:06 -0700 IronPort-SDR: QiZChsFD9/CAm5H7U803ZIVeZOWL5MmmWzM+FhRgS06vr0mC6LLKk4O8UTVyBCHGR7RzTW7p5R mQ6e4Y9WYbAA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,369,1583222400"; d="scan'208";a="305640805" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 08 May 2020 17:39:06 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 17:39:06 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 8 May 2020 17:39:05 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 8 May 2020 17:39:05 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 17:39:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UPrOviuF6QEcDy2+dHprXlc9YpC0KOeu9K8tiRHR8OpOnpu+vhIFng4fUY0rs6yqVPi1vNGx4s4K+i4xckl/qbMxmPkH+m68R7zzV/nXIER0qrImGyYTY7FweAXDswxkJ/NYH5pLeCysdGc1+ab6wcnZTLklE44bYKCIuerfCMlV2wcnTm+5JVCM4y3qGKuKQ3pRetErK1dEhDiawWIh1dOKzarHYnAr8My0YVsVY9cnnbPQtnazTY+yMNPgxhXyvbLGdN1MiLdAi4K311xljipf+EYFubW0Yn185YOKGmC8OdyiZjw8QgR5Nwv+wjrF0BunFbR5S/Cy464Aspy1+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nviNFPQD3w3U0e+SNVnd3N+uF84h6urLjmIKUdMD52A=; b=kb/fvX+jowourxmwAStSTaJPjwKm2lufykQguK8SHaFDDyyFcgG58SiQz3ppxW4f+j1HSY0QXFQtEYEZpAhWmxA3TOOMYHKnzMwOn4tQi+kkI6d9FRomSa04u+DVoboHGc8r/y80PbaiLm8dOhZ7dxOpr7xxQjQLYFDcc07ZrkXoCW3T4x2wvFWpgzCcdo5aPGO0e6FId8A23PZgxIROb+TtRURzEeD9zGRu1GL6lnbA5zPqLvnfLuX9M3N4YnIuStOmcqa1ecQ/NapqDNLHwYbov13GzolrEcv6shBrJjlOE9xt762qqvfktEuQ0Wnaj8+vTdpv0/EkYLdzpRiUJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nviNFPQD3w3U0e+SNVnd3N+uF84h6urLjmIKUdMD52A=; b=BujUlQqfrPp6VsVxfUzfg80b74FIK5BOco/F4xGAISOEmo7d9lohwzCK53oJs3jXrlDBGNOZHVgI533mL+rd4gRE8fNMiPP17jJybT/n1E1QBS4hVn7fp+jCNdERXprltyVrgmGLbjSyK1ydPchrTxbL20pz/TCp1RbShFgtIdQ= Received: from BN7PR11MB2804.namprd11.prod.outlook.com (2603:10b6:406:ac::12) by BN7PR11MB2593.namprd11.prod.outlook.com (2603:10b6:406:ab::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Sat, 9 May 2020 00:39:04 +0000 Received: from BN7PR11MB2804.namprd11.prod.outlook.com ([fe80::79e2:ed1f:4d6b:532c]) by BN7PR11MB2804.namprd11.prod.outlook.com ([fe80::79e2:ed1f:4d6b:532c%7]) with mapi id 15.20.2958.033; Sat, 9 May 2020 00:39:04 +0000 From: "Zhiguang Liu" To: Oleksiy Yakovlev , "devel@edk2.groups.io" CC: "Feng, Bob C" , "Gao, Liming" , "Kinney, Michael D" , Felix Polyudov Subject: Re: [edk2-devel] [PATCH v3 3/7] MdePkg: REST style formset Thread-Topic: [edk2-devel] [PATCH v3 3/7] MdePkg: REST style formset Thread-Index: AQHWJKPwGbaqdKRjfESqt9PJlmb5lqidhfNwgAC2L4CAAK11EA== Date: Sat, 9 May 2020 00:39:03 +0000 Message-ID: References: <20200507191358.74904-1-oleksiyy@ami.com> <20200507191358.74904-4-oleksiyy@ami.com> <6BD875C24FFE2A4E8D6EFC142C67836F03FFFF9BE0@atlms1.us.megatrends.com> In-Reply-To: <6BD875C24FFE2A4E8D6EFC142C67836F03FFFF9BE0@atlms1.us.megatrends.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: ami.com; dkim=none (message not signed) header.d=none;ami.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ee7544f7-f0c1-4a12-62ef-08d7f3b15ffe x-ms-traffictypediagnostic: BN7PR11MB2593: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:499; x-forefront-prvs: 03982FDC1D x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: II48JJKDCOSn2Ta/KRaQVDmV29T0MwChKptcRt9zm4QbBIv9h7EYMcMGB7KWYd/oAAI+WJLsufou5JPwcf0uD36V33z3oXv2kvqqzM3ukK3Yugxzzv+GXydqCrh7OtW7W669O/Vkw+E6QbZFQW9ZUSraxXrPIRNlQrMpzSqXqxHpKzO7yhGmOBMAlcE9cX/pK0lHoyVHk4ZG3dHB2pJ0y3ovo5Sc5yJgO+ZD3LGrOuhKXpNTlQ56PirBpkcsVzH7B+jd4vJer962AuQ1vlw69w+Sgzs+2SHKozMP38vT/YOju6e0H3jAqdHCRowfINe6b8w+2OU8aL7F7LohtVXJE3lw4b6gikWk1R6nxCpra+iSIsKEARD6CS/jUcxQgP6aVpB4Q9xmRiBdTbI34/gmCFBkS8C9xDNdkiNjZ0UbFiwskWpRy2KkNSPMJzO5Uhc3mYn29MguPrTX2L6D7eju689f9AxoIR4C+fpFEDDTIZ79XHsTP9VZdm+zJxC6LU7S27vaAMzrxWzU9RMXYg/B1jH+hhYntpYozbMtslK3Rk26Cs7aD0pIdELpPzvzc4JtElkPO55AuY/9j0CpIZZ/asLaKKHuxRnnC/kKzCRFOJk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR11MB2804.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(39860400002)(366004)(376002)(396003)(136003)(33430700001)(316002)(966005)(55016002)(7696005)(64756008)(186003)(6506007)(66946007)(71200400001)(86362001)(76116006)(66476007)(53546011)(66446008)(26005)(8936002)(110136005)(5660300002)(4326008)(2906002)(9686003)(66556008)(33656002)(8676002)(478600001)(52536014)(33440700001)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: noDIVfPW4jQa0gF1WkeIlN8K5suWY3gqyc/lA9fsZ653Fa5z/YU5c8/YdEUxK5ZZ1E8Vnc7jciu822a22vE4tPXV7VRN0ngm6irerYuQyBiFkoEfNfwTOgslYH/sHKTp3I90DN6EMaGqq72CIV9nCCLZqmiPfKpoByhLnwpJ+WXj8JtR6IE+XUV8lSe90lZITwBuOzVp/d92Cd5q8EBGhos2m0TvWq/th6H1ocG0jP5EdGlBUyncqfdS8E4XTRR8j3COLURiegNHmZdNXPZYYXIJuoHMIALs6O1waq1BaBj7TGZufY74wj5p8Zlte2rVW0Nu91BXE7WVPLHzWpKwex0uFUkgtLSpKaM2SuR13X+Nme7WoiPSmf8V5PC+ZS81ouGg2b0K3WA9JmQSSLbfeDYly2ZkDoMqWEKFNAYM3eLH/gPrStXAskf7Zer/b0cvj025AU3mSlazFtHaRUzNdIc923CCcAMzq0GFly718aGqOFVluDlMXTZn2XvM7KMi MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ee7544f7-f0c1-4a12-62ef-08d7f3b15ffe X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2020 00:39:03.9903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: O+Mjnh03x6ntaq8n+YqG938VtDxZfX3JKsfFw4YRAP1XXDDWojVfa9GzYxbneNToXsa8g6gX8OxnQtauMo0DDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2593 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Oleksiy, Sorry I didn't explain myself clearly. It is about the below line. An Opcode with this flag indicates this question support REST style operat= ion It has 79 characters, but Commit-Message-Format wiki recommend to have les= s than 76 characters. I don't know if breaking this rule slightly will affect pull request or no= t=20 Thanks Zhiguang > -----Original Message----- > From: Oleksiy Yakovlev > Sent: Friday, May 8, 2020 10:12 PM > To: Liu, Zhiguang ; devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Kinney, Michael D ; > Felix Polyudov > Subject: RE: [edk2-devel] [PATCH v3 3/7] MdePkg: REST style formset >=20 > Hi Zhiguang. >=20 > Commit messages are formatted correctly in patches when I view them in > editor (notepad ++). Looks like sending them via emails resulted in > eliminating all EOL before dot (making single sentences inline). >=20 > I am using "git send-email --suppress-from --to ..." command. Is there a= ny > key to avoid such behavior? >=20 > Regards, Oleksiy. >=20 > -----Original Message----- > From: Liu, Zhiguang [mailto:zhiguang.liu@intel.com] > Sent: Thursday, May 07, 2020 11:24 PM > To: devel@edk2.groups.io; Oleksiy Yakovlev > Cc: Feng, Bob C; Gao, Liming; Kinney, Michael D; Felix Polyudov > Subject: RE: [edk2-devel] [PATCH v3 3/7] MdePkg: REST style formset >=20 > Hi Oleksiy, > Some lines in commit message is too long , from > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message- > Format, line length should be less than 76 characters when possible. > Other parts are fine to me. >=20 > Thanks > Zhiguang >=20 > Reviewed-by: Zhiguang Liu >=20 >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oleksiy > Yakovlev > Sent: Friday, May 8, 2020 3:14 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Kinney, Michael D ; > Felixp@ami.com; oleksiyy@ami.com > Subject: [edk2-devel] [PATCH v3 3/7] MdePkg: REST style formset >=20 > New ClassGuid EFI_HII_REST_STYLE_FORMSET_GUID is defined. A formset > with this class GUID indicates all the questions in the formset support = REST > style operation and can be exposed to a REST service point. > In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined. > An Opcode with this flag indicates this question support REST style oper= ation > and can be exposed to a REST service point. > (UEFI 2.8 mantis 1853) >=20 > Signed-off-by: Oleksiy Yakovlev > --- > MdePkg/Include/Guid/HiiPlatformSetupFormset.h | 4 ++++ > MdePkg/Include/Uefi/UefiInternalFormRepresentation.h | 1 + > 2 files changed, 5 insertions(+) >=20 > diff --git a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h > b/MdePkg/Include/Guid/HiiPlatformSetupFormset.h > index 540483d..a6ba55b 100644 > --- a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h > +++ b/MdePkg/Include/Guid/HiiPlatformSetupFormset.h > @@ -22,8 +22,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define > EFI_HII_USER_CREDENTIAL_FORMSET_GUID \ > { 0x337f4407, 0x5aee, 0x4b83, { 0xb2, 0xa7, 0x4e, 0xad, 0xca, 0x30, 0= x88, > 0xcd } } >=20 > +#define EFI_HII_REST_STYLE_FORMSET_GUID \ > + { 0x790217bd, 0xbecf, 0x485b, { 0x91, 0x70, 0x5f, 0xf7, 0x11, 0x31, > +0x8b, 0x27 } } > + > extern EFI_GUID gEfiHiiPlatformSetupFormsetGuid; extern EFI_GUID > gEfiHiiDriverHealthFormsetGuid; extern EFI_GUID > gEfiHiiUserCredentialFormsetGuid; > +extern EFI_GUID gEfiHiiRestStyleFormsetGuid; >=20 > #endif > diff --git a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h > b/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h > index 4a1346a..40fcdb7 100644 > --- a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h > +++ b/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h > @@ -825,6 +825,7 @@ typedef struct _EFI_IFR_QUESTION_HEADER { > #define EFI_IFR_FLAG_READ_ONLY 0x01 > #define EFI_IFR_FLAG_CALLBACK 0x04 > #define EFI_IFR_FLAG_RESET_REQUIRED 0x10 > +#define EFI_IFR_FLAG_REST_STYLE 0x20 > #define EFI_IFR_FLAG_RECONNECT_REQUIRED 0x40 > #define EFI_IFR_FLAG_OPTIONS_ONLY 0x80 >=20 > -- > 2.9.0.windows.1 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intende= d > to be read only by the individual or entity to whom it is addressed or b= y their > designee. If the reader of this message is not the intended recipient, y= ou are > on notice that any distribution of this message, in any form, is strictl= y > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission. >=20 >=20 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intende= d > to be read only by the individual or entity to whom it is addressed or b= y their > designee. If the reader of this message is not the intended recipient, y= ou are > on notice that any distribution of this message, in any form, is strictl= y > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission.