From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.77.53]) by mx.groups.io with SMTP id smtpd.web12.1234.1587494865703904469 for ; Tue, 21 Apr 2020 11:47:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=PppmoF68; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.77.53, mailfrom: leo.duran@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=el3hPXKzpSgbBAU0kL/TyqP8X++UW67arGUerESETIZVpnY0wz54BKTnD1eH9MmJm5PSxhGatiyozgXxQ5VNGLr8frGnxW4nRmhY9keV3Sl1KEgjz2UXbU8tT/aLFvZCgH9cwcvB14cStadXr6CyAKD/X2chD6MO/9j1YIRkEnR3e6jHBQKgk+YQwhY68IoO5WCNOLpgA8TwDskqnB1H1V68/JhdK0MhBL/7fkIusD5NdmHdKW4GXyYgKLFwUsg+wi567nAy22DRAZ+m7LgENBC9XsKHUMzpuKo1LtjBhb26jzWYep8jeiGUlHZ0ztrhfeMIv88pSQ2M5g8C5PREmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kxw2vWBuJGVza6ht7sDU4fvy3LBMwG4Xb+oMOD/EkN0=; b=POHqH9caj0tSWVJTj8PlXj5d0EkGPSf5YOYwBbZaWCWN/JwDSvER2RmbsO7q/UyaZMGjkWftOPys36MnaCWuS1TGSHwUmtpjW8PtaBRb35y/oJISg0dfvZ64OniAlZRAXLJ66IHcopOLg+5ET8WAKhruwufVCMmOtJQP6snWujcpFpXkPGnbaPdwkTtOcd2Gq6R+1q2yEmPimhiDLPhuH3I2UzSbDwOk78Yaq8Cxh8/N4nIVu2SrZsqaQ5HU4rp0e+/ovHuYuYPXHrUw2DgpQ/J24zfEYrr+lmTb9rKsQJDf9MWG+RFuUqjRtkm9wmxoBvnFV9U1gQi7+sQw8As0ZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kxw2vWBuJGVza6ht7sDU4fvy3LBMwG4Xb+oMOD/EkN0=; b=PppmoF68pzz7GdAsAHqn7ad8Fxu2vqAX0z85bxCg+md4KdzwZhOzsh/R+FvYO38m2SHU45XjPCa3kG4DQlxf/NEr5nePMCKP0A18oeeK0X9L+5p/hdTGcicNQSjzXcumJD88jVzPXrlnnTTv6YyqqBukzE7dlqHxwic3FZosJmc= Received: from BN7PR12MB2644.namprd12.prod.outlook.com (2603:10b6:408:2d::20) by BN7PR12MB2834.namprd12.prod.outlook.com (2603:10b6:408:31::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.27; Tue, 21 Apr 2020 18:47:44 +0000 Received: from BN7PR12MB2644.namprd12.prod.outlook.com ([fe80::c86b:749e:9ab9:374d]) by BN7PR12MB2644.namprd12.prod.outlook.com ([fe80::c86b:749e:9ab9:374d%5]) with mapi id 15.20.2921.030; Tue, 21 Apr 2020 18:47:44 +0000 From: "Duran, Leo" To: Laszlo Ersek , Gary Lin , "devel@edk2.groups.io" CC: Eric Dong , Ray Ni Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors. Thread-Topic: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors. Thread-Index: AQHV7xG+/tMpPhHkv0eVfDt0EV7wN6h9QmCAgATPGACAAiqR4A== Date: Tue, 21 Apr 2020 18:47:43 +0000 Message-ID: References: <1582988745-1189-1-git-send-email-leo.duran@amd.com> <1582988745-1189-2-git-send-email-leo.duran@amd.com> <20200417081447.GC26140@GaryWorkstation> <79c80320-8d0c-d99f-030a-2a9a0ba796be@redhat.com> In-Reply-To: <79c80320-8d0c-d99f-030a-2a9a0ba796be@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leo.duran@amd.com; x-originating-ip: [173.170.80.115] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 277cb381-0249-49fd-db52-08d7e6247a49 x-ms-traffictypediagnostic: BN7PR12MB2834: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 038002787A x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR12MB2644.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(6029001)(4636009)(376002)(346002)(396003)(39860400002)(366004)(136003)(52536014)(478600001)(316002)(54906003)(45080400002)(2906002)(110136005)(8676002)(76116006)(966005)(5660300002)(66946007)(7696005)(71200400001)(66476007)(66556008)(9686003)(4326008)(33656002)(53546011)(81156014)(26005)(6506007)(186003)(66446008)(64756008)(83080400001)(55016002)(8936002)(86362001);DIR:OUT;SFP:1101; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uBPtnrP/8av6rUO/4spGKMDhE5YFo5I/9cF1CwjTCeywtYClM9xlEQlN+FxWZFvEZvPoiydRGtMWkJoOM3iUtfAhkZjYrw4eEb8+peMgZBgiWbhK4bimefoDwc5iAWLwjUC9z87Jv5721P7M/ekrVEx87nJ3h3SvJWXHtYnfHvzEUfcD9W/SDTziLkqNir6eApp3nb8FUfVuQjo0SyIUsDp3Nri8dLrnCy5SrULkVOb2/53CEeHX7pGeOweIPeiFWIRpaBKHaxTZUs8Ch3Vu4BJARMCXB7fy2ldwJwePnNQr9eDgt/1Yn7z4lMAEObdsbUbmGUbHVWvyFm3zy6iueF2XnZ7lT1dvBr5jmsKr4MZe7nbCFplY7Xb/VqkrO7ip/u577qUv3ihUhWqmXgh83d4c/sYWWaMYPJgYUQo68P/9n3wYGmPW9sWjHkdpfxr5vAsQk5Lr5qFHe+OsMCkIR+tY1IDWkjhnz1bhg8eyWCHzBRqdCFR8hLMFTOIhmnO6H/HG6tohdK7jqCOaQt4KRg== x-ms-exchange-antispam-messagedata: llHOSI7fllFxBhalJXp0dp5W8UU8XfI/iKVxG97c7VoHBQJM9cSJGzyJsli/5G+W/bRo9e5pbgOZXgV2IBBm8usj9/KtbEtMjdFc/6bM7AkbI7oXcfzXeN+yvqtsWqERE33YNdl47SSsiB4rHZourA== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 277cb381-0249-49fd-db52-08d7e6247a49 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 18:47:43.9099 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +T4h2clszm6F3wLkjBPmPP0YtvbwB2TIwzPGJTKADccF4OXF0hnys/FCFXWvueiS X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR12MB2834 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Monday, April 20, 2020 5:41 AM > To: Gary Lin ; devel@edk2.groups.io; Duran, Leo > > Cc: Eric Dong ; Ray Ni > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading > PlatformId on AMD processors. >=20 > On 04/17/20 10:14, Gary Lin wrote: > > On Sat, Feb 29, 2020 at 09:05:45AM -0600, Leo Duran wrote: > >> REF: > >> > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbug > >> > zilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2556&data=3D02%7C01%7 > Cleo > >> > .duran%40amd.com%7C10bcdc9150b24c3c53c108d7e50ef6a9%7C3dd8961fe > 4884e6 > >> > 08e11a82d994e183d%7C0%7C0%7C637229724752057989&sdata=3Dfcn7 > g8Tpx97I > >> U6FBPB%2BZ8wJFMtd9zhQzxJIhOct%2B1Vo%3D&reserved=3D0 > >> > >> This patch uses CPUID signature check to skip reading the PlatformId > >> MSR, which is not implemented on AMD processors. > >> > >> The PlatformId is used for loading microcode patches, which is also > >> not supported and AMD-based platforms. To mitigate the PlatformId > >> dependency, PcdCpuMicrocodePatchAddress and > >> PcdCpuMicrodePatchRegionSize must be set to 0 (default value), in orde= r > to bypass microcode loading code paths. > >> > > I got an error report about the executable bit of MpLib.h while > > packaging ovmf. It turned out that this patch accidentally changed the > > file mode. It would be nice if the mode can be corrected. >=20 > Thanks for the report. I've filed > zilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2678&data=3D02%7C01%7 > Cleo.duran%40amd.com%7C10bcdc9150b24c3c53c108d7e50ef6a9%7C3dd89 > 61fe4884e608e11a82d994e183d%7C0%7C0%7C637229724752057989& > sdata=3DwlBDe%2BOTRXpUyuCyJv5aJd1mH7NMbNkzZ%2B4obnhkfx0%3D&am > p;reserved=3D0> and assigned it to Leo. >=20 > Leo, can you please submit the patch? [Duran, Leo]=20 Yes, I can do that... Unless the Maintainer prefers to take care of the fil= e permission bits. >=20 > Thanks! > Laszlo